| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-07 | |||
| 11:43:33 | stephenfin | I think so (since it's a rebuild) but want to be sure before I put it in writing :) | |
| 12:09:53 | openstackgerrit | Lee Yarwood proposed openstack/os-traits master: Add COMPUTE_BFV_RESCUE trait https://review.opendev.org/694033 | |
| 12:25:18 | luyao | stephenfin, artom, sean-k-mooney : FYI, spec ‘support live migration with vpmem’ is updated and still waiting for review, looking forward to your comments. :) | |
| 12:26:12 | luyao | https://review.opendev.org/#/c/695863/ | |
| 12:26:56 | sean-k-mooney | luyao: thanks we are just gettting back but i guess now is a good a time as any to take a look | |
| 12:28:03 | luyao | sean-k-mooney: Hah, thanks. :D | |
| 12:28:39 | sean-k-mooney | stephenfin: yes you can but ther is an issue with it | |
| 12:29:03 | stephenfin | sean-k-mooney: tell me more | |
| 12:29:08 | sean-k-mooney | stephenfin: you can cold mighrate but then you have to either rebuild or hard reboot it | |
| 12:29:24 | sean-k-mooney | a cold migration does not set up the mdev properly | |
| 12:29:44 | sean-k-mooney | there is a note in the docs and bauzas is aware of the issue | |
| 12:29:53 | sean-k-mooney | i dont think he has had time to fix it | |
| 12:30:01 | sean-k-mooney | bauzas: ^ is correct right | |
| 12:30:22 | sean-k-mooney | stephenfin: i rememebr talking about this with bauzas just before the break but i could be mistaken | |
| 12:31:14 | stephenfin | sean-k-mooney: Ah, indeed. "Cold migrating an instance to another host will have the same problem as resize. If you want to migrate an instance, make sure to rebuild it after the migration." | |
| 12:31:18 | stephenfin | sean-k-mooney++ thanks :) | |
| 12:39:13 | sean-k-mooney | stephenfin: im not actully sure if rebuild is the only way to fix it. i suspect that a hard reboot would work too be dont have a gpu i can test it with and bauzas has not had time to test it either | |
| 13:50:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix excessive runtime of test test_migrate_within_cell https://review.opendev.org/701364 | |
| 13:51:25 | gibi | stephenfin, bauzas: simple func test fix ^^ | |
| 14:08:16 | bauzas | sean-k-mooney: whoops, sorry I was at the gym when you pinged me | |
| 14:27:46 | efried | #success Cross-cell resize is complete! https://docs.openstack.org/nova/latest/admin/configuration/cross-cell-resize.html | |
| 14:27:48 | openstackstatus | efried: Added success to Success page (https://wiki.openstack.org/wiki/Successes) | |
| 14:28:39 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213 | |
| 14:30:34 | efried | stephenfin: Once you've shaken off the dust, could I possibly nag you to get the vTPM spec closed out? https://review.opendev.org/#/c/686804/ TIA | |
| 14:34:12 | huaqiang | hi stephenfin, happy new year! | |
| 14:34:39 | huaqiang | can you have a look and review spec https://review.opendev.org/#/c/668656 in your convenient time? | |
| 14:55:32 | gibi | efried: there are missing pieces for cross-cell resize like supporting re-schedule https://review.opendev.org/#/c/696213/13 | |
| 14:57:10 | efried | gibi: Yup, see notes in that patch and in the blueprint | |
| 14:59:40 | gibi | efried: ohh, good info there, thanks. | |
| 15:22:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Filter policy warning in func test log https://review.opendev.org/701382 | |
| 15:23:06 | gibi | cores: another simple func test fix ^^ | |
| 16:29:50 | openstackgerrit | Merged openstack/nova master: FUP for docs nits in cross-cell-resize series https://review.opendev.org/699259 | |
| 16:32:18 | Sundar | dansmith: How are you doing? I responded in https://review.opendev.org/#/c/673735/ | |
| 16:32:45 | dansmith | Sundar: I replied to you about an hour ago | |
| 16:33:57 | Sundar | dansmith: Thanks, I see it now. Happy New Year, and hope you had a good break. | |
| 16:49:25 | stephenfin | guess there's a first time for everything | |
| 16:49:57 | stephenfin | efried: Meant to get back to you earlier. Was still stuck on the same stuff from before Christmas but I think that's done now. Should get to it tomorrow | |
| 16:50:05 | stephenfin | ditto for huaqiang ^ | |
| 16:53:14 | openstackgerrit | Merged openstack/nova master: FUP to Iff8194c868580facb1cc81b5567d66d4093c5274 https://review.opendev.org/700202 | |
| 17:01:41 | efried | thanks stephenfin | |
| 17:27:54 | gmann | mriedem: gibi : replied in review. this will fix the policy warning things, i missed to notify here early. - https://review.opendev.org/#/c/700797/ | |
| 17:58:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix the suppress of policy deprecation warnings https://review.opendev.org/700797 | |
| 18:22:32 | dansmith | efried: isn't this the thing that doesn't work? https://review.opendev.org/#/c/699554/2/nova/scheduler/request_filter.py@231 | |
| 18:52:24 | efried | dansmith: it'll need https://review.opendev.org/#/c/699050/ which is still in progress | |
| 18:52:42 | dansmith | yeah, I thought so | |
| 18:53:15 | efried | ...but which I should get back to | |
| 18:53:42 | efried | oh, right, cause I really wanted your look at that dansmith, since basically whatever you tell me OVO-wise is what I'll go do. | |
| 18:54:11 | dansmith | okay | |
| 18:54:39 | efried | I can respin per mriedem's comments, but probably save a step to find out now how much your opinion doesn't overlap with that. | |
| 19:03:30 | dansmith | efried: didn't review enough to +2, but enough to add weight to the -1 | |
| 19:03:47 | efried | thanks | |
| 19:15:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 19:15:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 19:15:24 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Report COMPUTE_BFV_RESCUE and check during rescue https://review.opendev.org/701429 | |
| 19:15:24 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | |
| 19:15:25 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Support boot from volume instance rescue https://review.opendev.org/701431 | |
| 19:22:29 | efried | dangit | |
| 19:22:52 | efried | dansmith: I think I'm going to need to write the rules for nullable on a post-it and stick it to my montior | |
| 19:23:16 | efried | Every time you explain it, I think I understand it. But then if more than a day or two passes til I have to think about it again, I forget. | |
| 19:23:29 | dansmith | nullable means exactly what it means for sql... "can be set to none".. that is ALL it means | |
| 19:23:31 | efried | Should request_level_params be nullable=True like requested_resources? | |
| 19:23:44 | dansmith | can/should it be set to none? | |
| 19:24:16 | efried | IMO no, IMO it should always be a RequestLevelParams even if that guy is "empty" (whatever that means for it). Which is why I had aggressively set the default. | |
| 19:24:31 | dansmith | aggressively setting the default is good | |
| 19:24:41 | efried | ...but not via default= | |
| 19:24:42 | dansmith | if it shouldn't be set to None, then it should not be nullable | |
| 19:25:20 | dansmith | default= doesn't actually default it, as you know, | |
| 19:25:48 | dansmith | but I just don't like the using of default= for this because it's a whole object and we're depending on deepcopy to do the right thing for it, and also it's probably more expensive to deepcopy those things than to create them fresh | |
| 19:33:51 | efried | dansmith: under what circumstances does obj_load_attr get invoked? Trying to ferret out how to do the defaulting there... | |
| 19:34:08 | dansmith | efried: it gets called if you reference a field that is not set | |
| 19:34:21 | dansmith | nothing to do with nullability | |
| 19:34:31 | efried | okay, neat, that makes what's already in there make more sense to me. | |
| 19:34:44 | efried | I was like, wait, won't these overwrite an existing field with a blank one?? | |
| 19:39:15 | efried | It would be neat if there was a way to enforce that this field *only* be initialized that way. Because then I can control how the sub-fields are initialized. But there doesn't seem to be a precedent for e.g. making a field "private" and using a @prop reader for its public incarnation. | |
| 19:41:28 | efried | guess I'll do it via comment | |
| 19:45:01 | dansmith | that's not really what ovo is trying to do, it's trying to make sure you're structured | |
| 19:45:24 | dansmith | but yes, I know this kind of thing seems to mystify people a lot | |
| 20:10:06 | efried | It's one of those things that's very powerful, and with great power comes great responsibility, which is fine for someone who's "mature" enough to handle the responsibility, but tough for fly-by-nighters like me. | |
| 20:10:41 | efried | As long as savvy reviewers are around to hand-hold, we should be able to avert the apocalypse. | |
| 20:17:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Use Placement 1.35 (root_required) https://review.opendev.org/699050 | |
| 20:17:42 | efried | dansmith: done ^ | |
| 20:17:42 | efried | Thanks as always for the guidance. | |
| 20:20:58 | efried | ...and remembered to post my comments just now. Weird where the vacation rust shows up. | |
| 21:12:34 | openstackgerrit | Merged openstack/nova master: Deprecate [glance]api_servers https://review.opendev.org/692227 | |
| 22:50:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Use Placement 1.35 (root_required) https://review.opendev.org/699050 | |
| 23:50:09 | openstackgerrit | melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478 | |
| 23:50:09 | openstack | bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929 | |
| #openstack-nova - 2020-01-08 | |||
| 01:30:08 | openstackgerrit | Merged openstack/nova master: nova-net: Remove firewall support (pt. 1) https://review.opendev.org/696514 | |
| 01:55:21 | openstackgerrit | Merged openstack/nova master: nova-net: Remove firewall support (pt. 2) https://review.opendev.org/700510 | |
| 03:59:59 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 03:59:59 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 04:00:00 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | |
| 04:00:00 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | |
| 05:59:56 | openstackgerrit | Merged openstack/nova master: Fix the suppress of policy deprecation warnings https://review.opendev.org/700797 | |
| 06:27:04 | openstackgerrit | Merged openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909 | |
| 09:02:20 | gibi | gmann: ack, thanks for the headsup abandoned my policy warning patch | |
| 09:08:16 | gibi | stephenfin: hi! could you check back to https://review.opendev.org/#/c/701364 it is green now | |
| 10:03:22 | openstackgerrit | Merged openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | |
| 10:06:03 | openstackgerrit | jichenjc proposed openstack/nova stable/train: libvirt: avoid cpu check at s390x arch https://review.opendev.org/701525 | |
| 10:06:14 | openstackgerrit | jichenjc proposed openstack/nova stable/stein: libvirt: avoid cpu check at s390x arch https://review.opendev.org/701526 | |