Posted	Nick	Remark
#openstack-nova - 2020-01-07
23:50:09	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
23:50:09	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
#openstack-nova - 2020-01-08
01:30:08	openstackgerrit	Merged openstack/nova master: nova-net: Remove firewall support (pt. 1) https://review.opendev.org/696514
01:55:21	openstackgerrit	Merged openstack/nova master: nova-net: Remove firewall support (pt. 2) https://review.opendev.org/700510
03:59:59	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
03:59:59	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
04:00:00	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
04:00:00	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
05:59:56	openstackgerrit	Merged openstack/nova master: Fix the suppress of policy deprecation warnings https://review.opendev.org/700797
06:27:04	openstackgerrit	Merged openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
09:02:20	gibi	gmann: ack, thanks for the headsup abandoned my policy warning patch
09:08:16	gibi	stephenfin: hi! could you check back to https://review.opendev.org/#/c/701364 it is green now
10:03:22	openstackgerrit	Merged openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228
10:06:03	openstackgerrit	jichenjc proposed openstack/nova stable/train: libvirt: avoid cpu check at s390x arch https://review.opendev.org/701525
10:06:14	openstackgerrit	jichenjc proposed openstack/nova stable/stein: libvirt: avoid cpu check at s390x arch https://review.opendev.org/701526
12:15:37	stephenfin	gibi: Sorry, missed the ping. Will hit now
12:22:02	stephenfin	gibi: done
12:34:03	stephenfin	efried: question on https://review.opendev.org/#/c/686804/12/specs/ussuri/approved/add-emulated-virtual-tpm.rst@365
12:34:22	stephenfin	wdym we can't do an API check? How's this different from the check sean-k-mooney added for the NUMA stuff?
12:35:01	stephenfin	basically if the old and new images have different vTPM metadata, fail?
12:48:42	sean-k-mooney	stephenfin: i was wondering that too
12:49:32	sean-k-mooney	i had acess to the old image which is embded in the instance, the new image and the flavor
12:50:08	sean-k-mooney	so that should be enough to do a check in the rebuild case
13:01:14	openstackgerrit	Merged openstack/nova master: Fix excessive runtime of test test_migrate_within_cell https://review.opendev.org/701364
13:09:44	gibi	stephenfin: thanks
13:57:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support (pt. 3) https://review.opendev.org/700511
13:57:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515
13:57:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516
13:57:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove 'MetadataManager' https://review.opendev.org/696748
13:57:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs to remove security group-related objects https://review.opendev.org/696517
13:57:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove dependency on nova-net from fake cache https://review.opendev.org/696749
13:57:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Kill it https://review.opendev.org/696518
13:57:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions https://review.opendev.org/697149
13:57:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776
13:57:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Rename 'nova.network.neutronv2' -> 'nova.network' https://review.opendev.org/696745
13:57:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746
13:57:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152
13:57:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153
13:57:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154
13:57:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155
13:57:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
14:32:54	shilpasd	mriedem: thanks for review
14:44:29	stephenfin	gibi: when you've a chance, could you hit https://review.opendev.org/#/c/700511/ again? Just addressed two of efried's nits
14:47:12	gibi	stephenfin: looking...
14:48:42	gibi	stephenfin: done
14:49:04	gibi	stephenfin: I will try to look into the next set of patches in the series during today or tomorrow
14:57:46	bauzas	gibi: can I ask you a question ?
14:58:01	bauzas	gibi: I'm looking at your comments on https://review.opendev.org/#/c/670112/11/nova/tests/functional/test_nova_manage.py
14:58:27	bauzas	gibi: I honestly prefer to leave castascall rather than having more than one method call per contextmanager
14:58:28	gibi	bauzas: sure
14:58:55	gibi	bauzas: I mean sure, lets look at my comment
14:59:06	bauzas	just because I think it's more understanding why we need to mock
14:59:45	bauzas	gibi: okay, so you would still be OK if I don't modify it ?
15:00:38	gibi	bauzas: unfortunately having only the post under the mock is a lie as such post starts an async task and the post returns before the function you are mocking really runs
15:01:06	gibi	in a unit test I'm ok with castascall but not in a functional test
15:01:09	gibi	sorry
15:01:52	efried	stephenfin: dahh, I guess we do have access to the old image meta, don't we? So yeah, sean-k-mooney is right, I can add a check for that.Do you want the spec updated now or fup'd?
15:01:54	gibi	in a functional test we want to express (and test) the async behavior of our API we are calling
15:02:15	sean-k-mooney	efried: i think we can just do it in the implemnation
15:02:28	sean-k-mooney	i dont think we need a spec update but a fup would be fine if you want
15:02:29	bauzas	gibi: mmmm not sure I understand you, sorry :(
15:02:38	stephenfin	efried: If you can get it today, I'm happy to fast approve and carry gibi's +2
15:03:00	efried	really in that spot I was just trying to give examples of how things could go wrong. I got one of the wrong things wrong, but it's the *thought* that counts :P
15:03:06	efried	stephenfin: Roger that, will do it right now...
15:03:07	bauzas	gibi: ah-ha I think I understand your concern
15:03:40	gibi	bauzas: in my eyes the nova internal in functional test shoudl behave exactly as it behaves in real life (except virt driver as it is hard, and except external dependencies like neutron) so I would like to keep the nova API async behaviour in func test
15:03:58	bauzas	gibi: honestly given we call directly by castascall, it's no longer async
15:04:17	bauzas	(and that's also why it works
15:04:28	gibi	bauzas: yes, and I'm against such behavior change in func test
15:04:49	bauzas	gibi: okay, fair enough :-)
15:05:33	bauzas	gibi: no worries, I'll then fix this
15:05:50	gibi	bauzas: we tend to allow to use some mocks in func test to inject faults as that is hard without the API but other than that I'm also against mocks in func test too
15:06:11	gibi	s/without the API/ with only the API/
15:06:19	gibi	bauzas: thanks
15:12:19	stephenfin	efried: Sweet. Ta. When you're done, I have done as commanded on https://review.opendev.org/700511 and it's just _itching_ to get through that gate
15:15:54	efried	stephenfin: firewall pt. 3 +A
15:16:58	efried	stephenfin: regarding the ImageMetaProps updates... I'm not sure.
15:18:20	efried	I always thought of image meta props the same as flavor extra specs -- a bag of random key/values that we can "enhance" without microversion changes -- except for some reason (that I never understood, never asked about) we actually have OVOs for image meta props, which need to be updated.
15:19:31	efried	but like extra specs, I would have expected them to show up in a REST payload like the others
15:20:07	efried	and be settable like anything else
15:21:49	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804
15:21:57	sean-k-mooney	efried: yes the can be extended without microverion changes
15:22:07	efried	stephenfin, gibi, sean-k-mooney: with just that update about the API check --^
15:22:12	sean-k-mooney	but the image metadata object is an ovo
15:22:22	sean-k-mooney	so it will alter the object version
15:22:52	efried	right; stephenfin is asking whether the new fields will be visible/settable via the API, and I don't see why not?
15:23:10	sean-k-mooney	we do not allow arbiary keys to be set in the image metadata
15:23:16	sean-k-mooney	but it should be visable yes
15:23:24	sean-k-mooney	we dont allow you to downgrade the ovo
15:23:39	sean-k-mooney	to strip out new keys and get an older version
15:24:11	efried	by "arbitrary" you mean keys that we haven't explicitly registered, which is why we register them. But anything we've registered, you can set
15:24:28	sean-k-mooney	yes
15:24:38	sean-k-mooney	although this is set in glance not nova obviously
15:28:10	efried	right, and then we pull in a copy of the meta and store it with the instance record, which is why this object exists in nova in the first place.
15:28:33	efried	not sure why we needed it for image meta but not flavor extra specs tho
15:28:43	sean-k-mooney	yes more or less
15:28:53	efried	or rather, why we couldn't leave it out for image meta like we left it out for extra specs.
15:28:58	sean-k-mooney	we did not have it for the image metadata orgithily
15:29:04	sean-k-mooney	it was just a dict of strings
15:29:11	dansmith	efried: you can use flavor extra specs for other things though right?

Earlier   Later