| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-12-10 | |||
| 20:22:59 | mriedem | only the db | |
| 20:23:03 | mriedem | there is no api to update migration records | |
| 20:24:15 | mriedem | it's an extremely latent bug so not high priority, just something i noticed while writing a test around that periodic | |
| 20:25:31 | sean-k-mooney | right /os-migrations is just a list of all migration and the server migration enpoint does not have a put | |
| 20:30:27 | sean-k-mooney | we check for both finished and confriming here https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L4267 do we arrive at that form finished from teh periodic task | |
| 20:30:41 | mriedem | yes | |
| 20:30:51 | sean-k-mooney | ah ok | |
| 20:31:01 | mriedem | https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L8866 | |
| 20:31:20 | mriedem | the periodic on the dest host calls the api method which calls confirm_resize on the source host | |
| 20:32:08 | sean-k-mooney | right but the compute api method set it to confirming https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/api.py#L3684 | |
| 20:32:19 | mriedem | correct | |
| 20:32:42 | mriedem | and after the api does that, if anything fails you can't re-confirm the resize | |
| 20:34:22 | sean-k-mooney | yes but in the compute manager do_confirm_resize which is an inner function of confirm_resize seams to exepct the migration could be in finished or confriming so i was trying to figure out when could it be finish since i think it shoudld only be in confirming based on that code flow | |
| 20:34:54 | sean-k-mooney | anyway its proably not important i just thought it was odd | |
| 20:35:04 | mriedem | it's probably leftover | |
| 20:35:19 | mriedem | or when deleting a resized server | |
| 20:35:28 | mriedem | see _confirm_resize_on_deleting | |
| 20:36:25 | sean-k-mooney | oh so we clean up the resouce on the source node then delete it on the dest | |
| 20:37:02 | mriedem | yes | |
| 20:38:13 | sean-k-mooney | that still calls confirm_resize via rpc but ya it looks like it " for status in ('finished', 'confirming'):" code was copied between the two functions | |
| 20:41:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize https://review.opendev.org/698304 | |
| 20:41:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize tests for _poll_unconfirmed_resizes https://review.opendev.org/698322 | |
| 22:02:45 | openstackgerrit | sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | |
| 22:25:21 | efried | well that took rather longer than expected. | |
| 22:25:59 | efried | sean-k-mooney: So I guess the right thing here is to hold off making irreversible OVO changes until we can get the word from gibi_off. Can you live with that? | |
| 22:26:14 | sean-k-mooney | yep that is fine with me | |
| 22:26:19 | sean-k-mooney | i address some of your nits | |
| 22:26:36 | sean-k-mooney | but i have not done the functional test changes yet | |
| 22:29:22 | efried | okay | |
| 22:30:13 | sean-k-mooney | do you want the extra functional test in the same patch or a follow up. i need to think about how to do it smartly instead of just copy pasting and tweeking | |
| 22:34:51 | efried | sean-k-mooney: stephenfin isn't disappearing until well after you do, so getting his re+2 ought to be easy enough; same patch seems reasonable. | |
| 22:35:15 | openstackgerrit | sean mooney proposed openstack/nova master: fix imports of typeing module https://review.opendev.org/698334 | |
| 22:35:30 | efried | we may not even be able to move on it until the new year -- not sure whether gibi is thoroughly gone until then. | |
| 22:35:33 | sean-k-mooney | i think artom is going to pick up the patch if its not reay before i do | |
| 22:36:13 | sean-k-mooney | hum ok that would less then ideal but ok | |
| 22:36:41 | sean-k-mooney | i could split the notifciation change into a second patch if that helped | |
| 22:37:37 | sean-k-mooney | anyway im done for today so that is tommorows problem | |
| 22:37:40 | sean-k-mooney | night o/ | |
| 22:37:59 | efried | yeah, let's talk again about this tomorrow, hopefully I'll have a clearer head too. | |
| 22:44:33 | efried | dansmith, sean-k-mooney, mriedem: FYI the cinder use of external events appears sane https://opendev.org/openstack/cinder/src/branch/master/cinder/compute/nova.py#L145 | |
| 22:45:16 | efried | uhm | |
| 22:45:17 | efried | actually no | |
| 22:45:55 | efried | it should be setting response_error=True on L168 | |
| 22:47:55 | efried | So that's actually a latent bug | |
| 22:49:36 | efried | Previously it would have triggered if they were extending volumes attached to multiple instances and a subset failed; | |
| 22:49:36 | efried | With our fix it would also trigger if they were extending volumes attached to one or more instances and all failed. | |
| 22:50:37 | efried | in this case the bug is simply that they wouldn't send the error through their messaging API. | |
| 22:55:22 | mriedem | rain hell fire upon them | |
| 22:57:40 | efried | I'm doing so in -cinder | |
| 23:28:49 | efried | ...and neutron is okay https://opendev.org/openstack/neutron/src/branch/master/neutron/notifiers/nova.py#L244 | |
| 23:28:49 | efried | They're just using the codes to print log messages, and they're doing it correctly. | |
| 23:29:35 | efried | and those are all the relevant hits | |
| 23:30:13 | efried | FYI I opened https://bugs.launchpad.net/cinder/+bug/1855940 and put up https://review.opendev.org/698340 in cinder. | |
| 23:30:13 | openstack | Launchpad bug 1855940 in Cinder "Messages sometimes not sent when nova fails to accept "extend volume" events" [Undecided,In progress] - Assigned to Eric Fried (efried) | |
| 23:30:21 | efried | and with that... o/ | |
| #openstack-nova - 2019-12-11 | |||
| 01:13:46 | openstackgerrit | Merged openstack/nova master: Tie requester_id to RequestGroup suffix https://review.opendev.org/696946 | |
| 02:30:47 | openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | |
| 02:45:20 | openstackgerrit | hutianhao27 proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523 | |
| 03:55:12 | openstackgerrit | hutianhao27 proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523 | |
| 06:25:45 | openstackgerrit | Merged openstack/nova master: Switch to uses_virtio to enable iommu driver for AMD SEV https://review.opendev.org/696697 | |
| 06:25:53 | openstackgerrit | Merged openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825 | |
| 07:18:46 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Handle new is_volume_backend join column query https://review.opendev.org/694462 | |
| 07:18:47 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Instance object changes for the new 'is_volume_backed' expected_attr https://review.opendev.org/694463 | |
| 07:18:48 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Ignore root_gb if instance is booted from volume https://review.opendev.org/612626 | |
| 07:47:04 | gibi | reading the notification while I was away I feel like IRC's away message system doesn't work as intended as I noted there that I back on Wednesday but it seems this info was unknown for the folks on the channel | |
| 08:10:13 | openstackgerrit | Eric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP' https://review.opendev.org/698132 | |
| 08:45:10 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421 | |
| 08:59:56 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421 | |
| 09:03:20 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421 | |
| 09:42:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246 | |
| 09:43:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247 | |
| 09:45:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541 | |
| 09:46:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574 | |
| 09:48:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905 | |
| 09:53:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246 | |
| 09:55:24 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247 | |
| 09:56:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541 | |
| 09:58:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574 | |
| 09:59:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905 | |
| 11:53:26 | sean-k-mooney | gibi: ya we did not get any away notifications | |
| 11:53:58 | sean-k-mooney | did you perhaps set your self as away before chaning your nick or something | |
| 11:54:18 | gibi | sean-k-mooney: used /away <message> in my irssi but then I will not try to rely on that in the future | |
| 11:54:39 | sean-k-mooney | that is what i use but with weechat and it works fine | |
| 11:54:56 | sean-k-mooney | if you ping me now you should get a message | |
| 11:55:03 | gibi | jeah could be an ordering issue | |
| 11:55:29 | skm | did you get a message before | |
| 11:56:11 | sean-k-mooney | oh you didnt use my name | |
| 11:57:17 | sean-k-mooney | gibi: anyway shall i proceed with keeping the notifications for now. | |
| 11:58:27 | gibi | sean-k-mooney: I think you should add your new image meta to the payload | |
| 11:58:34 | gibi | just to follow the pattern | |
| 11:59:00 | sean-k-mooney | but i am the only person that has done that since the notification have been added | |
| 11:59:19 | sean-k-mooney | and we have added lots of image properties since then | |
| 11:59:46 | sean-k-mooney | i also added the 1.1 version bump | |
| 12:00:44 | sean-k-mooney | so i can set and follow a new pattern but if i was to follow the exitising one i would ignore it | |
| 12:00:46 | gibi | I opened the original patch introduced the payload class and at that time it contained everyhing, so the intention is clear to me based on that | |
| 12:01:22 | sean-k-mooney | yep which is why i added the property but we have not been doing that | |
| 12:02:14 | sean-k-mooney | i can file a bug to bring them in sync and work on a patch to do that if that is what we want to do going forward | |
| 12:02:15 | gibi | honestly I would not block you patch on this in either way. It is pretty clear to me know that there are no active notification consumers out there that are willing to give us feedback what they need | |
| 12:02:25 | gibi | s/know/now/ | |
| 12:02:50 | gibi | so I won't be hard with rules | |