Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-10
22:45:17 efried actually no
22:45:55 efried it should be setting response_error=True on L168
22:47:55 efried So that's actually a latent bug
22:49:36 efried Previously it would have triggered if they were extending volumes attached to multiple instances and a subset failed;
22:49:36 efried With our fix it would also trigger if they were extending volumes attached to one or more instances and all failed.
22:50:37 efried in this case the bug is simply that they wouldn't send the error through their messaging API.
22:55:22 mriedem rain hell fire upon them
22:57:40 efried I'm doing so in -cinder
23:28:49 efried ...and neutron is okay https://opendev.org/openstack/neutron/src/branch/master/neutron/notifiers/nova.py#L244
23:28:49 efried They're just using the codes to print log messages, and they're doing it correctly.
23:29:35 efried and those are all the relevant hits
23:30:13 efried FYI I opened https://bugs.launchpad.net/cinder/+bug/1855940 and put up https://review.opendev.org/698340 in cinder.
23:30:13 openstack Launchpad bug 1855940 in Cinder "Messages sometimes not sent when nova fails to accept "extend volume" events" [Undecided,In progress] - Assigned to Eric Fried (efried)
23:30:21 efried and with that... o/
#openstack-nova - 2019-12-11
01:13:46 openstackgerrit Merged openstack/nova master: Tie requester_id to RequestGroup suffix https://review.opendev.org/696946
02:30:47 openstackgerrit jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228
02:45:20 openstackgerrit hutianhao27 proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523
03:55:12 openstackgerrit hutianhao27 proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523
06:25:45 openstackgerrit Merged openstack/nova master: Switch to uses_virtio to enable iommu driver for AMD SEV https://review.opendev.org/696697
06:25:53 openstackgerrit Merged openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825
07:18:46 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Handle new is_volume_backend join column query https://review.opendev.org/694462
07:18:47 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Instance object changes for the new 'is_volume_backed' expected_attr https://review.opendev.org/694463
07:18:48 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Ignore root_gb if instance is booted from volume https://review.opendev.org/612626
07:47:04 gibi reading the notification while I was away I feel like IRC's away message system doesn't work as intended as I noted there that I back on Wednesday but it seems this info was unknown for the folks on the channel
08:10:13 openstackgerrit Eric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP' https://review.opendev.org/698132
08:45:10 openstackgerrit Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421
08:59:56 openstackgerrit Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421
09:03:20 openstackgerrit Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421
09:42:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246
09:43:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247
09:45:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541
09:46:39 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574
09:48:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
09:53:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246
09:55:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247
09:56:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541
09:58:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574
09:59:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
11:53:26 sean-k-mooney gibi: ya we did not get any away notifications
11:53:58 sean-k-mooney did you perhaps set your self as away before chaning your nick or something
11:54:18 gibi sean-k-mooney: used /away <message> in my irssi but then I will not try to rely on that in the future
11:54:39 sean-k-mooney that is what i use but with weechat and it works fine
11:54:56 sean-k-mooney if you ping me now you should get a message
11:55:03 gibi jeah could be an ordering issue
11:55:29 skm did you get a message before
11:56:11 sean-k-mooney oh you didnt use my name
11:57:17 sean-k-mooney gibi: anyway shall i proceed with keeping the notifications for now.
11:58:27 gibi sean-k-mooney: I think you should add your new image meta to the payload
11:58:34 gibi just to follow the pattern
11:59:00 sean-k-mooney but i am the only person that has done that since the notification have been added
11:59:19 sean-k-mooney and we have added lots of image properties since then
11:59:46 sean-k-mooney i also added the 1.1 version bump
12:00:44 sean-k-mooney so i can set and follow a new pattern but if i was to follow the exitising one i would ignore it
12:00:46 gibi I opened the original patch introduced the payload class and at that time it contained everyhing, so the intention is clear to me based on that
12:01:22 sean-k-mooney yep which is why i added the property but we have not been doing that
12:02:14 sean-k-mooney i can file a bug to bring them in sync and work on a patch to do that if that is what we want to do going forward
12:02:15 gibi honestly I would not block you patch on this in either way. It is pretty clear to me know that there are no active notification consumers out there that are willing to give us feedback what they need
12:02:25 gibi s/know/now/
12:02:50 gibi so I won't be hard with rules
12:03:30 sean-k-mooney well its more efried that was interested since he was addeding image peorperties too and he was wondering if he should be doing the same
12:04:55 sean-k-mooney i was wondering if we should document the policy if there was one somewhere so that we can do the right thing
12:06:15 gibi so we need to 1) decide what is the policy 2) make sure we can somehow enforce the policy
12:06:41 gibi for 1) the original policy was to mirror image meta but then later patches not followed that policy
12:06:47 sean-k-mooney well we can just compare the fields dict of both ovos
12:07:19 sean-k-mooney they shoulds always be in sync right
12:07:49 gibi then we need a separate patch to re-sync the two
12:08:10 sean-k-mooney yes, i commented on the bug that i was not sure why it needed to be a seperate object vs the nova.object.ImageMetaProps
12:08:18 sean-k-mooney *patch
12:08:44 sean-k-mooney was there a reson you made the payload object sperate?
12:09:41 gibi in general we wanted to have separate objects for notification payload so that we are not enforced to push every internal data out in the notification. But for this particular case if we decide that we always want to push every image meta in the notification then sure in this case we don't need a separate payload class
12:11:41 sean-k-mooney well i guess that is the issue right. having a seperate class made the notification update optional since it would not fail tests if you forgot.
12:12:24 sean-k-mooney ok so ill level the notification updates in the patch for now assuming efried is ok with that and ill file a bug for the fact tehy are not in sync.
12:12:42 gibi sean-k-mooney: ack, it works for me
12:12:51 gibi and thanks for taking care of
12:13:13 sean-k-mooney then we can decide if we want to fix that by extending the new object and added the test for the fields or if we want to just use one object in this case sound good?
13:53:40 openstackgerrit Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421
14:00:48 gibi sean-k-mooney: sorry, I was pulled. Yeah, it sounds like a plan
14:01:01 sean-k-mooney hehe no worries
14:16:13 efried gibi, sean-k-mooney: ack, thanks for the followup. Sounds like we'll want a big patch to sync the two objects.
14:16:37 efried and maybe some kind of clever test that enforces their parity.
14:16:50 efried for the future
14:17:12 gibi efried: hi! I can get behind this plan
14:17:34 efried This ship has probably sailed, but is there no way to use the same object for both purposes?
14:18:03 sean-k-mooney well the clever test is just loop over the fields dict in the nova.object.image_meta.ImageProp object and assert they are in the notificaiton object dict
14:18:54 gibi efried: if we hack the versioning then I guess we can. But I don't know if we really want to heck the versioning
14:19:06 gibi sean-k-mooney: yeah that could work
14:19:41 sean-k-mooney ill write a patch to do that when i finish updating the functional tests
14:20:21 efried sean-k-mooney: and vice versa
14:20:26 efried thanks sean-k-mooney
14:21:17 sean-k-mooney well actully they are dicts so i could jsut assert the keys are equal
14:21:41 sean-k-mooney if we want the typs to match i could jsut assert the dicts are equal to check the keys and values
14:26:11 efried I'd be fine just asserting they have the same keys.
14:26:32 efried it's really just a sniff test to make sure devs didn't miss syncing.
14:27:06 sean-k-mooney yep ill include it in the sync patch
14:27:24 sean-k-mooney also ddt makes updating the func test way simpler
14:27:42 efried sweet.
14:28:19 efried gibi: what's your vacation schedule?
14:29:33 gibi efried: last official day in the office is 16th. If I cannot finish with the qos live migration until then then I will add some extra time to that before 20th
14:29:58 gibi then back in the 6th of Jan
14:30:35 efried Okay. I'll try to get some reviews in on that. I'm also going to ask for another look at the vTPM spec soon if that's okay. I need to do another update, so maybe tomorrow?

Earlier   Later