| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-16 | |||
| 15:48:38 | mriedem | dansmith: replied | |
| 15:48:38 | bauzas | mriedem: we can honestly revert the change for asking at least for more | |
| 15:49:24 | bauzas | mriedem: do you want me to provide the revert change (and then the revert of revert) ? | |
| 15:49:27 | bauzas | efried: WFY ? | |
| 15:49:29 | mriedem | no | |
| 15:49:44 | mriedem | i'd say if someone on the core team has a stink about what was merged we can amend later | |
| 15:50:05 | bauzas | ok, I can write a ML email to mention it got merged then | |
| 15:50:20 | mriedem | sure | |
| 15:50:26 | bauzas | and ask for people to provide some change if they disagree with some stuff | |
| 15:50:28 | bauzas | ok, doing | |
| 15:50:33 | bauzas | mriedem: and again, apologies | |
| 15:51:07 | bauzas | FWIW, those were my notes for the +2 "OK, after commenting a lot about this spec process, I think I'm quite +2 with it, even if I could still have some concerns. Given it's important to have a consensus about this, I think it's more important to just accept it and then providing other follow-ups if there would be some points." | |
| 16:00:41 | efried | bauzas: I already wrote an email mentioning it's merged. | |
| 16:00:55 | bauzas | efried: ack | |
| 16:01:40 | efried | http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010158.html | |
| 16:02:18 | efried | Let's be honest, if we waited for a majority of cores, we would be waiting forever. Not because they necessarily object, but because they don't care. | |
| 16:03:03 | mriedem | that's why i said it's fine to just amend if people care or take issue with it at this point | |
| 16:03:08 | efried | ++ | |
| 16:21:04 | mriedem | dansmith: replied on https://review.opendev.org/#/c/688832/ - that's just a wip right now that i pushed late last night, it's definitely not in final form, | |
| 16:21:12 | mriedem | i'm working on a recreate test for the latent same-cell resize bug | |
| 16:22:12 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Add COMPUTE_NODE trait https://review.opendev.org/688969 | |
| 16:26:09 | melwitt | mriedem: question on this in case you didn't see https://review.opendev.org/687427 | |
| 16:28:19 | dansmith | mriedem: aight | |
| 16:30:12 | dansmith | mriedem: so on this object-or-id thing, | |
| 16:31:05 | dansmith | mriedem: if I take either are you expecting me to validate the uuid if it was given, or just pass that in the body? Like, leave the actually-check-with-glance part in the CLI shell, and just make the python API able to do either, but not validate? | |
| 16:37:20 | dansmith | mriedem: I guess based on the other examples, just include and not validate | |
| 16:37:48 | mriedem | the cli would get the image from glance based on name or id, | |
| 16:37:55 | mriedem | the python api binding method would just pass through | |
| 16:38:09 | dansmith | yeah | |
| 16:38:13 | mriedem | that's how other api methods like create, rebuild, rescue work | |
| 16:38:25 | dansmith | I'm not a fan, but consistency is more important for usre | |
| 16:39:48 | mriedem | if going directly to the api we'll barf and return a 400 if the image doesn't exist | |
| 16:39:49 | mriedem | so i think we're ok | |
| 16:40:17 | dansmith | yeah | |
| 16:45:44 | mriedem | melwitt: replied, thanks | |
| 16:46:06 | melwitt | ack thanks | |
| 16:46:30 | openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | |
| 17:00:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | |
| 17:11:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1848343 https://review.opendev.org/688980 | |
| 17:11:17 | openstack | bug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/1848343 | |
| 17:11:17 | mriedem | dansmith: here is a pretty simple recreate of that latent allocation leak bug ^ | |
| 17:12:12 | dansmith | schwing | |
| 17:16:58 | mriedem | this is your reward https://www.youtube.com/watch?v=vKDx_66nnAw | |
| 17:17:25 | efried | ye gods, save me from SRV | |
| 17:17:34 | efried | <eyeroll> | |
| 17:19:10 | dansmith | I will say | |
| 17:19:31 | dansmith | I didn't think you could get too much SRV, but living in Austin made it clear that you can | |
| 17:19:40 | efried | exactly | |
| 17:20:04 | dansmith | which is too bad, because SRV is awesome and Austin just kinda messes that up | |
| 17:20:06 | efried | because you not only get SRV, you get every freaking SRV clone ever | |
| 17:20:27 | efried | though I've never been a fan of that style of blues personally. Way too homogeneous. | |
| 17:20:48 | efried | but SRV+clones took it from meh to active dislike | |
| 17:22:59 | melwitt | same thing in houston, I grew to hate SRV from oversaturation | |
| 17:51:14 | mriedem | it's all about hotdish | |
| 17:51:24 | mriedem | and bad sports teams | |
| 17:59:24 | openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | |
| 18:01:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | |
| 18:01:36 | KeithMnemonic | frickler I will let you know what I find out. my guess is it is some config issue in this one env, as so far i can not reproduce it | |
| 18:01:52 | gmann | melwitt: I added you as 'Feature Liaison' in policy spec re-proposed for U. https://review.opendev.org/#/c/686058/ | |
| 18:01:58 | KeithMnemonic | ah did not see i posted already, too much going on today | |
| 18:02:24 | KeithMnemonic | if anyone has time to please review https://review.opendev.org/683008 i appreciate it | |
| 18:02:49 | melwitt | gmann: ok, thanks | |
| 18:03:13 | gmann | melwitt: I will rebase the code patches once the spec is merged. looking for your review on this re-proposed spec. | |
| 18:03:30 | melwitt | ack | |
| 18:03:34 | gmann | thanks | |
| 18:05:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add live migration recreate test for bug 1848343 https://review.opendev.org/688994 | |
| 18:05:44 | openstack | bug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/1848343 | |
| 18:05:46 | artom | gmann, since you're around, gentle poke, re: whitebox spec: https://review.opendev.org/#/c/656890/ | |
| 18:06:45 | gmann | artom: thanks for reminder. I will surly review this week, (as done for train release things.) | |
| 18:18:43 | mriedem | dansmith: do you want to fix this nit otherwise i'm +2 https://review.opendev.org/#/c/687141/ | |
| 18:19:05 | dansmith | mriedem: oh sure, just a sec | |
| 18:19:58 | openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | |
| 18:20:07 | dansmith | mriedem: spanks ^ | |
| 18:20:31 | mriedem | how did you know i was wearing those? | |
| 18:20:45 | mriedem | oh s/k/x/ | |
| 18:20:46 | dansmith | I think you mean Spanx(tm) | |
| 18:20:49 | dansmith | I was saying | |
| 18:20:57 | dansmith | "spanks for catching that" | |
| 18:21:00 | mriedem | yeah i know | |
| 18:21:06 | mriedem | i just wanted to make a spanx joke | |
| 18:21:31 | dansmith | noted | |
| 18:44:00 | mriedem | argh, | |
| 18:44:06 | mriedem | Instance.save(expected_state_state=) | |
| 18:44:08 | mriedem | that's a tuple or lits, | |
| 18:44:11 | mriedem | *list | |
| 18:44:17 | mriedem | the singular in the name *always* screws me up | |
| 18:44:31 | mriedem | we should maybe guard against that in the save method | |
| 18:44:31 | dansmith | except that it takes None too, IIRC | |
| 18:44:48 | mriedem | yeah, | |
| 18:44:55 | mriedem | so if not None, assert it's an iterable | |
| 18:45:16 | mriedem | https://review.opendev.org/#/c/627891/63/nova/conductor/tasks/cross_cell_migrate.py@423 | |
| 18:46:39 | efried | melwitt: in case you haven't been following closely, note that we no longer do fast approvals for unchanged spec reproposals. | |
| 18:47:13 | melwitt | efried: I had read that in one of the emails, then forgot about it, so thanks for reminding | |
| 18:50:24 | mriedem | yeah we have several places where we pass a string to expected_task_state | |
| 18:53:32 | artom | expected_attrs all over again | |
| 18:53:52 | mriedem | https://bugs.launchpad.net/nova/+bug/1848373 | |
| 18:53:52 | openstack | Launchpad bug 1848373 in OpenStack Compute (nova) "Instance.save(expected_task_state=) is passed string in many locations" [Medium,Triaged] | |
| 18:54:31 | melwitt | dynamic types ftw | |
| 18:57:50 | mriedem | back in 2012 the db api handled it.... https://review.opendev.org/#/c/12222/5/nova/db/sqlalchemy/api.py | |
| 18:57:53 | efried | gmann: was os-cells a cellsv1 thing? | |