| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-16 | |||
| 17:11:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1848343 https://review.opendev.org/688980 | |
| 17:11:17 | openstack | bug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/1848343 | |
| 17:11:17 | mriedem | dansmith: here is a pretty simple recreate of that latent allocation leak bug ^ | |
| 17:12:12 | dansmith | schwing | |
| 17:16:58 | mriedem | this is your reward https://www.youtube.com/watch?v=vKDx_66nnAw | |
| 17:17:25 | efried | ye gods, save me from SRV | |
| 17:17:34 | efried | <eyeroll> | |
| 17:19:10 | dansmith | I will say | |
| 17:19:31 | dansmith | I didn't think you could get too much SRV, but living in Austin made it clear that you can | |
| 17:19:40 | efried | exactly | |
| 17:20:04 | dansmith | which is too bad, because SRV is awesome and Austin just kinda messes that up | |
| 17:20:06 | efried | because you not only get SRV, you get every freaking SRV clone ever | |
| 17:20:27 | efried | though I've never been a fan of that style of blues personally. Way too homogeneous. | |
| 17:20:48 | efried | but SRV+clones took it from meh to active dislike | |
| 17:22:59 | melwitt | same thing in houston, I grew to hate SRV from oversaturation | |
| 17:51:14 | mriedem | it's all about hotdish | |
| 17:51:24 | mriedem | and bad sports teams | |
| 17:59:24 | openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | |
| 18:01:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | |
| 18:01:36 | KeithMnemonic | frickler I will let you know what I find out. my guess is it is some config issue in this one env, as so far i can not reproduce it | |
| 18:01:52 | gmann | melwitt: I added you as 'Feature Liaison' in policy spec re-proposed for U. https://review.opendev.org/#/c/686058/ | |
| 18:01:58 | KeithMnemonic | ah did not see i posted already, too much going on today | |
| 18:02:24 | KeithMnemonic | if anyone has time to please review https://review.opendev.org/683008 i appreciate it | |
| 18:02:49 | melwitt | gmann: ok, thanks | |
| 18:03:13 | gmann | melwitt: I will rebase the code patches once the spec is merged. looking for your review on this re-proposed spec. | |
| 18:03:30 | melwitt | ack | |
| 18:03:34 | gmann | thanks | |
| 18:05:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add live migration recreate test for bug 1848343 https://review.opendev.org/688994 | |
| 18:05:44 | openstack | bug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/1848343 | |
| 18:05:46 | artom | gmann, since you're around, gentle poke, re: whitebox spec: https://review.opendev.org/#/c/656890/ | |
| 18:06:45 | gmann | artom: thanks for reminder. I will surly review this week, (as done for train release things.) | |
| 18:18:43 | mriedem | dansmith: do you want to fix this nit otherwise i'm +2 https://review.opendev.org/#/c/687141/ | |
| 18:19:05 | dansmith | mriedem: oh sure, just a sec | |
| 18:19:58 | openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | |
| 18:20:07 | dansmith | mriedem: spanks ^ | |
| 18:20:31 | mriedem | how did you know i was wearing those? | |
| 18:20:45 | mriedem | oh s/k/x/ | |
| 18:20:46 | dansmith | I think you mean Spanx(tm) | |
| 18:20:49 | dansmith | I was saying | |
| 18:20:57 | dansmith | "spanks for catching that" | |
| 18:21:00 | mriedem | yeah i know | |
| 18:21:06 | mriedem | i just wanted to make a spanx joke | |
| 18:21:31 | dansmith | noted | |
| 18:44:00 | mriedem | argh, | |
| 18:44:06 | mriedem | Instance.save(expected_state_state=) | |
| 18:44:08 | mriedem | that's a tuple or lits, | |
| 18:44:11 | mriedem | *list | |
| 18:44:17 | mriedem | the singular in the name *always* screws me up | |
| 18:44:31 | mriedem | we should maybe guard against that in the save method | |
| 18:44:31 | dansmith | except that it takes None too, IIRC | |
| 18:44:48 | mriedem | yeah, | |
| 18:44:55 | mriedem | so if not None, assert it's an iterable | |
| 18:45:16 | mriedem | https://review.opendev.org/#/c/627891/63/nova/conductor/tasks/cross_cell_migrate.py@423 | |
| 18:46:39 | efried | melwitt: in case you haven't been following closely, note that we no longer do fast approvals for unchanged spec reproposals. | |
| 18:47:13 | melwitt | efried: I had read that in one of the emails, then forgot about it, so thanks for reminding | |
| 18:50:24 | mriedem | yeah we have several places where we pass a string to expected_task_state | |
| 18:53:32 | artom | expected_attrs all over again | |
| 18:53:52 | mriedem | https://bugs.launchpad.net/nova/+bug/1848373 | |
| 18:53:52 | openstack | Launchpad bug 1848373 in OpenStack Compute (nova) "Instance.save(expected_task_state=) is passed string in many locations" [Medium,Triaged] | |
| 18:54:31 | melwitt | dynamic types ftw | |
| 18:57:50 | mriedem | back in 2012 the db api handled it.... https://review.opendev.org/#/c/12222/5/nova/db/sqlalchemy/api.py | |
| 18:57:53 | efried | gmann: was os-cells a cellsv1 thing? | |
| 18:57:57 | mriedem | yes | |
| 18:58:16 | efried | thx | |
| 18:58:28 | gmann | yeah | |
| 18:58:30 | melwitt | hah, I wonder why that was removed | |
| 18:59:12 | mriedem | https://review.opendev.org/#/c/202593/ | |
| 18:59:22 | mriedem | since liberty | |
| 18:59:34 | mriedem | so i don't even know if expected_task_state is even enforced in the DB API anymore | |
| 18:59:40 | mriedem | dansmith: ^ does that jive with you? | |
| 19:00:09 | mriedem | https://github.com/openstack/nova/blob/1a226aaa9e8c969ddfdfe198c36f7966b1f692f3/nova/db/sqlalchemy/api.py#L2783 is definitely no longer true | |
| 19:01:19 | mriedem | wtf, that expected= kwarg in instance_update_and_get_original isn't even used anywhere | |
| 19:01:54 | dansmith | mriedem: I don't think I know anything about that change | |
| 19:02:06 | mriedem | i remember mdbooth pushing for it way back when | |
| 19:02:35 | dansmith | I remember talking about the comnpare-and-swap thing | |
| 19:03:21 | mriedem | and i reverted the first attempt https://review.opendev.org/#/c/201771/ | |
| 19:05:38 | melwitt | time for another revert | |
| 19:05:39 | melwitt | JUST KIDDING | |
| 19:05:52 | mriedem | don't tempt me | |
| 19:07:02 | mriedem | oh i see where expected_task_state is used | |
| 19:07:04 | mriedem | tricky | |
| 19:07:24 | mriedem | https://github.com/openstack/nova/blob/1a226aaa9e8c969ddfdfe198c36f7966b1f692f3/nova/db/sqlalchemy/api.py#L2850 | |
| 19:09:06 | dansmith | # Coerce all single values to singleton lists | |
| 19:09:45 | mriedem | yeah i see that too | |
| 19:10:05 | mriedem | i'll abandon the bug since even though we're using the object interface incorrectly the db api is hiding it | |
| 19:11:50 | mriedem | the expected= kwarg is still never used from anywhere | |
| 19:12:03 | mriedem | so it just adds to confusion | |
| 19:25:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add compute side revert allocation test for bug 1848343 https://review.opendev.org/689013 | |
| 19:25:41 | openstack | bug 1848343 in OpenStack Compute (nova) "Reverting migration-based allocations leaks allocations if the server is deleted" [Medium,Triaged] https://launchpad.net/bugs/1848343 | |
| 19:27:52 | mriedem | heh, just got a random code review comment from someone on a merged commit in github, | |
| 19:28:01 | mriedem | i appreciate the stat padding but | |
| 19:38:42 | mriedem | stable/train is open so i've start +2ing things we were holding https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/train | |
| 19:38:46 | mriedem | *started | |
| 19:39:22 | mriedem | bauzas: since you brought up queens reviews last week maybe you can go through some of these tomorrow https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=1 | |
| 19:42:53 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: Switch to opensuse-15 nodeset https://review.opendev.org/689020 | |
| 19:51:14 | mriedem | efried: some rambling in https://review.opendev.org/#/c/687416/ if it means anything to you, probably not worth pursuing | |
| 20:07:45 | efried | mriedem: separate pursuit though, yah? | |
| 20:08:07 | efried | I was also considering making False the default throughout, since that's the more "modern" thing, but that would obv be a separate change as well. | |
| 20:08:14 | mriedem | efried: yeah | |
| 20:44:31 | KeithMnemonic | frickler: we found the issue, they needed -on-shared-storage. | |