| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-30 | |||
| 09:32:10 | aspiers | but also, "virtio-blk" is not a valid value in nova.objects.fields.SCSIModel | |
| 09:36:44 | aspiers | and in fact that doc is missing all the other valid values | |
| 10:16:03 | aspiers | ah, I think I figured it out | |
| 10:16:29 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use the `preferred` memory allocation mode for NUMA https://review.opendev.org/684375 | |
| 10:16:36 | aspiers | the default when hw_scsi_model is not specified is no SCSI controller, and something like <target dev='vda' bus='virtio'/> | |
| 10:17:03 | aspiers | which is colloquially referred to as virtio-blk, but it's just 'virtio' in the code | |
| 10:23:23 | sean-k-mooney | aspiers: yes the defualt for libvirt/kvm is virtio or virtio-blk or virtio block | |
| 10:23:58 | aspiers | sean-k-mooney: thanks for confirmation. just submitted https://review.opendev.org/#/c/685674/ | |
| 10:24:06 | sean-k-mooney | if you want to use virto-scsi you need to set the disk bus to scsi and then set the scsi model to virtio-scsi | |
| 10:25:16 | sean-k-mooney | the default storage contole depend on the hypervisor and virt type | |
| 10:25:32 | sean-k-mooney | it wont alwyas be virtio if you dont set hw_disk_bus | |
| 10:28:37 | sean-k-mooney | aspiers: this is the funciton in the libvirt driver that chooes the defult disk bus https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L221-L296 | |
| 10:31:52 | sean-k-mooney | i should also point out that there is this horrible code that tries to incorrectly determin the optimal default disk and cd buss form the image os | |
| 10:31:54 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L114-L147 | |
| 10:33:16 | sean-k-mooney | but its actully broken by desgin in that it expect the OS version to be concatonated into the os_distro field instead of actully reading the os_version field so it does not actully work correctly | |
| 10:39:24 | openstackgerrit | Dongcan Ye proposed openstack/nova master: libvirt: Check the guest support UEFI https://review.opendev.org/685678 | |
| 11:32:53 | sean-k-mooney | lyarwood: care to hit some easy sable patches in os-vif | |
| 11:33:05 | sean-k-mooney | https://review.opendev.org/#/c/683489/ https://review.opendev.org/#/c/683488/ | |
| 11:33:37 | sean-k-mooney | well not backports release stuff. just the git review and constraits file updates for train | |
| 11:48:41 | lyarwood | sean-k-mooney: ack looking | |
| 11:52:09 | lyarwood | sean-k-mooney: done | |
| 12:15:07 | openstackgerrit | Seyeong Kim proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info https://review.opendev.org/579004 | |
| 13:04:34 | openstackgerrit | Merged openstack/os-vif master: Update the constraints url https://review.opendev.org/683873 | |
| 13:12:28 | openstackgerrit | Merged openstack/os-vif master: Update master for stable/train https://review.opendev.org/683490 | |
| 13:27:12 | bauzas | mriedem: morningh | |
| 13:27:20 | bauzas | mriedem: reviewing a shit number of times https://review.opendev.org/#/c/678100/ | |
| 13:29:10 | bauzas | IIUC, we leak the source allocation by https://review.opendev.org/#/c/678100/1/nova/tests/functional/wsgi/test_services.py | |
| 13:35:38 | openstackgerrit | Merged openstack/os-vif stable/train: Update .gitreview for stable/train https://review.opendev.org/683488 | |
| 13:43:38 | mriedem | bauzas: i'm not following the question | |
| 13:43:50 | bauzas | sorry then | |
| 13:44:02 | mriedem | for evacuate we leak the source allocation when deleting the source compute service | |
| 13:44:13 | mriedem | b/c we fail to delete the resource provider b/c it has allocatoins against it from the evacuate | |
| 13:44:14 | bauzas | trying to exactly understand how to get an orphan allocation when resizeing | |
| 13:44:25 | bauzas | as I want to write some functest | |
| 13:44:33 | mriedem | for resize, you'd migrate the server so it gets to VERIFY_RESIZE, then delete the source compute service | |
| 13:44:43 | bauzas | for the moment, I did : create the instance, resize, delete the service | |
| 13:44:46 | mriedem | yes | |
| 13:44:56 | mriedem | the source resource provider will have allocations held by the migration record | |
| 13:45:04 | bauzas | but when confirming the resize, I get an exception | |
| 13:45:22 | mriedem | that's separate from the leaked allocation issue | |
| 13:46:03 | bauzas | hum, so, once I delete the service, I'll just delete the instance? | |
| 13:46:04 | mriedem | for one thing, if you restart the source compute service it will create a new compute node with a new uuid and a new resource provider, so the migration record won't be able to find allocations on that one | |
| 13:46:20 | mriedem | i guess i'd have to know what the error is when you go to confirm the resize | |
| 13:46:35 | bauzas | secf | |
| 13:47:36 | bauzas | mriedem: http://paste.openstack.org/show/780354/ | |
| 13:48:22 | bauzas | when confirming the resize, I get an exception saying that it doesn't get the source compute UUID | |
| 13:49:20 | mriedem | does the test stop/start a new compute service after deleting the original source compute service? | |
| 13:49:30 | mriedem | starting a new compute service is going to create a new compute node record | |
| 13:49:50 | mriedem | if you didn't fully stop the service it's going to have residual cached information in the ResourceTracker.compute_nodes dict | |
| 13:50:23 | mriedem | which is likely a bug in your test, though someone could totally forget to stop the compute service before deleting it, we have warnings in the API about that | |
| 13:51:35 | openstackgerrit | Merged openstack/os-vif stable/train: Update TOX/UPPER_CONSTRAINTS_FILE for stable/train https://review.opendev.org/683489 | |
| 13:51:52 | bauzas | mriedem: okay, I can restart the service before confirming, then | |
| 13:51:53 | bauzas | thanks | |
| 13:52:13 | mriedem | well, to do things the proper way, you should be stopping the source compute service, then deleting it, and then starting a new one | |
| 13:52:29 | mriedem | https://docs.openstack.org/api-ref/compute/?expanded=delete-compute-service-detail#delete-compute-service | |
| 13:53:22 | mriedem | so what is happening i think is that because you're confirming with a stale ResourceTracker.compute_nodes entry, it's trying to update a record that was deleted when you deleted the compute service | |
| 13:53:26 | mriedem | w/o stopping it | |
| 13:54:50 | mriedem | one could argue that drop_move_claim should handle that since we don't prevent you from deleting the compute service in the api w/o stopping it first | |
| 13:54:56 | mriedem | but it's a different bug | |
| 13:55:49 | bauzas | okay, I'll quickly write it | |
| 13:56:32 | mriedem | b/c of this https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L714 is why we don't create a new compute node record when you start the service after deleting it | |
| 13:56:39 | mriedem | and we're using the old now-deleted version | |
| 13:57:03 | mriedem | https://review.opendev.org/#/c/684849/ is a similar issue | |
| 13:57:13 | mriedem | i've found a few problems in the RT code lately b/c of that caching | |
| 13:57:30 | mriedem | https://review.opendev.org/#/q/I9fa1d509a3de405d6246fb8670612c65c10cc93b | |
| 13:58:49 | mriedem | feel free to hit the queens backport for ^ before you get a bz downstream for it anyway | |
| 14:02:22 | mriedem | need another stable core to approve this backport for train rc2 https://review.opendev.org/#/c/685387/ | |
| 14:02:49 | bauzas | mriedem: can do | |
| 14:06:53 | mriedem | bauzas: btw i might have misled you with a comment on your placement audit patch about recreating an evacuate scenario with leaked allocations, if i said there is a migration-based allocatoin on the source provider during evacuate, that was wrong | |
| 14:07:04 | mriedem | we only do migration-based allocation swap-a-roo for cold and live migrate | |
| 14:07:07 | mriedem | *and resize | |
| 14:07:37 | bauzas | mriedem: hmmm | |
| 14:07:44 | mriedem | there is an allocation on the source provider, it's just not held by a migration record, it's held by the instance consumer | |
| 14:08:04 | bauzas | mriedem: that's what I found | |
| 14:08:15 | bauzas | mriedem: I already have a test for evacuate which works | |
| 14:08:59 | bauzas | mriedem: https://review.opendev.org/#/c/670112/5/nova/tests/functional/test_nova_manage.py@1470 (but I need to rewrite this test to use the existing helpers thanks to gibi :) ) | |
| 15:14:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in '_IntegratedTestBase' subclasses https://review.opendev.org/684326 | |
| 15:14:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in 'ApiSampleTestBase' subclasses https://review.opendev.org/684328 | |
| 15:14:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in 'ServersSampleBase' subclasses https://review.opendev.org/684330 | |
| 15:14:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | |
| 15:14:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | |
| 15:14:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | |
| 15:14:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | |
| 15:14:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | |
| 15:14:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | |
| 15:14:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_networks_associate' functional tests https://review.opendev.org/684338 | |
| 15:14:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | |
| 15:14:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | |
| 15:14:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | |
| 15:14:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | |
| 15:14:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | |
| 15:14:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | |
| 15:14:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | |
| 15:25:24 | openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825 | |
| 15:25:56 | openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825 | |
| 15:29:55 | openstackgerrit | Merged openstack/nova stable/train: Stop filtering out 'accepted' for in-progress migrations https://review.opendev.org/685387 | |
| 15:34:27 | openstackgerrit | Eric Fried proposed openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593 | |
| 15:36:34 | dansmith | efried: looks like that should be an rc2 thing eh? | |
| 15:39:35 | dansmith | really, the guest config module should handle that | |
| 15:41:59 | efried | dansmith: Could make an argument for RC2, yeah. | |