Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-30
15:25:24 openstackgerrit Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825
15:25:56 openstackgerrit Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825
15:29:55 openstackgerrit Merged openstack/nova stable/train: Stop filtering out 'accepted' for in-progress migrations https://review.opendev.org/685387
15:34:27 openstackgerrit Eric Fried proposed openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593
15:36:34 dansmith efried: looks like that should be an rc2 thing eh?
15:39:35 dansmith really, the guest config module should handle that
15:41:59 efried dansmith: Could make an argument for RC2, yeah.
15:42:08 efried since basically py3 is busted otherwise.
15:42:17 dansmith it's a regression and a broken feature we added in train, so it seems clear to me
15:42:48 efried dansmith: Since Alex was +2 and I just changed the test, would you feel good about fast approving it?
15:43:27 efried "the guest config module should handle" like by knowing which fields are supposed to be int and casting them before stringifying them?
15:43:31 dansmith I'm pulling it down to mess with it
15:43:54 dansmith efried: uhyeah.. right now it would stringify an object in that field if you gave it to it
15:43:56 dansmith which is dumb
15:44:02 dansmith obviously not for this fix though
15:44:26 efried yeah, seems like probably that would be a pervasive problem throughout
15:44:34 efried though I haven't looked
15:44:35 dansmith it is, from a quick look
15:45:07 efried It took me a hot minute to figure out why we weren't getting by on the fact that the ovo fields are IntegerField()
15:45:15 efried but it's because we're doing the conversion after that
15:45:22 efried s/conversion/division/
15:45:35 dansmith yeah, this is way after any object stuff
15:50:58 openstackgerrit Dan Smith proposed openstack/nova stable/train: make virtual pmem feature compatible with python3 https://review.opendev.org/685742
15:58:30 dansmith I guess if we
15:58:48 dansmith are going to merge things based purely on manual testing by the submitter, we should ask for them to do it in py2 and py3
15:58:56 dansmith (or not do that thing)
16:00:40 efried Well, it wasn't manual, it was 3pCI, but I never thought to check that it was running py3.
16:00:51 efried Are we planning to continue supporting py2 in ussuri?
16:01:24 efried the argument could be made that testing (3pCI et al) should *only* be py3
16:03:10 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326
16:03:10 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332
16:03:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333
16:03:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334
16:03:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335
16:03:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
16:03:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
16:03:13 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_networks_associate' functional tests https://review.opendev.org/684338
16:03:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339
16:03:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
16:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
16:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
16:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
16:03:16 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
16:03:17 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:03:55 bauzas mriedem: you know what ? can't confirm a resize after stopping/deleting/restarting the original compute
16:04:19 mriedem that's not surprising
16:04:23 bauzas mriedem: after this, I'm stopping to do this, I'll just mock out the allocation delete
16:04:38 bauzas so it'll just leave the orphaned migration allocation
16:05:35 mriedem bauzas: i'm assuming the failure is the same as before? or something new because on restart of the source compute service, we've created a new compute node record with a new uuid and a new resource provider and we can't cleanup the migration-based allocations b/c we're looking for the wrong provider?
16:05:58 bauzas mriedem: a different exception
16:06:11 bauzas mriedem: a conflict because we want to recreate a new RP with the same name
16:06:12 mriedem do you have a paste?
16:06:25 bauzas sure, sec
16:06:39 mriedem nvm that's a known bug
16:07:07 mriedem https://bugs.launchpad.net/nova/+bug/1817833
16:07:07 openstack Launchpad bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)
16:07:11 mriedem called out in https://review.opendev.org/#/c/678100/
16:08:00 bauzas mriedem: http://paste.openstack.org/show/780370/
16:08:13 bauzas mriedem: anyway, like I said, I'll just mock out the allocation delete
16:08:30 bauzas so once we fix the bug, we won't need to modify the functional test
16:08:49 bauzas (or I'll just recreate the migration allocation)
16:09:06 bauzas in order to make sure the nova-manage audit command sees it and then deletes it if asked
16:10:46 mriedem i'd make sure to have a note explaining it's due to bug 1817833
16:10:46 openstack bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem)
16:10:51 mriedem if you're mocking things out in a functional test
16:11:40 bauzas mriedem: I'll write something and rushing to upload it, so you can provide comments
16:12:07 mriedem you're assuming i'm going to review that today...
16:12:24 mriedem but sure :)
16:12:53 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334
16:12:55 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335
16:12:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
16:12:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
16:12:57 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
16:12:57 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
16:12:58 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
16:12:58 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
16:12:59 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
16:12:59 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:13:37 bauzas mriedem: nah, it's 6:13pm, my wife is looking at me angrily
16:13:45 bauzas mriedem: so I'll do this tomorrow morning
16:13:47 mriedem i understand
16:14:28 bauzas well, my wife understands more my upstream work than other folks :)
16:19:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:21:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Migrate old style volume attachments on nova-compute startup https://review.opendev.org/549130
16:21:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Extract some helper functions from DriverVolumeBlockDevice https://review.opendev.org/685752
16:24:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
16:24:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:26:52 openstackgerrit Merged openstack/nova-specs master: Fix invalid link index https://review.opendev.org/685664
16:45:50 openstackgerrit Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825
16:47:44 openstackgerrit Adam Spiers proposed openstack/nova stable/train: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/685756
17:05:40 efried aspiers: RC2? ^
17:06:07 efried not clear from the bug report what actually breaks
17:11:46 sean-k-mooney efried: im guessing it breaks sev guest when you set the disk bus to scsi and select virt-scsi as the model
17:14:08 efried sean-k-mooney: is that something that happens frequently?
17:14:13 sean-k-mooney yes
17:14:41 efried and by "breaks" -- the guest won't boot? or won't be SEV'd? or...?
17:14:52 sean-k-mooney hw_disk_mode=scsi and hw_scsi_model=virtio-scsi is the recommend mode for ceph

Earlier   Later