| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 13:16:32 | sean-k-mooney | * __eq__ | |
| 13:16:41 | efried | right, but it's not called "two_objects_identical" | |
| 13:16:46 | efried | it's called "all_things_equal" | |
| 13:17:06 | sean-k-mooney | yes and equal is a stonger guarentee then equvalent | |
| 13:17:19 | sean-k-mooney | anyway | |
| 13:17:23 | lyarwood | mriedem: no if it's new | |
| 13:17:25 | sean-k-mooney | the way its used it will work | |
| 13:18:03 | efried | sean-k-mooney: the only reason this code is added to base is so it can be removed from numa and reused | |
| 13:18:07 | efried | the code isn't changed. | |
| 13:18:19 | sean-k-mooney | so ill change to a +1 i guess but i still think that is an incorerct implemation of __eq__ | |
| 13:18:41 | sean-k-mooney | right i think the code in numa was wrong | |
| 13:18:56 | sean-k-mooney | againg it proably works for the case we use it in | |
| 13:19:03 | sean-k-mooney | *again | |
| 13:19:23 | sean-k-mooney | but its not generally correct | |
| 13:20:01 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 13:20:28 | alex_xu | sean-k-mooney: I guess just quite return, since self can't be None, if the other is None, then just return False | |
| 13:20:34 | lyarwood | mriedem: that smells like more of an issue with resume_guests_state_on_host_boot tbh | |
| 13:20:48 | efried | sean-k-mooney: more tech debt we shouldn't be fixing here. | |
| 13:21:09 | efried | see https://review.opendev.org/#/c/681397/8 | |
| 13:21:14 | sean-k-mooney | efried: ya i said it could be fix in a follow up | |
| 13:21:30 | sean-k-mooney | as a free fuction its incorrect | |
| 13:21:52 | sean-k-mooney | but if only invoked in __eq__ where the first arguemtn it self | |
| 13:22:00 | sean-k-mooney | then soem of the assumtion make sense | |
| 13:26:03 | efried | sean-k-mooney: are you un -1 ing? | |
| 13:26:39 | sean-k-mooney | ill +1 but https://www.python.org/dev/peps/pep-0207/#proposed-resolutions section 4 allow the interperter to swap the arguemtn to == which is why i rased this | |
| 13:27:02 | bauzas | folks, I'm being dragged for some internal bug duty, ping me for urgent reviews | |
| 13:27:12 | efried | ack, thanks bauzas | |
| 13:27:23 | bauzas | live my life | |
| 13:27:34 | sean-k-mooney | efried: if == is not reflexiv/semetic it can break on no cpython impmenations | |
| 13:27:52 | sean-k-mooney | on cpython this will work fine as it wont swap them | |
| 13:28:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Log notifications if assertion in _test_live_migration_force_complete fails https://review.opendev.org/681743 | |
| 13:28:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix race in _test_live_migration_force_complete https://review.opendev.org/681744 | |
| 13:28:29 | efried | sean-k-mooney: open a bug? | |
| 13:29:01 | sean-k-mooney | sure | |
| 13:32:11 | mriedem | gibi: sorry about all of that _reschedule_resize_or_reraise noise | |
| 13:32:15 | mriedem | i had the logic obviously wrong | |
| 13:35:47 | efried | I'm going to get a nap while the gate cranks. Back in... say, 3.5h. | |
| 13:35:50 | dansmith | gate looks constipated | |
| 13:35:56 | dansmith | heh | |
| 13:36:16 | efried | dansmith: there was a dep problem overnight, resolved now, but everything is backed up, yes. | |
| 13:36:50 | bauzas | dansmith: we checked whether we should provide the gate a pill, but looks like the issue is solved | |
| 13:37:12 | gibi | mriedem: no worries. I needed my fresh mind the morning to figure out what is going on. | |
| 13:37:51 | gibi | mriedem, bauzas: I will be on and off in the coming 2-3 hours. But I will be back for the night to finish up things if needed | |
| 13:38:07 | bauzas | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ERROR%3A%20Could%20not%20find%20a%20version%20that%20satisfies%20the%20requirement%20configparser%5C%22 | |
| 13:38:14 | dansmith | bauzas: go natural: https://www.youtube.com/watch?v=Ku42Iszh9KM | |
| 13:38:33 | bauzas | gibi: like I said, I'm also dragged due to some internal bug scrub duty | |
| 13:38:49 | bauzas | :( | |
| 13:38:51 | mriedem | gibi: ok, i did spot a race in the new functional test in the sriov patch, so i'm going to -1 for that, but i can probably just fix and rebase the series myself | |
| 13:39:15 | mriedem | bauzas: you can't tell your management / team lead that today is f'ing upstream feature freeze? | |
| 13:39:19 | mriedem | and get a 1 day break? | |
| 13:39:35 | bauzas | dansmith: I wish you knew some french folks named "Les Nuls" so I could share you some video | |
| 13:39:57 | dansmith | heh | |
| 13:40:10 | mriedem | if bauzas can't review the rest of the bw provider migrate series i'll see if i can get melwitt to help out | |
| 13:40:24 | bauzas | mriedem: this duty should be around 1 hour or 2 | |
| 13:40:28 | bauzas | but then I'll have meeting | |
| 13:40:33 | bauzas | yay | |
| 13:40:54 | mriedem | is there a manager standing next to you with a gun to your head saying you have to do bug duty over FF? | |
| 13:40:59 | mriedem | can you tell them you're a nova core? | |
| 13:41:05 | mriedem | one of the remaining few? | |
| 13:41:09 | bauzas | my dog is barking at me | |
| 13:41:24 | mriedem | whatever, this is why i have no hope for "we'll do it in U" | |
| 13:42:07 | bauzas | mriedem: that's why you'll never see me saying "Ussuri" | |
| 13:42:16 | bauzas | mriedem: "Unicorn" sounds a way better release name | |
| 13:42:35 | bauzas | (more appropriate at least) | |
| 13:43:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count https://review.opendev.org/681374 | |
| 13:43:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 13:43:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | |
| 13:43:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | |
| 13:43:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 13:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Additional functional tests for pinned instances https://review.opendev.org/681750 | |
| 13:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove single-use classmethod https://review.opendev.org/681751 | |
| 13:44:39 | alex_xu | stephenfin: need you kick the first one https://review.opendev.org/#/c/678447/14 | |
| 13:44:41 | stephenfin | dansmith: In case you didn't see the scrollback, we modified the solution in https://review.opendev.org/671801 slightly | |
| 13:44:48 | stephenfin | alex_xu: just done | |
| 13:44:53 | alex_xu | stephenfin: thanks | |
| 13:45:04 | stephenfin | though I realize I missed some of your comments | |
| 13:45:22 | artom | bauzas, want me to do the bugs thing? | |
| 13:45:28 | artom | bauzas, so you can concentrate on w/e? | |
| 13:45:31 | stephenfin | alex_xu: However, https://review.opendev.org/#/c/671801/ should be ready for your viewing pleasure too | |
| 13:45:42 | bauzas | artom: how is your series ? | |
| 13:45:48 | alex_xu | stephenfin: got it | |
| 13:45:55 | artom | bauzas, merged (well, merging, because gate) | |
| 13:46:06 | stephenfin | bauzas: Want to look at https://review.opendev.org/#/c/681750/, pretty please? | |
| 13:46:07 | artom | (Otherwise I wouldn't have offered) | |
| 13:46:21 | stephenfin | (I split it out to make https://review.opendev.org/#/c/671801/ smaller) | |
| 13:46:29 | bauzas | artom: cool then okay, we could switch | |
| 13:46:45 | bauzas | stephenfin: I can | |
| 13:46:47 | artom | bauzas, ack, I'll handle the bugs, do your nova core job | |
| 13:47:08 | bauzas | stephenfin: did your reorganised your series ? | |
| 13:47:16 | bauzas | oh wait no | |
| 13:47:20 | stephenfin | nope, just broke some things out | |
| 13:47:28 | artom | The "out" is ket | |
| 13:47:30 | artom | *key | |
| 13:48:36 | dansmith | stephenfin: I didn't but I'll try to circle back in a bit | |
| 13:49:41 | alex_xu | stephenfin: I didn't find that part for sean-k-mooney said host both have pcpu and vcpu | |
| 13:50:43 | stephenfin | alex_xu: We test it implicitly here https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@364 | |
| 13:50:55 | stephenfin | Both of those hosts have both PCPU and VCPU inventory | |
| 13:51:33 | stephenfin | and we still get PCPU as expected https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@460 | |
| 13:51:44 | stephenfin | and https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@489 | |
| 13:53:49 | mriedem | gibi: i've gone through the updates, i'll rebase and fix the small things and then i'll be +2 up the stack | |