| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 13:44:39 | alex_xu | stephenfin: need you kick the first one https://review.opendev.org/#/c/678447/14 | |
| 13:44:41 | stephenfin | dansmith: In case you didn't see the scrollback, we modified the solution in https://review.opendev.org/671801 slightly | |
| 13:44:48 | stephenfin | alex_xu: just done | |
| 13:44:53 | alex_xu | stephenfin: thanks | |
| 13:45:04 | stephenfin | though I realize I missed some of your comments | |
| 13:45:22 | artom | bauzas, want me to do the bugs thing? | |
| 13:45:28 | artom | bauzas, so you can concentrate on w/e? | |
| 13:45:31 | stephenfin | alex_xu: However, https://review.opendev.org/#/c/671801/ should be ready for your viewing pleasure too | |
| 13:45:42 | bauzas | artom: how is your series ? | |
| 13:45:48 | alex_xu | stephenfin: got it | |
| 13:45:55 | artom | bauzas, merged (well, merging, because gate) | |
| 13:46:06 | stephenfin | bauzas: Want to look at https://review.opendev.org/#/c/681750/, pretty please? | |
| 13:46:07 | artom | (Otherwise I wouldn't have offered) | |
| 13:46:21 | stephenfin | (I split it out to make https://review.opendev.org/#/c/671801/ smaller) | |
| 13:46:29 | bauzas | artom: cool then okay, we could switch | |
| 13:46:45 | bauzas | stephenfin: I can | |
| 13:46:47 | artom | bauzas, ack, I'll handle the bugs, do your nova core job | |
| 13:47:08 | bauzas | stephenfin: did your reorganised your series ? | |
| 13:47:16 | bauzas | oh wait no | |
| 13:47:20 | stephenfin | nope, just broke some things out | |
| 13:47:28 | artom | The "out" is ket | |
| 13:47:30 | artom | *key | |
| 13:48:36 | dansmith | stephenfin: I didn't but I'll try to circle back in a bit | |
| 13:49:41 | alex_xu | stephenfin: I didn't find that part for sean-k-mooney said host both have pcpu and vcpu | |
| 13:50:43 | stephenfin | alex_xu: We test it implicitly here https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@364 | |
| 13:50:55 | stephenfin | Both of those hosts have both PCPU and VCPU inventory | |
| 13:51:33 | stephenfin | and we still get PCPU as expected https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@460 | |
| 13:51:44 | stephenfin | and https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@489 | |
| 13:53:49 | mriedem | gibi: i've gone through the updates, i'll rebase and fix the small things and then i'll be +2 up the stack | |
| 13:53:54 | alex_xu | emm...let me check | |
| 13:54:14 | bauzas | mriedem: cool, I'll look at the series once i'm done with a couple of changes from stephenfin | |
| 13:55:11 | mriedem | efried_afk: so we're pushing PCPU in before the scheduler and quotas stuff is approved? https://review.opendev.org/#/c/671793/ | |
| 13:56:10 | mriedem | i think for train the quotas one is pretty straight-forward, counting from placement will work the same as counting from nova, | |
| 13:56:16 | mriedem | but the scheduler patch looks like it's still in flux | |
| 13:56:20 | stephenfin | the quota stuff has got a tentative ack from melwitt, and the scheduler stuff has the same from efried and alex_xu | |
| 13:56:22 | stephenfin | see here | |
| 13:56:29 | stephenfin | https://review.opendev.org/#/c/681719/ | |
| 13:57:05 | dansmith | even still, if we were to land that first patch and get stuck on the rest, we've got a config option that claims to enable something that doesn't, which is uncool | |
| 13:58:05 | stephenfin | it'll do exactly what it says - you just won't be able to use the things it provides (PCPUs) | |
| 13:58:19 | gibi | mriedem: thanks a lot! | |
| 13:58:39 | bauzas | stephenfin: can you please tell me why we need this https://review.opendev.org/#/c/681750/1/nova/tests/unit/virt/libvirt/fake_imagebackend.py ? | |
| 13:58:52 | mriedem | i hope there is going to be some "so you want to use PCPUs" admin doc at some point b/c there are a ton of moving parts | |
| 13:59:17 | bauzas | mriedem: I feel there are some docs that absolutely need to be written | |
| 13:59:20 | stephenfin | bauzas: There's a check deep in the libvirt code for that. If it's not done, it complains with "function doesn't have attribute SUPPORTS_CLONE" | |
| 13:59:33 | bauzas | mriedem: in particular given the upgrade plan we took a while to agree this morning | |
| 13:59:50 | stephenfin | bauzas: I'm not the only one who found that. This is from the vPMEM series https://review.opendev.org/#/c/678470/35/nova/tests/unit/virt/libvirt/fake_imagebackend.py | |
| 13:59:51 | mriedem | stephenfin: there should probably be a comment on that in the fake imagebackend code then | |
| 14:00:02 | bauzas | stephenfin: what mriedem said | |
| 14:00:15 | bauzas | because I have no idea why you need this | |
| 14:00:23 | mriedem | pretty gross that the virt agnostic image backend fixture has to have libvirt specific stuff in it | |
| 14:00:56 | mriedem | bauzas: stephenfin loves to doc so i'm sure he doesn't have a problem documenting all the things | |
| 14:01:22 | bauzas | mriedem: the upgrade strategy is a bit tricky, I'm just saying we need to carefully doc it | |
| 14:01:35 | bauzas | based on the fact we'll provide some options | |
| 14:01:38 | stephenfin | mriedem: It's a libvirt-specific image backend fixture - look at the filename | |
| 14:01:51 | stephenfin | it's for mocking out nova/virt/libvirt/imagebackend.py | |
| 14:02:56 | mriedem | stephenfin: you're right, sorry - i was thinking of https://review.opendev.org/#/c/678470/35/nova/tests/unit/image/fake.py | |
| 14:03:36 | stephenfin | all g | |
| 14:03:43 | stephenfin | I wonder what the comment should be though | |
| 14:04:10 | stephenfin | I mean, it's an attribute of the Image base class in nova/virt/libvirt/imagebackend.py | |
| 14:04:26 | stephenfin | and this function is a stub for that class (or some subclass) | |
| 14:04:50 | stephenfin | so it's not really doing anything special but rather just ensuring the stub looks like the thing it's stubbing | |
| 14:05:22 | mriedem | # Set the SUPPORTS_CLONE member variable to satisfy the Image base class. | |
| 14:08:11 | stephenfin | Sounds good. Done | |
| 14:08:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Additional functional tests for pinned instances https://review.opendev.org/681750 | |
| 14:08:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count https://review.opendev.org/681374 | |
| 14:08:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 14:08:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | |
| 14:08:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | |
| 14:08:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 14:08:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove single-use classmethod https://review.opendev.org/681751 | |
| 14:09:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove single-use classmethod https://review.opendev.org/681751 | |
| 14:13:33 | dansmith | stephenfin: what job logs can I look at to see this running? | |
| 14:14:29 | stephenfin | dansmith: Look at the functional logs for https://review.opendev.org/#/c/671801 | |
| 14:14:41 | dansmith | no I mean a devstack/tempest job | |
| 14:16:17 | stephenfin | None. The Intel NFV CI has been missing for quite some time. It's been alex_xu, sean-k-mooney, Bhagyashri Shewale (forgot his IRC nick) and I testing it locally | |
| 14:16:37 | dansmith | stephenfin: is there some reason this has to be tested in special ci? | |
| 14:16:51 | sean-k-mooney | yes it need nested virt | |
| 14:16:52 | stephenfin | Pinned CPUs. That needs nested virt | |
| 14:16:58 | stephenfin | which we can't rely on | |
| 14:17:00 | sean-k-mooney | but i can test it in FN | |
| 14:17:06 | dansmith | we can't get a one-off? | |
| 14:17:14 | dansmith | sean-k-mooney: that would be good | |
| 14:17:22 | artom | stephenfin, wait, I thought this used the <vcpus> style pinning, no? | |
| 14:17:29 | artom | Which *does* work in the vanilla gate | |
| 14:17:42 | dansmith | I'm shocked that artom and sean-k-mooney were able to get numa live migration tested for us, so surely this is possible | |
| 14:18:07 | sean-k-mooney | that was also testing pinning with the resize flavors | |
| 14:18:09 | sean-k-mooney | so yes | |
| 14:18:23 | artom | dansmith, let's be honest, *sean-k-mooney* was able to get NUMA live migration tested | |
| 14:18:37 | dansmith | artom: I just meant that effort, but sure | |
| 14:18:38 | stephenfin | sean-k-mooney: can we just point the same job at the top-most change of this so? | |
| 14:18:51 | sean-k-mooney | we can also technical test non numa stuff in vexhost and limestone | |
| 14:19:13 | sean-k-mooney | stephenfin: yes but ill create a second patch | |
| 14:19:14 | dansmith | I'm disappointed that nobody has asked this question yet :/ | |
| 14:19:20 | sean-k-mooney | i want to actully merge that job | |
| 14:20:28 | stephenfin | between manual tests and the functional tests, I figure our coverage is pretty much spot on as-is | |
| 14:20:33 | dansmith | stephenfin: what testing are you doing locally? Just hand booting some things or running tempest? | |
| 14:20:48 | artom | dansmith, presumably the crucial thing would be testing the upgrade path - so something grenade-y? | |
| 14:20:50 | stephenfin | dansmith: https://etherpad.openstack.org/p/nova-cpu-resources | |
| 14:21:27 | stephenfin | alex_xu has his own set of tests that he's been working towards too | |
| 14:21:28 | sean-k-mooney | what do people want me to actully test for this in the ci job? | |