| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 12:08:47 | sean-k-mooney | if there are free pcpus and vcpus we will pass the host and have two candiates | |
| 12:09:00 | sean-k-mooney | and hopefully rely on orderr to pic the PCPU one | |
| 12:09:14 | efried | Yes exactly. Whole point of this is to make sure the first thing we look at is *either* a PCPU candidate *or* there are no PCPU candidates. | |
| 12:09:29 | sean-k-mooney | ya | |
| 12:09:49 | sean-k-mooney | stephenfin: rather then guessing | |
| 12:09:52 | sean-k-mooney | can you add a test | |
| 12:10:05 | stephenfin | sure. What should the test do? | |
| 12:10:06 | sean-k-mooney | create a host that has inventories fo both | |
| 12:10:15 | sean-k-mooney | and assrt the pcpu inventory was calimed | |
| 12:10:20 | sean-k-mooney | as a functional test | |
| 12:10:36 | stephenfin | I think I have that already | |
| 12:10:40 | sean-k-mooney | if it is we are all good | |
| 12:10:58 | efried | If ordering was random, that would be nondeterministic | |
| 12:11:07 | stephenfin | sean-k-mooney: Yeah, look at https://review.opendev.org/#/c/671801/46/nova/tests/functional/libvirt/test_numa_servers.py@364 | |
| 12:11:10 | alex_xu | If a host have both vcpu and pcpu, then we will get two allocation_request in alloc_reqs_by_rp_uuid https://review.opendev.org/#/c/681719/1/nova/scheduler/manager.py@212 | |
| 12:11:10 | sean-k-mooney | well we coudl do it in a loop | |
| 12:11:15 | sean-k-mooney | bug fair point | |
| 12:11:24 | stephenfin | It's a resize test but it does exactly this | |
| 12:11:25 | alex_xu | then we only claim the PCPU one | |
| 12:11:28 | stephenfin | Lemme run that in a loop | |
| 12:11:29 | efried | alex_xu: exactly | |
| 12:12:14 | alex_xu | so there will be check to found out there two allocation req, one for vcpu and another for pcpu, then only claim for pcpu | |
| 12:14:14 | sean-k-mooney | ok i think ye have that in hand to ill go back to the vpmem reviews | |
| 12:17:34 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Update flavor-related metadata on resize https://review.opendev.org/681004 | |
| 12:18:08 | stephenfin | efried: What was the decision on '.update()' vs. the for-loop again? | |
| 12:21:18 | sean-k-mooney | stephenfin: update is fine | |
| 12:21:36 | sean-k-mooney | the sumaris will be the same | |
| 12:22:15 | sean-k-mooney | efried: the vpmem xml generation patch looks sane to me | |
| 12:22:29 | sean-k-mooney | im starting form the bottom of the seriese now and working my way up | |
| 12:25:00 | openstackgerrit | Merged openstack/nova master: Fix race in _test_live_migration_force_complete https://review.opendev.org/681540 | |
| 12:25:01 | sean-k-mooney | donnyd: thanks for the head up on the mirror issue | |
| 12:26:24 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Update flavor-related metadata on resize https://review.opendev.org/681004 | |
| 12:28:03 | donnyd | sean-k-mooney: I think we have it narrowed down. should be back up in the next couple hours | |
| 12:28:30 | sean-k-mooney | it looks like its the same issue i was having from your conversation on infra | |
| 12:28:41 | sean-k-mooney | you are hitting MTU issue becasue of the tunnel | |
| 12:28:49 | sean-k-mooney | well similar | |
| 12:29:00 | sean-k-mooney | i needed to clamp it on HEs end | |
| 12:29:14 | sean-k-mooney | in your case you need to clamp the mtu in the neutron subnet | |
| 12:29:39 | sean-k-mooney | but same general symptoms of retransmits of large packets | |
| 12:30:24 | sean-k-mooney | by the way i also sit in the infra channel so you can always ping me there if there are issues | |
| 12:30:39 | sean-k-mooney | if you want to notify nova in general then here is fine too | |
| 12:37:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Skip querying resource request in revert_resize if no qos port https://review.opendev.org/681513 | |
| 12:38:12 | gibi | bauzas, mriedem: I've finished respinning the bandwidth series | |
| 12:41:45 | openstackgerrit | Thomas Bechtold proposed openstack/nova master: Add nova-status to man-pages list https://review.opendev.org/681733 | |
| 13:05:59 | bauzas | gibi: ack, will look | |
| 13:06:52 | openstackgerrit | Thomas Bechtold proposed openstack/nova master: Add nova-status to man-pages list https://review.opendev.org/681733 | |
| 13:10:35 | sean-k-mooney | luyao: efried stephenfin https://review.opendev.org/#/c/678448/21/nova/objects/base.py i think that is a proablem that should be fixed. it could be a follow up but all_things_equal is not a valid comparison implematnion of == | |
| 13:13:07 | efried | sean-k-mooney: say wha? | |
| 13:13:34 | sean-k-mooney | its not symetic so a == b will not always be the same as b == a | |
| 13:13:47 | sean-k-mooney | and it does not check type | |
| 13:14:17 | sean-k-mooney | so two ovo with the same filed will compare equal if they are complete unrelated types | |
| 13:14:18 | efried | sean-k-mooney: This code is copied in from numa.py | |
| 13:14:38 | efried | a is not None because this is invoked with `self` | |
| 13:14:55 | efried | and I don't care if they're different types. | |
| 13:15:05 | mriedem | lyarwood: have you seen this? https://bugs.launchpad.net/nova/+bug/1843643 | |
| 13:15:06 | openstack | Launchpad bug 1843643 in OpenStack Compute (nova) "VM on encrypted boot volume fails to start after compute host reboot" [Undecided,New] | |
| 13:16:14 | sean-k-mooney | efried: well it a free function so you can only rely on it being invoked with self when it is used to implement _equal_ | |
| 13:16:32 | sean-k-mooney | * __eq__ | |
| 13:16:41 | efried | right, but it's not called "two_objects_identical" | |
| 13:16:46 | efried | it's called "all_things_equal" | |
| 13:17:06 | sean-k-mooney | yes and equal is a stonger guarentee then equvalent | |
| 13:17:19 | sean-k-mooney | anyway | |
| 13:17:23 | lyarwood | mriedem: no if it's new | |
| 13:17:25 | sean-k-mooney | the way its used it will work | |
| 13:18:03 | efried | sean-k-mooney: the only reason this code is added to base is so it can be removed from numa and reused | |
| 13:18:07 | efried | the code isn't changed. | |
| 13:18:19 | sean-k-mooney | so ill change to a +1 i guess but i still think that is an incorerct implemation of __eq__ | |
| 13:18:41 | sean-k-mooney | right i think the code in numa was wrong | |
| 13:18:56 | sean-k-mooney | againg it proably works for the case we use it in | |
| 13:19:03 | sean-k-mooney | *again | |
| 13:19:23 | sean-k-mooney | but its not generally correct | |
| 13:20:01 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 13:20:28 | alex_xu | sean-k-mooney: I guess just quite return, since self can't be None, if the other is None, then just return False | |
| 13:20:34 | lyarwood | mriedem: that smells like more of an issue with resume_guests_state_on_host_boot tbh | |
| 13:20:48 | efried | sean-k-mooney: more tech debt we shouldn't be fixing here. | |
| 13:21:09 | efried | see https://review.opendev.org/#/c/681397/8 | |
| 13:21:14 | sean-k-mooney | efried: ya i said it could be fix in a follow up | |
| 13:21:30 | sean-k-mooney | as a free fuction its incorrect | |
| 13:21:52 | sean-k-mooney | but if only invoked in __eq__ where the first arguemtn it self | |
| 13:22:00 | sean-k-mooney | then soem of the assumtion make sense | |
| 13:26:03 | efried | sean-k-mooney: are you un -1 ing? | |
| 13:26:39 | sean-k-mooney | ill +1 but https://www.python.org/dev/peps/pep-0207/#proposed-resolutions section 4 allow the interperter to swap the arguemtn to == which is why i rased this | |
| 13:27:02 | bauzas | folks, I'm being dragged for some internal bug duty, ping me for urgent reviews | |
| 13:27:12 | efried | ack, thanks bauzas | |
| 13:27:23 | bauzas | live my life | |
| 13:27:34 | sean-k-mooney | efried: if == is not reflexiv/semetic it can break on no cpython impmenations | |
| 13:27:52 | sean-k-mooney | on cpython this will work fine as it wont swap them | |
| 13:28:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Log notifications if assertion in _test_live_migration_force_complete fails https://review.opendev.org/681743 | |
| 13:28:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix race in _test_live_migration_force_complete https://review.opendev.org/681744 | |
| 13:28:29 | efried | sean-k-mooney: open a bug? | |
| 13:29:01 | sean-k-mooney | sure | |
| 13:32:11 | mriedem | gibi: sorry about all of that _reschedule_resize_or_reraise noise | |
| 13:32:15 | mriedem | i had the logic obviously wrong | |
| 13:35:47 | efried | I'm going to get a nap while the gate cranks. Back in... say, 3.5h. | |
| 13:35:50 | dansmith | gate looks constipated | |
| 13:35:56 | dansmith | heh | |
| 13:36:16 | efried | dansmith: there was a dep problem overnight, resolved now, but everything is backed up, yes. | |
| 13:36:50 | bauzas | dansmith: we checked whether we should provide the gate a pill, but looks like the issue is solved | |
| 13:37:12 | gibi | mriedem: no worries. I needed my fresh mind the morning to figure out what is going on. | |
| 13:37:51 | gibi | mriedem, bauzas: I will be on and off in the coming 2-3 hours. But I will be back for the night to finish up things if needed | |