| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-06 | |||
| 21:25:15 | sean-k-mooney | are the nova unit test mocking stuff in os-bricks | |
| 21:25:20 | prometheanfire | try import except import? | |
| 21:25:33 | mnaser | btw | |
| 21:25:36 | mnaser | there is some context here https://review.opendev.org/#/c/643421/ | |
| 21:27:08 | sean-k-mooney | ok so we are importing the conector object in the test | |
| 21:27:41 | mnaser | `initiator.NVME` that was left around for backwards compat | |
| 21:28:01 | mnaser | but the connector did not keep a backwards compat | |
| 21:29:07 | mnaser | i mean as a work around you could fall back to asserting the initiator used instead of the connector used | |
| 21:29:45 | sean-k-mooney | so the real driver code use the factory method to consurct it | |
| 21:29:47 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/nvme.py#L34 | |
| 21:30:04 | mnaser | sean-k-mooney: it uses `initiator.NVME` which is still around | |
| 21:30:23 | sean-k-mooney | i think the real fix is to not assert thing abot the data type of an external lib | |
| 21:30:39 | mnaser | https://github.com/openstack/os-brick/blob/0f057aee6e0351bdef68fadf1fc56ac315027c98/os_brick/initiator/connector.py#L117-L122 | |
| 21:30:40 | mnaser | cause thats still around | |
| 21:30:52 | sean-k-mooney | mnaser: yes but i guess they considerd as part of the public interface | |
| 21:31:01 | sean-k-mooney | and the conector object are not | |
| 21:31:30 | mnaser | maybe the test should mock `connector.InitiatorConnector.factory` and make sure it calls it with initiator.NVME ? | |
| 21:31:39 | mnaser | which is enough to know we are doing the right thing(tm) | |
| 21:32:00 | sean-k-mooney | maybe but its stil mocking stuff we dont own | |
| 21:32:06 | sean-k-mooney | but that seams safer | |
| 21:32:16 | sean-k-mooney | sice we are mocking somethign we are calling | |
| 21:32:16 | mnaser | well at least it makes sure that we're creating a connector with the right type of initiator | |
| 21:32:29 | mnaser | which i think is the biggest thing that test is supported to do.. | |
| 21:32:43 | sean-k-mooney | right but that is not novas job to test | |
| 21:32:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix server topology "host_numa_node" field param name https://review.opendev.org/680775 | |
| 21:32:50 | sean-k-mooney | that is os-bricks job to test | |
| 21:33:03 | sean-k-mooney | we shoudl jsut assert we called ti with the correct input | |
| 21:33:18 | mnaser | exactly thats what i meant about mocking `connector.InitiatorConnector.factory` | |
| 21:33:31 | mnaser | aka make sure we're calling it with initiator.NVME as an argument (instead of $some_other_weird_thing) | |
| 21:33:32 | sean-k-mooney | ya which seams more robust | |
| 21:33:41 | sean-k-mooney | yep | |
| 21:33:58 | mnaser | its friday and im waiting for my food | |
| 21:34:01 | efried | dansmith: responded in https://review.opendev.org/671075 | |
| 21:34:02 | mnaser | let me push up a patch quick.. | |
| 21:35:04 | dansmith | efried: ack, but I'm EOD | |
| 21:35:10 | efried | nod | |
| 21:36:52 | dansmith | replied for action | |
| 21:38:18 | efried | thanks | |
| 21:41:07 | mriedem | it's in-law o'clock | |
| 21:41:07 | mriedem | o/ | |
| 21:48:30 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 21:49:16 | openstackgerrit | Adam Spiers proposed openstack/nova master: Reject live migration and suspend on SEV guests https://review.opendev.org/680158 | |
| 21:52:17 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick https://review.opendev.org/680779 | |
| 21:52:28 | mnaser | sean-k-mooney: ^ unit tests and flake8 passes here locally | |
| 21:53:14 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 21:53:29 | mnaser | efried: fyi the requirements breakage should be solved by that ^ | |
| 21:53:41 | mnaser | oh rap | |
| 21:53:45 | mnaser | i have an extra file there | |
| 21:53:55 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick https://review.opendev.org/680779 | |
| 21:54:54 | efried | mnaser: ugh, do we really need root helper? | |
| 21:55:07 | mnaser | efried: i mean i can skip the mock and import utils ? | |
| 21:55:19 | mnaser | but i mean its being passed down there | |
| 21:55:49 | efried | sorry, I just remember recently seeing where we were trying to get rid of that thing, so adding another reference to it feels like increasing tech debt. | |
| 21:55:54 | mnaser | https://docs.openstack.org/os-brick/stein/reference/os_brick/initiator/connector.html | |
| 21:56:03 | mnaser | well i only touched the tests, it was already referencing it | |
| 21:56:13 | mnaser | and it looks like the library relies on needing it | |
| 21:56:30 | efried | yeah, it just makes me sad. | |
| 21:56:58 | efried | mnaser, prometheanfire: Ima update the req patch to dep-on this guy to make sure it clears up, mkay? | |
| 21:57:09 | mnaser | efried: i mean i can get rid of the mock and have it call the real function but still gonna have a reference at the end of teh day | |
| 21:57:24 | efried | don't worry about it. | |
| 21:57:36 | mnaser | cools | |
| 22:07:27 | aspiers | efried: woot, SEV tempest test is working, exercising many code paths, and even found a bug which is now fixed :) | |
| 22:07:39 | aspiers | now I just have to wait a week for Zuul to catch up :( | |
| 22:12:01 | efried | nice | |
| 22:12:10 | efried | aspiers: did you do the tempest work? | |
| 22:12:13 | aspiers | yes | |
| 22:12:30 | aspiers | I'd never touched tempest before yesterday | |
| 22:12:42 | aspiers | It's pretty straight-forward though, and nicely documented | |
| 22:12:44 | efried | feel like writing one to cover https://review.opendev.org/#/c/680542/ ? | |
| 22:13:08 | aspiers | Not right now ;-) It's 11am and yet another week where I'm about 20 hours over time | |
| 22:13:27 | efried | it was worth a try | |
| 22:13:56 | aspiers | But hey, if all the SEV stuff lands early next week then I'd have spare time on my hands ... hint hint ;-) | |
| 22:14:51 | aspiers | In fixing the designer.py found by tempest, the code got a lot simpler - look: https://review.opendev.org/#/c/644565/53/nova/virt/libvirt/designer.py@202 | |
| 22:15:07 | aspiers | *missing "bug" in above sentence | |
| 22:15:57 | efried | ack | |
| 22:16:52 | aspiers | Other than reinstating W+1 on the rebased https://review.opendev.org/#/c/680158/, there's only that patch and the final master switch one left needing reviews | |
| 22:17:07 | aspiers | so it feels like we're close, CI permitting | |
| 22:25:50 | prometheanfire | efried: sgtm | |
| 22:54:00 | openstackgerrit | Merged openstack/nova master: doc: cleanup references to conductor doc https://review.opendev.org/680535 | |
| 23:28:34 | openstackgerrit | Merged openstack/nova master: Remove old comments about caching scheduler compat https://review.opendev.org/680521 | |
| #openstack-nova - 2019-09-07 | |||
| 00:36:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | |
| 00:36:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229 | |
| 00:36:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 00:36:13 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 00:36:13 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 01:59:21 | sean-k-mooney | artom: in case you didnt see my message dont use check experimental on any fo the DNM test jobs | |
| 01:59:24 | sean-k-mooney | just use recheck | |
| 01:59:50 | sean-k-mooney | the base one that does not have [DNM] will also fail | |
| 02:00:15 | sean-k-mooney | i dont know why but the new lable is broken so it need to be revert back to the old oone that works. | |
| 02:15:43 | openstackgerrit | Dongcan Ye proposed openstack/nova master: Get pci_devices from _list_devices https://review.opendev.org/680674 | |
| 02:25:41 | artom | sean-k-mooney, I saw your messages, yeah | |
| 02:25:57 | artom | sean-k-mooney, also, good morning? Or... wtf are you not sleeping? I guess I should know better than to ask :P | |
| 02:26:41 | artom | sean-k-mooney, I triggered because I want to re-test the XML generation since adding the allocation-style pinning (<vcpu cpuset=>) | |
| 02:27:12 | artom | I should also do a DNM grenade job for that - we can do it in the upstream gate, right? | |
| 02:27:19 | artom | Anyways, not tonight :P | |
| 02:40:55 | alex_xu | sean-k-mooney: just found you are still awake :) | |
| 02:41:35 | alex_xu | is the 49th hour in your planet~ | |
| 03:18:42 | prometheanfire | could be worse, could be on venus | |
| 03:19:14 | prometheanfire | 2802 hour days | |
| 04:00:34 | alex_xu | stephenfin: found some problem by test, we should take care of more for old host without host_cell.pcpuset https://review.opendev.org/#/c/671800/28/nova/virt/hardware.py | |