Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-06
21:32:06 sean-k-mooney but that seams safer
21:32:16 sean-k-mooney sice we are mocking somethign we are calling
21:32:16 mnaser well at least it makes sure that we're creating a connector with the right type of initiator
21:32:29 mnaser which i think is the biggest thing that test is supported to do..
21:32:43 sean-k-mooney right but that is not novas job to test
21:32:45 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: fix server topology "host_numa_node" field param name https://review.opendev.org/680775
21:32:50 sean-k-mooney that is os-bricks job to test
21:33:03 sean-k-mooney we shoudl jsut assert we called ti with the correct input
21:33:18 mnaser exactly thats what i meant about mocking `connector.InitiatorConnector.factory`
21:33:31 mnaser aka make sure we're calling it with initiator.NVME as an argument (instead of $some_other_weird_thing)
21:33:32 sean-k-mooney ya which seams more robust
21:33:41 sean-k-mooney yep
21:33:58 mnaser its friday and im waiting for my food
21:34:01 efried dansmith: responded in https://review.opendev.org/671075
21:34:02 mnaser let me push up a patch quick..
21:35:04 dansmith efried: ack, but I'm EOD
21:35:10 efried nod
21:36:52 dansmith replied for action
21:38:18 efried thanks
21:41:07 mriedem it's in-law o'clock
21:41:07 mriedem o/
21:48:30 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
21:49:16 openstackgerrit Adam Spiers proposed openstack/nova master: Reject live migration and suspend on SEV guests https://review.opendev.org/680158
21:52:17 openstackgerrit Mohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick https://review.opendev.org/680779
21:52:28 mnaser sean-k-mooney: ^ unit tests and flake8 passes here locally
21:53:14 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
21:53:29 mnaser efried: fyi the requirements breakage should be solved by that ^
21:53:41 mnaser oh rap
21:53:45 mnaser i have an extra file there
21:53:55 openstackgerrit Mohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick https://review.opendev.org/680779
21:54:54 efried mnaser: ugh, do we really need root helper?
21:55:07 mnaser efried: i mean i can skip the mock and import utils ?
21:55:19 mnaser but i mean its being passed down there
21:55:49 efried sorry, I just remember recently seeing where we were trying to get rid of that thing, so adding another reference to it feels like increasing tech debt.
21:55:54 mnaser https://docs.openstack.org/os-brick/stein/reference/os_brick/initiator/connector.html
21:56:03 mnaser well i only touched the tests, it was already referencing it
21:56:13 mnaser and it looks like the library relies on needing it
21:56:30 efried yeah, it just makes me sad.
21:56:58 efried mnaser, prometheanfire: Ima update the req patch to dep-on this guy to make sure it clears up, mkay?
21:57:09 mnaser efried: i mean i can get rid of the mock and have it call the real function but still gonna have a reference at the end of teh day
21:57:24 efried don't worry about it.
21:57:36 mnaser cools
22:07:27 aspiers efried: woot, SEV tempest test is working, exercising many code paths, and even found a bug which is now fixed :)
22:07:39 aspiers now I just have to wait a week for Zuul to catch up :(
22:12:01 efried nice
22:12:10 efried aspiers: did you do the tempest work?
22:12:13 aspiers yes
22:12:30 aspiers I'd never touched tempest before yesterday
22:12:42 aspiers It's pretty straight-forward though, and nicely documented
22:12:44 efried feel like writing one to cover https://review.opendev.org/#/c/680542/ ?
22:13:08 aspiers Not right now ;-) It's 11am and yet another week where I'm about 20 hours over time
22:13:27 efried it was worth a try
22:13:56 aspiers But hey, if all the SEV stuff lands early next week then I'd have spare time on my hands ... hint hint ;-)
22:14:51 aspiers In fixing the designer.py found by tempest, the code got a lot simpler - look: https://review.opendev.org/#/c/644565/53/nova/virt/libvirt/designer.py@202
22:15:07 aspiers *missing "bug" in above sentence
22:15:57 efried ack
22:16:52 aspiers Other than reinstating W+1 on the rebased https://review.opendev.org/#/c/680158/, there's only that patch and the final master switch one left needing reviews
22:17:07 aspiers so it feels like we're close, CI permitting
22:25:50 prometheanfire efried: sgtm
22:54:00 openstackgerrit Merged openstack/nova master: doc: cleanup references to conductor doc https://review.opendev.org/680535
23:28:34 openstackgerrit Merged openstack/nova master: Remove old comments about caching scheduler compat https://review.opendev.org/680521
#openstack-nova - 2019-09-07
00:36:11 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
00:36:11 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229
00:36:12 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
00:36:13 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
00:36:13 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
01:59:21 sean-k-mooney artom: in case you didnt see my message dont use check experimental on any fo the DNM test jobs
01:59:24 sean-k-mooney just use recheck
01:59:50 sean-k-mooney the base one that does not have [DNM] will also fail
02:00:15 sean-k-mooney i dont know why but the new lable is broken so it need to be revert back to the old oone that works.
02:15:43 openstackgerrit Dongcan Ye proposed openstack/nova master: Get pci_devices from _list_devices https://review.opendev.org/680674
02:25:41 artom sean-k-mooney, I saw your messages, yeah
02:25:57 artom sean-k-mooney, also, good morning? Or... wtf are you not sleeping? I guess I should know better than to ask :P
02:26:41 artom sean-k-mooney, I triggered because I want to re-test the XML generation since adding the allocation-style pinning (<vcpu cpuset=>)
02:27:12 artom I should also do a DNM grenade job for that - we can do it in the upstream gate, right?
02:27:19 artom Anyways, not tonight :P
02:40:55 alex_xu sean-k-mooney: just found you are still awake :)
02:41:35 alex_xu is the 49th hour in your planet~
03:18:42 prometheanfire could be worse, could be on venus
03:19:14 prometheanfire 2802 hour days
04:00:34 alex_xu stephenfin: found some problem by test, we should take care of more for old host without host_cell.pcpuset https://review.opendev.org/#/c/671800/28/nova/virt/hardware.py
05:19:50 openstackgerrit Merged openstack/nova master: Use fields="instance_uuid" when calling Ironic API https://review.opendev.org/680542
08:54:12 openstackgerrit Merged openstack/nova master: Fix incorrect invocation of openstacksdk's baremetal.nodes() https://review.opendev.org/680684
08:54:52 openstackgerrit Merged openstack/nova master: Ensure non-q35 machine type is not used when booting with SEV https://review.opendev.org/680065
08:55:01 openstackgerrit Merged openstack/nova master: Extract fake KVM guest fixture for reuse https://review.opendev.org/680526
08:55:10 openstackgerrit Merged openstack/nova master: Move get_machine_type() test to test_utils.py https://review.opendev.org/680527
12:23:17 openstackgerrit Merged openstack/nova master: Decouple NVMe tests from os-brick https://review.opendev.org/680779
13:26:55 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229
13:26:55 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
13:26:56 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
13:26:56 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
13:51:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Run grenade multinode with vcpu_pin_set https://review.opendev.org/680806
15:54:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Follow up for 220fa02ee916728e241503084b14984bab4b0c3b https://review.opendev.org/680810
18:01:06 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Run grenade and live migration with vcpu_pin_set https://review.opendev.org/680806
18:03:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Run grenade and live migration with vcpu_pin_set https://review.opendev.org/680806
18:11:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Follow up for I220fa02ee916728e241503084b14984bab4b0c3b https://review.opendev.org/680810
20:06:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove stubs from VolumeAttachmentsSample API sample test https://review.opendev.org/680834
20:10:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove stubs from VolumeAttachmentsSample API sample test https://review.opendev.org/680834
20:18:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove stubs from VolumeAttachmentsSample API sample test https://review.opendev.org/680834
22:53:26 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Run grenade and live migration with vcpu_pin_set https://review.opendev.org/680806

Earlier   Later