| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-05 | |||
| 12:13:37 | sean-k-mooney | yes in driver.py | |
| 12:13:47 | aspiers | hmm | |
| 12:14:18 | sean-k-mooney | it can call the hardware.py if it wans ill type up som sudo code. | |
| 12:14:33 | aspiers | yeah OK I think that might work | |
| 12:16:13 | aspiers | artom: I think sean-k-mooney's proposal should work ^^^ | |
| 12:16:22 | aspiers | kashyap too, in case you are interested | |
| 12:16:46 | aspiers | efried: you might just want to wait for the new patch sets rather than wade through this conversation ... | |
| 12:16:55 | aspiers | OK gotta go | |
| 12:17:06 | aspiers | lunch | |
| 12:18:04 | brinzhang | gmann: Would you prefer https://review.opendev.org/#/c/673133/15/nova/tests/unit/api/openstack/compute/test_volumes.py@1036 ? | |
| 12:18:41 | Sundar | sean-k-mooney: Re. "testing patch that runs the tempst job on nova", I believe that would be https://review.opendev.org/#/c/670999/ | |
| 12:18:53 | brinzhang | gmann: I think this test already test pre 2.78 microversion, and the 'delete_on_termination' field not in the response body. | |
| 12:19:02 | gmann | brinzhang: yeah that is good test and same we need for list and show API operation | |
| 12:19:27 | gmann | brinzhang: that is for POST and same we should test for other modified API also. | |
| 12:20:32 | brinzhang | gmann: got it, I will update it, beacause it will be conflict, https://review.opendev.org/#/c/621476/ this patch will be merged first | |
| 12:20:52 | brinzhang | gmann: no need a follow-up patch. | |
| 12:21:54 | gmann | brinzhang: ok but we cna check how matt prefer. it will be easy for him to re+2 if you only rebase on microverison and do other changes in followup. | |
| 12:22:17 | gmann | i am ok either way | |
| 12:22:37 | brinzhang | gmann: thanks. | |
| 12:24:41 | sean-k-mooney | aspiers: when you get back see if that makes sense. https://review.opendev.org/#/c/680065/6/nova/virt/hardware.py | |
| 12:27:47 | sean-k-mooney | Sundar: yes alther when i ran it 3 weeks ago it failed | |
| 12:27:52 | sean-k-mooney | ill recheck it | |
| 12:28:56 | sean-k-mooney | Sundar: actully that patch does not pull in the nova integration code unless the cyborge cod is | |
| 12:29:29 | sean-k-mooney | Sundar: so no that is propsoed agains nova but it does not run any of the nova cyborge integration code | |
| 12:29:52 | Sundar | sean-k-mooney: The dependencies need to be fixed there too. Will follow up. Thanks. | |
| 12:30:20 | sean-k-mooney | that should jsut be rebased on top of the final cyborg patch | |
| 12:31:36 | Sundar | Ok, I will ask thr author or do it myself | |
| 12:31:40 | Sundar | *the | |
| 12:32:00 | sean-k-mooney | i think we can do that in the gerrit ui | |
| 12:32:09 | sean-k-mooney | want me too try | |
| 12:32:43 | sean-k-mooney | this is the final patch in teh series right https://review.opendev.org/#/c/673735/ | |
| 12:33:33 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add cyborg tempest job https://review.opendev.org/670999 | |
| 12:33:35 | Sundar | sean-k-mooney: Yes, 673735 | |
| 12:33:59 | sean-k-mooney | ok its rebased and i updated the topic | |
| 12:34:18 | Sundar | Thank you | |
| 12:34:39 | sean-k-mooney | and i kicked off an experimental build so we should get results in an hour or so | |
| 12:35:34 | Sundar | It will probably fail because the Cyborg code dependencies are not set yet? | |
| 12:35:43 | sean-k-mooney | they are | |
| 12:35:57 | sean-k-mooney | well they coudl be wrong | |
| 12:36:12 | sean-k-mooney | it has | |
| 12:36:14 | sean-k-mooney | Depends-On: https://review.opendev.org/#/c/667231/ Depends-On: https://review.opendev.org/#/c/665318/ | |
| 12:36:46 | sean-k-mooney | so that is the fake driver and the tempest plugin | |
| 12:37:05 | Sundar | Yea, those are offbase. Should be 670470 and 674520 | |
| 12:37:05 | sean-k-mooney | the cyborg one might need to be updated if there is other stuff pending | |
| 12:37:44 | sean-k-mooney | ah ok ill let it to them or you to update | |
| 12:40:02 | kashyap | aspiers: Was AFK; reading now | |
| 12:41:22 | kashyap | aspiers: We might've discussed (on machine types as traits) ... although I'm fuzzy on what we talked, though | |
| 12:44:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 12:44:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 12:44:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 12:44:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth https://review.opendev.org/680394 | |
| 12:44:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680395 | |
| 12:44:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680396 | |
| 12:50:52 | kashyap | aspiers: Glad if you worked out a way to resolve the imports impasse. /me back to duking around with SB code | |
| 12:51:37 | openstackgerrit | Merged openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | |
| 12:51:53 | sean-k-mooney | kashyap: i think we have. and we discovered a 7 year old bit of tech debt to go clean up eventually. | |
| 12:52:18 | kashyap | sean-k-mooney: :D Which is? Also I saw in passing, that you wanted to "kill off designer.py" | |
| 12:52:30 | kashyap | IIRC, it was introduced with a purpose back in the day. | |
| 12:52:46 | sean-k-mooney | it was but we never finished it | |
| 12:53:05 | kashyap | (For making "policy" decisions.) | |
| 12:53:18 | sean-k-mooney | but that is not what i was refering too | |
| 12:53:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 12:54:04 | sean-k-mooney | kashyap: i was refering to removing this | |
| 12:54:05 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/__init__.py#L15-L17 | |
| 12:54:33 | sean-k-mooney | because of that when you import anythin in nova.virt.libvit.* | |
| 12:54:50 | sean-k-mooney | it pulls in the dirver which pulls in half of nova | |
| 12:55:09 | sean-k-mooney | well not really but importin nova.virt.libvirt.utils | |
| 12:55:17 | sean-k-mooney | shoudl not have that silent side effect | |
| 12:55:24 | kashyap | sean-k-mooney: Ah, okay; I see what you mean | |
| 12:55:44 | kashyap | Thanks for the context | |
| 12:55:51 | sean-k-mooney | so we shoudl remove that at somepoint | |
| 12:56:04 | sean-k-mooney | but its been that way for 7 years+ | |
| 12:56:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 12:56:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 12:56:48 | artom | aspiers, so the API-level check boils down to essentially "if 'q35' in machine_type"? | |
| 12:57:25 | artom | And actually yeah, we can't do anything else | |
| 12:57:46 | artom | It just dawned on me that calling libvirt_utils on anything other than the compute host doesn't make sense | |
| 12:57:50 | artom | Since it checks the CONF | |
| 12:58:02 | artom | For the machine type, which may not even be set on a controller | |
| 12:59:20 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133 | |
| 12:59:22 | sean-k-mooney | artom: yep | |
| 12:59:46 | sean-k-mooney | artom: even if it was set on the contoler i t would be wrong | |
| 13:00:13 | artom | sean-k-mooney, yep | |
| 13:01:12 | sean-k-mooney | the main api check we care about is for live migrate and suspend | |
| 13:01:51 | sean-k-mooney | the create server one is fine too but its not the main one | |
| 13:02:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 13:02:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 13:04:41 | aspiers | artom: exactly | |
| 13:07:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 13:09:05 | brinzhang | mriedem: Beacause of https://review.opendev.org/#/c/621476/ hit the microversion 2.78, I was rebased it. Can you review https://review.opendev.org/#/c/673133/16 again? | |
| 13:09:59 | mriedem | brinzhang: yes | |
| 13:10:12 | mriedem | yonglihe: will you be working on adding support for microversion 2.78 to openstackclient as well? | |
| 13:10:56 | brinzhang | mriedem: About your comment in PS14, I update https://review.opendev.org/#/c/674243/20/nova/tests/functional/api_sample_tests/test_migrations.py@424, could you please review this again, and I will update it tomorrow. | |
| 13:12:22 | brinzhang | mriedem: Alex already leaving comments on https://review.opendev.org/#/c/674243 | |
| 13:12:26 | gmann | mriedem: i asked few more test to add in 673133 and in followup as it was +2 by you. as he need to rebase you want to fix those in followup or same commit? what ever is easy to get your +2 :) | |
| 13:13:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | |
| 13:15:06 | mriedem | gmann: you asked for a test that already exists | |
| 13:15:09 | mriedem | test_attach_volume_pre_v278 | |
| 13:15:36 | gmann | mriedem: that is for POST API only i asked to test the same for GET (list and show) | |
| 13:16:12 | mriedem | ok | |