| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-05 | |||
| 13:15:09 | mriedem | test_attach_volume_pre_v278 | |
| 13:15:36 | gmann | mriedem: that is for POST API only i asked to test the same for GET (list and show) | |
| 13:16:12 | mriedem | ok | |
| 13:16:46 | brinzhang | mriedem: gmann: thanks | |
| 13:17:57 | luyao | dansmith: Hi, Dan, comments addressed, https://review.opendev.org/#/c/678447/ and https://review.opendev.org/#/c/678448/. Could you help confirm if it is right? | |
| 13:19:36 | mriedem | brinzhang: https://review.opendev.org/#/c/674243/20 is in merge conflict | |
| 13:21:00 | brinzhang | mriedem: yeah, beacause of https://review.opendev.org/#/c/621476/ hit the microversion 2.78 | |
| 13:22:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 13:23:03 | brinzhang | mriedem: I will update it by tomorrow, and need your suggestion in https://review.opendev.org/#/c/674243/20/nova/tests/functional/api_sample_tests/test_migrations.py | |
| 13:24:26 | yonglihe | mriedem: the client code is under reviewing now. | |
| 13:24:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth https://review.opendev.org/680394 | |
| 13:24:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680395 | |
| 13:26:43 | mriedem | brinzhang: i'm likely not going to get to the migrations API change today | |
| 13:26:47 | mriedem | lots of other stuff to review | |
| 13:26:57 | mriedem | yonglihe: novaclient is, but what about openstackclient? | |
| 13:27:09 | mriedem | yonglihe: see: https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc - we don't want to add more gaps to osc | |
| 13:27:12 | bauzas | gibi: can I start looking at your updated change ? ^ | |
| 13:27:16 | yonglihe | o, i like to do that also. | |
| 13:27:55 | gibi | bauzas: the first 3 patches are ready | |
| 13:28:00 | bauzas | gibi: cool | |
| 13:28:06 | mriedem | yonglihe: the osc change likely won't land until ussuri but you can start on it, | |
| 13:28:12 | mriedem | maybe after we get closer on the novaclient change | |
| 13:28:26 | brinzhang | mriedem: Ok, tomorrow I will update it, and then wait for your time :) | |
| 13:28:34 | yonglihe | mriedem: Sure, i definitely need few days to do that. | |
| 13:29:54 | gibi | mriedem: I replied in https://review.opendev.org/#/c/656422/18/nova/compute/manager.py@2122 I diverged from your original suggestion a bit | |
| 13:30:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680396 | |
| 13:31:34 | sean-k-mooney | donnyd: i seam to be getting node failures when i use multi-numa-ubuntu-bionic-expanded and multi-numa-ubuntu-bionic | |
| 13:31:35 | yonglihe | mriedem: I take it as my task, for sure. thanks your remind. | |
| 13:31:50 | sean-k-mooney | donnyd: based on https://github.com/openstack/project-config/blob/master/nodepool/nl02.openstack.org.yaml#L348-L357 they shoudl be the correct lables | |
| 13:33:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 13:36:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 13:37:27 | stephenfin | mriedem: Mind taking a look at that patch to validate CPU config options again today? https://review.opendev.org/#/c/680107/ | |
| 13:39:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 13:39:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 13:39:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 13:40:56 | stephenfin | bauzas: I split that "Differentiate between shared and dedicated CPUs" patch into two patches, btw :) https://review.opendev.org/#/c/680108/ and https://review.opendev.org/#/c/671800/ | |
| 13:41:37 | stephenfin | what kind of monster sharpens a _pen_? | |
| 13:41:56 | stephenfin | must be where you got the tattoos | |
| 13:42:13 | mriedem | gibi: sure that works | |
| 13:42:32 | gibi | mriedem: phee, I was a it worried | |
| 13:42:44 | sean-k-mooney | donnyd: actully it seams to be running now | |
| 13:43:12 | gibi | bauzas, mriedem: I think comments are fixed up until the first functional test. I'm working on that now | |
| 13:43:21 | bauzas | stephenfin: the OpenStack CLA doesn't require you to provide your filings | |
| 13:43:35 | bauzas | so I let you imagine whatever you want | |
| 13:43:47 | efried | sean-k-mooney: Can I please ask you to vet the libvirt xml stuff for vpmem here? https://review.opendev.org/#/c/678455/ | |
| 13:43:53 | bauzas | gibi: cool, later today if time allows me | |
| 13:44:42 | gibi | bauzas: thanks | |
| 13:46:26 | bauzas | mriedem: gibi: just one thing, hardly working on the placement audit command, are we hit by feature freeze or not ? | |
| 13:46:36 | bauzas | efried: ^ | |
| 13:46:49 | gibi | bauzas: ff is next week | |
| 13:46:54 | bauzas | I know | |
| 13:47:08 | bauzas | talking of https://bugs.launchpad.net/nova/+bug/1793569 | |
| 13:47:09 | openstack | Launchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,In progress] - Assigned to sean mooney (sean-k-mooney) | |
| 13:47:12 | bauzas | it's wishlist | |
| 13:47:45 | mriedem | gibi: a bit confusing that the commit message title is the same for these https://review.opendev.org/#/c/680395/2 https://review.opendev.org/#/c/680396/2 | |
| 13:48:01 | gibi | mriedem: noted, I will add some creativity to those | |
| 13:48:11 | openstackgerrit | Chris Dent proposed openstack/nova master: single pass instance info fetch in host manager https://review.opendev.org/623558 | |
| 13:48:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 13:48:54 | gibi | bauzas: do you mean ff affects the work on that bug? | |
| 13:48:57 | efried | bauzas: If work isn't already well underway for that, it seems unlikely to make Train. | |
| 13:49:04 | donnyd | sean-k-mooney: those labels got put in the pool with the rest of everything else.. so you will likely have to wait a little longer | |
| 13:49:21 | bauzas | efried: I'm targeting to upload a last rev by tomorrow | |
| 13:49:31 | efried | bauzas: who's on the hook to review it? | |
| 13:49:38 | bauzas | efried: good question | |
| 13:49:41 | efried | What do you consider the importance/priority versus other things we're behind on? | |
| 13:49:53 | bauzas | efried: https://review.opendev.org/#/c/670112/ | |
| 13:50:31 | bauzas | efried: I don't disagree with your statement | |
| 13:50:44 | efried | I haven't made statements, just questions :) | |
| 13:50:54 | efried | oh, the "unlikely" one perhaps | |
| 13:51:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 13:51:17 | mriedem | bauzas: it's not going to make train | |
| 13:51:18 | bauzas | efried: well, nevermind my question then, you know what, we'll see what's left | |
| 13:51:54 | cdent | efried: i put some unit tests on that host manager change of jays, above. it was as painful as I feared it would be, but I think it got it. at least cover says so | |
| 13:51:58 | dansmith | mriedem: so you think you can take a trip through the numa lm set this morning? | |
| 13:52:08 | mriedem | dansmith: it's on the todo list | |
| 13:52:16 | dansmith | mriedem: thanks | |
| 13:52:50 | efried | dansmith: can you run through the vpmem obj patches again please? | |
| 13:53:10 | mriedem | so, | |
| 13:53:22 | mriedem | efried: dansmith: besides numa lm, | |
| 13:53:36 | dansmith | efried: I just dropped a -1.9 on one | |
| 13:53:38 | mriedem | it seems the two other series that dansmith was reviewing was the forbidden aggregates stuff and sort of the vpmem stuff, right? | |
| 13:53:54 | mriedem | wouldn't it be a better use of dan's time to focus on forbidden aggregates if he's going to review one of those? | |
| 13:54:05 | dansmith | um.. | |
| 13:54:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 13:54:13 | mriedem | not that i'm picking what dan should work on in the next week, | |
| 13:54:19 | dansmith | apparently you are :) | |
| 13:54:22 | mriedem | but forbidden aggregates isn't merged yet right? | |
| 13:54:34 | mriedem | it was all +2ed at some point | |
| 13:55:46 | dansmith | I haven't looked at that set in a while, but I can circle back | |
| 13:55:48 | efried | ugh, forbidden aggregates slid down my list and out of sight at some point. | |
| 13:55:51 | mriedem | my point is if you're going to ask dan to review something he's reviewed before, maybe make it the forbidden aggs one | |
| 13:55:52 | efried | yeah, same | |
| 13:56:27 | dansmith | mriedem: well, I had gone back and forth on the vpmems bottom patches already recently | |
| 13:56:28 | mriedem | the vpmems series seeems way too risky to me at this point | |
| 13:56:41 | efried | mriedem: for me, vpmem is higher priority, and also more reliant on dansmith's expertise. If we needed to finish up forbidden aggs without him, it would be possible. vpmems (clearly) not so much. | |
| 13:56:42 | mriedem | sure, but do we expect to land that whole series in the next week? | |
| 13:56:44 | mriedem | w/o regression? | |
| 13:57:04 | dansmith | efried: the vpmem series has a -1 on the fourth patch and is really large above that, is that really going to land? | |
| 13:57:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | |
| 13:57:13 | dansmith | efried: because if not, we shouldn't merge the db and object stuff, IMHO | |