| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-04 | |||
| 20:41:39 | aspiers | melwitt: got it working finally | |
| 20:41:48 | aspiers | melwitt: thanks for your help :) | |
| 20:41:51 | melwitt | yay | |
| 20:43:03 | openstackgerrit | Merged openstack/nova master: Modernize nova-lvm job https://review.opendev.org/674356 | |
| 20:45:55 | openstackgerrit | Adam Spiers proposed openstack/nova master: Reject live migration and suspend on SEV guests https://review.opendev.org/680158 | |
| 20:46:17 | aspiers | melwitt: https://review.opendev.org/#/c/680158/2..3/nova/tests/unit/api/openstack/compute/test_suspend_server.py@47 | |
| 20:47:09 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 20:48:10 | melwitt | aspiers: oh, so you didn't need to stub compute_api | |
| 20:48:19 | aspiers | melwitt: right, it was just image_meta | |
| 20:48:43 | aspiers | I didn't want to stub compute_api because that's where the desired exception gets thrown | |
| 20:49:15 | melwitt | yeah, makes sense | |
| 20:55:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951 | |
| 20:57:14 | aspiers | oh crap, circular imports | |
| 21:01:38 | aspiers | what's the ASCII smiley for a facepalm? | |
| 21:09:34 | aspiers | efried: make sense if I move sev_enabled() from libvirt.utils to virt.hardware to break the circular import? | |
| 21:10:04 | efried | aspiers: without looking specifically at the patch, that sounds like a reasonable thing. | |
| 21:10:17 | aspiers | I don't think it's possible to move get_mem_encryption_constraint() and its helpers in the other direction | |
| 21:10:24 | aspiers | which is a shame, cause they're libvirt-specific | |
| 21:10:29 | efried | except that I still resent that nova.virt.hardware is libvirt-specific | |
| 21:10:35 | aspiers | right | |
| 21:10:36 | efried | yeah | |
| 21:10:42 | aspiers | thing is, they depend _get_flavor_image_meta which is shared | |
| 21:10:43 | efried | that ship has sailed though. | |
| 21:10:49 | aspiers | OK | |
| 21:11:06 | aspiers | efried: I suggested to kashyap yesterday that we actually move the machine type stuff to a separate machine_types file | |
| 21:11:30 | aspiers | libvirt.utils is a kinda dumb bag of random shit | |
| 21:11:34 | efried | if you're just grasping for shit to do, you could factor the libvirt-specific stuff out of nova.virt.hardware and into a nova.virt.libvirt.hardware module, leaving anything that's actually generic (assuming there is anything) in nova.virt.hardware. | |
| 21:12:06 | efried | but we probably have more important things to do | |
| 21:12:13 | aspiers | but I dunno, maybe I can | |
| 21:12:33 | aspiers | however I'm very conscious that once this runway window closes, that's my last chance to land SEV in Train gone | |
| 21:13:11 | aspiers | anyway yet again it's 10pm and I haven't had dinner | |
| 21:13:17 | aspiers | time to tear myself away | |
| 21:14:12 | aspiers | efried: parting thought - once I fix the circular import, in *theory* the patch series is code complete (haha how many times have I said that before) | |
| 21:15:08 | efried | aspiers: That refactor would have nothing to do with the SEV series, runways, or indeed probably Train, as we would likely prefer to wait until ussuri opens to land it. | |
| 21:15:37 | aspiers | efried: cool | |
| 21:15:45 | aspiers | what do you think about the machine_types.py idea? | |
| 21:16:09 | aspiers | nova.virt.machine_types | |
| 21:16:16 | aspiers | I don't even know if it's libvirt-specific actually | |
| 21:16:18 | aspiers | I think not | |
| 21:16:35 | aspiers | but specific to QEMU so ... | |
| 21:17:23 | aspiers | yeah, qemu-kvm -machine help lists them all | |
| 21:24:08 | donnyd | melwitt: dansmith booya | |
| 21:24:12 | donnyd | https://usercontent.irccloud-cdn.com/file/OdTlIVXX/image.png | |
| 21:24:34 | dansmith | donnyd: chunk size or something else? | |
| 21:24:36 | donnyd | chunk size numbers are looking much mo betta | |
| 21:24:44 | dansmith | sweet | |
| 21:24:52 | dansmith | donnyd: let me get you an address where you can send the check... | |
| 21:25:08 | donnyd | LOL | |
| 21:26:18 | donnyd | 5x faster | |
| 21:26:37 | donnyd | that is a pretty big win | |
| 21:27:09 | melwitt | yeah, that's awesome. I didn't know about glance chunk size until today | |
| 21:28:24 | dansmith | donnyd: that was with 16MiB chunks? | |
| 21:28:28 | donnyd | yea | |
| 21:28:40 | dansmith | cool | |
| 21:28:47 | donnyd | not sure if I should turn it up anymore or not | |
| 21:29:20 | dansmith | higher will increase memory usage on the controllers of course | |
| 21:29:35 | dansmith | by at least $chunk_size per parallel download thread I imagine | |
| 21:30:00 | donnyd | I think its probably smart to left this settle in for a day or so | |
| 21:31:19 | donnyd | I should know in the next 24 hours | |
| 21:31:30 | dansmith | yeah | |
| 21:52:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107 | |
| 21:52:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108 | |
| 21:52:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | |
| 21:52:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | |
| 21:52:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 21:52:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 21:52:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229 | |
| 22:05:22 | donnyd | dansmith: I couldn't resist | |
| 22:05:27 | donnyd | 32m is too high | |
| 22:05:53 | donnyd | 16m is the sweet spot, and if you are curious dansmith melwitt I can show the data | |
| 22:06:11 | donnyd | https://grafana.fortnebula.com/d/9MMqh8HWk/openstack-utilization?orgId=2&refresh=30s&from=now-1h&to=now&fullscreen&panelId=14 | |
| 22:06:29 | dansmith | donnyd: you went below 16m too I assume? | |
| 22:06:47 | donnyd | No, I should probably test that direction as well | |
| 22:06:51 | dansmith | yeah | |
| 22:08:45 | melwitt | cool donnyd, that's good to know. I've already told penick about it and he's gonna check their settings too :) | |
| 22:09:53 | donnyd | That link i just sent has the data to show the difference in both upload and download speeds at different chunk sizes | |
| 22:11:32 | donnyd | maybe I should note that in the glance docs or something | |
| 22:15:18 | donnyd | maximum d/l speed at 32m is 3Gs / 16m is 8G/s /8m 6.5G/s | |
| 22:15:36 | donnyd | so it looks like 16m is the sweet spot for at least my infra | |
| 22:16:04 | donnyd | Thanks again.. this was really the only thing i was unhappy with on FN... | |
| 22:16:12 | donnyd | woot woot!!! | |
| 22:16:18 | melwitt | yay | |
| 22:16:45 | donnyd | https://grafana.fortnebula.com/d/9MMqh8HWk/openstack-utilization?orgId=2&from=1567633743742&to=1567635376855&fullscreen&panelId=14 | |
| 22:16:54 | melwitt | I'm glad to know what the issue was. I've been wondering about it | |
| 22:16:54 | donnyd | and here is 32-8 left to right | |
| 22:17:02 | donnyd | me too | |
| 22:17:05 | donnyd | LOL melwitt | |
| 22:17:08 | melwitt | haha xD | |
| 22:17:17 | donnyd | Its that dinner time around here | |
| 22:17:43 | melwitt | o/ | |
| 22:30:56 | aspiers | efried: hmm, other option for breaking the cycle is to move get_machine_type() from utils to new machine_types.py | |
| 22:31:03 | aspiers | maybe that's better | |
| 22:31:29 | aspiers | (than moving libvirt-specific sev_enabled() to virt.hardware) | |
| 22:35:06 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | |
| 22:35:32 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | |
| 22:37:12 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | |
| 22:37:31 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | |
| 22:37:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | |
| 22:38:06 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | |
| 22:38:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | |