Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-04
21:10:49 aspiers OK
21:11:06 aspiers efried: I suggested to kashyap yesterday that we actually move the machine type stuff to a separate machine_types file
21:11:30 aspiers libvirt.utils is a kinda dumb bag of random shit
21:11:34 efried if you're just grasping for shit to do, you could factor the libvirt-specific stuff out of nova.virt.hardware and into a nova.virt.libvirt.hardware module, leaving anything that's actually generic (assuming there is anything) in nova.virt.hardware.
21:12:06 efried but we probably have more important things to do
21:12:13 aspiers but I dunno, maybe I can
21:12:33 aspiers however I'm very conscious that once this runway window closes, that's my last chance to land SEV in Train gone
21:13:11 aspiers anyway yet again it's 10pm and I haven't had dinner
21:13:17 aspiers time to tear myself away
21:14:12 aspiers efried: parting thought - once I fix the circular import, in *theory* the patch series is code complete (haha how many times have I said that before)
21:15:08 efried aspiers: That refactor would have nothing to do with the SEV series, runways, or indeed probably Train, as we would likely prefer to wait until ussuri opens to land it.
21:15:37 aspiers efried: cool
21:15:45 aspiers what do you think about the machine_types.py idea?
21:16:09 aspiers nova.virt.machine_types
21:16:16 aspiers I don't even know if it's libvirt-specific actually
21:16:18 aspiers I think not
21:16:35 aspiers but specific to QEMU so ...
21:17:23 aspiers yeah, qemu-kvm -machine help lists them all
21:24:08 donnyd melwitt: dansmith booya
21:24:12 donnyd https://usercontent.irccloud-cdn.com/file/OdTlIVXX/image.png
21:24:34 dansmith donnyd: chunk size or something else?
21:24:36 donnyd chunk size numbers are looking much mo betta
21:24:44 dansmith sweet
21:24:52 dansmith donnyd: let me get you an address where you can send the check...
21:25:08 donnyd LOL
21:26:18 donnyd 5x faster
21:26:37 donnyd that is a pretty big win
21:27:09 melwitt yeah, that's awesome. I didn't know about glance chunk size until today
21:28:24 dansmith donnyd: that was with 16MiB chunks?
21:28:28 donnyd yea
21:28:40 dansmith cool
21:28:47 donnyd not sure if I should turn it up anymore or not
21:29:20 dansmith higher will increase memory usage on the controllers of course
21:29:35 dansmith by at least $chunk_size per parallel download thread I imagine
21:30:00 donnyd I think its probably smart to left this settle in for a day or so
21:31:19 donnyd I should know in the next 24 hours
21:31:30 dansmith yeah
21:52:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107
21:52:06 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108
21:52:07 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
21:52:07 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
21:52:08 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
21:52:08 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
21:52:09 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229
22:05:22 donnyd dansmith: I couldn't resist
22:05:27 donnyd 32m is too high
22:05:53 donnyd 16m is the sweet spot, and if you are curious dansmith melwitt I can show the data
22:06:11 donnyd https://grafana.fortnebula.com/d/9MMqh8HWk/openstack-utilization?orgId=2&refresh=30s&from=now-1h&to=now&fullscreen&panelId=14
22:06:29 dansmith donnyd: you went below 16m too I assume?
22:06:47 donnyd No, I should probably test that direction as well
22:06:51 dansmith yeah
22:08:45 melwitt cool donnyd, that's good to know. I've already told penick about it and he's gonna check their settings too :)
22:09:53 donnyd That link i just sent has the data to show the difference in both upload and download speeds at different chunk sizes
22:11:32 donnyd maybe I should note that in the glance docs or something
22:15:18 donnyd maximum d/l speed at 32m is 3Gs / 16m is 8G/s /8m 6.5G/s
22:15:36 donnyd so it looks like 16m is the sweet spot for at least my infra
22:16:04 donnyd Thanks again.. this was really the only thing i was unhappy with on FN...
22:16:12 donnyd woot woot!!!
22:16:18 melwitt yay
22:16:45 donnyd https://grafana.fortnebula.com/d/9MMqh8HWk/openstack-utilization?orgId=2&from=1567633743742&to=1567635376855&fullscreen&panelId=14
22:16:54 melwitt I'm glad to know what the issue was. I've been wondering about it
22:16:54 donnyd and here is 32-8 left to right
22:17:02 donnyd me too
22:17:05 donnyd LOL melwitt
22:17:08 melwitt haha xD
22:17:17 donnyd Its that dinner time around here
22:17:43 melwitt o/
22:30:56 aspiers efried: hmm, other option for breaking the cycle is to move get_machine_type() from utils to new machine_types.py
22:31:03 aspiers maybe that's better
22:31:29 aspiers (than moving libvirt-specific sev_enabled() to virt.hardware)
22:35:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
22:35:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027
22:37:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031
22:37:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299
22:37:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344
22:38:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
22:38:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
22:38:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
22:38:54 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
22:39:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
23:30:33 openstackgerrit Nathan Kinder proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502
23:54:52 brinzhang mriedem: pretty good, thanks
#openstack-nova - 2019-09-05
00:40:09 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
00:40:09 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
00:40:10 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
00:57:36 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
00:57:36 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
00:57:37 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522
02:28:36 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.78: Add delete_on_termination to volume-attach API https://review.opendev.org/673485
02:49:36 alex_xu dansmith: Luyao defined a field type for resource_class https://review.opendev.org/#/c/678448/13/nova/objects/fields.py@94, but I doubt validate the standard rc is right thing.
02:51:06 alex_xu dansmith: if we are in the middle of upgrade, like Live migraiton, there will be have object transfer between new and old node. so for old node, it may have old os-resource-class lib, so it may not know the new RC, then the deserilzier will blowup. So if we want the validation, I think we only need a copy of generic RC pattern
02:51:08 alex_xu https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L19, let me know if it is right
03:01:52 openstackgerrit Merged openstack/nova master: Use microversion in put allocations in test_report_client https://review.opendev.org/679622
03:30:59 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.78: Add delete_on_termination to volume-attach API https://review.opendev.org/673485
04:14:54 gmann melwitt: johnthetubaguy alex_xu looking for review/feedback on this first set of policy-defaults-refresh changes. This one and all its base patches - https://review.opendev.org/#/c/648480/
04:15:36 alex_xu gmann: got it
04:16:04 gmann alex_xu: thanks. and this nit followup change in spec - https://review.opendev.org/#/c/669196/
04:17:05 gmann alex_xu: this is review guide i sent on ML - http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008504.html
04:17:46 alex_xu gmann: got it, I will give it try, let see if i have enough bandwidth
04:18:18 gmann alex_xu: thx again , kenichi has +2 on most of them i think

Earlier   Later