Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-27
11:05:55 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
11:08:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
11:10:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140
11:10:57 openstackgerrit Merged openstack/nova master: [Trivial]Remove unused helper get_vm_ref_from_name https://review.opendev.org/678444
11:12:55 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
11:15:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
11:17:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
11:17:54 sean-k-mooney gibi: does ^ work with sriov livemigrtaion or just cold migration
11:18:33 gibi sean-k-mooney: just cold so far
11:18:51 gibi sean-k-mooney: I still have to work on live migrate, evacuate, and shelve offload
11:18:54 sean-k-mooney ok do you have live migration support ingeneral
11:18:58 sean-k-mooney ah ok
11:19:12 sean-k-mooney i dont think you will have to do anything spcial for sriov in that regard
11:19:16 gibi sean-k-mooney: I expect resize to work out of the box but I have to add functinal coverage for it
11:19:29 sean-k-mooney if you get generic live migration working then it should work for sriov too
11:20:13 gibi sean-k-mooney: the selection of pci devices needs to be driven the same way for live migration as it is now done for cold migration
11:20:27 gibi sean-k-mooney: but besides that I don't expect any sriov specific thing
11:20:39 sean-k-mooney we handel that differently for sriov
11:20:44 sean-k-mooney we do not use move claims
11:21:02 sean-k-mooney so i hope you are not assuming we do
11:21:18 sean-k-mooney ill take a look at the patch in either case
11:22:21 gibi sean-k-mooney: how does live migration selects the pci device on the target host?
11:23:12 gibi sean-k-mooney: if it uses the InstancePCIRequest then I think my strategy will work
11:23:12 sean-k-mooney we claim the in the pci resouce tracker in check_can_live_migrate_at_dest
11:23:52 sean-k-mooney we create new instancePCIRequest object i think
11:24:12 gibi sean-k-mooney: OK, then I need to patch those requests with https://review.opendev.org/#/c/676980/6/nova/compute/manager.py@2141
11:25:14 sean-k-mooney then we store the pci addresse of the new vif objects in the migrate_data
11:25:28 sean-k-mooney oh the provider_mappings
11:25:32 sean-k-mooney ya proably
11:25:54 sean-k-mooney did you see my comment by the way regarding the lenght of that parmater/variable
11:26:26 gibi sean-k-mooney: I'm going through the series today so I will
11:27:01 sean-k-mooney basically request_group_resource_providers_mapping -> provider_mappings
11:27:48 aspiers sean-k-mooney: shall I rebase the other 2 patches on top so that they have a chance of passing pep8 at least?
11:28:11 sean-k-mooney if we need to explain it is a request froup resouce provder mapping we can state that in the doc string
11:28:18 aspiers hmm, I guess they will still fail on test_utils
11:28:34 sean-k-mooney aspiers: no need ill do that later
11:28:35 gibi sean-k-mooney: ack
11:28:44 sean-k-mooney was getting through my email
11:32:57 sean-k-mooney aspiers: grabing tea but ill rebase the follow up patch and fix the test to work on py27 shortly
12:00:06 aspiers sean-k-mooney: cool
12:04:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
12:04:12 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
12:04:12 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
12:07:57 openstackgerrit zhangyujun proposed openstack/nova master: Should not raise when restore power on failed https://review.opendev.org/624854
12:11:12 openstackgerrit Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
12:13:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
12:13:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
12:18:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
12:19:48 gibi sean-k-mooney: addressed your comments ^^
12:20:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
12:22:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
12:24:34 sean-k-mooney cool ill try an emake it through the full seriese end to end this week
12:25:06 sean-k-mooney ill also try and deploy it but my backlog of thig to deploy and test is kind of long at the moment
12:25:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
12:27:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
12:27:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
12:27:59 openstackgerrit Peter Penchev proposed openstack/nova master: libvirt: use native AIO mode for StorPool Cinder volumes. https://review.opendev.org/676172
12:41:31 gibi sean-k-mooney: tanks
12:53:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
13:16:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827
13:17:17 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914
13:17:18 openstackgerrit sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915
13:17:18 openstackgerrit sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
13:29:10 mriedem lyarwood: if you're hitting stable reviews, https://review.opendev.org/#/c/678254/ is a simple docs fix that has confused many operators
13:30:26 lyarwood mriedem: yup trying to, one more downstream fire to go first...
13:41:02 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add resize tests to nova-grenade job https://review.opendev.org/678841
13:48:36 stephenfin gibi: I'm seeing the following in a functional test. Any idea why that might be? 'AllocationDeleteFailed: Failed to delete allocations for consumer [uuid]'
13:48:56 stephenfin Being raised by 'delete_allocation_for_instance' in 'nova/scheduler/client/report.py'
13:49:14 stephenfin I suspect it's to do with cleanup, but I've no idea why this test is triggering it but no others
13:49:39 gibi stephenfin: I'm on a call, I will get back to you in an hour
13:49:43 stephenfin (y)
13:54:33 artom dansmith, did you notice the new TODO above https://review.opendev.org/#/c/634827/50/nova/objects/migrate_data.py? I thought it would answer your question.
13:54:58 dansmith artom: yes
13:55:10 artom dansmith, OK, then I don't understand your question :)
13:55:23 dansmith artom: is it the current instance's numa toplology?
13:55:26 artom Yes
13:55:57 dansmith so you're passing a whole extra nested object, which is a thing that the other side already has, to functional as a sentinel?
13:56:25 artom Well if you put it that way, or course it's going to sound dumb ;)
13:56:32 artom So... just a boolean flag then?
13:56:36 dansmith we have a couple other boolean fields above it that indicate dest or source support for a feature
13:57:03 sean-k-mooney we also need the data it contians for updating the xml right
13:57:14 dansmith that's why I'm asking, but I don't think so
13:57:16 artom sean-k-mooney, the dest can pull it from the database
13:57:34 artom I need to double check, but it's probably already loaded
13:57:49 dansmith and/or has it on the instance which is sent via rpc anyway
13:58:31 artom And we can always add it to expected_attrs in the initial REST API method
13:58:52 dansmith you claim you already do that
13:58:55 dansmith also,
13:58:57 sean-k-mooney by the way im not really following what you are refering to are ye talkign about the LibvirtLiveMigrateNUMAInfo object
13:59:04 dansmith it should be lazy-loadable on the instance, and if not, make it
13:59:09 dansmith sean-k-mooney: no
13:59:14 sean-k-mooney oh ok
13:59:31 artom dansmith, am I? It's possible, it's been a while :)
13:59:44 dansmith artom: I left a question about it a few minutes ago
13:59:54 artom Right, but before that
13:59:57 sean-k-mooney oh the numa_toplogy field in https://review.opendev.org/#/c/634827/50/nova/objects/migrate_data.py@247
14:00:28 dansmith artom: I think it's probably time for mriedem to take a run through these to see how he's feeling about some of the softer things I have complained about previously,
14:00:48 dansmith like the two nano patches in the middle, and some of the dead code stuff you're setting up
14:00:56 dansmith I also need to look at the functional test patch yet
14:01:20 artom dansmith, aha, it's loaded in the REST API layer since stephenfin's "disable LM for NUMA" patch

Earlier   Later