| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-27 | |||
| 11:20:44 | sean-k-mooney | we do not use move claims | |
| 11:21:02 | sean-k-mooney | so i hope you are not assuming we do | |
| 11:21:18 | sean-k-mooney | ill take a look at the patch in either case | |
| 11:22:21 | gibi | sean-k-mooney: how does live migration selects the pci device on the target host? | |
| 11:23:12 | gibi | sean-k-mooney: if it uses the InstancePCIRequest then I think my strategy will work | |
| 11:23:12 | sean-k-mooney | we claim the in the pci resouce tracker in check_can_live_migrate_at_dest | |
| 11:23:52 | sean-k-mooney | we create new instancePCIRequest object i think | |
| 11:24:12 | gibi | sean-k-mooney: OK, then I need to patch those requests with https://review.opendev.org/#/c/676980/6/nova/compute/manager.py@2141 | |
| 11:25:14 | sean-k-mooney | then we store the pci addresse of the new vif objects in the migrate_data | |
| 11:25:28 | sean-k-mooney | oh the provider_mappings | |
| 11:25:32 | sean-k-mooney | ya proably | |
| 11:25:54 | sean-k-mooney | did you see my comment by the way regarding the lenght of that parmater/variable | |
| 11:26:26 | gibi | sean-k-mooney: I'm going through the series today so I will | |
| 11:27:01 | sean-k-mooney | basically request_group_resource_providers_mapping -> provider_mappings | |
| 11:27:48 | aspiers | sean-k-mooney: shall I rebase the other 2 patches on top so that they have a chance of passing pep8 at least? | |
| 11:28:11 | sean-k-mooney | if we need to explain it is a request froup resouce provder mapping we can state that in the doc string | |
| 11:28:18 | aspiers | hmm, I guess they will still fail on test_utils | |
| 11:28:34 | sean-k-mooney | aspiers: no need ill do that later | |
| 11:28:35 | gibi | sean-k-mooney: ack | |
| 11:28:44 | sean-k-mooney | was getting through my email | |
| 11:32:57 | sean-k-mooney | aspiers: grabing tea but ill rebase the follow up patch and fix the test to work on py27 shortly | |
| 12:00:06 | aspiers | sean-k-mooney: cool | |
| 12:04:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | |
| 12:04:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | |
| 12:04:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | |
| 12:07:57 | openstackgerrit | zhangyujun proposed openstack/nova master: Should not raise when restore power on failed https://review.opendev.org/624854 | |
| 12:11:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | |
| 12:13:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 12:13:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | |
| 12:18:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 12:19:48 | gibi | sean-k-mooney: addressed your comments ^^ | |
| 12:20:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 12:22:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 12:24:34 | sean-k-mooney | cool ill try an emake it through the full seriese end to end this week | |
| 12:25:06 | sean-k-mooney | ill also try and deploy it but my backlog of thig to deploy and test is kind of long at the moment | |
| 12:25:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 12:27:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 12:27:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 12:27:59 | openstackgerrit | Peter Penchev proposed openstack/nova master: libvirt: use native AIO mode for StorPool Cinder volumes. https://review.opendev.org/676172 | |
| 12:41:31 | gibi | sean-k-mooney: tanks | |
| 12:53:15 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 13:16:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 13:17:17 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | |
| 13:17:18 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915 | |
| 13:17:18 | openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | |
| 13:29:10 | mriedem | lyarwood: if you're hitting stable reviews, https://review.opendev.org/#/c/678254/ is a simple docs fix that has confused many operators | |
| 13:30:26 | lyarwood | mriedem: yup trying to, one more downstream fire to go first... | |
| 13:41:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add resize tests to nova-grenade job https://review.opendev.org/678841 | |
| 13:48:36 | stephenfin | gibi: I'm seeing the following in a functional test. Any idea why that might be? 'AllocationDeleteFailed: Failed to delete allocations for consumer [uuid]' | |
| 13:48:56 | stephenfin | Being raised by 'delete_allocation_for_instance' in 'nova/scheduler/client/report.py' | |
| 13:49:14 | stephenfin | I suspect it's to do with cleanup, but I've no idea why this test is triggering it but no others | |
| 13:49:39 | gibi | stephenfin: I'm on a call, I will get back to you in an hour | |
| 13:49:43 | stephenfin | (y) | |
| 13:54:33 | artom | dansmith, did you notice the new TODO above https://review.opendev.org/#/c/634827/50/nova/objects/migrate_data.py? I thought it would answer your question. | |
| 13:54:58 | dansmith | artom: yes | |
| 13:55:10 | artom | dansmith, OK, then I don't understand your question :) | |
| 13:55:23 | dansmith | artom: is it the current instance's numa toplology? | |
| 13:55:26 | artom | Yes | |
| 13:55:57 | dansmith | so you're passing a whole extra nested object, which is a thing that the other side already has, to functional as a sentinel? | |
| 13:56:25 | artom | Well if you put it that way, or course it's going to sound dumb ;) | |
| 13:56:32 | artom | So... just a boolean flag then? | |
| 13:56:36 | dansmith | we have a couple other boolean fields above it that indicate dest or source support for a feature | |
| 13:57:03 | sean-k-mooney | we also need the data it contians for updating the xml right | |
| 13:57:14 | dansmith | that's why I'm asking, but I don't think so | |
| 13:57:16 | artom | sean-k-mooney, the dest can pull it from the database | |
| 13:57:34 | artom | I need to double check, but it's probably already loaded | |
| 13:57:49 | dansmith | and/or has it on the instance which is sent via rpc anyway | |
| 13:58:31 | artom | And we can always add it to expected_attrs in the initial REST API method | |
| 13:58:52 | dansmith | you claim you already do that | |
| 13:58:55 | dansmith | also, | |
| 13:58:57 | sean-k-mooney | by the way im not really following what you are refering to are ye talkign about the LibvirtLiveMigrateNUMAInfo object | |
| 13:59:04 | dansmith | it should be lazy-loadable on the instance, and if not, make it | |
| 13:59:09 | dansmith | sean-k-mooney: no | |
| 13:59:14 | sean-k-mooney | oh ok | |
| 13:59:31 | artom | dansmith, am I? It's possible, it's been a while :) | |
| 13:59:44 | dansmith | artom: I left a question about it a few minutes ago | |
| 13:59:54 | artom | Right, but before that | |
| 13:59:57 | sean-k-mooney | oh the numa_toplogy field in https://review.opendev.org/#/c/634827/50/nova/objects/migrate_data.py@247 | |
| 14:00:28 | dansmith | artom: I think it's probably time for mriedem to take a run through these to see how he's feeling about some of the softer things I have complained about previously, | |
| 14:00:48 | dansmith | like the two nano patches in the middle, and some of the dead code stuff you're setting up | |
| 14:00:56 | dansmith | I also need to look at the functional test patch yet | |
| 14:01:20 | artom | dansmith, aha, it's loaded in the REST API layer since stephenfin's "disable LM for NUMA" patch | |
| 14:01:28 | dansmith | remind me why we can't test this with multinode in the gate? We can't have arbitrarily simple numa topo on a flavor that will always work, but exercise some of this? | |
| 14:01:55 | sean-k-mooney | do we need it for revert? initally i did not think we should need to have the source node numa topology in the LibvirtLiveMigrateData | |
| 14:02:19 | dansmith | artom: okay, well, I think that's a long walk for a short drink of water, and selective backports could break that assumption | |
| 14:03:14 | artom | dansmith, you're saying we could backport something that would stop loading instance.numa_topology in _migrate_live()? | |
| 14:03:33 | artom | That would break a whole lot of things | |
| 14:03:37 | dansmith | or backport this without that, or backport them both but at different times such that it's no longer a useful sentinel | |
| 14:03:56 | artom | NUMA LM isn't backportable... | |
| 14:03:58 | sean-k-mooney | we cant backport object change though | |
| 14:04:08 | mriedem | what are you talking about? why can't the API pre-load the instance.numa_topology field? | |
| 14:04:10 | dansmith | I'm just saying, tie the flag to the actual support, not to some other side effect you think is recent enough | |
| 14:04:42 | artom | dansmith, oh, sorry, we're talking about different things. I'll definitely replace numa_topology in migrate_data with a boolean sentinel | |
| 14:04:43 | mriedem | is there just some random, "if 'numa_topology' in instance: <make numa lm work>" logic? | |
| 14:04:56 | sean-k-mooney | mriedem: we are talking about is https://review.opendev.org/#/c/634827/50/nova/objects/migrate_data.py@247 requried or can we just make it a bool | |
| 14:04:57 | dansmith | mriedem: artom is saying the api is pre-loading it, and then he's checking somewhere to see if it's pre-loaded and determining whether or not the source is new enough to do the numa lm | |
| 14:04:57 | stephenfin | Wow, 'NUMAServersWithNetworksTest.test_cold_migrate_with_physnet' takes 12 seconds to run. That's a long-ass functional test | |
| 14:05:02 | artom | I was saying the destination will have the instance object with numa_topology loaded already | |
| 14:05:21 | sean-k-mooney | cant we just check the compute node verion in the conductor | |
| 14:05:50 | artom | sean-k-mooney, dansmith was saying there's caching that makes this fragile, IIRC | |