Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-20
22:03:31 mriedem ok yeah https://review.opendev.org/#/c/122162/ vs https://review.opendev.org/#/c/174480/
22:03:36 mriedem but having said that, i'm not sure why it matters
22:03:49 mriedem it's just making sure there is a method for the migration, but the method just passes so...
22:03:53 mriedem the actual test is in another module
22:04:09 dansmith well, it's more just the principle of the case where nothing should be added to those exclusion lists in the future, and I don't think you need to
22:04:36 mriedem if you're +2 besides that will you fast approve if i make that change?
22:04:52 dansmith yeah
22:05:11 dansmith sorry
22:10:33 mriedem np, i have to rebase anyway
22:14:23 dansmith mriedem: you meant soon right? :)
22:15:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add blocker migration for completing services.uuid migration https://review.opendev.org/673620
22:15:42 mriedem thar she blar
22:18:06 dansmith got it
23:04:34 mriedem thanks
23:05:29 sean-k-mooney mriedem: ack, thanks for updating the deprecation patch. i had planned to throw up a [WIP:U] patch to actully delete the thing in u but that is still future
23:05:42 sean-k-mooney just missed him hehe
23:41:12 openstackgerrit Dustin Cowles proposed openstack/nova master: Public method to retrieve custom resource providers https://review.opendev.org/676029
23:41:13 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Load the custom resource providers to resource tracker https://review.opendev.org/676522
#openstack-nova - 2019-08-21
01:15:27 openstackgerrit sean mooney proposed openstack/nova stable/pike: lxc: make use of filter python3 compatible https://review.opendev.org/676502
01:43:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix missing rule description in HACKING.rst https://review.opendev.org/677589
02:21:05 openstackgerrit Merged openstack/nova master: [Trivial]Remove unused helper filter_and_format_resource_metadata https://review.opendev.org/676038
03:00:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a hacking rule for non-existent assertions https://review.opendev.org/677596
03:26:31 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
04:44:01 openstackgerrit melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840
04:44:51 openstackgerrit melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840
05:23:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a hacking rule for non-existent assertions https://review.opendev.org/677596
05:46:17 openstackgerrit Merged openstack/nova master: doc: Trivial fixes to API version history https://review.opendev.org/649561
05:46:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a hacking rule for useless assertions https://review.opendev.org/677610
05:50:17 openstackgerrit Merged openstack/nova master: Add blocker migration for completing services.uuid migration https://review.opendev.org/673620
07:02:52 alex_xu efried: sean-k-mooney dansmith, here is the refined version about using db persistent https://etherpad.openstack.org/p/vpmems-non-virt-driver-specific-new. I also sent email to summary the pros/cons of two ways http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008625.html
08:07:11 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
09:00:15 openstackgerrit Ghanshyam Mann proposed openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665136
09:56:27 openstackgerrit Merged openstack/nova master: [Trivial]Remove unused helper _get_instances_by_filters https://review.opendev.org/676036
10:34:32 aspiers alex_xu: I will have another PS for you very soon
10:34:41 aspiers alex_xu: I'm adding the missing tests
11:15:31 openstackgerrit Merged openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338
11:51:55 alex_xu aspiers: thanks a lot
11:52:10 aspiers alex_xu: just finished now, submitting ...
11:52:58 openstackgerrit Adam Spiers proposed openstack/nova master: Split fake host capabilities into reusable variables https://review.opendev.org/677710
11:53:38 openstackgerrit Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151
11:53:50 mdbooth Heads up: the libvirt tpool proxy doesn't work reliably: https://bugs.launchpad.net/nova/+bug/1840912 Potentially the cause of a bunch of interesting behaviours
11:53:51 openstack Launchpad bug 1840912 in OpenStack Compute (nova) "libvirt calls aren't reliably using tpool.Proxy" [Undecided,New]
11:53:52 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
11:55:49 alex_xu aspiers: I will try another around tomorrow
11:56:16 aspiers alex_xu: thanks. I just updated the test comment and added some simple tests to test_host.py
11:56:22 aspiers alex_xu: so it should be easy to review
11:58:20 alex_xu aspiers: cool
12:27:39 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133
12:28:45 stephenfin alex_xu: Think you could send this on its way? https://review.opendev.org/#/c/675570/
12:36:38 openstackgerrit Adam Spiers proposed openstack/nova master: Split fake host capabilities into reusable variables https://review.opendev.org/677710
12:36:53 openstackgerrit Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151
12:37:05 openstackgerrit Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964
12:37:06 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
12:37:22 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
12:37:40 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
12:37:51 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
12:38:03 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
12:38:21 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
12:40:54 shilpasd stephenfin: Hi, small doubt, at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/versions.py#L43
12:41:12 shilpasd for multiple choices reply, links getting printed
12:41:30 shilpasd and if we given wrong request path, that getting added to response
12:41:41 stephenfin shilpasd: Could you give me an example?
12:41:46 stephenfin Expected vs. actual
12:42:00 shilpasd actual: "links": [{"href": "http://10.232.48.206/compute/v2.1/compute/v4.1/servers/detail", "rel": "self"}]
12:43:00 shilpasd expected: "links": [{"href": "http://10.232.48.206/compute/v2/servers/detail", "rel": "self"}]
12:43:32 sean-k-mooney its reading v4.1
12:43:36 sean-k-mooney as the server uuid
12:43:45 sean-k-mooney actully no its not
12:44:11 shilpasd i have purposfully given v4.1 in req path
12:44:35 sean-k-mooney ya i guessed that
12:45:06 sean-k-mooney compute/v4.1/servers/detail was what you used
12:45:08 shilpasd curl -g -i -X GET http:///compute/v4.1/servers/detail -H "Accept: application/json" -H "OpenStack-API-Version: compute 2.74 " -H "X-OpenStack-Nova-API-Version: 2.74"
12:45:16 shilpasd yes
12:45:26 shilpasd sean-k-mooney: yes
12:46:04 aspiers Can anyone comment on whether six.iteritems() should be avoided in nova? Currently our hacking extensions allow it despite http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
12:46:11 sean-k-mooney well we proably should be validaing the links if nothing else
12:46:28 shilpasd i referred https://docs.openstack.org/api-guide/compute/versions.html
12:46:33 stephenfin I'm trying to figure out where we parse the URL, but it sounds like a legit bug
12:46:45 stephenfin I assume you meant to request 'http:///compute/v2.1/servers/detail' ?
12:47:09 stephenfin I'd ask cdent but he's not around
12:47:19 shilpasd stephenfin: yes
12:47:41 shilpasd but purposefully requested 'http:///compute/v4.1/servers/detail'
12:48:11 sean-k-mooney aspiers: am i dont htink the time it examples in that post are good tests
12:48:23 aspiers sean-k-mooney: read the whole thread
12:48:48 aspiers also currently there are only two uses of six.iteritems in the whole of nova
12:49:30 sean-k-mooney we have removed som uses of it recently
12:49:58 sean-k-mooney personally given we intend to kill python 3 support in 2 months i could live with items at this point
12:50:02 stephenfin aspiers: Personally, I'd just avoid it unless you know you need it
12:50:19 aspiers stephenfin: yes, I've just removed it from my patches
12:50:19 sean-k-mooney but as a general preference i dont think we should write slow code by default
12:50:34 aspiers stephenfin: but I'm wondering whether we should add a hacking check
12:50:51 sean-k-mooney aspiers: i think that is overkill
12:51:04 stephenfin We can, but we have less than three months of needing to care about Python 2.7 left
12:51:12 stephenfin so yeah, overkill
12:51:14 sean-k-mooney maybe in Ussuri
12:51:21 aspiers ok
12:51:37 aspiers sean-k-mooney: in other news, https://review.opendev.org/#/c/677710
12:51:42 sean-k-mooney e.g. in ussuri we should not be writing new code that uses six at all
12:51:46 stephenfin sean-k-mooney: Within reason. I'll take readable code over slightly faster code in 90% of cases
12:51:58 stephenfin Yeah, if anything we could start stripping out six

Earlier   Later