| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-21 | |||
| 12:27:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | |
| 12:28:45 | stephenfin | alex_xu: Think you could send this on its way? https://review.opendev.org/#/c/675570/ | |
| 12:36:38 | openstackgerrit | Adam Spiers proposed openstack/nova master: Split fake host capabilities into reusable variables https://review.opendev.org/677710 | |
| 12:36:53 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151 | |
| 12:37:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964 | |
| 12:37:06 | openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | |
| 12:37:22 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 12:37:40 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 12:37:51 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 12:38:03 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 12:38:21 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 12:40:54 | shilpasd | stephenfin: Hi, small doubt, at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/versions.py#L43 | |
| 12:41:12 | shilpasd | for multiple choices reply, links getting printed | |
| 12:41:30 | shilpasd | and if we given wrong request path, that getting added to response | |
| 12:41:41 | stephenfin | shilpasd: Could you give me an example? | |
| 12:41:46 | stephenfin | Expected vs. actual | |
| 12:42:00 | shilpasd | actual: "links": [{"href": "http://10.232.48.206/compute/v2.1/compute/v4.1/servers/detail", "rel": "self"}] | |
| 12:43:00 | shilpasd | expected: "links": [{"href": "http://10.232.48.206/compute/v2/servers/detail", "rel": "self"}] | |
| 12:43:32 | sean-k-mooney | its reading v4.1 | |
| 12:43:36 | sean-k-mooney | as the server uuid | |
| 12:43:45 | sean-k-mooney | actully no its not | |
| 12:44:11 | shilpasd | i have purposfully given v4.1 in req path | |
| 12:44:35 | sean-k-mooney | ya i guessed that | |
| 12:45:06 | sean-k-mooney | compute/v4.1/servers/detail was what you used | |
| 12:45:08 | shilpasd | curl -g -i -X GET http:// |
|
| 12:45:16 | shilpasd | yes | |
| 12:45:26 | shilpasd | sean-k-mooney: yes | |
| 12:46:04 | aspiers | Can anyone comment on whether six.iteritems() should be avoided in nova? Currently our hacking extensions allow it despite http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html | |
| 12:46:11 | sean-k-mooney | well we proably should be validaing the links if nothing else | |
| 12:46:28 | shilpasd | i referred https://docs.openstack.org/api-guide/compute/versions.html | |
| 12:46:33 | stephenfin | I'm trying to figure out where we parse the URL, but it sounds like a legit bug | |
| 12:46:45 | stephenfin | I assume you meant to request 'http:// |
|
| 12:47:09 | stephenfin | I'd ask cdent but he's not around | |
| 12:47:19 | shilpasd | stephenfin: yes | |
| 12:47:41 | shilpasd | but purposefully requested 'http:// |
|
| 12:48:11 | sean-k-mooney | aspiers: am i dont htink the time it examples in that post are good tests | |
| 12:48:23 | aspiers | sean-k-mooney: read the whole thread | |
| 12:48:48 | aspiers | also currently there are only two uses of six.iteritems in the whole of nova | |
| 12:49:30 | sean-k-mooney | we have removed som uses of it recently | |
| 12:49:58 | sean-k-mooney | personally given we intend to kill python 3 support in 2 months i could live with items at this point | |
| 12:50:02 | stephenfin | aspiers: Personally, I'd just avoid it unless you know you need it | |
| 12:50:19 | aspiers | stephenfin: yes, I've just removed it from my patches | |
| 12:50:19 | sean-k-mooney | but as a general preference i dont think we should write slow code by default | |
| 12:50:34 | aspiers | stephenfin: but I'm wondering whether we should add a hacking check | |
| 12:50:51 | sean-k-mooney | aspiers: i think that is overkill | |
| 12:51:04 | stephenfin | We can, but we have less than three months of needing to care about Python 2.7 left | |
| 12:51:12 | stephenfin | so yeah, overkill | |
| 12:51:14 | sean-k-mooney | maybe in Ussuri | |
| 12:51:21 | aspiers | ok | |
| 12:51:37 | aspiers | sean-k-mooney: in other news, https://review.opendev.org/#/c/677710 | |
| 12:51:42 | sean-k-mooney | e.g. in ussuri we should not be writing new code that uses six at all | |
| 12:51:46 | stephenfin | sean-k-mooney: Within reason. I'll take readable code over slightly faster code in 90% of cases | |
| 12:51:58 | stephenfin | Yeah, if anything we could start stripping out six | |
| 12:52:03 | stephenfin | where it made sense, that is | |
| 12:52:41 | sean-k-mooney | stephenfin: sure but it adds up. if the perfomace is close readablity win if it way more readabel but way slower we should not use it in performance critical parts of nova or any project | |
| 12:53:24 | aspiers | sean-k-mooney: need you to check https://review.opendev.org/#/c/673151/13..15/nova/tests/unit/virt/libvirt/test_host.py | |
| 12:53:57 | sean-k-mooney | aspiers: ah your adding the fake data for capablites too. i had that in my orginial version but then dropped it as it was not needed | |
| 12:54:19 | aspiers | sean-k-mooney: not adding, more like moving and updating | |
| 12:54:25 | sean-k-mooney | that looks like a potentally good approch to take | |
| 12:54:37 | sean-k-mooney | refactoring :) | |
| 12:56:01 | sean-k-mooney | im in two minds about your test__get_machine_types fucntion | |
| 12:56:46 | sean-k-mooney | i dont like use hardcoding data like that in tests that are that coupled but i guess its ok | |
| 12:57:30 | sean-k-mooney | i guess its fine since it matching the fixture but it would be nic if you could get teh expected arch/machine types form the fixture | |
| 12:58:35 | sean-k-mooney | ill think about it over lunch but ill proably +1 goes to actully have lunch now | |
| 12:59:07 | aspiers | sean-k-mooney: thanks :) | |
| 13:17:26 | mdbooth | dansmith: I've got a much better feeling about this one: https://bugs.launchpad.net/nova/+bug/1840912 | |
| 13:17:27 | openstack | Launchpad bug 1840912 in OpenStack Compute (nova) "libvirt calls aren't reliably using tpool.Proxy" [Undecided,New] | |
| 13:20:45 | dulek | Hi! This is probably trivial, but I see this in n-cpu logs on a fresh DevStack instance: `libvirtError: Cannot access storage file '/opt/stack/data/nova/instances/403824ef-422f-4e23-9e3a-d897766aa70d/disk' (as uid:107, gid:107)`. Any ideas how to get rid of that? | |
| 13:29:33 | dansmith | mdbooth: okay, have to do something first but then I'll look | |
| 13:30:36 | mdbooth | dansmith: That's just the bug description, btw. Patch incoming. Patch might touch a couple of testing weird spots, so I'm expecting discussion/rework. | |
| 13:33:03 | dansmith | mdbooth: I'll be looking for why this wasn't a thing in the first eight years of its life, of course :) | |
| 13:33:39 | mdbooth | dansmith: I think it was ;) I suspect there's a point 2 to this bug which is why libvirt is being slow enough for this customer to trigger it. | |
| 13:33:52 | mdbooth | However, we tested it and it's definitely not using the proxy | |
| 13:42:58 | dansmith | mdbooth: ah, I see, looks like a good lead | |
| 13:46:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: Make memtune parameters consistent with libvirt docs and code https://review.opendev.org/636301 | |
| 13:53:23 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151 | |
| 13:57:35 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/677736 | |
| 14:10:25 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964 | |
| 14:10:25 | openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | |
| 14:10:35 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 14:10:49 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 14:11:03 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 14:11:14 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 14:11:39 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 14:20:34 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/677736 | |
| 14:36:54 | openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790 | |
| 14:39:53 | mriedem | mdbooth: can we avoid the libvirt-python test dependency? i think that will mean local dev needs to install a native package, from what i remember years ago anyway | |
| 14:40:16 | mdbooth | mriedem: Yeah, I threw that in there to have a starting point, tbh | |
| 14:40:20 | mriedem | and it was a source of problems before too | |
| 14:40:22 | mriedem | ok | |
| 14:40:31 | mdbooth | mriedem: I mostly wanted to get a full tempest run against it. | |
| 14:40:42 | mriedem | so WIP it? | |
| 14:40:55 | mdbooth | mriedem: Will do. | |
| 14:41:01 | mriedem | thanks | |
| 14:41:28 | mdbooth | mriedem: I really want eyes on it, though :) Also, ideas for useful testing without using libvirt. | |
| 14:42:00 | mdbooth | Might look at something using fakelibvirt | |
| 14:42:07 | mriedem | i assumed fakelibvirt | |
| 14:42:12 | mriedem | since that's what we always use | |
| 14:42:28 | sean-k-mooney | mdbooth: you porbaly could mock the call to inspect | |
| 14:42:48 | sean-k-mooney | and pass in a set of different moduels for it to use and assert they were wrapped | |