Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-14
21:18:54 melwitt mriedem: I'm thinking I should fix this up and rebase on it for the multi-cell archive patch https://review.opendev.org/675218
21:19:53 melwitt bc if it does the re-use of db engine, I won't have to make any changes to the "for table" method
21:21:13 mriedem melwitt: i forgot all about that patch :(
21:21:41 mriedem i've got part of it fixed, i can push that up once i'm done rebasing the cross-cell-resize series and mark as WIP if you want to swing at it
21:21:50 mriedem but yeah i assumed you'd rebase on that series of fixups
21:22:04 melwitt me too kinda, until I went to address review feedback and was like, hm, I think mriedem did something about this in another patch
21:22:22 melwitt ok, that would be great. thanks
21:38:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
21:38:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
21:38:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
21:39:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
21:39:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
21:39:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
21:39:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
21:39:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
21:39:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
21:39:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
21:39:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
21:39:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
21:39:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
21:39:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.opendev.org/614037
21:39:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
21:39:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
21:39:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
21:39:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
21:45:05 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Re-use DB engine connection during archive_deleted_rows https://review.opendev.org/675218
21:45:16 mriedem melwitt: ^ some test_db_api tests are failing with unique constraint errors, like an instance was archived when it didn't expect it to
21:45:50 melwitt mriedem: ok, thanks
21:49:35 mriedem ok i fixed it
21:49:49 mriedem still need to call metadata.bind.connect() per call to _archive_deleted_rows_for_table
21:49:52 mriedem not entirely sure why...
21:52:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
21:52:29 mriedem ah crap need to remove the WIP
21:52:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
21:52:58 mriedem ok now i need to run
21:56:19 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
21:56:19 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Public method to retrieve custom resource providers https://review.opendev.org/676029
21:56:20 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Load the custom resource providers to resource tracker https://review.opendev.org/676522
22:00:13 melwitt thanks mriedem++
22:08:46 openstackgerrit Eric Fried proposed openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495
22:08:59 efried mordred: A big but very focused hammer ^
22:14:24 mordred efried: wow
22:14:44 mordred efried: I feel like pep8 isn't going to like it - but I do
22:14:55 efried oh, rat farts, forgot to fix that part...
22:15:19 openstackgerrit Eric Fried proposed openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495
22:15:33 efried thanks mordred for saving me a failed zuul run on a stupid
22:17:31 openstackgerrit Merged openstack/nova stable/rocky: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676290
22:18:53 sean-k-mooney gibi: by the way you asked me over a month ago if i had an example of how to configure a host to use the same interface for both ovs and sriov. i am setting up my sriov servers again and this is the local.conf i use http://paste.openstack.org/show/757169/
22:20:55 sean-k-mooney im using port enp1s0f1 as teh ovs port on the br-ex and its also the pf of the sriov vfs with the neutron fdb extention enalbed to make sure that ovs vm to sriov vm traffic does nto need to hairpin at teh top of rack switch
#openstack-nova - 2019-08-15
00:03:58 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072
00:05:05 openstackgerrit Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074
00:05:49 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075
00:06:13 efried dansmith, melwitt: If you're still around, this iteration of that fixture passed zuul: https://review.opendev.org/#/c/676495/
00:06:13 efried would be nice to have it merged by morning to unwedge https://review.opendev.org/#/c/676457/
00:06:35 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952
00:26:41 melwitt efried: looking
00:28:12 efried thanks melwitt
00:31:09 melwitt guh, I don't know what I'm looking at here
00:31:35 efried melwitt: I can splain if you got a minute
00:32:01 melwitt ok. I see mordred said earlier that he thinks it looks good, if he could +1 it again that would be helpful too
00:36:10 efried Without any fixturing, unit and functional tests fail because many of them hit paths that try to use placement, and placement now uses sdk.
00:36:10 efried When we try to load up sdk, it normally does some discovery for us, things like checking the service catalog and asking for version documents.
00:36:10 efried And in unit/functional tests, we don't care about any of that.
00:36:10 efried The problem is that the discovery stuff is done through ksa - and we have other things (glance, cinder, ironic...) that rely on those ksa-isms either not being mocked at all, or being mocked a certain way in their own tests.
00:36:10 efried So I can't just mock away the ksa stuff - which was my first PS on this fix - because then those all puke.
00:36:11 efried So instead I'm mocking the thing in the sdk that triggers that discovery. And I'm making it do almost all of what it would do anyway - just skipping that one part that hits ksa.
00:36:11 efried The linked patch shows the code I cribbed from.
00:37:17 melwitt ok, thanks
00:38:57 efried As before, this is just making sure that unit/func tests that only care about a default no-op-ish ksa Adapter actually get something that looks like an Adapter.
00:38:57 efried The problem is that sdk is a moving target right now, which is why I had to change it; but hopefully this version will stick for a little while longer until we can get real fixtures from sdk.
00:39:21 melwitt yeah, I was looking through wondering why mocking get_endpoint didn't work
00:40:29 melwitt like, you're skipping around the get_endpoint call in the new mock, but yet mocking get_endpoint itself didn't work. and I wasn't seeing what/how this avoids the problem
00:40:56 efried Right - if you look at the PS1 failures, you can see where things like glance and cinder are relying on get_endpoint to "work" and be un-mocked.
00:41:26 efried So whereas mocking get_endpoint gets around the paths where *placement* tries to create an Adapter, it makes those other ones puke.
00:44:02 melwitt efried: could you have mocked get_endpoint conditionally if self.service_type is placement to get the same thing or no?
00:46:47 efried melwitt: I think then in tests that hit placement *and* one of the other things, it would still get mocked - possibly at an unpredictable time in the test
00:47:25 melwitt ok. sorry for all the questions, this is confusing to me
00:47:45 efried the right solution, long-term, and mordred is working on this, is for openstacksdk to publish fixtures that we can just import and use. Because openstacksdk will always know what it's doing internally and how.
00:48:39 efried This - like the previous iteration of the fixture that mocked Adapter.get_major_api_version - is just a stopgap to let us move forward until that happens.
00:49:20 efried and it's only affecting unit/func tests. The real proof that sdk is working for us is in the fact that all the tempest tests - which all use placement, which uses sdk - pass.
00:49:41 melwitt yeah, I get that part, I just didn't want to fast approve something I had zero understanding of. I'll look at it some more and if I can grok it, I'll send it on
00:50:06 melwitt thanks for explaining all that
00:50:32 efried Thanks for looking.
00:50:32 efried I think alex_xu might be arriving on the scene soon, so if you prefer not to +W it, he might be able to do so while we sleep.
00:52:50 melwitt it might just take me a bit longer to get this
00:53:13 efried It's not the end of the world if it has to wait for morning.
00:53:55 efried It would just be nice to be able to recheck the u-c patch and have it merged by morning so I can move on with the stuff that builds on it.
00:54:48 melwitt yeah, I understand. I'll keep looking at it, just need a bit more time
00:55:00 efried thanks melwitt
01:43:18 openstackgerrit Dongcan Ye proposed openstack/nova master: Libvirt: Rename _guest_add_memory_balloon https://review.opendev.org/676534
01:45:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536
01:53:16 openstackgerrit Mohammed Naser proposed openstack/nova master: cleanup: remove osapi_v21.project_id_regex https://review.opendev.org/676537
01:58:38 melwitt efried: +W (finally)
02:02:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536
02:06:35 yonglihe melwitt: Hi, I hope the comments address your concern, very nice to have you review that, thank. https://review.opendev.org/#/c/627765/
02:14:01 openstackgerrit Mohammed Naser proposed openstack/nova master: config: remove deprecated checksum options https://review.opendev.org/676539
02:29:54 openstackgerrit Mohammed Naser proposed openstack/nova master: Remove nova.image.download.modules extension point https://review.opendev.org/676540
02:32:39 melwitt yonglihe: I'll try to take a look tomorrow, sorry for the delay
03:13:50 openstackgerrit CHENGLEI proposed openstack/nova stable/pike: Insert the description of the change. https://review.opendev.org/676541
05:17:36 openstackgerrit ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407

Earlier   Later