| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-15 | |||
| 00:06:13 | efried | dansmith, melwitt: If you're still around, this iteration of that fixture passed zuul: https://review.opendev.org/#/c/676495/ | |
| 00:06:13 | efried | would be nice to have it merged by morning to unwedge https://review.opendev.org/#/c/676457/ | |
| 00:06:35 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 00:26:41 | melwitt | efried: looking | |
| 00:28:12 | efried | thanks melwitt | |
| 00:31:09 | melwitt | guh, I don't know what I'm looking at here | |
| 00:31:35 | efried | melwitt: I can splain if you got a minute | |
| 00:32:01 | melwitt | ok. I see mordred said earlier that he thinks it looks good, if he could +1 it again that would be helpful too | |
| 00:36:10 | efried | Without any fixturing, unit and functional tests fail because many of them hit paths that try to use placement, and placement now uses sdk. | |
| 00:36:10 | efried | When we try to load up sdk, it normally does some discovery for us, things like checking the service catalog and asking for version documents. | |
| 00:36:10 | efried | And in unit/functional tests, we don't care about any of that. | |
| 00:36:10 | efried | The problem is that the discovery stuff is done through ksa - and we have other things (glance, cinder, ironic...) that rely on those ksa-isms either not being mocked at all, or being mocked a certain way in their own tests. | |
| 00:36:10 | efried | So I can't just mock away the ksa stuff - which was my first PS on this fix - because then those all puke. | |
| 00:36:11 | efried | So instead I'm mocking the thing in the sdk that triggers that discovery. And I'm making it do almost all of what it would do anyway - just skipping that one part that hits ksa. | |
| 00:36:11 | efried | The linked patch shows the code I cribbed from. | |
| 00:37:17 | melwitt | ok, thanks | |
| 00:38:57 | efried | As before, this is just making sure that unit/func tests that only care about a default no-op-ish ksa Adapter actually get something that looks like an Adapter. | |
| 00:38:57 | efried | The problem is that sdk is a moving target right now, which is why I had to change it; but hopefully this version will stick for a little while longer until we can get real fixtures from sdk. | |
| 00:39:21 | melwitt | yeah, I was looking through wondering why mocking get_endpoint didn't work | |
| 00:40:29 | melwitt | like, you're skipping around the get_endpoint call in the new mock, but yet mocking get_endpoint itself didn't work. and I wasn't seeing what/how this avoids the problem | |
| 00:40:56 | efried | Right - if you look at the PS1 failures, you can see where things like glance and cinder are relying on get_endpoint to "work" and be un-mocked. | |
| 00:41:26 | efried | So whereas mocking get_endpoint gets around the paths where *placement* tries to create an Adapter, it makes those other ones puke. | |
| 00:44:02 | melwitt | efried: could you have mocked get_endpoint conditionally if self.service_type is placement to get the same thing or no? | |
| 00:46:47 | efried | melwitt: I think then in tests that hit placement *and* one of the other things, it would still get mocked - possibly at an unpredictable time in the test | |
| 00:47:25 | melwitt | ok. sorry for all the questions, this is confusing to me | |
| 00:47:45 | efried | the right solution, long-term, and mordred is working on this, is for openstacksdk to publish fixtures that we can just import and use. Because openstacksdk will always know what it's doing internally and how. | |
| 00:48:39 | efried | This - like the previous iteration of the fixture that mocked Adapter.get_major_api_version - is just a stopgap to let us move forward until that happens. | |
| 00:49:20 | efried | and it's only affecting unit/func tests. The real proof that sdk is working for us is in the fact that all the tempest tests - which all use placement, which uses sdk - pass. | |
| 00:49:41 | melwitt | yeah, I get that part, I just didn't want to fast approve something I had zero understanding of. I'll look at it some more and if I can grok it, I'll send it on | |
| 00:50:06 | melwitt | thanks for explaining all that | |
| 00:50:32 | efried | Thanks for looking. | |
| 00:50:32 | efried | I think alex_xu might be arriving on the scene soon, so if you prefer not to +W it, he might be able to do so while we sleep. | |
| 00:52:50 | melwitt | it might just take me a bit longer to get this | |
| 00:53:13 | efried | It's not the end of the world if it has to wait for morning. | |
| 00:53:55 | efried | It would just be nice to be able to recheck the u-c patch and have it merged by morning so I can move on with the stuff that builds on it. | |
| 00:54:48 | melwitt | yeah, I understand. I'll keep looking at it, just need a bit more time | |
| 00:55:00 | efried | thanks melwitt | |
| 01:43:18 | openstackgerrit | Dongcan Ye proposed openstack/nova master: Libvirt: Rename _guest_add_memory_balloon https://review.opendev.org/676534 | |
| 01:45:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536 | |
| 01:53:16 | openstackgerrit | Mohammed Naser proposed openstack/nova master: cleanup: remove osapi_v21.project_id_regex https://review.opendev.org/676537 | |
| 01:58:38 | melwitt | efried: +W (finally) | |
| 02:02:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536 | |
| 02:06:35 | yonglihe | melwitt: Hi, I hope the comments address your concern, very nice to have you review that, thank. https://review.opendev.org/#/c/627765/ | |
| 02:14:01 | openstackgerrit | Mohammed Naser proposed openstack/nova master: config: remove deprecated checksum options https://review.opendev.org/676539 | |
| 02:29:54 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Remove nova.image.download.modules extension point https://review.opendev.org/676540 | |
| 02:32:39 | melwitt | yonglihe: I'll try to take a look tomorrow, sorry for the delay | |
| 03:13:50 | openstackgerrit | CHENGLEI proposed openstack/nova stable/pike: Insert the description of the change. https://review.opendev.org/676541 | |
| 05:17:36 | openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | |
| 07:52:34 | gibi | sean-k-mooney: thanks for the devstack conf with the mixed sriov ovs setup | |
| 08:11:40 | gibi | sean-k-mooney: did you set up connectivity between br-ex and enp1s0f1 on the physical host? | |
| 08:24:41 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass RequestContext to oslo_policy https://review.opendev.org/674038 | |
| 08:28:30 | openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | |
| 08:28:35 | sean-k-mooney | gibi: that config does it automatically | |
| 08:28:55 | sean-k-mooney | it add enp1sof1 to the br-ex | |
| 08:29:01 | sean-k-mooney | *adds | |
| 08:30:00 | sean-k-mooney | i also put the echo to allocate the vf in the local.conf and set the pci whitelist based on the vendor id and procut id of the vf so it automaticl allows the correect vfs | |
| 08:31:14 | sean-k-mooney | when stacking compltes you are basiaclly ready to boot a vm with an sriov port and it will get a dhcp adress for the dhcp agent attached to ovs | |
| 08:32:18 | sean-k-mooney | i say basiacally ready as cirros may not have your nic driver so you might need to upload a new image first | |
| 08:45:51 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | |
| 08:49:28 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | |
| 08:50:27 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | |
| 08:51:06 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 08:54:37 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698 | |
| 08:54:55 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Ensure we pass a target in admin actions https://review.opendev.org/663095 | |
| 09:03:54 | gibi | sean-k-mooney: thanks | |
| 09:14:06 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-agents policies https://review.opendev.org/669578 | |
| 09:19:28 | gibi | gmann: hi! If you have time, could you give your oppinion in https://review.opendev.org/#/c/675371/ ? | |
| 09:23:10 | openstackgerrit | Merged openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495 | |
| 09:39:14 | gmann | gibi: sure, i will check. | |
| 09:42:24 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles and mapping in policy base class https://review.opendev.org/645452 | |
| 09:42:57 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 09:54:17 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698 | |
| 09:54:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Ensure we pass a target in admin actions https://review.opendev.org/663095 | |
| 10:14:45 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in Admin Actions https://review.opendev.org/657823 | |
| 10:19:49 | openstackgerrit | Guo Jingyu proposed openstack/nova master: define and catch InstanceGuestAgentNotRunning for set-password failure https://review.opendev.org/676667 | |
| 10:39:11 | openstackgerrit | Guo Jingyu proposed openstack/nova master: define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/676667 | |
| 10:42:40 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add policy deprecation fixture and Suppress warnings in tests https://review.opendev.org/676670 | |
| 10:44:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 10:44:27 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 10:48:42 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 10:53:45 | openstackgerrit | Chris Dent proposed openstack/nova master: Add a "Caveats" section to the eventlet profiling docs https://review.opendev.org/676672 | |
| 10:56:39 | sean-k-mooney | what time does matt normally log on? about 1-2 hours form now? | |
| 10:57:22 | stephenfin | sean-k-mooney: We have a conflict with cpu-resources | |
| 10:57:23 | sean-k-mooney | i started early today so it feels weird to have been online for a while and not see the us folks about | |
| 10:57:34 | sean-k-mooney | we do? | |
| 10:57:44 | sean-k-mooney | with what | |
| 10:58:17 | stephenfin | There's a workaround option to disable VCPU -> PCPU flavor translation and we've decided to report both PCPUs and VCPUs for compute nodes without explicit CPU pinset configuration | |
| 10:58:33 | sean-k-mooney | yes | |
| 10:58:42 | sean-k-mooney | i was talking about this yesterday | |
| 10:58:47 | stephenfin | If I reshape, I move every allocation for pinned instances on that host from VCPUs to PCPUs | |
| 10:58:59 | sean-k-mooney | right | |
| 10:59:19 | sean-k-mooney | which is why i raised that workaround option as an issue | |
| 10:59:23 | stephenfin | But if you enable the workaround option (so your pinned instances continue to request VCPUs), more pinned instances will land on that host that use VCPUs instead of PCPUs | |
| 10:59:39 | sean-k-mooney | yes | |
| 10:59:48 | stephenfin | so those two things can't coexist | |
| 11:00:05 | sean-k-mooney | yes you cant reshap until you disabel the workaround | |
| 11:00:27 | stephenfin | yup, and the workaround needs to be set on every single host, and toggled on every host at the same time | |
| 11:00:41 | sean-k-mooney | well currently its only set on the schduler | |
| 11:00:44 | stephenfin | compute nodes and controllers (well, scheduler hosts) | |
| 11:00:47 | sean-k-mooney | but it would have to be if you were to use | |