| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-14 | |||
| 17:22:45 | dansmith | maybe not been started, | |
| 17:22:50 | dansmith | but because we're using the fake driver, | |
| 17:22:58 | dansmith | we've already run get_available_nodes() by the time start_service has returned | |
| 17:23:08 | dansmith | and that returns the same name as host.hostname or something | |
| 17:23:25 | dansmith | so when he then overrides the node list to be node1, node2, you'd get a deletion of the host1 node that was already created | |
| 17:24:18 | dansmith | anyway, I think your "I pulled down the patch" comment explains what I was asking, just that you were noticing test behavior and not concerned about relevance to real life or something else | |
| 17:25:28 | efried | I was concerned about relevance to real life. But if you're telling me it's just test harness noise, I'm okay with that. | |
| 17:25:35 | dansmith | ack | |
| 17:25:43 | efried | however, if it is test harness noise, I feel like we ought to be able to fix it. | |
| 17:25:50 | efried | more easily than if it's in the real code. | |
| 17:26:03 | dansmith | we could for sure (just made a comment to that effect) | |
| 17:26:07 | dansmith | I just don't think it's that important | |
| 17:26:26 | dansmith | normally having them match is handy | |
| 17:26:45 | efried | "normally" not-ironic | |
| 17:26:50 | efried | no doubt | |
| 17:27:24 | efried | but for ironic cases in general I would think it's never handy, n/a most of the time, but in certain cases like this one really confusing. | |
| 17:27:38 | dansmith | yes, normally not ironic | |
| 17:27:44 | dansmith | yep | |
| 17:27:58 | dansmith | well, yep to the first part, not the second | |
| 17:28:10 | dansmith | I don't really think it's confusing, but probably just because I know the details | |
| 17:28:28 | dansmith | the test isn't testing the ironic case, it's testing the bring-back-the-dead case, | |
| 17:28:46 | dansmith | which is related to how it works with ironic, but... not entirely ironic specific | |
| 17:28:49 | dansmith | ANYway | |
| 17:30:17 | efried | we could add to the fragility of FakeDriver's init_host by special-casing another CONF.host, say ironic-compute, and making self._nodes [] in that case. | |
| 18:19:09 | mriedem | efried: fwiw, | |
| 18:19:22 | mriedem | when we had a fake.set_nodes global i could have used that to avoid this problem, | |
| 18:19:28 | mriedem | but since that was removed, you get the thing described above | |
| 18:19:35 | mriedem | "so when he then overrides the node list to be node1, node2, you'd get a deletion of the host1 node that was already created" | |
| 18:20:23 | mriedem | so i could have started with host1:host1, and then returned available nodes host1:host1 and host1:node2 but that's also weird - which was my reply | |
| 18:25:44 | efried | I let it go, but if y'all keep talking about it, I'm going to have to fix it. | |
| 18:25:58 | openstackgerrit | Merged openstack/nova master: lxc: make use of filter python3 compatible https://review.opendev.org/676263 | |
| 18:26:16 | mriedem | do you want to talk about AZ design in a new private cloud instead? | |
| 18:26:36 | mriedem | sean-k-mooney: do you want to backport https://review.opendev.org/#/c/676263/ ? | |
| 18:45:00 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Log compute node uuid when the record is created https://review.opendev.org/676487 | |
| 19:15:07 | sean-k-mooney | mriedem: i can backport it. how far? | |
| 19:15:20 | sean-k-mooney | mriedem: also i looked at what devstack is doing | |
| 19:15:32 | sean-k-mooney | its useing a cirros image for lxc by defult | |
| 19:15:58 | sean-k-mooney | i have not unpacked it but they use a different init system or rather non standard | |
| 19:16:13 | sean-k-mooney | so that coudl be the issue with the other error | |
| 19:16:40 | sean-k-mooney | i might try to set up an lxc deployment locally and see if i can figure it out later in the week | |
| 19:20:07 | openstackgerrit | Eric Fried proposed openstack/nova master: Enhance SDK fixture for 0.34.0 https://review.opendev.org/676495 | |
| 19:20:14 | efried | mordred: ^ | |
| 19:21:00 | mordred | efried: ++ I think that's the right call | |
| 19:21:32 | efried | mriedem, dansmith: can I get a fast approval (assuming zuul happy) for this --^ please? It's blocking u-c for openstacksdk https://review.opendev.org/#/c/676457/ | |
| 19:21:54 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: lxc: make use of filter python3 compatible https://review.opendev.org/676496 | |
| 19:23:29 | sean-k-mooney | if i want to cherry pick back multiple branches gerrit does not update the cherry picked from commit like unless its merged right | |
| 19:24:17 | sean-k-mooney | so i shoudl either do it via the commandline or update it manually? | |
| 19:25:11 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: lxc: make use of filter python3 compatible https://review.opendev.org/676498 | |
| 19:25:53 | openstackgerrit | sean mooney proposed openstack/nova stable/queens: lxc: make use of filter python3 compatible https://review.opendev.org/676500 | |
| 19:26:58 | openstackgerrit | sean mooney proposed openstack/nova stable/pike: lxc: make use of filter python3 compatible https://review.opendev.org/676502 | |
| 19:27:29 | sean-k-mooney | ok i have cherry picked it to pike since that is when we added python3 support now to fix all the topics | |
| 19:31:13 | mriedem | efried: done | |
| 19:32:05 | efried | thanks | |
| 19:33:18 | mriedem | nice to know that after talking about what to do for AZs in a new cloud for a couple of hours that my initial, "at this point i don't think we need any AZs" comment turned out to be the correct one | |
| 19:33:25 | mriedem | $$$ professional $$$ | |
| 19:40:29 | sean-k-mooney | the only thinig i have ever used AZs for is to give people the choice of the old servers, the new servers or the ci servers | |
| 19:47:05 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676507 | |
| 19:47:05 | openstack | bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | |
| 19:49:03 | mriedem | sean-k-mooney: which you could do with host aggregates and flavors tied to those aggregates | |
| 20:02:34 | mriedem | dropping os-acc before we even have a working nova/cyborg integration seems like jumping the gun | |
| 20:06:01 | efried | mordred: stubbing Adapter.get_endpoint is too big a hammer. I'm struggling to come up with another approach... | |
| 20:07:38 | mordred | efried: poop. my brain is towards the end of its hours of effectiveness in terms of coming up with useful ideas... I'll dig in to it first thing in the morning when I'm fresh. | |
| 20:07:43 | mordred | there's got to be something | |
| 20:08:03 | efried | mordred: problem is a bunch of other things hit Adapter and Adapter.get_endpoint | |
| 20:08:22 | mordred | yeah | |
| 20:10:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Restore soft-deleted compute node with same uuid https://review.opendev.org/676509 | |
| 20:14:40 | openstackgerrit | Merged openstack/nova master: Add functional regression recreate test for bug 1839560 https://review.opendev.org/675705 | |
| 20:14:40 | openstack | bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | |
| 20:14:49 | openstackgerrit | Merged openstack/nova master: Restore soft-deleted compute node with same uuid https://review.opendev.org/675496 | |
| 20:16:21 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676513 | |
| 20:16:21 | openstack | bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | |
| 20:19:17 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Restore soft-deleted compute node with same uuid https://review.opendev.org/676514 | |
| 20:19:21 | mriedem | mnaser: backports are all up | |
| 20:20:58 | mriedem | TheJulia: looks like ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is busted on stable/rocky, | |
| 20:21:11 | mriedem | seeing this: It looks like a path. File ''/home/zuul/src/opendev.org/openstack/ironic-tempest-plugin'' does not exist. | |
| 20:23:24 | mriedem | queens and stein are ok | |
| 20:27:09 | mriedem | oh i bet it's this https://github.com/openstack/ironic/commit/ef0fde41e9c78e79d0b3b618102bcb475fa1f691 | |
| 20:30:09 | TheJulia | but that was on master and stein | |
| 20:30:39 | mriedem | "The has stopped working out of a sudden." doesn't mention the root cause | |
| 20:30:45 | mriedem | which might be something that affects rocky as well | |
| 20:30:49 | TheJulia | mriedem: unless your meaning that it might be the fix? | |
| 20:30:55 | mriedem | yeah | |
| 20:31:02 | TheJulia | maybe, I'm wondering why we've not seen it on rocky then | |
| 20:31:23 | TheJulia | mriedem: are you guys just invoking the job directly by name, or do you hae a definition in nova's config? | |
| 20:31:28 | mriedem | looks like you have... https://review.opendev.org/#/c/648360/ | |
| 20:31:49 | mriedem | we just use the job name | |
| 20:32:09 | mriedem | https://github.com/openstack/nova/blob/stable/rocky/.zuul.yaml#L213 | |
| 20:32:37 | TheJulia | interesting | |
| 20:32:53 | mriedem | yeah stable/rocky is broken for ironic as well, | |
| 20:32:59 | mriedem | i'm working on backporting that fix but there are merge conflicts | |
| 20:34:44 | TheJulia | well, it was working as of Aug 3 | |
| 20:35:06 | TheJulia | mriedem: okay, if your doing that, I'll wait then | |
| 21:18:54 | melwitt | mriedem: I'm thinking I should fix this up and rebase on it for the multi-cell archive patch https://review.opendev.org/675218 | |
| 21:19:53 | melwitt | bc if it does the re-use of db engine, I won't have to make any changes to the "for table" method | |
| 21:21:13 | mriedem | melwitt: i forgot all about that patch :( | |
| 21:21:41 | mriedem | i've got part of it fixed, i can push that up once i'm done rebasing the cross-cell-resize series and mark as WIP if you want to swing at it | |
| 21:21:50 | mriedem | but yeah i assumed you'd rebase on that series of fixups | |
| 21:22:04 | melwitt | me too kinda, until I went to address review feedback and was like, hm, I think mriedem did something about this in another patch | |
| 21:22:22 | melwitt | ok, that would be great. thanks | |
| 21:38:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |