| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-07 | |||
| 05:20:53 | openstackgerrit | Merged openstack/nova master: Replace non-nova server fault message https://review.opendev.org/674821 | |
| 05:40:27 | openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | |
| 07:01:13 | openstackgerrit | Merged openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893 | |
| 07:14:33 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix non-existent method of Mock https://review.opendev.org/675041 | |
| 07:55:50 | brinzhang | takashi: Why abandon this patch https://review.opendev.org/#/c/450119? | |
| 07:57:35 | brinzhang | takashi: I have a bp, it's codes need to add parameters to support for migration-list command, but there isnot the ``openstack server migration-list`` CLI | |
| 08:01:53 | brinzhang | takashin: :) | |
| 08:02:13 | takashin | brinzhang: Hi | |
| 08:02:55 | brinzhang | https://review.opendev.org/#/c/450119 this patch, looks good, but why are you abandon? | |
| 08:03:38 | takashin | brinzhang: There was a subsequnt BP. It was the function to abort cold migration. | |
| 08:04:33 | takashin | brinzhang: But in community discussin, it is not necessary to abort cold migration. So https://review.opendev.org/#/c/450119 was abondaned. | |
| 08:05:39 | brinzhang | takashin: Now in the openstackclient, there is not has the 'opesntack server migration-list', I was reviewed this patch, found you added it | |
| 08:06:19 | brinzhang | takashin: so I asked for that, if so, I will push a new patch for the migration-list | |
| 08:06:41 | takashin | brinzhang: You can take over it. | |
| 08:08:38 | brinzhang | takashin: cool, I will have a try, and remove the cold migration deal, and add my requirement. | |
| 08:23:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | |
| 09:22:18 | openstackgerrit | Chris Dent proposed openstack/nova master: Add a document that describes profiling eventlet services https://review.opendev.org/674865 | |
| 09:28:09 | bhagyashris | stephenfin: Hi , Good morning :) | |
| 09:29:19 | stephenfin | bhagyashris: Evening o/ | |
| 09:29:49 | bhagyashris | stephenfin: I saw you have uploaded patches including the upgrade changes, But I found few issues after applying all the patches. #link: http://paste.openstack.org/show/755606/ | |
| 09:30:24 | bhagyashris | stephenfin: noted issues in above #link path | |
| 09:34:47 | bhagyashris | stephenfin: As per discussion and mentioned in spec we are not going to support both the PCPU and VCPU in single boot request so IMO we will need to add check some where to reject such request with proper error message to user. | |
| 09:34:56 | stephenfin | bhagyashris: Yeah, I should have a WIP flag on that. There's a few corner cases I still need to cover including that one | |
| 09:35:54 | stephenfin | You're correct about the pinning though. I guess that's because we need to set the 'cpu_policy' field on the 'InstanceNUMATopology' object | |
| 09:36:59 | bhagyashris | stephenfin:yeah | |
| 09:37:50 | bhagyashris | stephenfin: And also I would like to know about are we going tp supporting new syntax of flavor extra specs like resources:PCPU and resources:VCPU in Train? | |
| 09:38:05 | bhagyashris | S/tp/to | |
| 09:39:18 | stephenfin | That would require changes to the InstanceNUMATopology object, but like we discussed previously, they don't need to be done yet | |
| 09:40:42 | bhagyashris | stephenfin: if yes then in that case we will also need to take care the first issue that I have mentioned above ... gust xml will give wrong result if user will create the instance using flavor extra specs resources:PCPU=1 | |
| 09:41:46 | stephenfin | Yup. Indeed. That needs to be done regardless. | |
| 09:42:09 | bhagyashris | stephenfin: OK | |
| 09:42:14 | bhagyashris | stephenfin: and one more thing I would like to ask about the translation of flavor extra specs and image meta data .. are you going to use my change https://review.opendev.org/#/c/672223/1 or you are going to continue on your change? | |
| 09:44:11 | stephenfin | I think I'm going to keep going with https://review.opendev.org/#/c/671801/. I don't like the idea of rewriting the flavor behind the users back and this change doesn't require that. I might change my mind again, but I'll go with this for now | |
| 09:45:20 | bhagyashris | stephenfin: OK No problem. | |
| 09:45:52 | stephenfin | bhagyashris: Thanks for testing this stuff, btw. Really good to have as many eyes on it as possible, as we're seeing :) | |
| 09:47:14 | bhagyashris | stephenfin: If you are OK? then I will take up adding the functional test cases and will fix the existing test that you have added for https://review.opendev.org/#/c/674895/2 | |
| 09:48:07 | stephenfin | bhagyashris: Yes, please. I kept the Author the same on that. I'm going to be working on the previous two patches and adding support for reporting the 'HW_CPU_HYPERTHREADING' trait today | |
| 09:48:58 | bhagyashris | stephenfin: OK then I will take up this task and will upload the patch soon | |
| 10:01:33 | bhagyashris | stephenfin: Thank you :) | |
| 11:40:47 | sean-k-mooney | stephenfin: gibi alex_xu https://review.opendev.org/#/c/621646/23 has been around for a while and it hasnt gotten any core review. i have review this several times at this point, would ye be able to take a look? | |
| 11:48:06 | gibi | sean-k-mooney: I opened it now on a tab but I cannot promies to reach there today | |
| 11:48:42 | sean-k-mooney | gibi: no worries i was pingged to review it yesterday so i did it this morning | |
| 11:49:32 | sean-k-mooney | i just wanted to flag it to some people since it was opened back in december and they have been rebasing it since | |
| 12:03:59 | alex_xu | sean-k-mooney: I added it to my review list, will reach it when I do review work this week | |
| 12:05:04 | sean-k-mooney | alex_xu: cool thanks | |
| 12:07:58 | stephenfin | sean-k-mooney: sure | |
| 12:10:59 | sean-k-mooney | speaking of reveiw where are we at with https://review.opendev.org/#/c/668656/7/specs/train/approved/use-pcpu-vcpu-in-one-instance.rst | |
| 12:11:19 | sean-k-mooney | oh wrong version | |
| 12:11:53 | sean-k-mooney | all the discusstion seams to be on 7 but the patch is on version 11 | |
| 12:14:19 | sean-k-mooney | i think the table for the setting in the image vs flavor is wrong by the way | |
| 12:26:35 | openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for resize with VGPU https://review.opendev.org/675106 | |
| 12:27:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | |
| 12:27:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 12:27:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 12:40:31 | alex_xu | sean-k-mooney: dansmith also has a point about whether we should let the user specific which vcpu is dedicated | |
| 12:43:37 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 12:45:01 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 12:46:18 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to forbidden aggregates https://review.opendev.org/671075 | |
| 12:47:11 | sean-k-mooney | alex_xu: dansmith the reason for being able to define which cpus are dedicated is the same for why we allow it for realtime cpus. we want to be able to say that core x is low performace and can be used for the os/manament interfaces vs core y is high perfomace and can be used for the application | |
| 12:48:03 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter forbidden_aggregates https://review.opendev.org/667952 | |
| 12:48:28 | sean-k-mooney | alex_xu: dansmith: so yes we do need to allow the user to pass a mask in my opipion and i dont think nova should do any magic to try and calualte it. | |
| 12:48:56 | alex_xu | sean-k-mooney: hint by you, if I want the realtime cpu to be dedicated, then I still need a way to define that. | |
| 12:49:03 | sean-k-mooney | if the user has multiple numa nodes and/or a specific cpu toplogy then they shoudl understand that mapping | |
| 12:49:40 | sean-k-mooney | well that is simple. use the same mask for both | |
| 12:49:50 | alex_xu | yea, otherwise, we will have a magic to mapping realtime vcpu to dedicated vcpu inside nova | |
| 12:49:55 | sean-k-mooney | but really i dont think we should allow realtime core to not be dedicated | |
| 12:50:57 | alex_xu | ah, that make sense. but it still will be a magic | |
| 12:51:02 | sean-k-mooney | if you are declaring a core as realtime it does not make sense for it to be multiplex to a shared host core that other vms can execute on as that will violate any realtiem logic | |
| 12:51:21 | sean-k-mooney | well we just and the bitmasks | |
| 12:51:56 | sean-k-mooney | actuuly xor the bits and check the result is 0 | |
| 12:52:30 | sean-k-mooney | actully no that is also wrong | |
| 12:53:05 | sean-k-mooney | but you get the idea we just need to validate each bit set in the realtime mask is set in the dedicated mask | |
| 12:53:19 | alex_xu | yea | |
| 12:53:23 | alex_xu | i got it | |
| 12:55:18 | sean-k-mooney | to dansmith point however i do belive we discusssed the idea of not exposing a mask in the past and instead doing what he say and just having tally counts of how many of each type you want | |
| 12:55:54 | sean-k-mooney | then evenly distubting them over the numa nodes and ensureing within a numa node the shared cpus are first followed by the pinned ones | |
| 12:56:16 | sean-k-mooney | that fits the paradime where core 0 is often reserved for the os | |
| 12:56:53 | sean-k-mooney | and in a multi numa works the first core on each numa node is often reserved for the os | |
| 12:57:17 | sean-k-mooney | but that does seam like magic that would easily break | |
| 13:00:39 | alex_xu | good to know | |
| 13:01:53 | sean-k-mooney | alex_xu: i saw the irc ping for the patch. what tempeted you to work on that | |
| 13:02:23 | sean-k-mooney | also what time zone are you in. i assume its eitehr quite late or very early for you | |
| 13:05:24 | alex_xu | sean-k-mooney: hah | |
| 13:19:53 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 13:23:58 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: docs: clarify nova migration-list --host option https://review.opendev.org/674950 | |
| 13:23:58 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add --migration-type and --source-compute to migration-list https://review.opendev.org/675117 | |
| 13:28:59 | mriedem | lyarwood: as you're probably aware once these land https://review.opendev.org/#/q/I5e0a43ec59341c9ac62f89105ddf82c4a014df81 we'll be doing stable branch releases | |
| 13:29:35 | sean-k-mooney | mriedem: those are the cve backports right | |
| 13:29:40 | mriedem | yes | |
| 13:29:46 | mriedem | dansmith: can you get this this stein backport? https://review.opendev.org/#/c/672723/ | |
| 13:30:09 | mriedem | melwitt: can you get these stein backports for a series you're familiar with https://review.opendev.org/#/q/topic:bug/1764556+(status:open+OR+status:merged)+branch:stable/stein | |
| 13:30:39 | lyarwood | mriedem: ack yup | |
| 13:30:55 | dansmith | mriedem: jes | |
| 13:31:41 | mriedem | thanks | |
| 13:42:44 | mnaser | can i get a second pair of eyes | |
| 13:42:50 | mnaser | i think there is a nova bug here that we uncovered in OSA | |
| 13:42:52 | mnaser | https://logs.opendev.org/33/660333/10/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/97d8bc3/logs/host/nova-compute.service.journal-23-20-40.log.txt.gz#_Aug_06_22_51_25 | |
| 13:42:58 | mnaser | nova-compute magically trying to access db? | |
| 13:43:07 | mnaser | (and raising an exception because of that) | |
| 13:45:44 | yonglihe | ||