| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-07 | |||
| 09:38:05 | bhagyashris | S/tp/to | |
| 09:39:18 | stephenfin | That would require changes to the InstanceNUMATopology object, but like we discussed previously, they don't need to be done yet | |
| 09:40:42 | bhagyashris | stephenfin: if yes then in that case we will also need to take care the first issue that I have mentioned above ... gust xml will give wrong result if user will create the instance using flavor extra specs resources:PCPU=1 | |
| 09:41:46 | stephenfin | Yup. Indeed. That needs to be done regardless. | |
| 09:42:09 | bhagyashris | stephenfin: OK | |
| 09:42:14 | bhagyashris | stephenfin: and one more thing I would like to ask about the translation of flavor extra specs and image meta data .. are you going to use my change https://review.opendev.org/#/c/672223/1 or you are going to continue on your change? | |
| 09:44:11 | stephenfin | I think I'm going to keep going with https://review.opendev.org/#/c/671801/. I don't like the idea of rewriting the flavor behind the users back and this change doesn't require that. I might change my mind again, but I'll go with this for now | |
| 09:45:20 | bhagyashris | stephenfin: OK No problem. | |
| 09:45:52 | stephenfin | bhagyashris: Thanks for testing this stuff, btw. Really good to have as many eyes on it as possible, as we're seeing :) | |
| 09:47:14 | bhagyashris | stephenfin: If you are OK? then I will take up adding the functional test cases and will fix the existing test that you have added for https://review.opendev.org/#/c/674895/2 | |
| 09:48:07 | stephenfin | bhagyashris: Yes, please. I kept the Author the same on that. I'm going to be working on the previous two patches and adding support for reporting the 'HW_CPU_HYPERTHREADING' trait today | |
| 09:48:58 | bhagyashris | stephenfin: OK then I will take up this task and will upload the patch soon | |
| 10:01:33 | bhagyashris | stephenfin: Thank you :) | |
| 11:40:47 | sean-k-mooney | stephenfin: gibi alex_xu https://review.opendev.org/#/c/621646/23 has been around for a while and it hasnt gotten any core review. i have review this several times at this point, would ye be able to take a look? | |
| 11:48:06 | gibi | sean-k-mooney: I opened it now on a tab but I cannot promies to reach there today | |
| 11:48:42 | sean-k-mooney | gibi: no worries i was pingged to review it yesterday so i did it this morning | |
| 11:49:32 | sean-k-mooney | i just wanted to flag it to some people since it was opened back in december and they have been rebasing it since | |
| 12:03:59 | alex_xu | sean-k-mooney: I added it to my review list, will reach it when I do review work this week | |
| 12:05:04 | sean-k-mooney | alex_xu: cool thanks | |
| 12:07:58 | stephenfin | sean-k-mooney: sure | |
| 12:10:59 | sean-k-mooney | speaking of reveiw where are we at with https://review.opendev.org/#/c/668656/7/specs/train/approved/use-pcpu-vcpu-in-one-instance.rst | |
| 12:11:19 | sean-k-mooney | oh wrong version | |
| 12:11:53 | sean-k-mooney | all the discusstion seams to be on 7 but the patch is on version 11 | |
| 12:14:19 | sean-k-mooney | i think the table for the setting in the image vs flavor is wrong by the way | |
| 12:26:35 | openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for resize with VGPU https://review.opendev.org/675106 | |
| 12:27:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | |
| 12:27:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 12:27:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 12:40:31 | alex_xu | sean-k-mooney: dansmith also has a point about whether we should let the user specific which vcpu is dedicated | |
| 12:43:37 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 12:45:01 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 12:46:18 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to forbidden aggregates https://review.opendev.org/671075 | |
| 12:47:11 | sean-k-mooney | alex_xu: dansmith the reason for being able to define which cpus are dedicated is the same for why we allow it for realtime cpus. we want to be able to say that core x is low performace and can be used for the os/manament interfaces vs core y is high perfomace and can be used for the application | |
| 12:48:03 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter forbidden_aggregates https://review.opendev.org/667952 | |
| 12:48:28 | sean-k-mooney | alex_xu: dansmith: so yes we do need to allow the user to pass a mask in my opipion and i dont think nova should do any magic to try and calualte it. | |
| 12:48:56 | alex_xu | sean-k-mooney: hint by you, if I want the realtime cpu to be dedicated, then I still need a way to define that. | |
| 12:49:03 | sean-k-mooney | if the user has multiple numa nodes and/or a specific cpu toplogy then they shoudl understand that mapping | |
| 12:49:40 | sean-k-mooney | well that is simple. use the same mask for both | |
| 12:49:50 | alex_xu | yea, otherwise, we will have a magic to mapping realtime vcpu to dedicated vcpu inside nova | |
| 12:49:55 | sean-k-mooney | but really i dont think we should allow realtime core to not be dedicated | |
| 12:50:57 | alex_xu | ah, that make sense. but it still will be a magic | |
| 12:51:02 | sean-k-mooney | if you are declaring a core as realtime it does not make sense for it to be multiplex to a shared host core that other vms can execute on as that will violate any realtiem logic | |
| 12:51:21 | sean-k-mooney | well we just and the bitmasks | |
| 12:51:56 | sean-k-mooney | actuuly xor the bits and check the result is 0 | |
| 12:52:30 | sean-k-mooney | actully no that is also wrong | |
| 12:53:05 | sean-k-mooney | but you get the idea we just need to validate each bit set in the realtime mask is set in the dedicated mask | |
| 12:53:19 | alex_xu | yea | |
| 12:53:23 | alex_xu | i got it | |
| 12:55:18 | sean-k-mooney | to dansmith point however i do belive we discusssed the idea of not exposing a mask in the past and instead doing what he say and just having tally counts of how many of each type you want | |
| 12:55:54 | sean-k-mooney | then evenly distubting them over the numa nodes and ensureing within a numa node the shared cpus are first followed by the pinned ones | |
| 12:56:16 | sean-k-mooney | that fits the paradime where core 0 is often reserved for the os | |
| 12:56:53 | sean-k-mooney | and in a multi numa works the first core on each numa node is often reserved for the os | |
| 12:57:17 | sean-k-mooney | but that does seam like magic that would easily break | |
| 13:00:39 | alex_xu | good to know | |
| 13:01:53 | sean-k-mooney | alex_xu: i saw the irc ping for the patch. what tempeted you to work on that | |
| 13:02:23 | sean-k-mooney | also what time zone are you in. i assume its eitehr quite late or very early for you | |
| 13:05:24 | alex_xu | sean-k-mooney: hah | |
| 13:19:53 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 13:23:58 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: docs: clarify nova migration-list --host option https://review.opendev.org/674950 | |
| 13:23:58 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add --migration-type and --source-compute to migration-list https://review.opendev.org/675117 | |
| 13:28:59 | mriedem | lyarwood: as you're probably aware once these land https://review.opendev.org/#/q/I5e0a43ec59341c9ac62f89105ddf82c4a014df81 we'll be doing stable branch releases | |
| 13:29:35 | sean-k-mooney | mriedem: those are the cve backports right | |
| 13:29:40 | mriedem | yes | |
| 13:29:46 | mriedem | dansmith: can you get this this stein backport? https://review.opendev.org/#/c/672723/ | |
| 13:30:09 | mriedem | melwitt: can you get these stein backports for a series you're familiar with https://review.opendev.org/#/q/topic:bug/1764556+(status:open+OR+status:merged)+branch:stable/stein | |
| 13:30:39 | lyarwood | mriedem: ack yup | |
| 13:30:55 | dansmith | mriedem: jes | |
| 13:31:41 | mriedem | thanks | |
| 13:42:44 | mnaser | can i get a second pair of eyes | |
| 13:42:50 | mnaser | i think there is a nova bug here that we uncovered in OSA | |
| 13:42:52 | mnaser | https://logs.opendev.org/33/660333/10/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/97d8bc3/logs/host/nova-compute.service.journal-23-20-40.log.txt.gz#_Aug_06_22_51_25 | |
| 13:42:58 | mnaser | nova-compute magically trying to access db? | |
| 13:43:07 | mnaser | (and raising an exception because of that) | |
| 13:45:44 | yonglihe | ||
| 13:47:28 | sean-k-mooney | am i can make time. i saw melwitt had a question when i looked last week about shutdown_unkown. was that resolved | |
| 13:47:37 | mnaser | im trying to do git blame on github and its timing out | |
| 13:47:37 | mnaser | boo | |
| 13:47:44 | mriedem | mnaser: hmm, yeah compute is calling compute.API.stop to stop the instance, which is hitting some code in the compute rpcapi client router to determine the minimum compute version across all cells which it shouldn't need to be doing, b/c you're in a cell | |
| 13:48:18 | mnaser | thats what i figured based on the traceback but i havent done my share of git blame yet to see when this might be started | |
| 13:48:25 | mnaser | https://github.com/openstack/nova/blame/master/nova/compute/manager.py crashes github | |
| 13:48:45 | mriedem | mnaser: https://review.opendev.org/#/c/649197/ | |
| 13:48:56 | sean-k-mooney | mnaser: ya that and the libvirt dirver are two of the files better blamed on the terminal | |
| 13:49:37 | mriedem | i want to say we should be hitting that when compute starts up though, or used to? | |
| 13:49:57 | mriedem | mnaser: do you have the api db configured in nova.conf that you're computes are using? | |
| 13:50:10 | mnaser | mriedem: in this case i believe its an aio so yes it will be there | |
| 13:50:23 | mnaser | in an actual deployment, osa doesnt do this | |
| 13:50:36 | mriedem | even if it's a single node you can run nova-compute with a different config file | |
| 13:50:38 | mriedem | w/o the db creds | |
| 13:50:42 | mriedem | that's what devstack does | |
| 13:50:42 | dansmith | mnaser: is the api db connection set? | |
| 13:50:55 | dansmith | I think that's how it determines if it should use the all-cells or this-cell method | |
| 13:51:14 | mnaser | yeah.. it would be a very 'CI' specific thing if we used 2 different configs, unless we always used 2 configs, but yeah | |
| 13:51:34 | mnaser | if we have to roll out nova-compute.conf and nova.conf -- that's fine, we'll fix that | |
| 13:51:38 | sean-k-mooney | mnaser: well always using two config makes sense in a way | |
| 13:51:40 | dansmith | mnaser: was that aimed at me? | |
| 13:52:01 | sean-k-mooney | it is nice to be able to seperate compute only things for contoler only things | |
| 13:52:05 | mnaser | dansmith: just in general, im wondering if we're doing things wrong (i.e. nova operates with the assumption that api db _should not_ be set in nova-compute) | |
| 13:52:23 | mriedem | i've got to run my kid somewhere, bbiab | |
| 13:52:38 | dansmith | mnaser: the assumption is that computes should not be talking to any db, and thus shouldn't have creds set at all | |
| 13:52:57 | dansmith | mnaser: like, the creds shouldn't even need to be on those systems | |