Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-06
16:29:34 eandersson https://bugs.launchpad.net/nova/+bug/1799309
16:29:34 openstack Launchpad bug 1799309 in OpenStack Compute (nova) "Migration/Resize fails with Unexpected exception in API method: Circular reference detected" [Undecided,New]
16:29:57 eandersson I attached the chat log to that bug report as well.
16:31:00 openstackgerrit Chris Dent proposed openstack/nova master: Add a document that describes profiling eventlet services https://review.opendev.org/674865
16:33:56 cdent eandersson: the placement thing was very specifically about a value being of a bad type
16:34:20 eandersson I see - yea the file referenced no longer exists
16:34:33 cdent mriedem: there's ^ a start at the profiling doc. Probably needs a few iterations (and the usual, oh, chris wrote a thing, see the typos)
16:39:15 mriedem Sundar: you asked for it https://review.opendev.org/#/c/674726/
16:39:25 mriedem cdent: thanks
16:44:17 sean-k-mooney efried: mriedem Sundar: by the way i would be fine with not supporting some operation in addtion to not support live migration but the current patch block way more operation then im comfortable with
16:45:43 sean-k-mooney with no support for snapshots resize/cold-migrate or live migrate there is not way to do upgrades of the node other then an inplace upgrade
16:47:08 mriedem i'm also not cool with the blocker really, at least without a policy rule to control it or something
16:47:30 mriedem if you do it like vgpus, then it's just docs on what works and what doesn't and anything we don't test is considered experimental and you fix it as bugs later
16:48:46 sean-k-mooney mriedem: ya that sound resonable. i am semi ok with 409s for live migratin or something we know upfont wont work
16:49:18 dansmith dear god
16:49:49 dansmith also, are we really adding a flavor property for device profile?
16:49:50 sean-k-mooney it was really blocking interface/volume attach/detach and lock that annoyed me
16:50:01 sean-k-mooney dansmith: its an extra spec
16:50:18 dansmith oh, it's added as a property on flavor, I see
16:50:30 dansmith I don't really like that
16:50:54 sean-k-mooney right but we did that not to need to change the nova apin in the first versions
16:51:15 sean-k-mooney dansmith: but at least your consitent in not liking it every time you see it
16:52:43 sean-k-mooney i think given how long it been waiting we should merge basic integation and consider it experimental. but my version of basic is more then boot, reboot, delete and status.
16:54:30 sean-k-mooney i prefer the docs approch rather then expcit blocker check given that in thory other virt driver will support cyborg at some point so i think doc are better for then api check when they could be virt dirver specifc.
16:57:22 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674876
16:57:25 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Replace non-nova server fault message https://review.opendev.org/674877
17:22:47 openstackgerrit sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072
17:47:58 dansmith mriedem: bauzas: hmm, we still construct reqspec by from_components() huh?
17:49:04 sean-k-mooney dansmith: i think bauzas is on PTO for the next 2-3 weeks
17:49:22 dansmith oh right, because he's in france and today ends in "day"
17:49:25 sean-k-mooney dansmith: but yes i belive we do
17:49:41 dansmith sean-k-mooney: yeah, that was rhetorical to start a bitch-fest :D
17:50:31 sean-k-mooney hehe i thought it was the from_flavor version that everyone hated
17:51:00 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L389-L417
17:51:28 sean-k-mooney oh wait im thinking of somthing else
17:53:26 sean-k-mooney you mean how its built form this blob of stuff https://github.com/openstack/nova/blob/master/nova/compute/api.py#L897
17:54:46 sean-k-mooney dansmith: when are you heading on PTO by the way. are you around this week?
17:55:19 dansmith sean-k-mooney: glad to know that me being gone ALL last week was so unimpactful that you didn't even notice
17:55:25 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
17:55:25 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893
17:55:26 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894
17:55:26 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
17:55:35 dansmith maybe that means I could take another week and nobody would know ;)
17:56:48 sean-k-mooney well i was off since tursday so i dont remember much form last weeks other then i need to relax. no i just noticed you comment that you were going to be off around august 24th in a review
17:57:28 sean-k-mooney maybe that was someone else
17:57:40 dansmith erm, Aug 24 is a saturday, so I do plan to not be around that day, but.. I think maybe you're confusing me with someone else. Which is also super flattering :D
17:59:25 mriedem dansmith: i think i've been working on burning out from_components the last few releases
17:59:38 mriedem like getting resize reschedule to pass the request spec back to conductor so we don't have to build a new one
17:59:49 mriedem some of that compat might be deletable by now too
17:59:52 dansmith okay
18:00:12 mriedem b/c yeah it's been an endless source of bugs
18:00:14 dansmith I can still -1 the cyborg patch for putting all the cyborg interaction inside that method anyway
18:00:24 mriedem "oh we re-constructed it with the wrong stuff huh?"
18:00:34 mriedem well,
18:00:42 mriedem it is used in the api right? and the port resource request stuff is in there
18:01:08 dansmith it is, but we just chuck the port requests into it
18:01:10 stephenfin dansmith: I'm just off home, but could you take a look at this object'y thing at some point this week? https://review.opendev.org/#/c/537414
18:01:17 dansmith we still do the bdm init after we construct it, which is what we should do here
18:01:52 dansmith stephenfin: okay will try
18:02:40 stephenfin ta
18:04:21 sean-k-mooney dansmith: yep apparently i was confusing you with kashyap. sorry, dont i just know how to get on your good side :)
18:04:29 dansmith jesus
18:04:34 dansmith one of us should be highly offended
18:09:56 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
18:09:57 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
18:09:57 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
18:09:58 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
18:09:58 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
18:09:59 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
18:26:36 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893
18:26:59 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894
18:27:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
18:27:29 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
18:39:38 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674906
18:39:39 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: fix unshelve notification test instability https://review.opendev.org/674907
18:39:39 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Replace non-nova server fault message https://review.opendev.org/674908
18:39:43 mriedem fungi: that's it for upstream backports ^
18:40:05 fungi mriedem: awesome, those were the last three i was waiting for. thanks!!!
18:40:10 fungi now to push up the ossa
18:40:10 mriedem np
18:42:06 fungi which is https://review.opendev.org/674909 for the record
18:56:29 melwitt efried: to your earlier question, yes OK with you removing the fixture from the patch to address gibi's -1 to continue work on series
19:21:58 openstackgerrit melanie witt proposed openstack/nova stable/rocky: Add 'path' query parameter to console access url https://review.opendev.org/674916
19:25:41 melwitt KeithMnemonic, fungi, mriedem: I'm not clear on why backporting the needed fix for esx in upstream noVNC isn't an option, so in case it is helpful, here is a proposed rocky backport of the nova change with conflicts documented ^
19:27:45 sean-k-mooney melwitt: i dont think it explcitly not an option. its just novnc 1.1 did not exsit when rocky was developed and we typically dont add support for things after the fact but in this case its trivial
19:27:58 KeithMnemonic melwitt: thanks! i found the fix for noVNC 1.0 to get it to work. do they except patches on older versions still?
19:31:24 melwitt KeithMnemonic: I don't know, sorry. I mention it based on the earlier discussion in the channel. I don't if they handle fixes for stable/older releases in the same way we do
19:33:09 KeithMnemonic i have several options. let me see which one is least painful ;-)
19:38:46 mriedem efried: https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-migration-list is missing some filter options (migration_type and source_compute) - need a blueprint for novaclient change to add those?
19:39:16 mriedem looks like we do have blueprints for novaclient to actually track stuff... https://blueprints.launchpad.net/python-novaclient
19:39:27 mriedem this is related to what spatel is trying to di in -placement
19:39:52 mriedem and eventually something i'd use to write a troubleshooting guide for manually recovering from https://bugs.launchpad.net/nova/+bug/1829479
19:39:52 openstack Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged]
19:43:52 melwitt doesn't look promising, I don't see anything that looks like stable branches other than an old branch for v0.6 last updated 3 years ago https://github.com/novnc/noVNC
19:44:58 KeithMnemonic it is literally 3 lines of code so it might be easier for us to carry it locally
19:45:19 KeithMnemonic it was pretty simple to fix once i got looking in the right place
19:45:31 melwitt oh, I see
19:48:24 melwitt well, I think I'm in support of the nova rocky backport given there seems to be no other way to have esx hypervisors consoles work out-of-the-box. though that also comes with caveat of the fact that I'm guessing for rocky noVNC v1.1.0 isn't what's installed out-of-the-box
19:48:50 efried mriedem: you tell me, do we usually require a blueprint for novaclient parity?
19:48:53 melwitt so people would have to know that they need v1.1.0 and install it

Earlier   Later