| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-06 | |||
| 18:00:34 | mriedem | well, | |
| 18:00:42 | mriedem | it is used in the api right? and the port resource request stuff is in there | |
| 18:01:08 | dansmith | it is, but we just chuck the port requests into it | |
| 18:01:10 | stephenfin | dansmith: I'm just off home, but could you take a look at this object'y thing at some point this week? https://review.opendev.org/#/c/537414 | |
| 18:01:17 | dansmith | we still do the bdm init after we construct it, which is what we should do here | |
| 18:01:52 | dansmith | stephenfin: okay will try | |
| 18:02:40 | stephenfin | ta | |
| 18:04:21 | sean-k-mooney | dansmith: yep apparently i was confusing you with kashyap. sorry, dont i just know how to get on your good side :) | |
| 18:04:29 | dansmith | jesus | |
| 18:04:34 | dansmith | one of us should be highly offended | |
| 18:09:56 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | |
| 18:09:57 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | |
| 18:09:57 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | |
| 18:09:58 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | |
| 18:09:58 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | |
| 18:09:59 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | |
| 18:26:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893 | |
| 18:26:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | |
| 18:27:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 18:27:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 18:39:38 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674906 | |
| 18:39:39 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: fix unshelve notification test instability https://review.opendev.org/674907 | |
| 18:39:39 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Replace non-nova server fault message https://review.opendev.org/674908 | |
| 18:39:43 | mriedem | fungi: that's it for upstream backports ^ | |
| 18:40:05 | fungi | mriedem: awesome, those were the last three i was waiting for. thanks!!! | |
| 18:40:10 | fungi | now to push up the ossa | |
| 18:40:10 | mriedem | np | |
| 18:42:06 | fungi | which is https://review.opendev.org/674909 for the record | |
| 18:56:29 | melwitt | efried: to your earlier question, yes OK with you removing the fixture from the patch to address gibi's -1 to continue work on series | |
| 19:21:58 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Add 'path' query parameter to console access url https://review.opendev.org/674916 | |
| 19:25:41 | melwitt | KeithMnemonic, fungi, mriedem: I'm not clear on why backporting the needed fix for esx in upstream noVNC isn't an option, so in case it is helpful, here is a proposed rocky backport of the nova change with conflicts documented ^ | |
| 19:27:45 | sean-k-mooney | melwitt: i dont think it explcitly not an option. its just novnc 1.1 did not exsit when rocky was developed and we typically dont add support for things after the fact but in this case its trivial | |
| 19:27:58 | KeithMnemonic | melwitt: thanks! i found the fix for noVNC 1.0 to get it to work. do they except patches on older versions still? | |
| 19:31:24 | melwitt | KeithMnemonic: I don't know, sorry. I mention it based on the earlier discussion in the channel. I don't if they handle fixes for stable/older releases in the same way we do | |
| 19:33:09 | KeithMnemonic | i have several options. let me see which one is least painful ;-) | |
| 19:38:46 | mriedem | efried: https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-migration-list is missing some filter options (migration_type and source_compute) - need a blueprint for novaclient change to add those? | |
| 19:39:16 | mriedem | looks like we do have blueprints for novaclient to actually track stuff... https://blueprints.launchpad.net/python-novaclient | |
| 19:39:27 | mriedem | this is related to what spatel is trying to di in -placement | |
| 19:39:52 | mriedem | and eventually something i'd use to write a troubleshooting guide for manually recovering from https://bugs.launchpad.net/nova/+bug/1829479 | |
| 19:39:52 | openstack | Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] | |
| 19:43:52 | melwitt | doesn't look promising, I don't see anything that looks like stable branches other than an old branch for v0.6 last updated 3 years ago https://github.com/novnc/noVNC | |
| 19:44:58 | KeithMnemonic | it is literally 3 lines of code so it might be easier for us to carry it locally | |
| 19:45:19 | KeithMnemonic | it was pretty simple to fix once i got looking in the right place | |
| 19:45:31 | melwitt | oh, I see | |
| 19:48:24 | melwitt | well, I think I'm in support of the nova rocky backport given there seems to be no other way to have esx hypervisors consoles work out-of-the-box. though that also comes with caveat of the fact that I'm guessing for rocky noVNC v1.1.0 isn't what's installed out-of-the-box | |
| 19:48:50 | efried | mriedem: you tell me, do we usually require a blueprint for novaclient parity? | |
| 19:48:53 | melwitt | so people would have to know that they need v1.1.0 and install it | |
| 19:51:01 | mriedem | efried: most blueprints in novaclient these days are tied to nova blueprints for microversion parity, | |
| 19:51:17 | mriedem | i think a standalone feature in novaclient should probably use a blueprint for tracking yeah, | |
| 19:51:33 | mriedem | but don't necessarily think it should fall under spec freeze or anything since it's not on the same release schedule | |
| 19:51:51 | efried | mriedem: specless? | |
| 19:52:13 | mriedem | yes, we don't need specs for novaclient blueprints :) | |
| 19:52:13 | efried | Seems like you could fit the necessary into a bp description. | |
| 19:52:14 | mriedem | https://blueprints.launchpad.net/python-novaclient/+spec/more-migration-list-filters | |
| 19:52:17 | mriedem | i did | |
| 19:52:42 | mriedem | if people want i'll just throw it under open discussion for thursday's meeting | |
| 19:52:48 | efried | wfm | |
| 19:52:59 | efried | should at least do that as a formality. | |
| 19:53:54 | mriedem | ack | |
| 19:54:02 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | |
| 19:54:02 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | |
| 19:54:03 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | |
| 19:54:03 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | |
| 19:54:04 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | |
| 19:54:04 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | |
| 19:55:03 | KeithMnemonic | melwitt: that would be great to have it ported, if that does not fly, i can share the patch to noVNC 1.0 if we need to document or something | |
| 19:58:23 | melwitt | KeithMnemonic: ack. feels like either way, we need to add a note on our consoles docs https://docs.openstack.org/nova/latest/admin/remote-console-access.html that calls out the issue for esx hypervisors and instructions on what to do. I would need your help to know what to write there as far as explaining what/how it is broken for esx | |
| 20:03:23 | KeithMnemonic | ok so lets try for the backport and then the note just mentions needing 1.1? and if that does not work we add the steps to fix with 1.0? does that seem reasonable | |
| 20:05:42 | melwitt | KeithMnemonic: right. my thought: I'd like to have the doc have a note about esx hypervisors and explain what is broken in < v1.1.0 and then instruction will be "install v1.1.0" if the backport succeeds, else "apply this patch" and maybe we could host it either our repo or one of the ops-oriented repos and link to it from the doc | |
| 20:06:38 | KeithMnemonic | ok so here was the issue, https://github.com/novnc/websockify/issues/402 i originally thought it was the websockify piece since it was just disconnecing | |
| 20:06:45 | KeithMnemonic | i can update the issue or try and move it | |
| 20:07:20 | KeithMnemonic | melwitt: this is the issue here "rfb.js:685 Failed while connected: Unsupported encoding (encoding: -260)" | |
| 20:07:34 | KeithMnemonic | so the older 1.0 does not handle encoding "-260" correctly | |
| 20:07:36 | KeithMnemonic | 1.1 does | |
| 20:07:38 | melwitt | ah, perfect, yeah we could just link to that issue for explaining the problem | |
| 20:08:05 | KeithMnemonic | should i move it under novnc? or close and reopen a new one ? | |
| 20:08:55 | KeithMnemonic | i dont think i can move it | |
| 20:09:06 | melwitt | oh, it's under the wrong component (I didn't understand that :P). yeah, I dunno, if it's possible to move it then that makes sense to me | |
| 20:09:07 | KeithMnemonic | so i could close and reopen under novnc/novnc | |
| 20:09:19 | KeithMnemonic | simple enough to close and reopen | |
| 20:10:07 | melwitt | yeah, might be worth doing for the sake of avoiding confusion | |
| 20:10:46 | openstackgerrit | Merged openstack/nova master: Add functional test for resize crash compute restart revert https://review.opendev.org/670393 | |
| 20:12:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert HostMapping.cells to a dict https://review.opendev.org/663387 | |
| 20:12:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388 | |
| 20:13:11 | melwitt | the noVNC people were responsive back when I proposed this nak'd pull request :P https://github.com/novnc/noVNC/pull/1220 | |
| 20:14:25 | melwitt | so there's a chance they'll add some comments on the issue, that would be cool | |
| 20:14:38 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext https://review.opendev.org/674138 | |
| 20:14:39 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement https://review.opendev.org/674129 | |
| 20:14:52 | efried | what a waste of a ci run | |
| 20:23:24 | KeithMnemonic | melwitt: here you go https://github.com/novnc/noVNC/issues/1273 | |
| 20:24:38 | melwitt | KeithMnemonic: woot thanks | |
| 20:24:53 | KeithMnemonic | that describes the issue and fix if needed | |
| 20:25:05 | KeithMnemonic | it was not exahaustively tested ;-) | |
| 20:25:31 | KeithMnemonic | but i could get to cirros and type commands! | |
| 20:25:44 | melwitt | what else do ya need? | |
| 20:26:47 | KeithMnemonic | melwitt: I did not try anything with X for example. I am all set .I will watch the backport progress. If you need anything else from me please let me know. Thanks again | |
| 20:28:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388 | |
| 20:28:13 | melwitt | KeithMnemonic: understood. I was trying to be funny, like what else do you need except cirros :P sounds good, thanks. I'll propose a patch for the console docs | |
| 20:28:26 | KeithMnemonic | ah, sorry was too serious today | |
| 20:28:34 | KeithMnemonic | lol | |