Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-05
17:57:52 efried because then you would have to be able to say which ones are P/V and which of those are from which NUMA node
17:58:06 efried but we could add pinset syntax support at that point?? Not sure.
17:59:56 dansmith that's what I just said above... if you really want your dedicated cpus to specifically be somewhere
17:59:58 dansmith but still
18:00:17 dansmith if you want to arrange your DIMMs in a specific order, maybe you want real hardware
18:01:00 dansmith honestly, I dunno what to say about this one for SFE
18:01:55 dansmith I've seen a couple patches in his code for this,
18:02:05 dansmith and it reports PCPUs to placement as inventory
18:02:12 mriedem traditionally, for both of these specs, if we're past spec freeze and it's not clear on either, and we're 5 weeks from feature freeze, i'd say there is no point in granting an exception for Train
18:02:21 dansmith I assume that if you put resources:PCPU=1 in a flavor, it'll break everything
18:02:35 mriedem if the goal is to just approve the specs to make life easier for re-approvals in U, then i guess....but i don't see either of these making Train
18:04:53 openstackgerrit Adam Spiers proposed openstack/nova master: Don't claim that CLI user data requires manual base64 encoding https://review.opendev.org/674665
18:06:50 openstackgerrit Adam Spiers proposed openstack/nova master: Don't claim that CLI user data requires manual base64 encoding https://review.opendev.org/674665
18:09:03 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: fix physets typo https://review.opendev.org/674667
18:11:28 aspiers kashyap: are you still working on https://review.opendev.org/#/c/673790/ ?
18:11:38 aspiers kashyap: because it's definitely broken :)
18:11:55 aspiers if you've already gone I guess I'll try to fix it when I have time
18:18:27 aspiers kashyap: well, reviewed anyway
18:23:53 kashyap aspiers: Yes, it's still broken :-)
18:24:03 kashyap aspiers: Ah, you reviewed, will look :-)
18:24:14 aspiers kashyap: I didn't see any tests in there
18:24:20 kashyap Thanks! And hehe, you were too polite in saying tests were "missing"
18:24:22 aspiers kashyap: did you forget to git add?
18:24:35 aspiers or it's just WIP
18:24:38 kashyap aspiers: I was first getting the parsing right. The tests are only half-done, and I'm ill :-(
18:24:47 aspiers oh sorry to hear that :-(((
18:25:01 aspiers well, I think I've pointed out the parsing issues
18:25:02 kashyap (Before I need to board a flight early tomm. The 4 hours kayaking yesterday)
18:25:05 aspiers or maybe I misunderstood
18:25:08 aspiers ugh
18:25:16 kashyap That's what happens if you're an "indoors enthusiast" and go do sportsy things :D
18:26:20 kashyap aspiers: It's WIP. It will remain dormant until I get back I think. As nobody else has interest in this area, besides you :D
18:26:51 aspiers kashyap: well, when you've finished making changes, push everything you have, mark as WIP, and maybe I can fix it while you're away
18:27:06 aspiers kashyap: include the half-done tests so I don't have to start them from scratch
18:27:54 kashyap aspiers: Yeah, first need to go run an errand, will push it from here or tomm from the aiport...
18:28:02 kashyap Thanks for the help and review, much appreciated!
18:28:51 aspiers sure
18:29:02 aspiers get well soon and have a great vacation!
19:12:27 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678
19:13:57 efried mriedem: ^ and dep ought to get rid of those warnings you mentioned earlier https://logs.opendev.org/57/666857/6/check/nova-live-migration/a379339/logs/screen-n-cpu.txt.gz#_Aug_01_21_21_25_517957
19:29:59 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Test blank sdk placement proxy https://review.opendev.org/674625
19:31:09 efried mordred: Slight adjustment gets back to the previous behavior (but is even more hacky) ^
19:31:30 efried sdk isn't running nova tests, is it? Cause we would have a chicken/egg there.
19:49:17 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790
19:49:17 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Introduce libvirt/QEMU version constants for Secure Boot https://review.opendev.org/674657
20:33:04 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
21:15:02 mordred efried: I stepped afk for a minute and had an idea of what I should do WRT the fixture we're talking about ...
21:15:40 efried oh, good, cause my latest attempt worked (passed tests) but failed miserably (bypassed the bit that was supposed to make the warnings go away) :(
21:15:43 mordred efried: so, hopefully i'll have something non-hacky for you to look at tomorrow
21:15:52 mordred efried: HAHAHAHA.
21:15:59 efried laugh it up fuzzball.
21:16:06 mordred I mean, that's not funny - but it's also funny - so, yeah - let's fix it properly
21:16:26 mordred (also, I think it'll remove some boilerplate in the sdk tests - so win/win all around)
21:16:32 efried nice.
21:16:46 efried Okay, I'll quit hacking at https://review.opendev.org/#/c/674625/ for the moment then.
21:16:50 efried thanks mordred
21:19:00 mordred efried: hopefully I'm not completely high :)
21:19:31 efried mordred: Whatever you do will be better than what I was about to have to do in nova.
21:19:41 efried mordred: which was basically mock a proxy object by hand
21:20:01 mordred efried: yeah. let's not do that - there's WAY too much magic under the scenes
21:20:03 mordred :)
21:20:08 efried totally
21:26:45 efried melwitt, mriedem, sean-k-mooney: Any idea why this [1] needs its own RequestContext, instead of reusing the one from the req.environ [2] which is just a couple hops up the call stack?
21:26:45 efried [1] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L70
21:26:45 efried [2] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L80
21:28:25 efried I guess it's because it needs to change the proj/user. Can we use temporary_mutation for that?
21:29:59 mriedem probably. why does it matter? this is a deprecated api as far as i know.
21:30:48 melwitt efried: mriedem or sean-k-mooney would know better than I, but my guess is the user_id needs to be ignored for that call (maybe neutron would otherwise return only networks owned by the project + user combo). I dunno about temporary mutation to do it, sounds like that would probably work
21:31:34 efried mriedem: I'm just trying to hunt down all places where we create a RequestContext and either collapse them or make sure they get the proper global_request_id from whatever invoked them.
22:11:59 openstackgerrit Merged openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553
22:11:59 openstack bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172
22:33:15 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext https://review.opendev.org/674138
22:33:15 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement https://review.opendev.org/674129
22:34:54 efried melwitt, mriedem: Okay, so I reordered the stack and tried to make nova's RequestContext always dtrt - i.e. a) always set a reasonable global_request_id and b) overwrite threadlocal context always and only when appropriate.
22:41:42 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
#openstack-nova - 2019-08-06
00:39:56 eandersson What populates the placement aggregates hosts?
00:40:19 eandersson We have some hosts that are not showing up under aggregates in placement.
00:45:32 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Add delete_on_termination to volume-attach API https://review.opendev.org/673485
02:04:29 openstackgerrit Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
02:58:01 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
02:58:02 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
02:58:02 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
02:58:03 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
02:58:03 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
02:58:04 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
02:58:05 dustinc mriedem, efried: so that is a quick PoC to lazy-initialize the SDK connection. I think the implementation needs a bit more thought but wanted to push up something to try it out and get more feedback. Let me know what you think....
05:34:44 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
05:34:44 openstackgerrit Sundar Nadathur proposed openstack/nova master: Refactor some methods for reuse by Cyborg-related code. https://review.opendev.org/673734
05:34:45 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
05:34:45 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244
05:34:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245
05:34:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
05:34:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
08:02:59 openstackgerrit Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190
08:13:22 openstackgerrit ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407
08:53:28 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
09:02:38 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
09:02:38 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Testing I41b7c1653c6a887ee4b08e588c5d422409aebfba with grenade https://review.opendev.org/674760
09:03:19 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:05:56 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990

Earlier   Later