Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-05
21:20:03 mordred :)
21:20:08 efried totally
21:26:45 efried melwitt, mriedem, sean-k-mooney: Any idea why this [1] needs its own RequestContext, instead of reusing the one from the req.environ [2] which is just a couple hops up the call stack?
21:26:45 efried [1] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L70
21:26:45 efried [2] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L80
21:28:25 efried I guess it's because it needs to change the proj/user. Can we use temporary_mutation for that?
21:29:59 mriedem probably. why does it matter? this is a deprecated api as far as i know.
21:30:48 melwitt efried: mriedem or sean-k-mooney would know better than I, but my guess is the user_id needs to be ignored for that call (maybe neutron would otherwise return only networks owned by the project + user combo). I dunno about temporary mutation to do it, sounds like that would probably work
21:31:34 efried mriedem: I'm just trying to hunt down all places where we create a RequestContext and either collapse them or make sure they get the proper global_request_id from whatever invoked them.
22:11:59 openstackgerrit Merged openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553
22:11:59 openstack bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172
22:33:15 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext https://review.opendev.org/674138
22:33:15 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement https://review.opendev.org/674129
22:34:54 efried melwitt, mriedem: Okay, so I reordered the stack and tried to make nova's RequestContext always dtrt - i.e. a) always set a reasonable global_request_id and b) overwrite threadlocal context always and only when appropriate.
22:41:42 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
#openstack-nova - 2019-08-06
00:39:56 eandersson What populates the placement aggregates hosts?
00:40:19 eandersson We have some hosts that are not showing up under aggregates in placement.
00:45:32 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Add delete_on_termination to volume-attach API https://review.opendev.org/673485
02:04:29 openstackgerrit Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
02:58:01 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
02:58:02 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
02:58:02 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
02:58:03 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
02:58:03 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
02:58:04 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
02:58:05 dustinc mriedem, efried: so that is a quick PoC to lazy-initialize the SDK connection. I think the implementation needs a bit more thought but wanted to push up something to try it out and get more feedback. Let me know what you think....
05:34:44 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
05:34:44 openstackgerrit Sundar Nadathur proposed openstack/nova master: Refactor some methods for reuse by Cyborg-related code. https://review.opendev.org/673734
05:34:45 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
05:34:45 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244
05:34:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245
05:34:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
05:34:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
08:02:59 openstackgerrit Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190
08:13:22 openstackgerrit ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407
08:53:28 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
09:02:38 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
09:02:38 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Testing I41b7c1653c6a887ee4b08e588c5d422409aebfba with grenade https://review.opendev.org/674760
09:03:19 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:05:56 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:29:31 stephenfin gmann: Could you take a look at https://review.opendev.org/#/c/672805/ this week so we can get https://review.opendev.org/#/c/672800/ merged ?
09:36:30 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
09:53:46 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789
09:53:47 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790
09:53:47 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414
09:53:48 openstackgerrit Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791
09:53:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792
09:53:49 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
09:53:49 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795
09:53:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797
09:53:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798
09:53:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799
09:53:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565
09:53:52 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336
09:53:52 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
09:53:53 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
09:53:53 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396
09:53:54 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
09:53:54 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
09:53:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
09:59:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Poison context usage in periodic tasks https://review.opendev.org/542891
10:32:55 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Remove redundant group host setup https://review.opendev.org/674770
11:04:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792
11:04:07 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
11:04:08 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795
11:04:08 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797
11:04:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798
11:04:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799
11:04:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565
11:04:10 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336
11:04:11 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
11:04:11 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
11:04:12 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396
11:04:12 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
11:04:13 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
11:04:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
11:22:57 openstackgerrit Merged openstack/nova master: Add nova-osprofiler-redis job to experimental queue https://review.opendev.org/674326
11:23:06 openstackgerrit Merged openstack/nova master: doc: fix physets typo https://review.opendev.org/674667
12:01:28 openstackgerrit Alex Xu proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices https://review.opendev.org/670782
12:01:28 openstackgerrit Alex Xu proposed openstack/nova master: Moves the allocation retrieving early https://review.opendev.org/670783
12:01:29 openstackgerrit Alex Xu proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker https://review.opendev.org/670784
12:01:29 openstackgerrit Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388
12:01:30 openstackgerrit Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787
12:01:30 openstackgerrit Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222
12:01:31 openstackgerrit Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398
12:05:02 openstackgerrit Artom Lifshitz proposed openstack/nova stable/stein: Add glanceclient method call debug log https://review.opendev.org/674791
12:11:52 sean-k-mooney efried: have you seen https://review.opendev.org/#/c/674726/1 that would be a hard blocker on cyborg integration proceeding in this cylce if the only instance action that work are basically spawn and delete instance
12:14:26 sean-k-mooney not supporting live migration in v1 is resonable but i think everything else shoudl be supported IMO or its not ready to be integrated.
12:17:41 cdent tssurya: are you still working on https://review.opendev.org/623558 ? I've been doing some profiling in the scheduler and it's definitely clear that multiple-queries to the db is problematic and that stacks approach would be better
12:19:54 tssurya cdent: feel free to update the patch and work on it
12:20:21 tssurya I am not working on it atm
12:20:36 cdent okay. I'm not sure if I will have time or not, but I'll see if I can use it as a starting point
12:21:01 tssurya I guess that patch had that typo https://review.opendev.org/#/c/623558/2/nova/scheduler/host_manager.py@892 which made it a bit wobly
12:21:11 tssurya cdent: thanks :)
12:21:36 cdent :)
12:21:59 sean-k-mooney jangutter: stephenfin thanks for reviewing https://review.opendev.org/#/c/672834/2 ill adress the nits and respin it after lunch
12:22:58 jangutter sean-k-mooney: I was thinking about it afterwards: have you seen bridges pop up with ageing_time != 300 ?
12:25:25 openstackgerrit Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388
12:25:26 openstackgerrit Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787
12:25:26 openstackgerrit Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222

Earlier   Later