Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-09
19:39:51 mriedem ah yeah
19:39:51 mriedem @mock.patch.object(fakelibvirt.Connection, 'getVersion')
19:39:51 mriedem @mock.patch.object(fakelibvirt.Connection, 'getLibVersion')
19:40:01 mriedem but that doesn't mock out conn = self.get_connection()
19:50:35 sean-k-mooney ya i have seen the same
19:51:57 sean-k-mooney i ws just checking it before i pip out to the shops to get dinner but i was thinking maybe we could run the test in two batchs
19:52:33 sean-k-mooney run the funtional test only first then unit tests only then have coverage combine the combine the two into one set of results
19:54:41 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: remove unused Service.get_by_compute_host mocks https://review.opendev.org/669934
20:01:06 mriedem sean-k-mooney: huh https://github.com/nedbat/coveragepy/blob/6b72dcbd98c69a7e8c5333d2926c7f871161db7e/coverage/collector.py#L115
20:01:09 mriedem the docs are really not clear about that
20:04:20 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: coverage job changes https://review.opendev.org/669912
20:06:28 mriedem efried: can you re-approve https://review.opendev.org/#/c/666042/ since i just had to rebase and fix the pep8 thing due to the newly enforced hacking rules
20:06:58 efried ...
20:08:22 efried done
20:10:28 mriedem thanks
21:05:37 mriedem dansmith: you might have an opinion on this https://review.opendev.org/#/c/669545/
21:07:42 dansmith hrm
21:07:57 dansmith I hate to add a traceback, but probably makes sense in the diaper case
21:08:22 dansmith is there a bug filed that shows what the actual issue was?
21:08:34 dansmith because we should definitely not take that path and log a traceback fro anything we can handle
21:09:09 mriedem no bug as far as i know
21:09:30 mriedem looks like something with nova - or some python-*client downstream - trying to get a response.status_code
21:09:34 mriedem and response is None
21:09:49 mriedem i thought of you b/c of the change i linked in there
21:12:41 dansmith yeah, and that case makes sense to not dump stack I think
21:12:54 dansmith but if we're not handling it, dumping is the right thing to do I think
21:13:16 dansmith point is, I think we should make sure we've fixed the problem that this would be dumping stack for
21:13:23 dansmith in addition to dumping stack for the future
21:14:11 mriedem if you're +2 i'll follow your lead
21:14:18 mriedem into the bowels of hell
21:15:28 dansmith commented
21:26:52 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: Replace a wiki link with API ref guide link https://review.opendev.org/669027
21:28:20 openstackgerrit Eric Fried proposed openstack/nova master: Perf: Use dicts for ProviderTree roots https://review.opendev.org/637225
21:28:55 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add a guide to add a new microversion support https://review.opendev.org/667002
21:36:17 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: Add links to novaclient contributor guide https://review.opendev.org/669028
22:39:05 efried dustinc: Bottom SDK patch is in merge conflict, not sure when that happened. I'm going to rebase it and the placement patch and leave the ironic series to you, mkay?
22:39:48 dustinc Yeah I have it taken care of in local branch, will push it this week
22:40:13 dustinc Thanks for heads up
22:40:42 openstackgerrit Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664
22:40:42 openstackgerrit Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023
22:44:31 efried dustinc: ^
22:44:31 efried be careful not to regress to a previous commit, then. You should pull the bottom patch and rebase your series onto it.
22:45:57 dustinc efried: hmm ok, yeah I had already rebased and resolved that conflict locally so will have to figure that out before I push then
22:46:11 efried right. lmk if you need help.
22:49:17 openstackgerrit Merged openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042
22:49:38 openstackgerrit Merged openstack/nova master: libvirt: remove unused Service.get_by_compute_host mocks https://review.opendev.org/669934
23:23:34 openstackgerrit Merged openstack/nova master: doc: Replace a wiki link with API ref guide link https://review.opendev.org/669027
23:56:05 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Deprecate cells v1 and extension commands and APIs https://review.opendev.org/669597
#openstack-nova - 2019-07-10
00:04:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200
00:59:39 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958
01:01:31 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958
01:20:07 openstackgerrit Merged openstack/python-novaclient master: Add irrelevant files in dsvm job again https://review.opendev.org/668293
01:27:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
01:27:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
01:27:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
01:27:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
01:27:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
01:27:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
01:27:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
01:27:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
01:27:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
01:27:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
01:27:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
01:27:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
01:27:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
01:27:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
01:27:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
01:27:48 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
02:23:46 openstackgerrit Luyao Zhong proposed openstack/nova-specs master: update spec: virtual persistent memory https://review.opendev.org/669970
02:38:00 openstackgerrit Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
02:42:10 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
03:36:06 openstackgerrit Li Liu proposed openstack/nova master: Added Cyborg accelerator external events to Nova https://review.opendev.org/669975
05:00:30 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548
06:05:48 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
06:27:28 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244
06:27:28 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245
07:03:10 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
07:05:38 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952
07:18:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/669993
07:38:57 openstackgerrit Alexandre arents proposed openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000
08:09:22 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912
08:09:22 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
08:19:04 alex_xu bauzas: do we have a short race window between allocate the gpu mdev and create the domain in the libvirt https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 ?
08:19:34 alex_xu bauzas: I'm reviewing the vpmem patches, and thinking of where we should allocate the actual device
08:21:09 bauzas alex_xu: AFAIK nope, because we already synchronize https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1865
08:22:07 bauzas it calls https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1873 which eventually calls spawn() https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2251
08:22:18 alex_xu bauzas: that is for avoid mulitple action for a singple instance, but if there are multiple instances are creating at same time
08:24:10 bauzas mmmm you're right
08:24:29 alex_xu bauzas: it is only protected by https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6415
08:24:52 bauzas yup indeed
08:25:24 alex_xu bauzas: but there still have a small window between https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3241
08:26:08 bauzas alex_xu: sure but we only assigned the mdev in the synchronized method
08:26:16 bauzas then we only define the XML
08:26:29 bauzas so two instances would have different mdevs

Earlier   Later