Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-10
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
01:27:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
01:27:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
01:27:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
01:27:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
01:27:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
01:27:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
01:27:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
01:27:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
01:27:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
01:27:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
01:27:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
01:27:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
01:27:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
01:27:48 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
02:23:46 openstackgerrit Luyao Zhong proposed openstack/nova-specs master: update spec: virtual persistent memory https://review.opendev.org/669970
02:38:00 openstackgerrit Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
02:42:10 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
03:36:06 openstackgerrit Li Liu proposed openstack/nova master: Added Cyborg accelerator external events to Nova https://review.opendev.org/669975
05:00:30 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548
06:05:48 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
06:27:28 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244
06:27:28 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245
07:03:10 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
07:05:38 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952
07:18:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/669993
07:38:57 openstackgerrit Alexandre arents proposed openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000
08:09:22 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912
08:09:22 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
08:19:04 alex_xu bauzas: do we have a short race window between allocate the gpu mdev and create the domain in the libvirt https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 ?
08:19:34 alex_xu bauzas: I'm reviewing the vpmem patches, and thinking of where we should allocate the actual device
08:21:09 bauzas alex_xu: AFAIK nope, because we already synchronize https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1865
08:22:07 bauzas it calls https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1873 which eventually calls spawn() https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2251
08:22:18 alex_xu bauzas: that is for avoid mulitple action for a singple instance, but if there are multiple instances are creating at same time
08:24:10 bauzas mmmm you're right
08:24:29 alex_xu bauzas: it is only protected by https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6415
08:24:52 bauzas yup indeed
08:25:24 alex_xu bauzas: but there still have a small window between https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3241
08:26:08 bauzas alex_xu: sure but we only assigned the mdev in the synchronized method
08:26:16 bauzas then we only define the XML
08:26:29 bauzas so two instances would have different mdevs
08:26:41 bauzas two concurrent*
08:28:00 alex_xu bauzas: but the available device is calculated by all - free, the assigned device is get by list all the libvirt domain
08:28:36 alex_xu so both two instances get the available devices by listing existed domain in the libvirt, and may get the same dev
08:29:09 alex_xu bauzas: here is the code for populate the mdev devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6306
08:29:30 alex_xu s/all - free/all - assigned/
08:29:41 bauzas alex_xu: oh shit you're right
08:30:05 bauzas given we're defining the XML out of that semaphore, the assigned mdev couldn't be seen concurrently
08:30:18 bauzas excellent point
08:30:29 bauzas alex_xu: worth shouting a patch ? or want me to do so ?
08:30:58 alex_xu bauzas: you can fix that if you want, actually I'm looking for a solution for pmem
08:31:14 alex_xu bauzas: also do we support resize for the instance with vgpu?
08:32:01 bauzas alex_xu: I'm working on it
08:32:07 bauzas alex_xu: I have a patch up
08:32:18 bauzas but I need to work on revert_resize too
08:32:20 alex_xu bauzas: where are you claim the mdev?
08:33:08 bauzas alex_xu: first, something is missing https://review.opendev.org/#/c/589085/
08:34:04 alex_xu bauzas: that doesn't include the mdev claim
08:34:25 alex_xu so I'm thinking whether we should manage those device in the resource tracker instead of virt driver
08:34:39 alex_xu s/manage those device/tracking those resource/
08:36:52 bauzas sorry in meeting
08:37:18 alex_xu bauzas: no worries, catch up you later
09:07:29 bauzas alex_xu: I'm back
09:08:27 bauzas alex_xu: so, we don't technically claim mdevs
09:08:43 bauzas alex_xu: as we do with PCI devices
09:08:47 openstackgerrit huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016
09:18:49 openstackgerrit huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016
09:35:30 openstackgerrit Merged openstack/nova master: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/669993
09:44:00 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549
09:58:03 alex_xu bauzas: yes, mdevs needn't claim, you can free to choice any one of free mdevs
09:59:50 alex_xu bauzas: vpmem needs the claim, since we need to copy the vpmem data to the destination vpmem
10:08:55 openstackgerrit Qiu Fossen proposed openstack/nova master: Correct project/user id descriptions with nova-server-actions https://review.opendev.org/670027
11:36:55 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Add conf to not update to placement during instance_claim https://review.opendev.org/670041
11:59:57 openstackgerrit huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016
12:48:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796
13:26:34 openstackgerrit Eric Fried proposed openstack/nova master: Make sure update resource usage when revert_resize https://review.opendev.org/665138
13:49:45 sean-k-mooney mriedem: mind if i push a slightly modified version of your coverage patch
13:49:55 sean-k-mooney i have a version that mostly works
13:50:40 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670064
13:50:51 sean-k-mooney we only get an extra 2% form the functional test by the way
13:50:54 sean-k-mooney TOTAL 82128 5924 24452 2240 91%
13:51:31 yonglihe sean-k-mooney, thanks for the review. For a instance is deleted, checking the states is not reliable at least for test case it's not correct. The instance.Destroy action call DB delete, which then make the instance.id attr gone. Instance.id not exist means the instance is 'deleted'.
13:51:54 sean-k-mooney yonglihe: your current code can delete active instnces
13:52:11 yonglihe that what i'm talking about.
13:52:29 yonglihe https://www.irccloud.com/pastebin/BSYfEoER/
13:52:53 yonglihe "not instance.obj_attr_is_set('id')" means instance is deleted.
13:53:05 mriedem sean-k-mooney: sure
13:53:20 sean-k-mooney yonglihe: im not sure that is correct
13:53:23 mriedem sean-k-mooney: btw i meant to split that out to do some of the cleanup stuff separately and only try to merge the functional tests in at the end
13:53:29 mriedem sean-k-mooney: i can do that split after you update it
13:53:39 mriedem i basically wanted to fire and forget yesterday
13:54:28 sean-k-mooney well this is actully the diff i was going to push http://paste.openstack.org/show/754262/
13:55:06 sean-k-mooney we cant remove the python hack entirely as running stestr on its own does not record any coverage info
13:55:35 sean-k-mooney the -p groups parrallel test by class
13:55:50 sean-k-mooney this gets rid of almost all the mocking issues
13:56:05 sean-k-mooney i have only 4 failing tests with that
13:56:10 mriedem go ahead and push it

Earlier   Later