| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-20 | |||
| 16:53:44 | sean-k-mooney1 | efried: i responed to your comments on the storageTransfrom as to why i intentionally did it this way. https://review.opendev.org/#/c/665844/1/nova/scheduler/request_filter.py@169 let me know if that is resonable | |
| 16:54:09 | efried | sean-k-mooney1: will look | |
| 16:56:59 | sean-k-mooney1 | i do admit the code is somewhat clever which is not always a smart thing to do but i can achive the same intent with multple moduels too | |
| 17:01:56 | openstackgerrit | Merged openstack/nova-specs master: Change new image property to hw_mem_encryption https://review.opendev.org/664397 | |
| 17:02:01 | stephenfin | sean-k-mooney1: Want to hit https://review.opendev.org/#/c/666387/1 ? | |
| 17:03:13 | sean-k-mooney1 | ill take a look now | |
| 17:04:25 | sean-k-mooney1 | we dont actully support python 3.4 sp that proably shoudl be 3.5 https://review.opendev.org/#/c/666387/1/doc/requirements.txt | |
| 17:04:44 | sean-k-mooney1 | that said its fine | |
| 17:04:53 | sean-k-mooney1 | let me check upper constratints | |
| 17:05:24 | openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Document AMD SEV support for encrypted VMs in libvirt https://review.opendev.org/666617 | |
| 17:05:39 | sean-k-mooney1 | stephenfin: how did the too long titles in teh rst not casue an error? | |
| 17:05:46 | sean-k-mooney1 | do we not have a check for that | |
| 17:05:48 | stephenfin | no idea | |
| 17:05:57 | stephenfin | we don't use doc8, which could catch these | |
| 17:06:04 | stephenfin | though I though Sphinx usually complained about them | |
| 17:06:21 | sean-k-mooney1 | but we do you warn as error for sphinx build | |
| 17:06:37 | sean-k-mooney1 | which i would have assumed would complain | |
| 17:07:49 | sean-k-mooney1 | stephenfin: so this is wrong | |
| 17:08:06 | sean-k-mooney1 | we should not be setting an upper limit in our requirements file | |
| 17:08:27 | stephenfin | we have to for sphinx on Python 2 | |
| 17:08:32 | sean-k-mooney1 | sphinx is already caped for py2.7 in upperconstraitns to https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L459 | |
| 17:08:44 | stephenfin | It is, but it complains if we don't sync them | |
| 17:08:45 | sean-k-mooney1 | no we cap to 1.8.5 for py27 | |
| 17:08:53 | sean-k-mooney1 | in upper constatints | |
| 17:08:59 | stephenfin | Yup | |
| 17:09:02 | sean-k-mooney1 | we might not be using it in the docs target | |
| 17:09:27 | sean-k-mooney1 | no we should be | |
| 17:09:38 | stephenfin | Propose a patch that touches requirements.txt without modifying the sphinx stuff and see what happens | |
| 17:09:44 | stephenfin | the requirements gate job will fail it | |
| 17:09:59 | stephenfin | infra might know why but I just know if we do this, it fixes things | |
| 17:10:29 | sean-k-mooney1 | we should not have teh <2.0.0 however | |
| 17:10:56 | sean-k-mooney1 | we are not ment to cap in repo | |
| 17:12:36 | mriedem | gibi: the end times is what | |
| 17:14:42 | stephenfin | sean-k-mooney1: I'd suggest proposing a WIP patch without that cap and seeing what happens. There have been a lot of these patches going in across oslo projects lately | |
| 17:16:11 | sean-k-mooney1 | stephenfin: well we also use python3 for building docs not python 2 | |
| 17:16:25 | sean-k-mooney1 | so i also dont see why we would need the python 2 version | |
| 17:16:28 | stephenfin | We do if you build docs using tox | |
| 17:16:38 | sean-k-mooney1 | yes which is the only thing we suport | |
| 17:16:55 | sean-k-mooney1 | that is what the pti also requires | |
| 17:16:57 | stephenfin | Right, but other projects use sphinx for things other than building docs | |
| 17:17:06 | stephenfin | for example, oslo_config.sphinxext | |
| 17:17:07 | sean-k-mooney1 | theat project supprot building docs via tox | |
| 17:17:26 | stephenfin | For those projects, we still need to support Python2 | |
| 17:17:35 | sean-k-mooney1 | why | |
| 17:17:54 | sean-k-mooney1 | they can move to running that under python3 | |
| 17:18:12 | sean-k-mooney1 | they need to do that this cycle anyway | |
| 17:18:41 | stephenfin | They can't drop py27 tests | |
| 17:19:29 | stephenfin | and if the project specifies sphinx as a requirement (vs. a test-requirement), it's going to pull in sphinx | |
| 17:19:30 | sean-k-mooney1 | well i guess not until U | |
| 17:19:36 | bnemec | It's kind of irrelevant. The requirements job isn't smart enough to differentiate, so you need the cap whether you support python 2 or not. | |
| 17:19:43 | sean-k-mooney1 | stephenfin: sure | |
| 17:19:53 | sean-k-mooney1 | but upper contratits caps it | |
| 17:19:57 | stephenfin | so attempting to install something like oslo.config on Python 2.7 would no longer be possible | |
| 17:20:00 | sean-k-mooney1 | so it should not be an issue | |
| 17:20:18 | sean-k-mooney1 | it is if you use upper-constratints | |
| 17:20:26 | sean-k-mooney1 | it cap sphix at 1.8.5 | |
| 17:20:37 | stephenfin | I don't know the specifics, but it's not as simple as that unfortunately | |
| 17:20:42 | stephenfin | See what bnemec said | |
| 17:20:51 | stephenfin | The requirements gate job will fail until we fix this | |
| 17:21:05 | sean-k-mooney1 | then we should wait to fix the gate | |
| 17:21:29 | stephenfin | Perhaps. I never looked into it, tbh | |
| 17:21:48 | stephenfin | Merging these patches seemed easier, particularly given we can drop them again in < 4 (3?) months | |
| 17:21:51 | sean-k-mooney1 | locally master works and im about to push a test patch to verify the gate | |
| 17:21:59 | bnemec | That's a discussion for the requirements team. | |
| 17:22:10 | bnemec | I know they're aware that this is bad, but I don't think they have a solution yet. | |
| 17:22:22 | openstackgerrit | sean mooney proposed openstack/os-vif master: testing docs job https://review.opendev.org/666651 | |
| 17:22:47 | sean-k-mooney1 | bnemec: well if i build with tox on master or with ^ its works | |
| 17:23:02 | bnemec | That won't demonstrate the problem. Make a change to a requirements file. | |
| 17:23:18 | bnemec | Without Stephen's patch it will fail the requirements job. | |
| 17:23:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.opendev.org/640730 | |
| 17:23:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.opendev.org/641723 | |
| 17:23:34 | sean-k-mooney1 | then the requirement job is broken | |
| 17:23:37 | sean-k-mooney1 | not the repo | |
| 17:23:49 | stephenfin | sean-k-mooney1: That's kind of what we're saying | |
| 17:23:50 | stephenfin | but | |
| 17:23:56 | bnemec | Again, that's an argument to have with the requirements team. :-) | |
| 17:23:57 | stephenfin | <bnemec> I know they're aware that this is bad, but I don't think they have a solution yet. | |
| 17:24:07 | sean-k-mooney1 | i have noticed and reported that the job does not handel the python version stuff properly | |
| 17:25:04 | sean-k-mooney1 | we spoke about this at the ptg when we wer fixing lower constraits | |
| 17:25:54 | stephenfin | sean-k-mooney1: If you fancy looking into this, by all means. However, if you want to save yourself a few hours of mostly thankless work, this patch and others like it are a good band-aid for this cycle :) | |
| 17:25:59 | stephenfin | and then, come next cycle | |
| 17:26:04 | stephenfin | Boom. Bye bye Python 2.7 | |
| 17:26:07 | openstackgerrit | sean mooney proposed openstack/os-vif master: testing docs job https://review.opendev.org/666651 | |
| 17:26:29 | aspiers | ffs devstack why do you hate me so? | |
| 17:26:43 | aspiers | good riddance to 2.7 | |
| 17:26:46 | stephenfin | aspiers: Don't worry, it hates everyone | |
| 17:26:56 | aspiers | it hates me more | |
| 17:27:06 | aspiers | it's even refusing to download stuff from files.pythonhosted.org! | |
| 17:27:07 | stephenfin | Good riddance to all manner of encoding issues | |
| 17:27:18 | aspiers | some SSL Certificate verification failure bullshit | |
| 17:27:37 | aspiers | SSLError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/09/f1/93603a26daf7a993a0acbbcfd32afce8b2fdf30a765d5651571ab635969b/etcd3-0.10.0.tar.gz (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661)'),)) | |
| 17:27:47 | aspiers | no matter that it used to work fine | |
| 17:28:08 | aspiers | pip install of anything fails | |
| 17:29:53 | stephenfin | I've seen that before but only against internal stuff | |
| 17:29:54 | sean-k-mooney1 | stephenfin: its a quick fix but its also againt the sprit of https://github.com/openstack/governance/blob/master/reference/pti/python.rst#constraints we opt in to the requiremetn team managing the upper-constiraits i dont like circumventing that | |
| 17:30:37 | sean-k-mooney1 | lets see if the bug is repoduced in the gate first | |
| 17:30:42 | stephenfin | aspiers: The solution internally is setting 'export REQUESTS_CA_BUNDLE=<path to some certs>' but I doubt that's applicable to you | |
| 17:30:46 | sean-k-mooney1 | if so then ill file a bug and we can merge it | |
| 17:31:31 | stephenfin | sean-k-mooney1: Fair. To be clear I think this will happen any time a package we use drops Python 2 support | |
| 17:31:40 | stephenfin | Again, until U | |