| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-20 | |||
| 17:23:57 | stephenfin | <bnemec> I know they're aware that this is bad, but I don't think they have a solution yet. | |
| 17:24:07 | sean-k-mooney1 | i have noticed and reported that the job does not handel the python version stuff properly | |
| 17:25:04 | sean-k-mooney1 | we spoke about this at the ptg when we wer fixing lower constraits | |
| 17:25:54 | stephenfin | sean-k-mooney1: If you fancy looking into this, by all means. However, if you want to save yourself a few hours of mostly thankless work, this patch and others like it are a good band-aid for this cycle :) | |
| 17:25:59 | stephenfin | and then, come next cycle | |
| 17:26:04 | stephenfin | Boom. Bye bye Python 2.7 | |
| 17:26:07 | openstackgerrit | sean mooney proposed openstack/os-vif master: testing docs job https://review.opendev.org/666651 | |
| 17:26:29 | aspiers | ffs devstack why do you hate me so? | |
| 17:26:43 | aspiers | good riddance to 2.7 | |
| 17:26:46 | stephenfin | aspiers: Don't worry, it hates everyone | |
| 17:26:56 | aspiers | it hates me more | |
| 17:27:06 | aspiers | it's even refusing to download stuff from files.pythonhosted.org! | |
| 17:27:07 | stephenfin | Good riddance to all manner of encoding issues | |
| 17:27:18 | aspiers | some SSL Certificate verification failure bullshit | |
| 17:27:37 | aspiers | SSLError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/09/f1/93603a26daf7a993a0acbbcfd32afce8b2fdf30a765d5651571ab635969b/etcd3-0.10.0.tar.gz (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661)'),)) | |
| 17:27:47 | aspiers | no matter that it used to work fine | |
| 17:28:08 | aspiers | pip install of anything fails | |
| 17:29:53 | stephenfin | I've seen that before but only against internal stuff | |
| 17:29:54 | sean-k-mooney1 | stephenfin: its a quick fix but its also againt the sprit of https://github.com/openstack/governance/blob/master/reference/pti/python.rst#constraints we opt in to the requiremetn team managing the upper-constiraits i dont like circumventing that | |
| 17:30:37 | sean-k-mooney1 | lets see if the bug is repoduced in the gate first | |
| 17:30:42 | stephenfin | aspiers: The solution internally is setting 'export REQUESTS_CA_BUNDLE=<path to some certs>' but I doubt that's applicable to you | |
| 17:30:46 | sean-k-mooney1 | if so then ill file a bug and we can merge it | |
| 17:31:31 | stephenfin | sean-k-mooney1: Fair. To be clear I think this will happen any time a package we use drops Python 2 support | |
| 17:31:40 | stephenfin | Again, until U | |
| 17:32:17 | sean-k-mooney1 | if that is the cases i really dont want to have to manage this in every repo and we should fix the requiremetns job | |
| 17:32:25 | aspiers | stephenfin: openssl s_client -connect files.pythonhosted.org:443 -prexit | |
| 17:32:29 | aspiers | gives this: | |
| 17:32:33 | aspiers | Verify return code: 9 (certificate is not yet valid) | |
| 17:33:18 | aspiers | cya tomorrow o/ | |
| 17:33:36 | efried | jroll: see latest response before you start hacking at the bp template | |
| 17:33:43 | efried | s/bp/spec/ | |
| 17:47:44 | jroll | efried: you severely underestimate my work queue if you think I start on anything within the hour :P | |
| 17:48:00 | jroll | oh, that's good news, thanks | |
| 17:48:10 | efried | yahyoubetcha | |
| 17:49:17 | efried | jroll: justification for no spec: no API change, no upgrade impact, no RPC/OVO changes, no new config, etc | |
| 17:49:40 | efried | mriedem may feel differently | |
| 17:49:57 | jroll | efried: yeah that's fair. I don't mind small specs anyway, so I'm open to either direction | |
| 17:50:22 | efried | heh, except nova-specs will bust you if you don't do the template just right. | |
| 17:50:26 | efried | but sure. | |
| 17:50:40 | sean-k-mooney1 | stephenfin: so http://logs.openstack.org/51/666651/2/check/requirements-check/c8c82c5/job-output.txt.gz#_2019-06-20_17_39_08_900979 is the same issue i spoke to the requirements folks about comming up to RC2 back like 3 months ago | |
| 17:51:14 | jroll | efried: I'm used to nit-picky CI :P | |
| 17:51:40 | sean-k-mooney1 | i hit it when trying to fix nova lower contratits job and found i could not actully use phytion version markers unless they matched upper constritns exactly | |
| 17:53:37 | sean-k-mooney1 | im pretty sure the problem is this | |
| 17:53:39 | sean-k-mooney1 | https://github.com/openstack/requirements/blob/master/global-requirements.txt#L459-L460 | |
| 17:53:54 | sean-k-mooney1 | we should not be listing the max versions there | |
| 17:54:11 | sean-k-mooney1 | that is what is causeign the conflict | |
| 17:55:25 | sean-k-mooney1 | so https://github.com/openstack/requirements/commit/00b2bcf7d664b1526b4eefe157c33113206d6251 is likely the reason all the other porject are broken | |
| 17:55:42 | sean-k-mooney1 | we should have caped just in upper constraitns not in global requiremetns | |
| 17:56:52 | mriedem | sean-k-mooney1: dansmith: it is done https://review.opendev.org/#/c/644881/37 | |
| 17:57:56 | mriedem | efried: jroll: passthrough tpm seems small spec worthy to me, but i can also pass the buck to dansmith | |
| 17:58:08 | sean-k-mooney1 | mriedem: thanks and thanks for rechecking too | |
| 17:58:11 | mriedem | we've had specs for less complicated things i'm sure | |
| 17:58:23 | dansmith | yeah | |
| 18:09:19 | mriedem | there, i have provided at least a few things that would likely need to be mulled over in a spec | |
| 18:09:44 | mriedem | creating a server with a thing and deleting it is easy, moving the damn thing and what happens when the compute is down and we need to cleanup later is the pain in the ass | |
| 18:14:03 | mriedem | stephenfin: remind me why you think it's better to list every option in the group here https://review.opendev.org/#/c/640730/8/doc/source/admin/vendordata.rst@134 rather than just the group itself and let the operator read through the config option docs? | |
| 18:15:39 | mriedem | previously you said, "While this service happens to have most things nicely grouped, that's not always the case. I realize duplication isn't nice but there's value in having everything grouped in one place. I'd like to keep this, if that's okay" but what is that value? and does it outweigh the duplication? | |
| 18:21:01 | mriedem | sean-k-mooney1: john is totally cool with https://review.opendev.org/#/c/647733/ | |
| 18:21:15 | mriedem | the +1 bot must not have -W filtering | |
| 18:22:11 | sean-k-mooney1 | haha ya... | |
| 18:22:53 | sean-k-mooney1 | i will get to adding the missing test before i sign off today | |
| 18:29:06 | efried | jroll: oh well, I tried | |
| 18:48:27 | openstackgerrit | Merged openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.opendev.org/633212 | |
| 18:48:31 | jroll | mriedem: <3 | |
| 18:50:17 | mriedem | jroll: that's not an ironic (as in hipster, not the openstack project) heart is it? is it...true love? | |
| 18:50:56 | jroll | somewhere in the middle, like, I love you in this moment but it is not promised forever :P | |
| 18:50:58 | mriedem | now i'm thinking about david coverdale, great | |
| 18:51:08 | jroll | lol | |
| 18:51:10 | openstackgerrit | Merged openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.opendev.org/633227 | |
| 19:01:15 | Nick_A | what are some potential reasons why metadata would have keys but not password (either in openstack/latest/password or openstack/latest/meta_data.json) when both are used to create the instance? | |
| 19:05:48 | efried | dansmith: Since request_filter.py is fresh in your head, how would you feel about moving the logic in the @trace decorator just into the main loop? | |
| 19:06:03 | efried | so we don't have to remember to decorate every method | |
| 19:06:59 | dansmith | efried: meh, seems like not much to remember and obvious if you're copying, but if you think it's important then okay | |
| 19:07:57 | efried | dansmith: When I was looking at sean-k-mooney1's patch and considering how best it could be done more simply, the fact that the trace was a decorator was slightly in the way of one of the better ways of organizing. Otherwise as you say not a big deal. | |
| 19:09:53 | dansmith | efried: I'm likely biased, but I totes don't see that much organization is needed at this point and prefer to wait for more things to be added so that clear patterns develop | |
| 19:09:54 | sean-k-mooney1 | efried: im not sure if dansmith has seen my patch yet | |
| 19:10:21 | efried | sean-k-mooney1: He did, swhat prompted me to bug him about it :) | |
| 19:10:36 | sean-k-mooney1 | ah i was doing bug assignment | |
| 19:10:44 | sean-k-mooney1 | let me check the patch | |
| 19:11:02 | dansmith | prepare to be overwhelmed with reading material | |
| 19:11:52 | sean-k-mooney1 | haha ok so you agree with erric :) | |
| 19:13:00 | sean-k-mooney1 | am are ye ok with me resturcting the code so ist more like the normal filter-schduler filers instead? | |
| 19:13:24 | dansmith | not really, no | |
| 19:13:46 | sean-k-mooney1 | ok... i can just revert to functions | |
| 19:14:06 | sean-k-mooney1 | and keep it all in one file but i think that is going to get annoying in the medium to long term | |
| 19:14:25 | dansmith | when it gets annoying we can split it up | |
| 19:15:00 | sean-k-mooney1 | well it was already annying me a littel :) but not enought to fight this battel to much | |
| 19:16:40 | sean-k-mooney1 | efried: im going to finish writing the 3 transform (as function not fucntors) and then ill start working on the dirver chagnes to report the tratis and move the filters to the end of the patch series | |
| 19:18:07 | sean-k-mooney1 | i might do the extraction fo the common helper code as a singel patch too and then build on that | |
| 19:18:25 | sean-k-mooney1 | that sound ok with people? | |
| 19:19:11 | dansmith | sean-k-mooney1: the three transforms need only be a single function..hopefully that's what you're planning right? | |
| 19:19:46 | sean-k-mooney1 | i was going to have one function for each to make the testing simplere but i can compess them | |
| 19:20:13 | dansmith | that is way (way) overkill, IMHO and just serves to get us to "annoying" sooner for no benefit :) | |
| 19:20:19 | sean-k-mooney1 | i would prefer to just add another fucntion to the dict everytime we add a new image metadata trait we support | |
| 19:20:38 | dansmith | but they're identical in behavior right? | |
| 19:21:03 | sean-k-mooney1 | i think i can generalise it actully | |
| 19:21:24 | sean-k-mooney1 | the main different is the field they match on and the prefix for the trait | |
| 19:21:36 | dansmith | I don't understand how it's not already generalized, but.. okay | |
| 19:21:38 | sean-k-mooney1 | that was on my todo list for the next versions anyway | |
| 19:23:58 | sean-k-mooney1 | which fucntio were you refering to by the way i plan to have only one filter fucntion transform_image_metadata but ideally i would also have one transfrom function that is paramaterised on teh traits prefix to use and the image metadata value to check | |