Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-20
15:42:15 Sundar sean-k-mooney, mriedem, gibi: Thanks, and agreed. So, once I fix the formatting issues that mriedem mentioned, we are ready to merge this one, right?
15:42:40 sean-k-mooney i dont have any outstanding issue with the current version
15:42:47 sean-k-mooney ignoring formating
15:42:57 openstackgerrit Adam Spiers proposed openstack/nova master: Add a new CONF.libvirt.num_memory_encrypted_guests option https://review.opendev.org/662105
15:42:58 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
15:43:17 mriedem Sundar: the formatting can be a follow up, i'll +2
15:43:17 gibi Sundar: I will +2 it after the config is dropped
15:43:28 openstackgerrit Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555
15:43:29 openstackgerrit Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556
15:43:29 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
15:43:30 openstackgerrit Adam Spiers proposed openstack/nova master: Add element to guest config for AMD SEV https://review.opendev.org/636318
15:43:30 openstackgerrit Adam Spiers proposed openstack/nova master: Allow guest devices to include https://review.opendev.org/644564
15:43:31 openstackgerrit Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565
15:43:31 openstackgerrit Adam Spiers proposed openstack/nova master: Use element when SEV is required https://review.opendev.org/662557
15:43:32 openstackgerrit Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558
15:43:32 openstackgerrit Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/666616
15:43:33 openstackgerrit Adam Spiers proposed openstack/nova master: WIP: Document AMD SEV support for encrypted VMs in libvirt https://review.opendev.org/666617
15:43:36 sean-k-mooney gibi: it was droped in the latest version i think
15:43:50 gibi sean-k-mooney: ahh, there is a newer ps, ...
15:43:50 sean-k-mooney uless there has been another version since i last looked
15:44:06 aspiers efried: ^^^ master switch floated to top, just under a new WIP docs patch (which could be squashed into the switch later)
15:44:09 melwitt gibi: I dunno if you saw my ping from yesterday, your review would be appreciated on this involved func test https://review.opendev.org/631294 where I have wondered if there are any simplifications you could spot because it's quite large and complicated IMHO
15:44:38 Sundar PS15 is the latest, and it drops the config under discussion
15:44:39 mriedem gibi: sean-k-mooney: yeah he dropped it in PS15, we're just discussing in PS14
15:44:55 gibi melwitt: I missed your ping. Put put that patch in my queue
15:45:39 mriedem Sundar: +Workflowed, congratulations, you can open some champagne now.
15:45:51 mriedem edleafe might still have some in the trunk of his car
15:46:01 melwitt gibi: thanks much
15:46:49 gibi mriedem: nothing is better during the summer than a glass of warm champagne :)
15:47:14 Sundar mriedem: I drank all the champagne after the PTG :P
15:49:18 Sundar mriedem, gibi, sean-k-mooney, efried, all: Thanks very much for your discussion and feedback. Learnt a lot (including patience ;) )
15:50:13 gibi Sundar: thank you for your perseverance!
16:02:07 edleafe mriedem: that was cdent with the bubbly. And it was prosecco, I believe
16:03:06 mriedem edleafe: i just like the idea of you driving around texas with a crate of champagne in the trunk of your car
16:03:09 openstackgerrit Merged openstack/nova-specs master: Nova Cyborg interaction specification. https://review.opendev.org/603955
16:08:48 edleafe mriedem: Sheesh, with temperatures these days over 100F, it would be exploding in my trunk
16:09:00 cdent Big Ed's Champagne and Nosh. We deliver.
16:10:14 aspiers Exception occurred:
16:10:16 aspiers File "<frozen importlib._bootstrap_external>", line 455, in _validate_bytecode_header
16:10:18 aspiers ImportError: bad magic number in 'nova.conf.cells': b'\x03\xf3\r\n'
16:10:20 aspiers #wtf
16:10:26 aspiers this is from tox -e docs
16:11:25 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.74: Add 'power-update' external event https://review.opendev.org/645611
16:11:54 aspiers stephenfin: this look familiar to you? https://gist.github.com/aspiers/63ed063899729c46d6fef7f751b92fee
16:12:35 stephenfin aspiers: You've got leftover pyc files and/or __pycache__ directories
16:12:42 aspiers ah ok thanks
16:14:13 mriedem aspiers: kill pyc
16:14:17 mriedem d'oh
16:14:36 mriedem stephenfin: remember when i said something about still having a tox.ini line to delete pycs when building docs?
16:15:10 aspiers yup there was a pyc somewhere
16:15:38 stephenfin I'm not sure why the docs target isn't respecting the PYTHONDONTWRITEBYTECODE option
16:15:57 stephenfin aspiers: Have you recently jumped back through stable branches?
16:16:10 aspiers don't think so
16:16:15 sean-k-mooney1 PYTHONDONTWRITEBYTECODE has issue if you cahnge branches
16:16:24 aspiers it's possible
16:16:27 sean-k-mooney1 unless we backport it to all brances
16:16:29 stephenfin Yeah, that's why I was asking
16:16:31 aspiers I haven't built the docs for a while
16:16:36 stephenfin I had backports proposed somewhere
16:16:47 sean-k-mooney1 that is why i prefered the find command
16:16:48 aspiers but I used --recreate and that didn't help, I had to remove .pyc from nova/
16:16:57 stephenfin Yeah, all the backports are there
16:17:07 stephenfin and Google doesn't help
16:17:21 sean-k-mooney1 the backport will only help if you have a clean repo
16:17:42 sean-k-mooney1 and you dont use the repor for devstack
16:17:46 sean-k-mooney1 but ya
16:18:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/609460
16:18:42 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Skip most of 'get_base_config' if not using virtio https://review.opendev.org/666629
16:18:42 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630
16:18:43 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631
16:19:22 stephenfin dansmith: I think that's closer to what you were looking for ^
16:20:41 dansmith stephenfin: ack, lemme pull that down and poke at that other test
16:20:44 dansmith but probably
16:21:14 sean-k-mooney1 stephenfin: ya https://review.opendev.org/#/c/609460/4/nova/virt/libvirt/vif.py look logically correct
16:24:07 dansmith stephenfin: okay, so on the test...
16:24:26 dansmith er, wait, lemme try something
16:30:11 stephenfin sean-k-mooney1: You should take a look at https://review.opendev.org/#/c/666630/ at some point too, if possible. I've been wanting to do that for as long as I've known it
16:30:15 dansmith stephenfin: okay, yeah, nevermind
16:34:41 stephenfin dansmith: On the same note, you'll probably like https://review.opendev.org/#/c/666629/ too (it's the same principle)
16:37:16 dansmith hrm, parallels uses virtio?
16:37:24 dansmith that seems, weird to me.
16:38:54 sean-k-mooney1 paralles have two backens
16:39:04 sean-k-mooney1 one based on openvz container and a vm based one
16:39:17 sean-k-mooney1 they use virtio if you are using the vm based one
16:44:11 dansmith ah
16:44:18 dansmith I only know of the container part I guess
16:44:25 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.opendev.org/666638
16:44:25 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.opendev.org/666639
16:48:08 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630
16:48:09 openstackgerrit Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631
16:50:43 gibi What will happen in review https://review.opendev.org/#/c/666666 ? We are pretty close to that number
16:53:44 sean-k-mooney1 efried: i responed to your comments on the storageTransfrom as to why i intentionally did it this way. https://review.opendev.org/#/c/665844/1/nova/scheduler/request_filter.py@169 let me know if that is resonable
16:54:09 efried sean-k-mooney1: will look
16:56:59 sean-k-mooney1 i do admit the code is somewhat clever which is not always a smart thing to do but i can achive the same intent with multple moduels too
17:01:56 openstackgerrit Merged openstack/nova-specs master: Change new image property to hw_mem_encryption https://review.opendev.org/664397
17:02:01 stephenfin sean-k-mooney1: Want to hit https://review.opendev.org/#/c/666387/1 ?
17:03:13 sean-k-mooney1 ill take a look now
17:04:25 sean-k-mooney1 we dont actully support python 3.4 sp that proably shoudl be 3.5 https://review.opendev.org/#/c/666387/1/doc/requirements.txt
17:04:44 sean-k-mooney1 that said its fine
17:04:53 sean-k-mooney1 let me check upper constratints

Earlier   Later