Earlier  
Posted Nick Remark
#openstack-nova - 2019-06-13
15:02:48 sean-k-mooney that would require resouceless RPs for it to work however
15:03:10 mgoddard mriedem: I'll add it to my reading list
15:03:14 sean-k-mooney efried: ^ was for you and i guess anyone that is interested
15:03:28 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth https://review.opendev.org/652965
15:03:28 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests https://review.opendev.org/652966
15:03:29 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens https://review.opendev.org/652967
15:03:30 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968
15:03:30 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969
15:03:30 efried sean-k-mooney: That could work, but sounds like a pretty big hammer.
15:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
15:03:31 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147
15:03:54 sean-k-mooney efried: it might be but it makes the nova and placmenet logic a lot simpler
15:04:05 sean-k-mooney but it also intoduce a depency on resouceles providers
15:04:13 mriedem mgoddard: the things you'd have to be aware of is the allow_resize_to_same_host config option in the compute api - you'd have to ignore that for baremetal instances, and figuring out if the instance is baremetal to begin with to change how scheduling is going to work etc - and then it's implementing some virt driver methods
15:04:20 sean-k-mooney maybe something to consider after train?
15:04:36 mriedem sean-k-mooney: or, or, we just say nova doesn't orchestrate that and if you want it, do it external to nova
15:04:55 mriedem b/c christ almighty we're already bad at orchestrating external resources,
15:04:59 sean-k-mooney mriedem: yes which is definetly what i think we shoudl do for train
15:05:01 mriedem case in point, see my ML thread about deleting a compute service
15:05:24 sean-k-mooney :) fair point
15:05:31 sean-k-mooney we are also terrible at math
15:05:36 efried mriedem, mgoddard: ironic resize: Is the consensus that someone should produce a spec (either revive the one linked above or write a new one)? But generally speaking there's no major objection to doing some form of "same host resize" for ironic?
15:06:26 sean-k-mooney efried: you would proably need a prefilter or somthing that could understand its a baremetal instance and force the same host
15:06:37 efried yes, mriedem mentioned that above
15:06:47 sean-k-mooney the allow same hsot resize jsut allows it rather then forces it
15:06:56 efried yes, mriedem mentioned that above
15:07:08 sean-k-mooney yep
15:07:18 sean-k-mooney the question i have however is do we really need to force that
15:07:30 sean-k-mooney i mean ironic could support resize in general
15:07:34 efried are you suggesting allowing ironic resize to a new node?
15:07:40 sean-k-mooney yes
15:07:43 efried baby steps, sean-k-mooney. Baby steps.
15:08:17 aspiers sean-k-mooney: turns out meetbot will recognise anyone issuing an #action
15:08:24 sean-k-mooney for bfv guest there is nothitng ot copy and for non-bfv the ironic agent could be extended to dd the data form one to anohter
15:08:34 aspiers which matches my memory
15:08:36 aspiers http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-06-13-14.00.html
15:08:40 sean-k-mooney aspiers: cool good to know
15:08:57 efried sean-k-mooney: Yes, but let's address the case we know we want to solve first, before enabling the general case and all the test surface that goes with it.
15:09:34 sean-k-mooney efried: sure although im pretty sure the general case had a spec form a few cylces ago which is why i brought it up
15:10:13 artom mriedem, efried, https://wiki.openstack.org/wiki/Nova/Mentoring#Work_Items_for_New_Contributors and https://etherpad.openstack.org/p/nova-reviews-looking-for-owner
15:10:35 sean-k-mooney efried: but yes i think that the simpler case of same host could be a stepping stone
15:11:19 efried thanks artom
15:21:51 mriedem artom: i'll update 522084 underneath the scheduler hints change
15:22:28 artom mriedem, ah, thanks, didn't notice it was a 2-patch series
15:25:11 openstackgerrit Merged openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583
15:25:12 openstackgerrit Merged openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786
15:28:49 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.opendev.org/629597
15:28:50 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939
15:29:02 stephenfin lyarwood: Could you take a look at https://review.opendev.org/#/c/629597 when you have a chance?
15:35:46 lyarwood stephenfin: queued
15:36:05 openstackgerrit Eric Fried proposed openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003
15:43:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.opendev.org/522084
15:43:46 mriedem artom: rebase on ^ - stephenfin - easy docs change ^
15:43:59 artom mriedem, ack
15:49:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
15:49:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
15:49:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
15:49:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
15:49:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
15:49:36 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
15:49:36 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
15:49:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
15:49:40 stephenfin mriedem: Could you or artom s/.. code::/.. code-block:: json/ in that? +W if so https://review.opendev.org/#/c/522084/
15:52:12 mriedem stephenfin: nope
15:52:17 mriedem you can't b/c of the ...
15:52:30 stephenfin I noted that. Can we drop it like we did elsewhere in the file?
15:52:40 mriedem drop what? the ... ?
15:52:45 stephenfin aye
15:52:47 mriedem i don't really want to put a full server create request in there
15:52:49 mriedem since those are big
15:52:50 stephenfin see line 810 in there
15:53:16 stephenfin I know, but I imagine people can guess it's not a full response
15:53:23 stephenfin as with 810, 829, etc.
15:54:06 mriedem ffs zuul restart
15:56:52 openstackgerrit Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559
15:56:59 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663677
15:57:21 mriedem lyarwood: why did you need to rebase ^?
15:57:26 mriedem oh i see
15:58:31 lyarwood mriedem: yeeeeeeah, I didn't notice the zuul restart, I wonder if that's going to get picked up.
15:58:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.opendev.org/522084
15:58:46 mriedem stephenfin: done
15:59:03 mriedem lyarwood: yeah idk, was just rechecking a bunch of other things too
15:59:30 lyarwood ah, so that change was picked up
15:59:41 stephenfin mriedem: +2. Happy for you to +W or I can
15:59:49 stephenfin thanks :)
16:01:03 mriedem i got it
16:03:57 mriedem looks like all my rechecks were dropped
16:03:59 mriedem weeeee
16:19:37 sean-k-mooney artom: i noticed you updated your numa migration stuff yesterday
16:20:07 sean-k-mooney artom: have you more changes pending or shoudl i plan to review it/test it next week
16:20:42 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.opendev.org/640730
16:20:42 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.opendev.org/641723
16:21:39 stephenfin efried: Think I asked you this before, but what's the chances of getting https://review.opendev.org/640730 blindly approved?
16:21:40 stephenfin It's docs only and I think it's a huge improvement, but I've no idea how to break it up more than I have without rewriting the whole darn thing
16:22:21 mriedem stephenfin: maybe ask dansmith to review it again first :)
16:22:35 stephenfin I think I've done that a few times too :(
16:22:37 mriedem since he did the most thorough review
16:23:07 dansmith stephenfin: done what a few times?
16:23:26 stephenfin dansmith: Have a look at that ridiculously big metadata doc rework patch of mine
16:23:33 stephenfin (https://review.opendev.org/640730)

Earlier   Later