Posted	Nick	Remark
#openstack-nova - 2019-06-13
15:07:18	sean-k-mooney	the question i have however is do we really need to force that
15:07:30	sean-k-mooney	i mean ironic could support resize in general
15:07:34	efried	are you suggesting allowing ironic resize to a new node?
15:07:40	sean-k-mooney	yes
15:07:43	efried	baby steps, sean-k-mooney. Baby steps.
15:08:17	aspiers	sean-k-mooney: turns out meetbot will recognise anyone issuing an #action
15:08:24	sean-k-mooney	for bfv guest there is nothitng ot copy and for non-bfv the ironic agent could be extended to dd the data form one to anohter
15:08:34	aspiers	which matches my memory
15:08:36	aspiers	http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-06-13-14.00.html
15:08:40	sean-k-mooney	aspiers: cool good to know
15:08:57	efried	sean-k-mooney: Yes, but let's address the case we know we want to solve first, before enabling the general case and all the test surface that goes with it.
15:09:34	sean-k-mooney	efried: sure although im pretty sure the general case had a spec form a few cylces ago which is why i brought it up
15:10:13	artom	mriedem, efried, https://wiki.openstack.org/wiki/Nova/Mentoring#Work_Items_for_New_Contributors and https://etherpad.openstack.org/p/nova-reviews-looking-for-owner
15:10:35	sean-k-mooney	efried: but yes i think that the simpler case of same host could be a stepping stone
15:11:19	efried	thanks artom
15:21:51	mriedem	artom: i'll update 522084 underneath the scheduler hints change
15:22:28	artom	mriedem, ah, thanks, didn't notice it was a 2-patch series
15:25:11	openstackgerrit	Merged openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583
15:25:12	openstackgerrit	Merged openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786
15:28:49	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.opendev.org/629597
15:28:50	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939
15:29:02	stephenfin	lyarwood: Could you take a look at https://review.opendev.org/#/c/629597 when you have a chance?
15:35:46	lyarwood	stephenfin: queued
15:36:05	openstackgerrit	Eric Fried proposed openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003
15:43:45	openstackgerrit	Matt Riedemann proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.opendev.org/522084
15:43:46	mriedem	artom: rebase on ^ - stephenfin - easy docs change ^
15:43:59	artom	mriedem, ack
15:49:33	openstackgerrit	Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
15:49:34	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
15:49:34	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
15:49:35	openstackgerrit	Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
15:49:35	openstackgerrit	Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
15:49:36	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
15:49:36	openstackgerrit	Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
15:49:37	openstackgerrit	Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
15:49:40	stephenfin	mriedem: Could you or artom s/.. code::/.. code-block:: json/ in that? +W if so https://review.opendev.org/#/c/522084/
15:52:12	mriedem	stephenfin: nope
15:52:17	mriedem	you can't b/c of the ...
15:52:30	stephenfin	I noted that. Can we drop it like we did elsewhere in the file?
15:52:40	mriedem	drop what? the ... ?
15:52:45	stephenfin	aye
15:52:47	mriedem	i don't really want to put a full server create request in there
15:52:49	mriedem	since those are big
15:52:50	stephenfin	see line 810 in there
15:53:16	stephenfin	I know, but I imagine people can guess it's not a full response
15:53:23	stephenfin	as with 810, 829, etc.
15:54:06	mriedem	ffs zuul restart
15:56:52	openstackgerrit	Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559
15:56:59	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663677
15:57:21	mriedem	lyarwood: why did you need to rebase ^?
15:57:26	mriedem	oh i see
15:58:31	lyarwood	mriedem: yeeeeeeah, I didn't notice the zuul restart, I wonder if that's going to get picked up.
15:58:44	openstackgerrit	Matt Riedemann proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.opendev.org/522084
15:58:46	mriedem	stephenfin: done
15:59:03	mriedem	lyarwood: yeah idk, was just rechecking a bunch of other things too
15:59:30	lyarwood	ah, so that change was picked up
15:59:41	stephenfin	mriedem: +2. Happy for you to +W or I can
15:59:49	stephenfin	thanks :)
16:01:03	mriedem	i got it
16:03:57	mriedem	looks like all my rechecks were dropped
16:03:59	mriedem	weeeee
16:19:37	sean-k-mooney	artom: i noticed you updated your numa migration stuff yesterday
16:20:07	sean-k-mooney	artom: have you more changes pending or shoudl i plan to review it/test it next week
16:20:42	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.opendev.org/640730
16:20:42	openstackgerrit	Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.opendev.org/641723
16:21:39	stephenfin	efried: Think I asked you this before, but what's the chances of getting https://review.opendev.org/640730 blindly approved?
16:21:40	stephenfin	It's docs only and I think it's a huge improvement, but I've no idea how to break it up more than I have without rewriting the whole darn thing
16:22:21	mriedem	stephenfin: maybe ask dansmith to review it again first :)
16:22:35	stephenfin	I think I've done that a few times too :(
16:22:37	mriedem	since he did the most thorough review
16:23:07	dansmith	stephenfin: done what a few times?
16:23:26	stephenfin	dansmith: Have a look at that ridiculously big metadata doc rework patch of mine
16:23:33	stephenfin	(https://review.opendev.org/640730)
16:23:43	artom	sean-k-mooney, just a rebase for now, bottomg patch is WIP
16:23:57	artom	To indicate that the whole series isn't ready yet
16:24:25	dansmith	stephenfin: just wanted to make sure you weren't implying you had asked me to revisit a few times
16:24:31	sean-k-mooney	artom: ok so saving the updated xml after the migration is still pending
16:24:56	sean-k-mooney	artom: that was the main thing that needed to be fixed and the rest is cleanup right
16:26:58	stephenfin	I think I may have and I get why you haven't, if so. Not intending to point fingers at all though. I'd just like to be done with it
16:28:16	artom	sean-k-mooney, the XML is fine, IIRC, it's the database numa_topology that wasn't saved
16:28:46	dansmith	stephenfin: point being, I'm quite sure I didn't hear anything after that review, but I'm looking at it right now
16:28:54	sean-k-mooney	artom: maybe i just recall we didnt save somthing
16:29:18	stephenfin	dansmith: Ah, sorry. That's my mistake so
16:29:23	stephenfin	And thank you
16:36:22	dansmith	mriedem: for the tenth and last time, can you hit this? https://review.opendev.org/#/c/640730/7
16:36:33	sean-k-mooney	stephenfin: i personlay prefer the ... then assuming people will guess its not a full respocne but its proably fine eitehr way
16:36:57	stephenfin	sean-k-mooney: Too late. mriedem already did the deed
16:37:00	stephenfin	mwahaha
16:37:03	sean-k-mooney	stephenfin: that was regarding mriedem change but he has updated it already
16:37:06	sean-k-mooney	yep i know
16:37:18	stephenfin	No take backsies
16:37:23	mriedem	dansmith: lucky for y'all i just got a fresh pack of red markers
16:37:42	sean-k-mooney	stephenfin: damn i have not heard that in a while
16:43:54	efried	stephenfin: looking now.
16:46:01	aspiers	efried: oslo.log guidelines feedback addressed, when you are looking for some light relief
16:46:29	efried	ack
17:18:39	openstackgerrit	melanie witt proposed openstack/nova master: Warn for duplicate host mappings during discover_hosts https://review.opendev.org/651947
17:19:14	melwitt	dansmith: ^ updated
17:21:53	dansmith	gdi
17:22:51	melwitt	what

Earlier   Later