Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-07
19:21:05 efried lyarwood: I suspect putting your patch together with ^ will have interesting side effects.
19:25:00 lyarwood efried: ack thanks, I'm heading offline now but I'll rebase on that and see what shakes out on Monday
19:25:58 efried lyarwood: They'll affect the tests (because `$string in $autospec_mock` doesn't work), but I don't think they can actually cause bugs in the code.
19:38:03 sean-k-mooney efried: 'foo' in 'foo' check if the 'foo' charater sequence extis in the second string 'foo'
19:38:20 efried right
19:39:00 sean-k-mooney efried: so 'f' in 'foo' is a substring match where as 'foo' in ('foo') is a contains check
19:39:16 efried contains in what sense?
19:39:22 sean-k-mooney e.g. is 'foo' one of the values of the tuple
19:39:26 efried 'foo' in ('foo') is the same as 'foo' in 'foo'.
19:39:31 efried Because ('foo') is not a tuple.
19:39:35 efried It's a string with redundant parens.
19:39:41 efried ('foo',) is a tuple.
19:40:00 sean-k-mooney ah well yes that too
19:40:27 sean-k-mooney although 'foo' in ('foo',) should also be true
19:40:56 efried 'foo' in ('foobar') # True
19:40:56 efried 'foo' in ('foobar',) # False
19:41:12 sean-k-mooney yes but that is not what i wrote
19:41:25 efried what you wrote where?
19:41:39 sean-k-mooney >>> 'foo' in ('foo',)
19:41:41 sean-k-mooney True
19:41:49 efried yes
19:42:07 sean-k-mooney if the string matachs a value in the tuple exactly it will be true
19:42:13 efried right
19:42:24 efried but only if it's a tuple
19:42:24 sean-k-mooney but it wont to a substring match on each of the values of the tuple
19:42:28 efried right
19:42:51 efried we are in violent agreement
19:42:59 sean-k-mooney yep :)
19:43:07 efried And I think we're not broken here, because there's no arch const that's a substring of another arch const (is there?)
19:43:25 efried but it's by luck. It's still wrong and should be fixed.
19:43:48 sean-k-mooney i dont know if we have x86 and x86_64 but i think if we did we would threat them as an alias
19:44:03 openstackgerrit Eric Fried proposed openstack/nova master: Fix some bogus `in (not_a_tuple)` uses https://review.opendev.org/664041
19:44:12 efried Enhanced commit message which (hopefully) makes it clearer ^
19:44:24 efried (also fixed the other two spots in the nova codebase that do the same)
19:44:40 sean-k-mooney this is the set we support https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L112-L153
19:45:01 sean-k-mooney technically tere a few
19:45:12 sean-k-mooney ppc64 and ppc64le
19:45:22 efried mm, s390/s390x
19:45:37 efried ppc is a substring of a bunch
19:45:42 sean-k-mooney ya look like only ibm was broken
19:45:46 efried sh4
19:45:56 efried xtensa
19:45:59 efried mips
19:46:06 efried arm7
19:46:10 sean-k-mooney ok
19:46:20 sean-k-mooney look like only x86 is not broken :P
19:46:29 efried the one in question was specifically saying in (AARCH64)
19:46:43 efried which looks like it's probably okay.
19:46:58 sean-k-mooney i dont think we use most of these constants anyway
19:49:18 sean-k-mooney if only we had static types...
20:14:55 openstackgerrit Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607
20:48:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add SchedulerReportClient.get_provider_by_name https://review.opendev.org/664062
21:06:46 mriedem well zuul just got restarted so i'm out of here for the weekend
21:06:52 mriedem sniff you jerks later
21:09:40 openstackgerrit Eric Fried proposed openstack/nova master: Hacking N363: `in (not_a_tuple)` https://review.opendev.org/664041
23:15:21 redkrieg Is there any way to run a virt-sparsify on a snapshot during creation?
#openstack-nova - 2019-06-08
02:32:36 openstackgerrit Merged openstack/nova master: Remove an unused method https://review.opendev.org/663502
04:51:45 openstackgerrit Merged openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774
07:00:24 openstackgerrit Merged openstack/nova master: Avoid unnecessary joins in InstanceGroup.get_hosts https://review.opendev.org/661032
11:40:23 openstackgerrit Merged openstack/nova master: Delete unused get_all_host_states method https://review.opendev.org/663377
12:55:12 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
12:55:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
12:55:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
12:55:14 openstackgerrit Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
12:55:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
12:55:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
12:55:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
12:55:16 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:36:13 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
15:36:13 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
15:41:00 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
15:41:01 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
15:48:52 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311
15:48:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
15:48:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
15:48:54 openstackgerrit Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
15:48:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
15:48:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
15:48:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
15:48:56 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:52:31 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
15:52:31 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
16:09:41 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036
20:34:13 Nick_A Trying to snapshot lxd containers - is there a way to force the snapshot to occur "online" like kvm?
#openstack-nova - 2019-06-09
13:57:52 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
22:56:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
#openstack-nova - 2019-06-10
00:22:27 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Enable omission of the value of '--config-drive' https://review.opendev.org/653683
02:23:54 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
04:59:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193
06:01:23 openstackgerrit Merged openstack/nova-specs master: Specifying az when restore shelved server https://review.opendev.org/624689
06:29:20 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Clarify the error response in proposed change https://review.opendev.org/664198
06:31:38 openstackgerrit Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237
08:05:58 sapd1 Hi everyone, In this line, https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L362 I think I can get devices which are being attached to the instance, But When I tried, It returns None.
08:07:57 sapd1 Can any one tell me why?
08:14:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175
08:14:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove unnecessary setUp methods https://review.opendev.org/663179
09:45:54 openstackgerrit Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607
09:52:54 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
10:50:52 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432
11:04:24 openstackgerrit Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522

Earlier   Later