Posted	Nick	Remark
#openstack-nova - 2019-06-08
15:48:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
15:48:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
15:48:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
15:48:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
15:48:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
15:48:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
15:48:56	openstackgerrit	Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:52:31	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
15:52:31	openstackgerrit	Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
16:09:41	openstackgerrit	Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036
20:34:13	Nick_A	Trying to snapshot lxd containers - is there a way to force the snapshot to occur "online" like kvm?
#openstack-nova - 2019-06-09
13:57:52	openstackgerrit	Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
22:56:10	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
#openstack-nova - 2019-06-10
00:22:27	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Enable omission of the value of '--config-drive' https://review.opendev.org/653683
02:23:54	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
04:59:08	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193
06:01:23	openstackgerrit	Merged openstack/nova-specs master: Specifying az when restore shelved server https://review.opendev.org/624689
06:29:20	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Clarify the error response in proposed change https://review.opendev.org/664198
06:31:38	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237
08:05:58	sapd1	Hi everyone, In this line, https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L362 I think I can get devices which are being attached to the instance, But When I tried, It returns None.
08:07:57	sapd1	Can any one tell me why?
08:14:35	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175
08:14:49	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove unnecessary setUp methods https://review.opendev.org/663179
09:45:54	openstackgerrit	Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607
09:52:54	openstackgerrit	Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
10:50:52	openstackgerrit	sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432
11:04:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
11:04:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245
13:28:24	stephenfin	efried: I'd like a python-novaclient release with https://review.opendev.org/#/c/650363/ in it. Have proposed https://review.opendev.org/#/c/664259/, assuming that's okay?
13:32:04	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102
13:47:06	efried	stephenfin: looking
13:51:06	efried	stephenfin: gross. Are you going to blacklist all 8 versions the original got included in, for py27?
13:51:19	efried	I guess if this only affects the CLI, no need for that.
13:51:23	stephenfin	I don't think so
13:51:45	stephenfin	It's a lot of effort and I figure distros will pick this up pretty quickly
13:51:46	dansmith	is gibi out?
13:53:12	efried	stephenfin: +1
14:20:03	stephenfin	efried: Want to take a look at this too and unblock the rest of the series https://review.opendev.org/#/c/651311/
14:21:44	efried	stephenfin: Will do. I was just looking at the "all call super" patch in that series...
14:21:49	stephenfin	Also got https://review.opendev.org/#/c/660950/ working, though that's lower priority (turns out it's 'foo(x=None, *args, **kwargs)' and not 'foo(*args, x=None, **kwargs)', but flake8 doesn't catch that)
14:21:52	stephenfin	Heh, jinx
14:29:05	efried	stephenfin: bottom one is +A.
14:29:17	efried	imo the super one shouldn't be adding *args or **kwargs anywhere they weren't already.
14:36:16	openstackgerrit	Matt Riedemann proposed openstack/nova master: Make get_provider_by_name public and remove safe_connect https://review.opendev.org/664062
14:38:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
14:38:30	stephenfin	efried: Cool. Fixed the super one by removing all the *args and **kwargs (none of them were necessary, fwict) ^
14:53:18	efried	stephenfin: Cool man, +2.
14:53:27	stephenfin	mriedem, sean-k-mooney: What am I missing here? I see only one callers to the revert_resize function and that's from the API https://review.opendev.org/#/c/662522/3/nova/compute/api.py@3420
14:53:52	stephenfin	We wouldn't call "openstack resize --revert" on a failed migration, would we?
14:54:38	sean-k-mooney	stephenfin: im pretty sure we use teh revert_resize api endpoint to revert a cold-migration
14:55:05	mriedem	stephenfin: cold migrate == resize except same flavor
14:55:09	mriedem	it's the same code flow
14:55:13	stephenfin	I realize that
14:55:17	stephenfin	100%
14:55:24	mriedem	your comment says, "This is the 'revert_resize' function. There's no way we could get here for anything unless we were doing a revert of the resize operation (i.e. no cold migration flow through here), right?"
14:55:26	stephenfin	but would a user revert a cold migration
14:55:32	mriedem	yes
14:55:33	mriedem	sure
14:55:42	sean-k-mooney	stephenfin: yes they can
14:55:53	mriedem	just because it's called "resize" doesn't mean it's not also used by the cold migrate flow
14:55:57	mriedem	same as rebuild is used for evacuate
14:56:19	stephenfin	Seriously? Why can't I find any documentation on the internet about this?
14:56:34	sean-k-mooney	because its an internal detail of nova implemeation
14:56:48	sean-k-mooney	it should be in a dev ref
14:56:55	stephenfin	The ability of a user to revert their failed cold migration is a internal detail?
14:57:07	stephenfin	How it's implemented, sure, but not the raw ability to do the thing
14:57:09	sean-k-mooney	its in the api ref
14:57:10	mriedem	for one, users don't cold migrate, admins do
14:57:22	mriedem	https://developer.openstack.org/api-ref/compute/?expanded=migrate-server-migrate-action-detail#migrate-server-migrate-action
14:57:40	mriedem	"after a successful cold migration and then must be confirmed or reverted."
14:58:37	stephenfin	the more you know
14:58:39	sean-k-mooney	i think revert does not require admin https://developer.openstack.org/api-ref/compute/?expanded=migrate-server-migrate-action-detail,revert-resized-server-revertresize-action-detail#migrate-server-migrate-action
14:58:52	sean-k-mooney	except as indicated in teh precondions
14:58:53	mriedem	"Policy defaults enable only users with the administrative role to perform this operation. "
14:59:01	mriedem	cold migrate is admin_api by default
14:59:15	stephenfin	Hmm, why don't we have an 'openstack server migrate --revert' thing for this?
14:59:24	mriedem	we do
14:59:44	mriedem	https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-resize
14:59:46	mriedem	resize --revert
15:00:01	stephenfin	that's 'resize --revert', not 'migrate --revert'
15:00:15	mriedem	they hit the same api
15:00:27	stephenfin	Then why have an 'openstack migrate' command
15:00:38	mriedem	for cold and live migration
15:00:48	mriedem	which are not resizes
15:01:34	stephenfin	live migration, sure, but not cold migration
15:01:44	stephenfin	that's the same thing but with the same image?
15:01:46	stephenfin	*flavor
15:02:06	sean-k-mooney	stephenfin: we could delete migrate and jsut use resize for the cold migration case but most user dont think a resize and migration are the same thing
15:02:07	mriedem	cold migrate == resize but with no flavor change
15:02:58	stephenfin	sean-k-mooney: Yeah, that's my point. Why would a user think "oh, my migration failed. Best revert this resize"
15:03:00	sean-k-mooney	migrate is just syntactic sugar over resize really.
15:03:06	stephenfin	yeah
15:03:14	mriedem	note that a revert isn't to recover a failed move
15:03:25	mriedem	you can only revert if the resize/cold migration *didn't* fali
15:03:26	mriedem	*fail
15:03:53	stephenfin	Actually, yeah, I've done this in tests now that I think about
15:03:54	stephenfin	*it
15:04:21	stephenfin	(Or rather avoided doing it because confirming a resize/migration requires a lot of mocking out of libvirt stuff in functional tests that's not worth the effort)
15:05:03	stephenfin	mriedem: I think a '--revert' flag for the 'openstack server migrate' command would be helpful syntactic sugar. Any reason not to?
15:05:04	mriedem	if you're concerned about docs, you could update the description on https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-migrate to talk about how after a successful cold migration you need to revert or confirm the migration and which commad does that

Earlier   Later