Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-07
16:29:34 mriedem a couple of easy -1s to address in the next 2 after that
16:29:45 finucannot yeah, just tackled those
16:33:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Refresh instance network info on deletion https://review.opendev.org/660761
16:34:09 mriedem easy fix ^
16:40:03 finucannot Indeed. +W
16:44:48 lyarwood mdbooth: replied btw, the caps stub is still required.
16:45:38 Sundar johnthetubguy: Hi, are you good with https://review.opendev.org/#/c/603955/ after the updates?
16:48:51 finucannot lyarwood: If you add TODOs for the few things mdbooth called out (I left my own comments on same), I'm +2
16:49:00 finucannot and then I'm going home
16:50:45 efried lyarwood: I gotta run, but you're hitting this code path in your tests
16:50:45 efried https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L4835
16:50:46 efried which is patently wrong - should either be ... in (fields.Architecture.AARCH64,) <== tuple -- or just ==
16:51:12 Sundar johnthetubaguy: ^
16:51:31 efried bbiab
16:54:00 lyarwood fried_rolls / finucannot: looking, thanks
16:59:14 artom Note to self: bdms != bdsm
17:00:23 mriedem tssurya: self.cells is a dict by the time we get to patch https://review.opendev.org/#/c/663388/
17:00:25 mriedem see the change below it
17:00:30 lyarwood artom: always a risky search term at work
17:00:49 artom Oh I don't need to search for it.
17:01:02 openstackgerrit Dr. Clemens Hardewig proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/664000
17:01:03 openstack bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Undecided,New] https://launchpad.net/bugs/1831657 - Assigned to Dr. Clemens Hardewig (bringha1)
17:08:13 tssurya mriedem: sorry, I am super stupid, I didn't pull the other two changes below it
17:08:41 mriedem don't worry about it
17:08:43 tssurya was working witht his and Jay's patches
17:08:58 tssurya hehe
17:15:43 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
17:15:43 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
17:15:56 lyarwood fried_rolls / finucannot / mdbooth ; ^ thanks again for the reviews, just need to drop for dinner, I'll be back in ~45mins or so if there's any more follow up.
17:18:16 lyarwood aaaaaactually I've done it again and butchered the tests, 2 mins
17:19:38 lyarwood haha, now I see why, sshfs has made the directory I was working on read-only, bloody wonderful
17:28:40 kashyap lyarwood: Nice! The 'diffstat' is better. I only looked now at the newer iteration
17:30:22 lyarwood kashyap: thanks :)
17:30:34 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
17:30:35 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
17:31:30 lyarwood ^ right I'm done, apologies again for all the noise with this
17:33:03 kashyap [Should also start a broader discussion on 'openstack-discuss' to _actually_ test 'q35' machine type in a proper job; 'i440fx' is a "second rate citizen", but it's not going to go away anytime soon, though]
18:01:49 openstackgerrit Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881
18:01:50 openstackgerrit Artom Lifshitz proposed openstack/nova master: Remove finish_revert_migration TypeError try/except https://review.opendev.org/664013
18:02:14 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: test legacy dsvm job base-test parent https://review.opendev.org/664014
18:02:28 openstackgerrit Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
18:02:28 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102
18:02:32 finucannot mriedem: Didn't address your two todos but that adds the functional test requested ^
18:02:40 finucannot now I'm *really* going home
18:03:03 artom mriedem, I only *slightly* hate you :)
18:03:07 artom ^^
18:06:23 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
18:06:23 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027
18:06:24 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028
18:06:24 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690
18:06:25 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691
18:32:20 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient stable/stein: Use SHA256 instead of MD5 in completion cache https://review.opendev.org/664023
18:32:36 openstackgerrit Artom Lifshitz proposed openstack/python-novaclient stable/rocky: Use SHA256 instead of MD5 in completion cache https://review.opendev.org/664025
18:42:09 mriedem sean-k-mooney: comments in https://review.opendev.org/#/c/647733/
18:42:34 sean-k-mooney thanks ill take a look at them shortly
18:42:38 mriedem or monday...
18:42:45 mriedem b/c you shouldn't be working
18:43:14 sean-k-mooney :) ill finish up in the next 20 mins or so.
18:47:24 sean-k-mooney ya they all make sense. ill try swaping out the mocking on monday as you suggested. regarding hw_architecture = aarch64 and hw_video_model = vga i dont know what will happen
18:47:36 sean-k-mooney i suspect qemu will bitch if its not supported
19:17:44 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: in-line machine_type_mappings into get_default_machine_type https://review.opendev.org/664036
19:17:45 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP fup: Replace call to get_capabilities within _has_uefi_support https://review.opendev.org/664037
19:20:21 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Fix some bogus `in (not_a_tuple)` uses https://review.opendev.org/664041
19:21:05 efried lyarwood: I suspect putting your patch together with ^ will have interesting side effects.
19:25:00 lyarwood efried: ack thanks, I'm heading offline now but I'll rebase on that and see what shakes out on Monday
19:25:58 efried lyarwood: They'll affect the tests (because `$string in $autospec_mock` doesn't work), but I don't think they can actually cause bugs in the code.
19:38:03 sean-k-mooney efried: 'foo' in 'foo' check if the 'foo' charater sequence extis in the second string 'foo'
19:38:20 efried right
19:39:00 sean-k-mooney efried: so 'f' in 'foo' is a substring match where as 'foo' in ('foo') is a contains check
19:39:16 efried contains in what sense?
19:39:22 sean-k-mooney e.g. is 'foo' one of the values of the tuple
19:39:26 efried 'foo' in ('foo') is the same as 'foo' in 'foo'.
19:39:31 efried Because ('foo') is not a tuple.
19:39:35 efried It's a string with redundant parens.
19:39:41 efried ('foo',) is a tuple.
19:40:00 sean-k-mooney ah well yes that too
19:40:27 sean-k-mooney although 'foo' in ('foo',) should also be true
19:40:56 efried 'foo' in ('foobar') # True
19:40:56 efried 'foo' in ('foobar',) # False
19:41:12 sean-k-mooney yes but that is not what i wrote
19:41:25 efried what you wrote where?
19:41:39 sean-k-mooney >>> 'foo' in ('foo',)
19:41:41 sean-k-mooney True
19:41:49 efried yes
19:42:07 sean-k-mooney if the string matachs a value in the tuple exactly it will be true
19:42:13 efried right
19:42:24 efried but only if it's a tuple
19:42:24 sean-k-mooney but it wont to a substring match on each of the values of the tuple
19:42:28 efried right
19:42:51 efried we are in violent agreement
19:42:59 sean-k-mooney yep :)
19:43:07 efried And I think we're not broken here, because there's no arch const that's a substring of another arch const (is there?)
19:43:25 efried but it's by luck. It's still wrong and should be fixed.
19:43:48 sean-k-mooney i dont know if we have x86 and x86_64 but i think if we did we would threat them as an alias
19:44:03 openstackgerrit Eric Fried proposed openstack/nova master: Fix some bogus `in (not_a_tuple)` uses https://review.opendev.org/664041
19:44:12 efried Enhanced commit message which (hopefully) makes it clearer ^
19:44:24 efried (also fixed the other two spots in the nova codebase that do the same)
19:44:40 sean-k-mooney this is the set we support https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L112-L153
19:45:01 sean-k-mooney technically tere a few
19:45:12 sean-k-mooney ppc64 and ppc64le

Earlier   Later