| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-20 | |||
| 16:16:43 | efried | fix it or not. It's only your reputation at stake, permanently and indelibly etched into git | |
| 16:16:50 | aspiers | ROFL | |
| 16:17:22 | aspiers | I see plenty of other trailing '.' in the commit history, thankfully | |
| 16:17:38 | aspiers | I'll just be joining a distinguished group of disgraced engineers | |
| 16:17:56 | aspiers | Hmm, "Disgraced Engineer" sounds like a job title | |
| 16:18:05 | aspiers | Maybe that's in my career track | |
| 16:18:58 | aspiers | Crap, now I have no way to re-submit the SEV trait change without rebasing all the other SEV stuff on top of this | |
| 16:19:10 | aspiers | or without rebasing this on top of the other SEV stuff | |
| 16:19:18 | aspiers | This appears to be a flaw in the Gerrit model | |
| 16:20:03 | efried | aspiers: Rebasing the whole series should be as easy as rebasing one patch. | |
| 16:20:32 | efried | aspiers: except it looks like you may not have been done rebasing the series on itself. | |
| 16:20:54 | aspiers | From the CLI perspective maybe, but it creates a load of CI churn and also resets existing +1 / +2 | |
| 16:21:05 | aspiers | And it's hard enough to get those precious votes already | |
| 16:21:18 | efried | rebasing doesn't reset votes. | |
| 16:21:31 | efried | unless it involves actual code changes | |
| 16:21:41 | aspiers | Doesn't that depend on the patch-id remaining constant? ... right | |
| 16:21:58 | efried | Change-Id has to stay constant. | |
| 16:22:08 | aspiers | I mean the git patch-id | |
| 16:22:22 | efried | I don't know what that is. You mean the commit hash? | |
| 16:22:26 | aspiers | nope | |
| 16:22:28 | aspiers | https://git-scm.com/docs/git-patch-id | |
| 16:22:42 | efried | ah | |
| 16:22:50 | aspiers | It's how git does clever stuff during rebase, for instance | |
| 16:22:52 | efried | yes, in spirit. | |
| 16:22:52 | sean-k-mooney | aspiers if its a commit message only change i thik it keeps previous votes | |
| 16:23:06 | efried | sean-k-mooney: Pretty sure not ^ | |
| 16:23:08 | aspiers | sean-k-mooney: it's not commit message only | |
| 16:23:12 | aspiers | in this case | |
| 16:23:28 | aspiers | (We moved on from the trailing "." discussion to something more serious) | |
| 16:23:39 | efried | In this case you don't have any votes yet on the patch that's consuming the refactor, right? | |
| 16:23:50 | efried | because you're having to address some annoying core's -1 | |
| 16:24:30 | sean-k-mooney | aspiers: we dont actully enforce the no trail . in the hacking checks if i rememebr | |
| 16:24:40 | aspiers | https://review.opendev.org/#/c/638680/ depends on https://review.opendev.org/#/c/633855/ which depends on https://review.opendev.org/#/c/655268/ | |
| 16:24:56 | sean-k-mooney | so sinc its not enforced by the ci or atleast was not always enforced it is likely not consitent | |
| 16:25:04 | aspiers | Now I need https://review.opendev.org/#/c/638680/ to *also* depend on this test_servers.py refactoring | |
| 16:25:30 | efried | oh, I see, you want to make a downward-facing tree | |
| 16:25:32 | aspiers | sean-k-mooney: like I said there are tons of trailing "." already in the history. That was just a joke ... | |
| 16:25:36 | efried | yeah, don't bother with that | |
| 16:25:42 | efried | just put the refactor on the bottom of the pile. | |
| 16:25:51 | aspiers | The top of the pile? | |
| 16:26:20 | aspiers | 655268 already has lots of + votes | |
| 16:26:21 | efried | "bottom" from the perspective of the 'Related changes' list on the top right of the gerrit panel. | |
| 16:26:44 | aspiers | Is that list ordered? | |
| 16:26:45 | efried | right, and if you rebase that onto the refactor, you'll preserve those votes. | |
| 16:26:54 | efried | aspiers: Yes, "first" is at the bottom | |
| 16:27:08 | efried | etc | |
| 16:28:27 | aspiers | Hrm | |
| 16:28:42 | aspiers | Yeah, this is *definitely* a flaw in the Gerrit model if it doesn't support doing this properly | |
| 16:29:04 | aspiers | A good model should definitely not force artificial dependencies between changes like this | |
| 16:30:19 | aspiers | We're assuming here that Gerrit can only handle a linear sequence of dependencies | |
| 16:30:30 | aspiers | Or maybe you know that for a fact | |
| 16:30:39 | aspiers | Either way, it should be able to handle trees | |
| 16:30:54 | efried | say wha? | |
| 16:30:57 | efried | oh | |
| 16:31:12 | efried | you can do upward-facing trees (again, upward from the perspective of Related Changes) | |
| 16:31:28 | efried | That is, you can have both B and C depend on A but not on each other. | |
| 16:31:38 | efried | gerrit will show B and C in arbitrary order, but both will always be above A | |
| 16:31:46 | aspiers | Yes, but this is the opposite way up | |
| 16:31:54 | aspiers | A depending on both B and C | |
| 16:31:58 | efried | Right, that's what you can't have. | |
| 16:31:59 | aspiers | but B and C are independent | |
| 16:32:15 | efried | It's possible that Depends-On would work in-repo | |
| 16:32:20 | efried | but I'm not sure about that. | |
| 16:32:26 | efried | And frankly it's not worth it in this case. | |
| 16:32:37 | aspiers | I don't think it would | |
| 16:32:51 | aspiers | a merge commit would be required | |
| 16:33:08 | efried | yeah, based on my vague notions of how depends-on works, I think you're right that it wouldn't work. | |
| 16:33:13 | openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add missing certain missing traits https://review.opendev.org/660168 | |
| 16:33:18 | efried | so anyway, moving on... | |
| 16:33:23 | aspiers | before submitting to Gerrit, the only way to get the local tree in the right shape would be to merge B and C, then base A on top of that merge commit | |
| 16:33:43 | aspiers | which is actually how I do it in git-explode | |
| 16:33:47 | kashyap | aspiers: efried: First pass --^. Surely I got some things wrong; but thought I'll "put it out there" :D | |
| 16:34:07 | kashyap | Err, what a grammatical blunder in the summary | |
| 16:34:27 | openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add certain missing traits https://review.opendev.org/660168 | |
| 16:36:04 | kashyap | [NB: This is WIP, as the commit message notes. If the layout is amenable to those who care, then I can split it, if need be.] | |
| 16:38:31 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract provider tree functional tests into new file. https://review.opendev.org/660157 | |
| 16:39:16 | aspiers | efried: I've had a better idea - rebased this refactor ^^^ on the highest review in the dependency tree I can get away with | |
| 16:39:38 | aspiers | efried: thereby avoiding any CI churn on earlier changes | |
| 16:39:57 | efried | yup, that works too. | |
| 17:14:10 | adrianc | efried: was held up in some b2b meeting will upload PS in a few min. | |
| 17:15:19 | adrianc | also saw that no need to use save_and_reraise exception ctx | |
| 17:17:46 | efried | adrianc: I would feel better if you did that anyway :) | |
| 17:18:29 | adrianc | sure | |
| 17:18:30 | efried | until we have hard evidence that it's really not needed, since it doesn't hurt anything... | |
| 17:19:01 | efried | back in a reboot... | |
| 17:36:19 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow driver to properly unplug VIFs on destination on confirm resize https://review.opendev.org/643024 | |
| 18:02:52 | openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add certain missing traits https://review.opendev.org/660168 | |
| 19:07:17 | efried | kashyap, mriedem_away, bauzas: Would y'all please look at https://review.opendev.org/#/c/651681/ some time soon? | |
| 19:09:15 | mriedem_away | dansmith has my power of attorney while i'm in dev jail | |
| 19:09:26 | mriedem_away | /dev/jail | |
| 19:09:32 | efried | nice | |
| 19:09:42 | dansmith | heh | |
| 20:34:38 | openstackgerrit | Merged openstack/nova master: Enable n-novnc in nova-multi-cell job https://review.opendev.org/655711 | |
| #openstack-nova - 2019-05-21 | |||
| 01:19:44 | tonyb | I have a couple of ironic nodes in my OpenStack, how can I see which traits they provide ... and if they don't provide useful ones add them? | |
| 06:32:49 | openstackgerrit | Wangliangyu proposed openstack/nova master: Replace colon with comma in route comment https://review.opendev.org/660256 | |
| 07:30:51 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 07:47:26 | kashyap | efried: Will look. Actually, Ya Wang did ping me on a few things in that PostCopy / Auto-Converge spec | |
| 07:50:35 | kashyap | yaawang: Hi, what do you mean "applicatoins sensitive to performance reduced"? | |
| 07:53:33 | openstackgerrit | ya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/660271 | |
| 08:05:36 | yaawang | kashyap: Hi, for example: some scientific computing applications may be more sensitive to memory access latency. | |