Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-21
06:32:49 openstackgerrit Wangliangyu proposed openstack/nova master: Replace colon with comma in route comment https://review.opendev.org/660256
07:30:51 openstackgerrit Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
07:47:26 kashyap efried: Will look. Actually, Ya Wang did ping me on a few things in that PostCopy / Auto-Converge spec
07:50:35 kashyap yaawang: Hi, what do you mean "applicatoins sensitive to performance reduced"?
07:53:33 openstackgerrit ya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/660271
08:05:36 yaawang kashyap: Hi, for example: some scientific computing applications may be more sensitive to memory access latency.
08:23:18 kashyap yaawang: Ah, noted.
08:23:35 kashyap efried: yaawang: I just reviewed it. The idea itself is sound. I had some small comments on phrasing -- they can be addressed as a follow-on, or in this if there's a strong need to respin.
08:24:47 openstackgerrit ya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/660271
08:25:31 openstackgerrit Alexandre arents proposed openstack/nova master: Fix live-migration when glance image deleted https://review.opendev.org/659054
08:28:41 openstackgerrit Merged openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271
08:28:51 openstackgerrit Merged openstack/nova stable/ocata: Do not dump all instances in the scheduler https://review.opendev.org/659833
08:53:52 openstackgerrit Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785
09:19:39 mdbooth johnthetubaguy: If you're around, any chance you might prod this over the line? https://review.opendev.org/#/c/659317/
09:24:15 openstackgerrit Lee Yarwood proposed openstack/nova master: fixtures: Return a mocked class instead of method within fake_imagebackend https://review.opendev.org/619804
09:25:41 lyarwood stephenfin: https://review.opendev.org/#/c/551349/ - would you mind taking a look at this if you have time today
09:26:12 lyarwood mdbooth: ^ there's additional stuff on top of that I could use your take on btw - https://review.opendev.org/#/q/topic:live-migration-volume-bdm-rollback-rework+(status:open+OR+status:merged)
09:26:24 stephenfin lyarwood: Sure. Fixing some issues with pbr/taskflow at the moment but it's next in the queue after that
09:26:29 lyarwood thanks
09:28:10 lyarwood stephenfin / mdbooth ; https://review.opendev.org/#/c/572790/ - could also use reviews if you have time.
09:34:03 mdbooth lyarwood: Ack
09:53:54 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Stop logging traceback when skipping quiesce https://review.opendev.org/660325
09:54:17 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Stop logging traceback when skipping quiesce https://review.opendev.org/660327
09:54:39 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Stop logging traceback when skipping quiesce https://review.opendev.org/660328
09:55:28 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Fix target used in nova.policy.check_is_admin https://review.opendev.org/660330
10:06:02 stephenfin lyarwood: Can I get a reno for https://review.opendev.org/#/c/572790/ please?
10:06:31 stephenfin Actually, that's mriedem's. nvm. He'll see it soon enough
10:19:46 lyarwood stephenfin: I will if he can't
10:33:14 cdent bauzas: Have you got a new version of https://review.opendev.org/#/c/552924/ coming?
10:45:02 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: refactor volume bdm rollback error handling https://review.opendev.org/656500
10:55:08 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969
10:55:09 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
10:56:10 openstackgerrit Merged openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/571410
10:58:45 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
11:05:15 openstackgerrit Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786
11:24:41 openstackgerrit Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785
11:26:57 openstackgerrit Merged openstack/nova master: Fix guestfs.set_backend_settings call https://review.opendev.org/524748
11:42:57 openstackgerrit Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785
11:44:25 openstackgerrit Merged openstack/nova master: Replace colon with comma in route comment https://review.opendev.org/660256
11:46:55 openstackgerrit Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786
12:07:39 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660361
12:07:57 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660362
12:08:16 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660363
12:27:38 openstackgerrit Merged openstack/nova master: Restore connection_info after live migration rollback https://review.opendev.org/551349
12:36:44 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Restore connection_info after live migration rollback https://review.opendev.org/660370
12:44:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Restore connection_info after live migration rollback https://review.opendev.org/660375
12:46:36 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Add uuid filter to nova list https://review.opendev.org/660376
13:05:02 alex_xu sean-k-mooney: good morning, do you want to have look at this https://review.opendev.org/#/c/658716/1/specs/train/approved/show-server-numa-topology.rst@110 ?
13:05:30 alex_xu i guess core and threads should be removed also.
13:06:08 efried thanks for that, kashyap
13:06:46 alex_xu since numa_cell.cpu_topology only valid for dedicated cpu policy, and I guess cores and threads is empty all the time
13:07:28 sean-k-mooney alex_xu im just waiting for someome form the gas company to call but i can take a look in an hour or so
13:07:58 alex_xu sean-k-mooney: thanks, not hurry
13:11:20 sean-k-mooney alex_xu: im ok with the api reporting the number of sockets, cores per socket and threads per core.
13:11:35 sean-k-mooney im not sure it shoudl be reported at the numa node level however
13:11:43 sean-k-mooney given that its vm wide
13:11:55 alex_xu sean-k-mooney: yea, at least not in the numa cell
13:12:59 sean-k-mooney i would add cpu_topology:{sockets:1,cores:10, threads:2} as a sibling but not childe of nodes
13:13:12 alex_xu whether we have separated file for sockets, cores and threads, that should be a question for yonglihe and chris
13:13:27 sean-k-mooney that said i have not really given that much tought
13:14:40 alex_xu sean-k-mooney: I will tell yonglihe, let him check with starlingx whether need sockets, cores and threads
13:15:07 openstackgerrit Merged openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
13:16:34 alex_xu sean-k-mooney: actually, we won't have different hugepage size for cells
13:17:06 alex_xu i'm not sure this one also
13:18:23 sean-k-mooney correct we wont
13:18:43 sean-k-mooney we store the info in the db percell
13:18:54 alex_xu yes
13:19:06 sean-k-mooney but that is just so we did not have to pass it in as a peramater when calulating the assignment
13:19:29 sean-k-mooney but as you said the pagesize will be the same for all cells in the instance
13:21:16 sean-k-mooney libvirt can technically support different page sizes per cell and even multipl page sizes in the same numa cell but we have no plans to ever support that in nova so we dont really need to worry about it
13:21:41 alex_xu yea, can't see a usecase for that
13:22:27 alex_xu if they need that, then put it out of cell also, sounds correct choice
13:22:57 sean-k-mooney yes i think so to.
13:23:58 sean-k-mooney i would prefer to have the vm wide things at the top level and the cell specific things at the node level. whcih i think is your preference too.
13:24:43 alex_xu yes. our db structure is really confuse me in the beginning
13:25:28 alex_xu sean-k-mooney: thanks, I think yonglihe can move forward now
13:52:11 efried kashyap: If you'll ack https://review.opendev.org/#/c/633855/ I'll approve it.
13:53:10 efried tia
13:53:23 boxiang_ alex_xu: hi alex, is it necessary for me to add the approved blueprint to runways again? https://review.opendev.org/#/c/645520/
13:53:51 mriedem boxiang_: yes
13:53:54 mriedem just queue it back up
13:53:56 alex_xu yea
13:54:04 boxiang_ ok, thanks :)
13:54:43 alex_xu boxiang_: another patch I have is want to remove something https://review.opendev.org/659243, if that makes sense, probably can save some of your code
13:54:50 alex_xu but still waiting for review
13:59:05 boxiang_ alex_xu: got it. I will read it later.
13:59:41 mriedem1 alex_xu: that removal change of yours would make this not work i think https://review.opendev.org/#/c/650376/
14:00:08 alex_xu mriedem1: emm...let me check that patch
14:00:41 mriedem1 i'm trying to use requested_destination in the rebuild + new image scenario, rather than force_hosts/force_nodes
14:00:45 mriedem1 which requires a hack in the host manager code
14:01:20 mriedem1 i haven't gone over https://review.opendev.org/#/c/645520/ but i would expect it to use requested_destination as well
14:01:57 efried mriedem1 fwiw I've been having similar concerns, which is why I have been procrastinating on that patch.
14:02:34 alex_xu mriedem1: ok, i can have look at it tomorrow, it sounds a complex thing I don't want to go through before sleep
14:02:51 mriedem1 yup understood, i'd comment on the review but
14:03:10 alex_xu efried: nice instinct~
14:04:33 boxiang_ one question.if my patch is something different from the approved spec. Can I update the spec again?
14:04:44 mriedem1 efried: the sriov bp in the top runway slot is expired by a few days https://etherpad.openstack.org/p/nova-runways-train
14:04:52 mriedem1 boxiang_: you can amend the spec yes
14:05:29 mriedem1 sean-k-mooney: adrianc: was a patch ever pushed to update these docs for sriov live migration? https://docs.openstack.org/neutron/latest/admin/config-sriov.html#known-limitations
14:06:07 sean-k-mooney mriedem1: no but its on my todolist for today. im currently updating the osc evacuate command patch

Earlier   Later