Posted	Nick	Remark
#openstack-nova - 2019-05-04
21:08:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.opendev.org/575311
21:08:55	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.opendev.org/575581
21:09:02	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.opendev.org/576017
21:09:15	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.opendev.org/576018
21:09:32	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.opendev.org/576019
21:09:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
21:10:01	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027
21:10:17	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031
21:10:33	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299
21:10:51	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344
21:11:06	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
21:11:17	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
21:11:35	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
21:11:51	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
21:12:07	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
21:12:36	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
22:38:43	openstackgerrit	Merged openstack/nova master: Improve metadata performance https://review.opendev.org/615435
22:49:36	openstackgerrit	Merged openstack/nova stable/stein: Eventlet monkey patching should be as early as possible https://review.opendev.org/647310
23:30:36	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Train Cycle Themes https://review.opendev.org/657171
#openstack-nova - 2019-05-05
01:56:20	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
02:53:30	openstackgerrit	Merged openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332
03:22:19	openstackgerrit	ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681
03:33:17	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271
03:39:31	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Remove unsafe convert of lvm imagebackend https://review.opendev.org/642667
03:46:37	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
11:56:35	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Log when port resource is leaked during port delete https://review.opendev.org/657079
12:04:52	openstackgerrit	Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.opendev.org/652608
12:18:39	openstackgerrit	Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955
14:34:13	openstackgerrit	Merged openstack/nova master: Make nova-tox-functional-py36 reusable https://review.opendev.org/657074
17:41:50	openstackgerrit	Merged openstack/nova stable/rocky: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657051
18:04:16	openstackgerrit	Merged openstack/nova stable/rocky: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657110
22:51:25	cfriesen	it looks like the PTG etherpad crashed again, did anyone back it up?
#openstack-nova - 2019-05-06
06:53:21	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271
07:28:55	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Remove unsafe convert of lvm imagebackend https://review.opendev.org/642667
08:27:25	openstackgerrit	zhufl proposed openstack/nova master: [Trivial fix]Remove unnecessary slash https://review.opendev.org/657342
10:44:00	amansi26	In order to remove this particular warning http://paste.openstack.org/show/750709/ . Do I need to add cafile option at both the places (glance and ssl)? or how is it?
10:59:00	brinzh	git review
10:59:00	brinzh	fatal: unable to access 'https://opendev.org/openstack/nova/': Failed to connect to 2604:e100:3:0:f816:3eff:fe6b:ad62: Network is unreachable
11:00:24	brinzh	How to resolve this error? From the gerrit address changes review.opendev.org, I cannot clone/review and so on...
11:22:55	gibi	brinzh: ssh://gibi@review.openstack.org:29418/openstack/nova works for me
11:24:23	brinzh	I remember the port of 29418 is forbidden in China
11:24:48	brinzh	gibi: Where are you?
11:26:25	brinzh	gibi: I will test the ssh to clone, maybe it works ok now :)
11:32:23	gibi	brinzh: EU. Are you from China? If yes then I guess my info does not relevant for you
11:34:18	brinzh	gibi: Yeah, I am come from China, but port of 29418 is ok, I can clone the code now ^_^, but the 'git review' need to be test later.
11:35:19	brinzh	gibi: Ti's process is 86%, thanks for your remind.
11:46:41	brinzh	Unfortunately, interrupted...
11:49:29	openstackgerrit	Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662
11:53:03	tssurya	gibi, alex_xu, gmann: I have added you all to review https://review.opendev.org/#/c/648662/ for the notification/API parts respectively
13:22:31	openstackgerrit	Merged openstack/nova master: [Trivial fix]Remove unnecessary slash https://review.opendev.org/657342
13:42:31	efried	o/
14:29:51	mriedem	hi
14:59:00	gibi	tssurya: ack
14:59:57	gibi	tssurya: the size of that patch is a bit intimidating
15:10:08	mriedem	the locked reason one?
15:10:14	mriedem	anything involving API samples is going to be big
15:14:51	gibi	mriedem: yes, that one. But I started reading it...
15:26:42	openstackgerrit	Merged openstack/nova stable/queens: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657050
15:32:42	openstackgerrit	Merged openstack/nova stable/queens: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657111
16:06:36	amansi26	fungi:In order to remove this particular warning http://paste.openstack.org/show/750709/ . Do I need to add cafile option at both the groups (glance and ssl)? or how is it?
16:24:01	mriedem	amansi26: it appears that way yes https://docs.openstack.org/nova/latest/configuration/config.html#glance.cafile
16:32:29	mriedem	fyi i saw a grenade job fail because it took 202 seconds to spawn an instance http://logs.openstack.org/61/621061/5/check/grenade-py3/6aabc8e/logs/screen-n-cpu.txt.gz#_May_05_16_41_08_772233 and the tempest timeout is 196 seconds
16:32:32	mriedem	maybe just a slow node
16:33:31	cdent	oh noes, i can't find it
16:36:38	efried	cfriesen: on TPM, did we decide to do implicit version?
16:40:48	efried	so
16:40:48	efried	=> required=$version present, hw:sev_model=$model present => $model at $version
16:40:48	efried	=> required=$version present, hw:sev_model absent => TIM at $version
16:40:48	efried	=> required=$version absent, hw:sev_model=$model present => nova adds required=$version, where $version = 2_0 if $model is CRB else 1_2
16:42:37	efried	dah, tpm_model, not sev_model :)
16:46:06	cdent	yeah, I'm going to need you to come in on saturday
16:46:22	efried	that's tps_report
16:46:25	cfriesen	efried: yeah. I started looking at the implementation yesterday and to avoid code duplication I'd have to move a bunch of code around into helper functions
16:46:42	efried	really?
16:46:44	mriedem	i know this is a bit fugly, but can we at least get another core on the (non-fugly and quite beautiful) recreate test for this stein regression? https://review.opendev.org/#/q/topic:bug/1825034+(status:open+OR+status:merged)
16:46:44	efried	okay.
16:47:01	efried	mriedem: looking.
16:48:03	mriedem	thanks. we at least have 1-2 regression fixes merged back to stable/stein so it'd be good to do a release soonish
16:55:42	cfriesen	efried: both the version and the model can be specified in both the image and the flavor, so I've got helper functions down in the libvirt driver to retrieve them. We'd need to move those up to where they're accessible from the sched request filter, which in turn means mucking around with test cases, etc.
16:56:43	efried	cfriesen: Oh, okay, well, I would have likely -1'd anyway requesting that the validation be done in the request filter :)
16:58:10	efried	No reason to wait until we get all the way to the compute to check for conflicting values, if we can fail at the scheduler
16:58:35	cfriesen	efried: yesterday I was looking at whether we could do validation in _validate_flavor_image*.
16:59:01	efried	yeah, could. But that doesn't mean you shouldn't *also* do it in the request filter.
16:59:31	efried	oh, maybe it does
16:59:54	cfriesen	validate all the things everywhere. :)
17:00:08	cfriesen	might be overkill
17:00:44	efried	yeah, that does validation, which is fine, but you would have to duplicate some of the logic to do the implicit required trait and/or model business.
17:00:59	efried	probably not a huge amount of overlap, actually.
17:01:18	efried	Anyway, the right place for all of that logic is *not* the virt driver.
17:02:33	cfriesen	yeah, it's high-level enough that it would apply to any implementation in other virt drivers
17:02:34	efried	um, the logic to do implicit model lives in the virt driver though.
17:03:51	cfriesen	I'll rework the change. Hopefully soonish.
17:04:10	efried	no hurry, I just wanted to record the design we decided on before I forgot it :)
17:23:53	efried	mriedem: https://review.opendev.org/#/c/653098/ <== If you want to add a comment, like:
17:23:53	efried	# The following (archive stuff) is used to prove that the migration created a "fake instance". It is not necessary to trigger the bug.
17:23:53	efried	$archive stuff
17:23:53	efried	# Since the above (archive stuff) removed the fake instance, do the migration again to recreate it so we can exercise the code path.
17:23:53	efried	...I'll fast approve
17:25:13	openstackgerrit	Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
17:53:01	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add regression test for bug 1825034 https://review.opendev.org/653098

Earlier   Later