| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-06 | |||
| 16:59:54 | cfriesen | validate all the things everywhere. :) | |
| 17:00:08 | cfriesen | might be overkill | |
| 17:00:44 | efried | yeah, that does validation, which is fine, but you would have to duplicate some of the logic to do the implicit required trait and/or model business. | |
| 17:00:59 | efried | probably not a huge amount of overlap, actually. | |
| 17:01:18 | efried | Anyway, the right place for all of that logic is *not* the virt driver. | |
| 17:02:33 | cfriesen | yeah, it's high-level enough that it would apply to any implementation in other virt drivers | |
| 17:02:34 | efried | um, the logic to do implicit model lives in the virt driver though. | |
| 17:03:51 | cfriesen | I'll rework the change. Hopefully soonish. | |
| 17:04:10 | efried | no hurry, I just wanted to record the design we decided on before I forgot it :) | |
| 17:23:53 | efried | mriedem: https://review.opendev.org/#/c/653098/ <== If you want to add a comment, like: | |
| 17:23:53 | efried | # The following (archive stuff) is used to prove that the migration created a "fake instance". It is not necessary to trigger the bug. | |
| 17:23:53 | efried | $archive stuff | |
| 17:23:53 | efried | # Since the above (archive stuff) removed the fake instance, do the migration again to recreate it so we can exercise the code path. | |
| 17:23:53 | efried | ...I'll fast approve | |
| 17:25:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078 | |
| 17:53:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for bug 1825034 https://review.opendev.org/653098 | |
| 17:53:02 | openstack | bug 1825034 in OpenStack Compute (nova) "listing deleted servers from the API fails after running fill_virtual_interface_list online data migration" [High,In progress] https://launchpad.net/bugs/1825034 - Assigned to Matt Riedemann (mriedem) | |
| 17:53:53 | mriedem | efried: done | |
| 17:53:55 | efried | mriedem: +A | |
| 17:53:58 | mriedem | thanks | |
| 17:54:03 | efried | mriedem: Not sure if the fix needs a rebase now? | |
| 17:54:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude fake marker instance when listing servers https://review.opendev.org/653158 | |
| 17:54:33 | mriedem | ^ | |
| 17:54:47 | efried | neat | |
| 17:54:49 | efried | +A | |
| 18:01:36 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add regression test for bug 1825034 https://review.opendev.org/657420 | |
| 18:01:38 | openstack | bug 1825034 in OpenStack Compute (nova) "listing deleted servers from the API fails after running fill_virtual_interface_list online data migration" [High,In progress] https://launchpad.net/bugs/1825034 - Assigned to Matt Riedemann (mriedem) | |
| 18:01:38 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Exclude fake marker instance when listing servers https://review.opendev.org/657421 | |
| 18:14:11 | rm_work | mriedem: correction -- apparently we use the log driver and ship notifications to splunk via logs, so no RMQ involved >_> | |
| 18:15:58 | mriedem | rm_work: ah ok, i don't hear of many people doing that | |
| 18:17:15 | rm_work | yeah, apparently some of our team didn't realize either... I had no idea what we were doing on the nova side of things at all, but finding out more about our deployments daily by asking around :D | |
| 18:45:07 | openstackgerrit | Merged openstack/nova master: Add regression test for bug 1825034 https://review.opendev.org/653098 | |
| 18:45:08 | openstack | bug 1825034 in OpenStack Compute (nova) stein "listing deleted servers from the API fails after running fill_virtual_interface_list online data migration" [High,In progress] https://launchpad.net/bugs/1825034 - Assigned to Matt Riedemann (mriedem) | |
| 18:59:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: add InstanceList.get_all_uuids_by_hosts() method https://review.opendev.org/623557 | |
| 18:59:59 | openstackgerrit | Jay Pipes proposed openstack/nova master: single pass instance info fetch in host manager https://review.opendev.org/623558 | |
| 20:38:42 | redkrieg | does anyone know how I determine which image property the nova scheduler ImagePropertiesFilter is failing a compute host for? | |
| 20:47:35 | efried | redkrieg: Debug logging switched on for n-sch? | |
| 20:48:17 | efried | you'd be looking for one of these: | |
| 20:48:17 | efried | LOG.debug("Instance contains properties %(image_props)s, " | |
| 20:48:17 | efried | "but no corresponding supported_instances are " | |
| 20:48:17 | efried | "advertised by the compute node", | |
| 20:48:17 | efried | or | |
| 20:48:18 | efried | LOG.debug("Instance contains properties %(image_props)s " | |
| 20:48:18 | efried | "that are not provided by the compute node " | |
| 20:48:19 | efried | "supported_instances %(supp_instances)s or " | |
| 20:48:19 | efried | "hypervisor version %(hypervisor_version)s do not match", | |
| 20:52:53 | redkrieg | hmm, I don't see either of those, but I did get this: 2019-05-06 16:50:31.908 1736 DEBUG nova.scheduler.filters.image_props_filter [req-91826f4d-09e1-45ba-92ce-da96721c3edf c7ff06eff7ea4850aeae27eaa7e285af cd8cde005d0841e5958408ef22e8ac72 - default default] (la-skvm-1, la-skvm-1.example.com) ram: 384892MB disk: 7231488MB io_ops: 0 instances: 0 does not support requested instance_properties | |
| 20:52:59 | redkrieg | host_passes /openstack/venvs/nova-18.1.5/lib/python2.7/site-packages/nova/scheduler/filters/image_props_filter.py:117 | |
| 20:54:01 | redkrieg | nevermind, missed that earlier | |
| 20:56:35 | redkrieg | efried: I see in this line that img_hv_type=qemu but the hypervisor says [u'x86_64', u'kvm', u'hvm']. could that be the problem? http://paste.openstack.org/show/750737/ | |
| 20:59:16 | efried | redkrieg: We're kind of surpassing my knowledge here, but that seems like a reasonable guess. | |
| 21:01:26 | redkrieg | thanks for taking a look, changing that property to kvm worked! | |
| 21:04:52 | artom | redkrieg, yeah, I assume you have libvirt+kvm hypervisors | |
| 21:05:10 | artom | So having your virt type set to qemu (aka emulation) doesn't work | |
| 21:05:41 | redkrieg | indeed. I created the image with a new control panel I'm testing and it didn't offer kvm as an option, only qemu. | |
| 21:05:43 | artom | Oh wait, it's an image prop | |
| 21:05:47 | redkrieg | yeah | |
| 21:05:54 | artom | OK, so fuzzier on the details, but you have the right idea :) | |
| 22:32:25 | openstackgerrit | Eric Fried proposed openstack/os-resource-classes master: Propose standard ACCELERATOR_FPGA resource class https://review.opendev.org/657464 | |
| 22:52:55 | openstackgerrit | Merged openstack/nova master: Exclude fake marker instance when listing servers https://review.opendev.org/653158 | |
| #openstack-nova - 2019-05-07 | |||
| 03:57:45 | openstackgerrit | Chason Chan proposed openstack/python-novaclient master: Tiny fix of documentation https://review.opendev.org/657522 | |
| 04:48:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix assert methods in unit tests https://review.opendev.org/657525 | |
| 09:07:24 | openstackgerrit | Merged openstack/nova master: Use migration_status during volume migrating and retyping https://review.opendev.org/637224 | |
| 11:27:43 | openstackgerrit | Merged openstack/nova master: Log when port resource is leaked during port delete https://review.opendev.org/657079 | |
| 11:27:58 | openstackgerrit | Merged openstack/nova master: Fix assert methods in unit tests https://review.opendev.org/657525 | |
| 11:30:10 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Policy Default Refresh spec https://review.opendev.org/547850 | |
| 11:39:29 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Use migration_status during volume migrating and retyping https://review.opendev.org/657575 | |
| 11:39:53 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201 | |
| 11:43:32 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Use migration_status during volume migrating and retyping https://review.opendev.org/657577 | |
| 11:43:50 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Use migration_status during volume migrating and retyping https://review.opendev.org/657579 | |
| 11:50:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Log when port resource is leaked during port delete https://review.opendev.org/657581 | |
| 11:54:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Resource provider - request group mapping in allocation candidate https://review.opendev.org/597601 | |
| 12:05:31 | ygk_12345 | hi all | |
| 12:05:48 | ygk_12345 | can someone help me how to get a vm's flavor from the nova database | |
| 12:06:08 | mriedem | instance_extras.flavor column | |
| 12:06:39 | mriedem | *instance_extra | |
| 12:06:40 | mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L386 | |
| 12:08:03 | gibi | ygk_12345: mysql nova_cell1 -e 'select flavor from instance_extra;' | |
| 12:08:15 | gibi | ahh mriedem was faster | |
| 12:09:08 | ygk_12345 | gibi: ok thanks got it :) | |
| 12:09:29 | ygk_12345 | gibi: but is there a way to get that name of the flavor only in the output ? | |
| 12:09:51 | mriedem | ygk_12345: original_name is provided in the output i think | |
| 12:10:05 | mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details | |
| 12:10:10 | mriedem | flavor.original_name | |
| 12:10:16 | mriedem | that's available since microversion 2.47 | |
| 12:10:51 | ygk_12345 | mriedem: is flavor a table ? | |
| 12:11:02 | gibi | and there is "name" key in the flavor json in the database | |
| 12:11:19 | mriedem | flavors is a table in the nova_api db yes | |
| 12:11:31 | mriedem | but the flavor used to create the instance is not necessarily still in that table, | |
| 12:11:37 | mriedem | or with the same values, i.e. extra specs | |
| 12:11:53 | mriedem | the copy of the flavor used to create or last resize the instance is in the instance_extra table | |
| 12:12:06 | ygk_12345 | gibi: yes I see but how to get it only in the query output. I am getting all the cluttered output | |
| 12:12:22 | mriedem | ygk_12345: it's stored as a json blob in the instance_extra table | |
| 12:12:27 | gibi | ygk_12345: ^^ | |
| 12:12:28 | mriedem | so you'd have to deserialize it | |
| 12:12:51 | mriedem | gibi: were you planning on backporting https://review.opendev.org/#/q/topic:bug/1819923+(status:open+OR+status:merged) ? i'm wondering about ordering for https://review.opendev.org/#/c/651945/ | |
| 12:13:32 | ygk_12345 | gibi: mriedem now I see in the nova_api db. I will extract it somehow. Thanks for your time guys | |
| 12:14:10 | mriedem | just remember what i said about the flavor used to create the server may not be in the flavors table anymore | |
| 12:15:26 | gibi | mriedem: yes, I'm planning to backport heal port allocation to stein | |
| 12:16:23 | gibi | mriedem: if https://review.opendev.org/#/c/651945/ merges then I will handle the conflicts | |