| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-26 | |||
| 09:52:18 | gibi | slaweq: seem like the VM did not got execution time so every service was slowed to halt | |
| 09:58:56 | kashyap | aspiers: Added some notes in the change; ruthlessly correct me if something is wrong :-) | |
| 09:59:03 | aspiers | I am doing ;-) | |
| 10:00:12 | kashyap | (Just a heads-up: won't be very responsive this afternoon due to prior committments; will read the change once my queue is free.) | |
| 10:00:18 | aspiers | np | |
| 10:05:47 | openstackgerrit | caoyuan proposed openstack/os-traits master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655066 | |
| 10:06:22 | aspiers | kashyap: very nice notes, thanks. I'm incorporating the missing points into the docstring | |
| 10:07:00 | aspiers | kashyap: believe it or not the C API *does* allow omitting some parameters, whereas they are mandatory in Python | |
| 10:07:10 | aspiers | kashyap: again replying in Gerrit | |
| 10:07:20 | aspiers | gotta dash to an appointment now though, back a bit later | |
| 10:16:34 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.opendev.org/629589 | |
| 10:25:06 | slaweq | gibi: yes, that may be this | |
| 11:01:26 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.opendev.org/652197 | |
| 11:21:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test_rpc: Stop f****** with global state https://review.opendev.org/655843 | |
| 11:30:18 | kashyap | aspiers: I should've read the C API closer (instead of skimming) -- I think it incorporates some sane defaults. I'll believe you, of course | |
| 11:38:11 | kashyap | aspiers: BTW, it's a bug -- the virConnectGetDomainCapabilities() allowing skipping params, while its Python binding not :-) | |
| 11:38:20 | kashyap | aspiers: A libvirt dev is pushing a patch upstream | |
| 11:39:41 | kashyap | s/skipping parms/skipping _some_ params/ | |
| 11:52:47 | aspiers | kashyap: you mean a bug in the Python binding? that's what I suspected | |
| 11:54:46 | kashyap | aspiers: Bug in the C API, from the sounds of it. | |
| 11:55:04 | aspiers | ? | |
| 11:55:32 | kashyap | If you run `virsh domcapabilities`, the C API is run with with NULL, NULL, NULL, 0 | |
| 11:55:41 | aspiers | right | |
| 11:56:08 | aspiers | and then it obtains defaults https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_driver.c;h=f48d9256e4cc0f6282dcd7aa13bb7a1b53508eb3;hb=HEAD#l19898 | |
| 11:56:22 | aspiers | I have all this in a draft comment on the Gerrit review | |
| 11:56:26 | aspiers | I only just got back to my desk | |
| 11:56:48 | kashyap | No rush | |
| 12:00:04 | kashyap | aspiers: Yeah, it's indeed a bug in Python binding | |
| 12:00:12 | kashyap | def getDomainCapabilities(self, emulatorbin, arch, machine, virttype, flags=0): | |
| 12:00:16 | kashyap | """Prior creating a domain (for instance via virDomainCreateXML | |
| 12:00:18 | kashyap | or virDomainDefineXML) it may be suitable to know what the | |
| 12:00:21 | kashyap | underlying emulator and/or libvirt is capable of. For | |
| 12:00:24 | kashyap | instance, if host, libvirt and qemu is capable of VFIO | |
| 12:00:26 | kashyap | passthrough and so on. """ | |
| 12:00:28 | kashyap | ret = libvirtmod.virConnectGetDomainCapabilities(self._o, emulatorbin, arch, machine, virttype, flags) | |
| 12:00:32 | kashyap | if ret is None: raise libvirtError ('virConnectGetDomainCapabilities() failed', conn=self) | |
| 12:00:36 | kashyap | return ret | |
| 12:00:39 | kashyap | aspiers: The "flags=0" | |
| 12:02:22 | aspiers | kashyap: I think flags is *always* 0 | |
| 12:02:32 | aspiers | kashyap: the problem is with omitting any of the other 4 | |
| 12:02:50 | aspiers | kashyap: maybe it works if I pass None | |
| 12:03:27 | aspiers | kashyap: but in any case we don't want to take the defaults in nova, but instead iterate over all relevant (arch, machine) tuples | |
| 12:03:59 | kashyap | aspiers: Let's see what the upstream fix is | |
| 12:07:18 | aspiers | kashyap: sure | |
| 12:07:29 | aspiers | kashyap: expect a new patch set shortly | |
| 12:35:48 | kashyap | aspiers: Just back; indeed, we can pass 'None' to the API, meanwhile. | |
| 12:35:53 | kashyap | (I commented on the change.) | |
| 12:35:55 | kashyap | Fun, fun. | |
| 12:40:21 | mriedem | gibi: looks like this introduces its own problem https://review.opendev.org/#/c/654466/4..5/oslo_config/cfg.py | |
| 12:41:09 | mriedem | bnemec: any ideas on how we can make that counter work in ConfigOpts? ^ | |
| 12:44:53 | mriedem | oh i think i see | |
| 12:45:07 | mriedem | self._get_counter isn't set until after register_opt which calls __clear_cache | |
| 12:45:26 | mriedem | fixing | |
| 13:09:17 | gibi | mriedem: good point | |
| 13:12:43 | gibi | mriedem: have you seen stephenfin's patch trying to solve this in a different way https://review.opendev.org/#/c/655843/ ? | |
| 13:13:10 | mriedem | i glanced at it... | |
| 13:18:50 | kashyap | aspiers: There it is: https://www.redhat.com/archives/libvir-list/2019-April/msg01418.html -- [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments | |
| 13:22:45 | kashyap | aspiers: I'm not "-1"ing it, because you already know what to do there ('None' for @emulatorbin) | |
| 13:36:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Add ironic driver image type capabilities https://review.opendev.org/655729 | |
| 13:36:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add vmware driver image type capabilities https://review.opendev.org/655730 | |
| 13:36:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add xenapi driver image type capabilities https://review.opendev.org/655731 | |
| 13:36:43 | openstackgerrit | Dan Smith proposed openstack/nova master: Add zvm driver image type capabilities https://review.opendev.org/655732 | |
| 13:43:24 | aspiers | kashyap: that would make one of my previous patches wasted effort ... | |
| 13:57:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add heal_instance_mappings command https://review.opendev.org/655908 | |
| 13:57:31 | mriedem | mnaser: ^ got around to porting your script from the bug into a nova-manage command | |
| 14:01:24 | mnaser | openstackgerrit: oooo that's awesoem | |
| 14:02:56 | mnaser | err | |
| 14:02:59 | mnaser | mriedem: ^ oops | |
| 14:06:00 | mriedem | https://review.opendev.org/#/c/586742/ got me thinking about it again | |
| 14:07:00 | kashyap | aspiers: Sorry, what is "that"? | |
| 14:07:33 | aspiers | kashyap: https://review.opendev.org/#/c/640483/ | |
| 14:57:35 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | |
| 15:07:22 | mriedem | jaypipes: dansmith: i'm having a brain fart on what i thought was a simple db query https://review.opendev.org/#/c/655908/1/nova/objects/instance_mapping.py@406 - i've got a test with an instance mapping with no cell_id but my query is not returning it and i'm at a loss to why | |
| 15:07:37 | mriedem | do you see anything obvious? | |
| 15:08:43 | mriedem | i have a feeling the joinedload is screwing it up | |
| 15:08:47 | mriedem | since there is no related cell mapping to join | |
| 15:09:08 | dansmith | I would think that would matter | |
| 15:09:14 | mriedem | oh actually it's just the join() i htink | |
| 15:09:22 | mriedem | .options(joinedload('cell_mapping')) will load up the null attribute | |
| 15:09:55 | dansmith | I meant "wouldn't" | |
| 15:10:09 | dansmith | I would think you could still query by that column directly, not sure why you would need to join the other | |
| 15:10:36 | dansmith | but no, nothing really stands out to me | |
| 15:11:01 | aspiers | hrm, the first of my SEV patches has bizarrely just started failing openstack-tox-lower-constraints due to having an old os-traits which misses the SEV trait | |
| 15:11:06 | mriedem | i run it through _from_db_object which loads the attribute on the ovo | |
| 15:11:13 | mriedem | get a lazy-load session error otherwise | |
| 15:11:18 | mriedem | but yeah it was the join() that was filtering it out, fixed | |
| 15:11:19 | mriedem | thanks | |
| 15:11:31 | aspiers | can I just up the version in lower-constraints? has something recently changed with the way lower-constraints is tested? | |
| 15:12:00 | mriedem | aspiers: if you require a new min of os-traits then yes you need to bump the version in lower-constraints.txt | |
| 15:12:10 | aspiers | mriedem: in the same commit? | |
| 15:12:16 | kashyap | mriedem: If you get a minute, when backporting this fix of yours to Rocky (admittedly, downstream), any other patch is required? -- https://review.opendev.org/#/c/591607/ ("Force refresh instance info_cache during heal") | |
| 15:12:44 | mriedem | jesus | |
| 15:12:57 | mriedem | i got this same questoin from sean-k-mooney earlier about some other patch going to newton | |
| 15:13:12 | openstackgerrit | Merged openstack/nova master: Create request spec, build request and mappings in one transaction https://review.opendev.org/586742 | |
| 15:13:33 | mriedem | kashyap: yes, there is an online data migration below that in the series, | |
| 15:13:42 | openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.opendev.org/650370 | |
| 15:13:42 | aspiers | kashyap: not sure if it helps here, but in general https://github.com/aspiers/git-deps can help answer that question | |
| 15:13:46 | mriedem | and that online data migration has resulted in a couple of regressions in stein still being worked | |
| 15:14:03 | aspiers | kashyap: https://github.com/aspiers/git-deps/blob/master/USE-CASES.md#use-case-1-porting-between-branches | |
| 15:14:47 | kashyap | aspiers: Ah, thanks. I was doing a lame `git blame -C -M -L [...]`, and nothing turned up besides Matt's commit | |