| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-26 | |||
| 12:00:04 | kashyap | aspiers: Yeah, it's indeed a bug in Python binding | |
| 12:00:12 | kashyap | def getDomainCapabilities(self, emulatorbin, arch, machine, virttype, flags=0): | |
| 12:00:16 | kashyap | """Prior creating a domain (for instance via virDomainCreateXML | |
| 12:00:18 | kashyap | or virDomainDefineXML) it may be suitable to know what the | |
| 12:00:21 | kashyap | underlying emulator and/or libvirt is capable of. For | |
| 12:00:24 | kashyap | instance, if host, libvirt and qemu is capable of VFIO | |
| 12:00:26 | kashyap | passthrough and so on. """ | |
| 12:00:28 | kashyap | ret = libvirtmod.virConnectGetDomainCapabilities(self._o, emulatorbin, arch, machine, virttype, flags) | |
| 12:00:32 | kashyap | if ret is None: raise libvirtError ('virConnectGetDomainCapabilities() failed', conn=self) | |
| 12:00:36 | kashyap | return ret | |
| 12:00:39 | kashyap | aspiers: The "flags=0" | |
| 12:02:22 | aspiers | kashyap: I think flags is *always* 0 | |
| 12:02:32 | aspiers | kashyap: the problem is with omitting any of the other 4 | |
| 12:02:50 | aspiers | kashyap: maybe it works if I pass None | |
| 12:03:27 | aspiers | kashyap: but in any case we don't want to take the defaults in nova, but instead iterate over all relevant (arch, machine) tuples | |
| 12:03:59 | kashyap | aspiers: Let's see what the upstream fix is | |
| 12:07:18 | aspiers | kashyap: sure | |
| 12:07:29 | aspiers | kashyap: expect a new patch set shortly | |
| 12:35:48 | kashyap | aspiers: Just back; indeed, we can pass 'None' to the API, meanwhile. | |
| 12:35:53 | kashyap | (I commented on the change.) | |
| 12:35:55 | kashyap | Fun, fun. | |
| 12:40:21 | mriedem | gibi: looks like this introduces its own problem https://review.opendev.org/#/c/654466/4..5/oslo_config/cfg.py | |
| 12:41:09 | mriedem | bnemec: any ideas on how we can make that counter work in ConfigOpts? ^ | |
| 12:44:53 | mriedem | oh i think i see | |
| 12:45:07 | mriedem | self._get_counter isn't set until after register_opt which calls __clear_cache | |
| 12:45:26 | mriedem | fixing | |
| 13:09:17 | gibi | mriedem: good point | |
| 13:12:43 | gibi | mriedem: have you seen stephenfin's patch trying to solve this in a different way https://review.opendev.org/#/c/655843/ ? | |
| 13:13:10 | mriedem | i glanced at it... | |
| 13:18:50 | kashyap | aspiers: There it is: https://www.redhat.com/archives/libvir-list/2019-April/msg01418.html -- [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments | |
| 13:22:45 | kashyap | aspiers: I'm not "-1"ing it, because you already know what to do there ('None' for @emulatorbin) | |
| 13:36:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Add ironic driver image type capabilities https://review.opendev.org/655729 | |
| 13:36:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add vmware driver image type capabilities https://review.opendev.org/655730 | |
| 13:36:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add xenapi driver image type capabilities https://review.opendev.org/655731 | |
| 13:36:43 | openstackgerrit | Dan Smith proposed openstack/nova master: Add zvm driver image type capabilities https://review.opendev.org/655732 | |
| 13:43:24 | aspiers | kashyap: that would make one of my previous patches wasted effort ... | |
| 13:57:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add heal_instance_mappings command https://review.opendev.org/655908 | |
| 13:57:31 | mriedem | mnaser: ^ got around to porting your script from the bug into a nova-manage command | |
| 14:01:24 | mnaser | openstackgerrit: oooo that's awesoem | |
| 14:02:56 | mnaser | err | |
| 14:02:59 | mnaser | mriedem: ^ oops | |
| 14:06:00 | mriedem | https://review.opendev.org/#/c/586742/ got me thinking about it again | |
| 14:07:00 | kashyap | aspiers: Sorry, what is "that"? | |
| 14:07:33 | aspiers | kashyap: https://review.opendev.org/#/c/640483/ | |
| 14:57:35 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | |
| 15:07:22 | mriedem | jaypipes: dansmith: i'm having a brain fart on what i thought was a simple db query https://review.opendev.org/#/c/655908/1/nova/objects/instance_mapping.py@406 - i've got a test with an instance mapping with no cell_id but my query is not returning it and i'm at a loss to why | |
| 15:07:37 | mriedem | do you see anything obvious? | |
| 15:08:43 | mriedem | i have a feeling the joinedload is screwing it up | |
| 15:08:47 | mriedem | since there is no related cell mapping to join | |
| 15:09:08 | dansmith | I would think that would matter | |
| 15:09:14 | mriedem | oh actually it's just the join() i htink | |
| 15:09:22 | mriedem | .options(joinedload('cell_mapping')) will load up the null attribute | |
| 15:09:55 | dansmith | I meant "wouldn't" | |
| 15:10:09 | dansmith | I would think you could still query by that column directly, not sure why you would need to join the other | |
| 15:10:36 | dansmith | but no, nothing really stands out to me | |
| 15:11:01 | aspiers | hrm, the first of my SEV patches has bizarrely just started failing openstack-tox-lower-constraints due to having an old os-traits which misses the SEV trait | |
| 15:11:06 | mriedem | i run it through _from_db_object which loads the attribute on the ovo | |
| 15:11:13 | mriedem | get a lazy-load session error otherwise | |
| 15:11:18 | mriedem | but yeah it was the join() that was filtering it out, fixed | |
| 15:11:19 | mriedem | thanks | |
| 15:11:31 | aspiers | can I just up the version in lower-constraints? has something recently changed with the way lower-constraints is tested? | |
| 15:12:00 | mriedem | aspiers: if you require a new min of os-traits then yes you need to bump the version in lower-constraints.txt | |
| 15:12:10 | aspiers | mriedem: in the same commit? | |
| 15:12:16 | kashyap | mriedem: If you get a minute, when backporting this fix of yours to Rocky (admittedly, downstream), any other patch is required? -- https://review.opendev.org/#/c/591607/ ("Force refresh instance info_cache during heal") | |
| 15:12:44 | mriedem | jesus | |
| 15:12:57 | mriedem | i got this same questoin from sean-k-mooney earlier about some other patch going to newton | |
| 15:13:12 | openstackgerrit | Merged openstack/nova master: Create request spec, build request and mappings in one transaction https://review.opendev.org/586742 | |
| 15:13:33 | mriedem | kashyap: yes, there is an online data migration below that in the series, | |
| 15:13:42 | openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.opendev.org/650370 | |
| 15:13:42 | aspiers | kashyap: not sure if it helps here, but in general https://github.com/aspiers/git-deps can help answer that question | |
| 15:13:46 | mriedem | and that online data migration has resulted in a couple of regressions in stein still being worked | |
| 15:14:03 | aspiers | kashyap: https://github.com/aspiers/git-deps/blob/master/USE-CASES.md#use-case-1-porting-between-branches | |
| 15:14:47 | kashyap | aspiers: Ah, thanks. I was doing a lame `git blame -C -M -L [...]`, and nothing turned up besides Matt's commit | |
| 15:14:55 | mriedem | kashyap: http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005242.html | |
| 15:15:04 | kashyap | mriedem: /me clicks; thank you, sir | |
| 15:15:23 | mriedem | aspiers: yes same commit | |
| 15:15:25 | kashyap | And actually, thank _you_ for the work. Someone downstream is bugging me to backport it | |
| 15:15:31 | aspiers | mriedem: cool thanks | |
| 15:16:07 | kashyap | mriedem: Whatever beverage (you didn't take up my Berlin "root beer" offer) you like in Denver. (Maybe they have a "user beer" :D) | |
| 15:16:09 | mriedem | kashyap: you can thank Maciej Jozefczyk since he did most of the work and the online data migration | |
| 15:16:21 | kashyap | Ah, thanks to him, too, from OVH | |
| 15:16:23 | mriedem | what is that now, like a 6 pack you owe me? | |
| 15:16:37 | kashyap | Guitly as charged. I'll shell it out in Denver | |
| 15:16:39 | mriedem | dtroyer has also said he owes me a few, i'll have rot gut | |
| 15:17:00 | kashyap | mriedem: You got an Amazon Wishlist (that doesn't contain things like Hubble Telescope or something like that) :D | |
| 15:17:54 | mriedem | heh, yeah but don't really want to get into that game | |
| 15:18:04 | mriedem | nor share my dirty wishlist secrets | |
| 15:18:09 | kashyap | Hehe | |
| 15:18:24 | kashyap | But I hate how much I depend on Amazon. But no one can beat their prices. Damn them | |
| 15:18:46 | kashyap | (I still go and support the local stores as much as I can.) | |
| 15:18:46 | aspiers | +1 on that | |
| 15:19:24 | kashyap | Although I live in Gent, I sometimes order from the Netherlands-based "bol.com" (a mini Amazon, as it were), but at least 5-6 euros more expensive | |
| 15:20:31 | mordred | kashyap: I have very conflicting feelings about my retail reliance on amazon ... because on the one side, amazon. but on the other side, I'm not sure that their competitors in the space are *better* | |
| 15:20:35 | kashyap | aspiers: Thanks for the interesting 'git-deps' URL. (Bookmarked, I'll check it out "soon".) | |
| 15:20:52 | aspiers | kashyap: the video is only a few mins :) | |
| 15:20:58 | kashyap | mordred: Yeah. But "the competitor is not better" is not a very satisfying argument | |
| 15:21:07 | mordred | no, it's not | |
| 15:21:45 | kashyap | It's just obscene the way they under-cut & squish everything else. Like a 9000-pound blue whale | |
| 15:21:50 | aspiers | kashyap: I guess you missed the L&L I gave on it in Denver last year https://www.youtube.com/watch?v=f6anrSKCIgI | |
| 15:21:51 | mordred | yup | |