| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-18 | |||
| 17:09:27 | mdbooth | Which sounded great, until I realised that command line tools also import nova | |
| 17:09:41 | mdbooth | testing, ftw | |
| 17:10:15 | mdbooth | So now I'm looking again at monkey patching only for certain entry points | |
| 17:10:38 | mdbooth | But we can't monkey patch lower than nova/api/openstack/... because __init__.py imports the world | |
| 17:10:59 | cdent | ayup | |
| 17:11:36 | mdbooth | I was hoping to move that out of the way, but that looks depressingly involved | |
| 17:21:42 | mriedem | efried: hmm, what am i missing with trying to hup n-cpu in devstack: sudo systemctl kill -s HUP devstack@n-cpu.service | |
| 17:21:46 | mriedem | doesn't seem to be doing anything | |
| 17:22:39 | efried | mriedem: have you tried just finding the pid? | |
| 17:26:27 | mriedem | hmm, i must have killed it somehow | |
| 17:26:27 | mriedem | Active: inactive (dead) since Mon 2019-03-18 17:09:49 UTC; 16min ago | |
| 17:31:15 | mriedem | got it | |
| 17:31:15 | mriedem | INFO nova.compute.manager [None req-65477139-47bd-4419-b5b3-d729fdadb369 None None] Reloading compute RPC API | |
| 17:32:15 | efried | mriedem: how did you do it? | |
| 17:32:26 | mriedem | kill -HUP <pid> | |
| 17:34:55 | efried | mriedem: based on the systemctl man page, it's possible you would have needed to say -s SIGHUP (not just HUP) and specify a --kill-who=main (or something?) to target the actual n-cpu process rather than its control process. | |
| 17:35:23 | efried | so yeah, kill -HUP <pid> sounds easier to me :P | |
| 17:35:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add docs for compute capabilities as traits https://review.openstack.org/644293 | |
| 17:40:08 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix SSL infinite recursion https://review.openstack.org/626952 | |
| 19:06:46 | melwitt | mriedem: new bug I tagged for stein-rc-potential https://bugs.launchpad.net/nova/+bug/1820588 | |
| 19:06:47 | openstack | Launchpad bug 1820588 in OpenStack Compute (nova) "Bandwidth resource is leaked if a bound port is deleted in neutron" [Low,Confirmed] | |
| 19:22:26 | aspiers | mriedem, kashyap: Sorry, had to take a few days break due to RSI issues. (Cautiously) back now and trying to catch up | |
| 19:36:30 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664 | |
| 19:36:31 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899 | |
| 19:53:48 | openstackgerrit | Eric Fried proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | |
| 19:54:47 | efried | kashyap: I added a colon to make that go ^ | |
| 19:54:54 | efried | you may (or may not) wish to rebase its successors. | |
| 20:12:37 | efried | mdbooth: I've only superficially been following along, but when you rip out eventlet monkey-patching, some deepcopyZ will start to fail on lock artifacts. | |
| 20:13:30 | efried | mdbooth: Not sure the best solution for this; the naïf one is to implement __deepcopy__ on the thing holding the lock to create a new one (which is what the monkey-patched version did). | |
| 20:28:34 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Add a prelude release note for the 19.0.0 Stein GA https://review.openstack.org/644412 | |
| 20:38:51 | openstackgerrit | Merged openstack/nova master: Remove obsolete policy configuration details from docs https://review.openstack.org/643949 | |
| 20:41:45 | mnaser | hi everyone -- is there anyone doing any work on policy/scopes at the moment? | |
| 20:44:39 | melwitt | mnaser: not that I know of, but I was thinking of trying to get some stuff going next cycle for scope types. I proposed a forum session which might get combined with a keystone proposed session of similar topic | |
| 20:44:58 | mnaser | melwitt: cool, ill tag along for that perhaps | |
| 20:58:47 | openstackgerrit | Merged openstack/python-novaclient master: Update master for stable/stein https://review.openstack.org/644183 | |
| 21:12:11 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Clarify policy shortcomings in policy enforcement doc https://review.openstack.org/643960 | |
| 21:12:12 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Remove additional policy configuration details from policy doc https://review.openstack.org/644423 | |
| 23:13:00 | mriedem | lbragstad: typo here? https://review.openstack.org/#/c/644423/ | |
| 23:49:36 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Remove additional policy configuration details from policy doc https://review.openstack.org/644423 | |
| 23:50:02 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Clarify policy shortcomings in policy enforcement doc https://review.openstack.org/643960 | |
| #openstack-nova - 2019-03-19 | |||
| 00:14:48 | openstackgerrit | Merged openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | |
| 00:30:28 | openstackgerrit | Adam Spiers proposed openstack/nova master: Remove unnecessary default provider_tree when getting traits https://review.openstack.org/644452 | |
| 01:54:00 | openstackgerrit | Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.openstack.org/601596 | |
| 04:41:25 | openstackgerrit | chenker proposed openstack/python-novaclient master: Optimize limit option docs string description for novaclient https://review.openstack.org/643035 | |
| 04:46:34 | openstackgerrit | chenker proposed openstack/python-novaclient master: Optimize limit option docs string description for novaclient https://review.openstack.org/643035 | |
| 05:11:20 | openstackgerrit | Rui Zang proposed openstack/nova-specs master: Virtual persistent memory libvirt driver implementation https://review.openstack.org/622893 | |
| 06:35:47 | Kevin_Zheng | ping gmann | |
| 06:53:15 | openstackgerrit | melanie witt proposed openstack/nova master: Add a prelude release note for the 19.0.0 Stein GA https://review.openstack.org/644412 | |
| 07:56:26 | openstackgerrit | Merged openstack/nova master: Remove stale aggregates notes from scheduler evolution doc https://review.openstack.org/643613 | |
| 08:26:47 | kashyap | efried: Thank you for putting it through. | |
| 08:39:54 | openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | |
| 08:56:24 | openstackgerrit | Seyeong Kim proposed openstack/nova stable/rocky: Extract compute API _create_image to compute.utils https://review.openstack.org/643852 | |
| 08:56:24 | openstackgerrit | Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853 | |
| 09:32:25 | openstackgerrit | zhangyangyang proposed openstack/nova master: Drop py35 jobs and add py36 jobs https://review.openstack.org/643871 | |
| 10:05:26 | gibi | melwitt: I don't think https://bugs.launchpad.net/nova/+bug/1820588 is rc potential, I left some reasoning in the bug | |
| 10:05:27 | openstack | Launchpad bug 1820588 in OpenStack Compute (nova) "Bandwidth resource is leaked if a bound port is deleted in neutron" [Low,Confirmed] | |
| 10:06:16 | sean-k-mooney | gibi: that will be fixed by handeling the networks-status event in the periodic jobs right? | |
| 10:06:37 | sean-k-mooney | gibi: have you been working on a fix for that already or is it still todo? | |
| 10:07:08 | sean-k-mooney | i vaguely rememebr talking about it a week or two ago that we would have to do something to handel this edgecase | |
| 10:07:55 | kashyap | aspiers: No problem; I myself will be off next week | |
| 10:09:10 | sean-k-mooney | gibi: even if its not rc potential which i kind of agree with i think this should be backportable shortly after GA | |
| 10:11:10 | gibi | sean-k-mooney: when the bound port is deleted in neutron nova gets the notification and detaches the port from the server. I don't know how the periodic is involved here | |
| 10:11:49 | gibi | sean-k-mooney: moreover I till not conviced that why the admin cannot detach the port in nova first and only delete it after in neutron | |
| 10:12:40 | gibi | detach + delete works properly with bandwidth | |
| 10:19:48 | sean-k-mooney | gibi: when a bound port is delete neutron send a notification to nova which the periodic jobs will recive | |
| 10:20:19 | sean-k-mooney | gibi: this also does not require admin acess | |
| 10:20:57 | sean-k-mooney | a tenant can simple do a openstack port delete to cause this issue | |
| 10:21:42 | aspiers | kashyap: you wanted me to split out the addition of getDomainCapabilities() from the <sev> parsing, right? | |
| 10:21:54 | kashyap | aspiers: Yes, please | |
| 10:22:05 | aspiers | kashyap: the problem is, that code doesn't parse anything else in the output | |
| 10:22:07 | sean-k-mooney | gibi: but you are right that this should be done by a nova interface detach in general | |
| 10:22:33 | aspiers | kashyap: so the first patch would introduce nonsensical code | |
| 10:23:11 | sean-k-mooney | we should however be able to process the network-status event we get form neutron and heal the placement allocation regardless of why it was done so its not something i would worry too much about | |
| 10:23:24 | aspiers | kashyap: the only thing it parses is <sev> under <features> | |
| 10:23:53 | aspiers | kashyap: so splitting it would result in 3 new LibvirtConfigObject classes which do absolutely nothing | |
| 10:24:03 | kashyap | Hmm | |
| 10:24:41 | aspiers | I could make it parse something else just for the sake of it | |
| 10:24:45 | kashyap | Why would it be "nonsensical code" to split out a logically separate part? | |
| 10:24:49 | aspiers | Not sure whether that makes sense though | |
| 10:25:23 | aspiers | Because that separate part is non-functional noop code | |
| 10:25:35 | aspiers | There'd be nothing to test | |
| 10:26:16 | gibi | sean-k-mooney: I disagree. Why end user wants to delete a bound port instead of deatching it? | |
| 10:26:29 | gibi | sean-k-mooney: what is the use case for this? | |
| 10:27:10 | sean-k-mooney | gibi: its something that we have supported for many releases. there is not a defined usecase but neutron has never prevented it and until now nova has alreays correctly detached the port | |
| 10:27:39 | sean-k-mooney | the only other fix we could do is modify neutron to make deleteing a bound port illegal | |
| 10:28:00 | sean-k-mooney | we could do that but that is a seperate issue | |
| 10:28:05 | aspiers | kashyap: unless you can think of something to test? | |
| 10:28:18 | aspiers | but if it's not parsing anything I can't really see how | |
| 10:28:40 | gibi | sean-k-mooney: to support bandwidth cleanup at bound port delete is not a trivial thing. It adds complexity for someting that has no clear use case and I don't like that | |
| 10:29:26 | kashyap | aspiers: /me needs to fully re-load this context; but if you think it is not helping in anyway (even for review), then leave it as-is | |
| 10:29:37 | kashyap | aspiers: And note this reasoning somewhere in the commit message or the change | |
| 10:29:45 | sean-k-mooney | gibi: that is true but the only way to prevent needeing to handle this is to modify the neutron api to prevent deletion of bound ports which will require a spec and my have unintended sideffects | |
| 10:30:12 | sean-k-mooney | anyway we could fix it in the periodic job but that does not mean we have too | |
| 10:30:49 | aspiers | kashyap: I've split out the move of machine type calculation to utils.py | |
| 10:30:54 | aspiers | kashyap: which already helps a bit | |
| 10:30:56 | gibi | sean-k-mooney: I'm not sure we can easly fix it in the periodic job. Also I think it would make sense to discuss why neutron allows deleteing a bound port | |
| 10:31:01 | kashyap | aspiers: Yeah, that helps | |
| 10:31:21 | aspiers | kashyap: take a look at https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/config.py | |
| 10:32:01 | aspiers | kashyap: if I remove parsing of <sev>, then LibvirtConfigDomainCapsFeatures becomes a noop (no features ever get parsed and added to self._features) | |
| 10:32:12 | aspiers | and in that case LibvirtConfigDomainCaps is also a noop | |