Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-19
10:29:37 kashyap aspiers: And note this reasoning somewhere in the commit message or the change
10:29:45 sean-k-mooney gibi: that is true but the only way to prevent needeing to handle this is to modify the neutron api to prevent deletion of bound ports which will require a spec and my have unintended sideffects
10:30:12 sean-k-mooney anyway we could fix it in the periodic job but that does not mean we have too
10:30:49 aspiers kashyap: I've split out the move of machine type calculation to utils.py
10:30:54 aspiers kashyap: which already helps a bit
10:30:56 gibi sean-k-mooney: I'm not sure we can easly fix it in the periodic job. Also I think it would make sense to discuss why neutron allows deleteing a bound port
10:31:01 kashyap aspiers: Yeah, that helps
10:31:21 aspiers kashyap: take a look at https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/config.py
10:32:01 aspiers kashyap: if I remove parsing of <sev>, then LibvirtConfigDomainCapsFeatures becomes a noop (no features ever get parsed and added to self._features)
10:32:12 aspiers and in that case LibvirtConfigDomainCaps is also a noop
10:32:38 aspiers parse_dom() would do absolutely nothing
10:32:42 sean-k-mooney gibi: yep we porablly should bring it up in the cross project session
10:33:05 gibi sean-k-mooney: OK, I'm adding it to the etherpad
10:33:09 sean-k-mooney gibi: the asymitry has always annoyed me that we can detach port via neutron but not attach them
10:33:29 aspiers kashyap: like I said, I could make it parse something simple like <path> and/or <arch> just so that there is something to test
10:33:58 kashyap aspiers: Dealing with 4 pings, please bear with me.
10:33:59 sean-k-mooney gibi: but yes to your original point this proably does not need to be fix in the RC and can be "fixed" what ever way we decided in train and backported if needed
10:34:01 aspiers kashyap: that would give just enough excuse to split it out, but whatever I parsed would not be consumed by anything, at least until you start using it
10:34:08 aspiers kashyap: haha sure :)
10:34:57 gibi sean-k-mooney: yeah. I don't want to rush this fix as honetly I don't see how can this be easily fixed
10:35:38 sean-k-mooney gibi: if we block it in the neutron api that wont be backportable but the osc-placement plugin can always be used to fix it by hand if needed
10:36:02 cdent "how can this be easily fixed" the story of nova's life
10:36:32 sean-k-mooney cdent: well you can always just delete the vm and that will make everything better :)
10:37:04 gibi cdent: especially that we "need to fix" even if we don't know what is the use case
10:37:08 cdent that's the other half of the story: "we're using this cloud as a home for our pets"
10:38:01 sean-k-mooney cdent: of cource clouds and nice and fluffy places for our pets to live with totally no sharp edges
10:38:19 cdent made by magical open source bunnies!
10:38:50 gibi sean-k-mooney: no edges?! :) we want EDGE in the cloud :D
10:39:34 sean-k-mooney gibi: hehe ture but hopefully said edges wont be sharp :)
10:39:49 gibi we need fluffy edges!
10:40:35 sean-k-mooney new goal for summit. get "fluffy edges" into someones marketing deck
10:44:06 cdent fluffy edges sounds like a pretty good term for dynamically scalable edge nodes
10:48:41 kashyap aspiers: "Not consumed by anything" is okay so long as it (a) helps with clarity; (b) makes way for future patches to cherry-pick it for a particular use case
10:55:21 aspiers kashyap: yeah but needs to be testable still!
10:56:14 kashyap aspiers: Agreed :-) Don't let this block you.
11:03:37 openstackgerrit Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952
11:09:54 kashyap mdbooth_: When you get a moment, since we always return a non-None 'disk_cachemode' here: https://review.openstack.org/#/c/641981/10/nova/virt/libvirt/driver.py@443
11:10:12 kashyap mdbooth_: Are you implying to remove the check there?
11:10:35 mdbooth kashyap: No, that comment was wrt the release note
11:10:50 mdbooth Because we never return non-None there, we never use the qemu default
11:10:57 mdbooth So to the qemu default is irrelevant
11:11:07 kashyap Ah, guessed as much.
11:11:13 kashyap You wrote it in reference to the help text
11:11:18 kashyap Okay, elided the irrelevant bit.
11:11:19 kashyap Thanks!
11:11:31 mdbooth s/release note/docs/
11:16:53 openstackgerrit Gorka Eguileor proposed openstack/nova master: Fix unnecessary locking when connecting volumes https://review.openstack.org/614190
11:22:35 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable https://review.openstack.org/641981
11:22:35 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376
11:22:36 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377
11:23:17 sean-k-mooney kashyap: you are not enableing writeback by defualt when none is not available are you?
11:24:01 kashyap sean-k-mooney: That's exactly what it's doing; please read the commit message. I spent 3 hours writing it.
11:24:04 kashyap https://review.openstack.org/#/c/641981/
11:24:22 sean-k-mooney kashyap: if none is not an option we shoudl default to the safet alternitive either directsync or writethrough and only use writeback if there is no other option
11:24:27 kashyap FWIW, : I ran the patch by QEMU Block Layer maintainer over an e-mail thread.
11:24:38 kashyap sean-k-mooney: No, that is wrong. See the commit message and the comment in the code, again.
11:24:44 sean-k-mooney i just saw the ping. i had not opened it yet
11:28:25 sean-k-mooney kashyap: i had under stood that writback did not honer guest fush commands. is that not the case?
11:28:40 sean-k-mooney if it does the ok
11:28:44 sean-k-mooney *then
11:32:58 kashyap sean-k-mooney: It does honour it
11:33:02 kashyap sean-k-mooney: Also see: http://git.openstack.org/cgit/openstack/nova/commit/?h=master&id=e7b64eaad8
11:33:06 sean-k-mooney ok ya looking at the docs it does
11:33:30 kashyap Nod
11:34:09 sean-k-mooney i had tought there was still an edgecase with virtio scsi not informing the guest os that it was in writeback mode and that this only worked with virtio-block but maybe not
11:34:18 sean-k-mooney i could be tinking of discard instead of flush
11:36:36 sean-k-mooney kashyap: anywya i trust your and the qemu maintiners knoladge of this better then my own. its been a while since i dug into the cahce modes in any detail
11:44:16 sean-k-mooney kashyap: ah i found the ceph note i was missremembering. when using caching with RBD you expcitly have to use writeback cache mode not that you sould not use cach=writeback. http://docs.ceph.com/docs/master/rbd/qemu-rbd/#running-qemu-with-rbd the last time i looked into this was determing the correct way to use qemu safely with ceph storage with caching which at the time was virio-scsi for
11:44:18 sean-k-mooney discard/trim support + writeback cache if i wanted safe caching
12:31:14 kashyap sean-k-mooney: Just back from lunch
12:32:08 kashyap sean-k-mooney: Yep, I also suggest you think about the cache modes in terms of the three booleans each mode toggles.
12:32:19 kashyap It allows better reasoning of the concept
12:32:49 kashyap sean-k-mooney: (Yeah, that Ceph thing is accounted for by our own NOTE in the Nova config help docs.)
12:35:24 openstackgerrit Adam Spiers proposed openstack/nova master: Move libvirt calculation of machine type to utils.py https://review.openstack.org/644554
12:39:56 sean-k-mooney kashyap: well i generally use boot from volume or rbd image driver so i generally have not needed to resonable about cachemodes for qemu/raw image backend
12:40:31 kashyap Noted; was only saying as a future note :-)
12:41:22 sean-k-mooney the only time i tend to have local images is devstack :) but yes i look this up about once a year when i need to but its one of those things that i generaly dont rememebr off the top of my head unfortunetly
12:45:29 kashyap Nod; /me does a yearly "refresher course" on QEMU's caching behaviour...because damned if I could ever remember the details
12:48:51 mdbooth There seems to be a problem with the openstack-tox-docs job
12:48:57 mdbooth It's failed for me twice in a row now.
12:49:12 mdbooth http://logs.openstack.org/52/626952/7/check/openstack-tox-docs/d4bea1d/job-output.txt.gz#_2019-03-19_11_13_38_088828
12:49:41 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.openstack.org/639091
12:52:14 aspiers kashyap: trying to split getDomCaps out, but another issue is that the design decision to use a nested dict of dicts was heavily influenced by SEV https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/host.py@706
12:52:47 aspiers mdbooth: that would be nice :)
12:52:50 mdbooth Or even better, a 'only recheck this single job'
12:52:56 kashyap mdbooth: Sounds like a nice request for the fine folks on #openstack-infra
12:53:00 frickler kashyap: seems this is your real error, probably related to your patch http://logs.openstack.org/52/626952/7/check/openstack-tox-docs/d4bea1d/job-output.txt.gz#_2019-03-19_11_13_31_488145
12:53:31 kashyap frickler: You mean mdbooth's ^
12:53:42 aspiers kashyap: so either the preliminary getDomCaps patch prematurely references SEV before introducing support for it, or it makes a design decision without explaining it
12:53:48 frickler kashyap: yes, mangled up scrollback, sorry
12:53:53 kashyap aspiers: Reading ...
12:54:18 mdbooth frickler: Ah, thanks!
12:54:30 mdbooth That was a super-unhelpful error message!
12:55:15 mdbooth frickler: Out of curiosity, what grep-fu did you use to find that?
12:56:11 mdbooth NM, I suppose it's just above the other error.
12:56:18 frickler mdbooth: none, I just know that failure to copy "../doc/build" mostly results from the docs build having failed earlier. so I scrolled back a bit more to find the other error
12:57:48 frickler mdbooth: another way to approach this is to look at the ara report, where you can easily spot that not only the docs-post job failed, but also the main run, which most of the time has the more interesting errors http://logs.openstack.org/52/626952/7/check/openstack-tox-docs/d4bea1d/ara-report/
12:58:29 mriedem dansmith: i'm assuming you want to just mark this as won't fix or something https://bugs.launchpad.net/nova/+bug/1820851
12:58:30 openstack Launchpad bug 1820851 in OpenStack Compute (nova) "Please do cell mapping without periodic task or active admin involvment" [Wishlist,Opinion]
13:00:08 mdbooth frickler: That's awesome. Thanks.

Earlier   Later