| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-27 | |||
| 23:40:15 | cfriesen | sean-k-mooney: you're thinking about allowing the flavor to explicitly forbid enabling vTPM? not sure why anyone would want to do that since it's purely a virtual thing. | |
| 23:40:22 | sean-k-mooney | if i have issue with nested virt i also have pysical servers i can test with too | |
| 23:40:50 | sean-k-mooney | cfriesen: it is but an operator may want to forbid it for live migration reasons | |
| 23:41:09 | cfriesen | sean-k-mooney: but we're going to make it support live migration, no? | |
| 23:41:32 | sean-k-mooney | yes but they may have old hyperviors | |
| 23:41:49 | sean-k-mooney | i guess they would have upgraded to stien anyway so its proably not important | |
| 23:42:02 | cfriesen | sean-k-mooney: then the dest won't advertise the trait | |
| 23:42:20 | sean-k-mooney | ya ok it shoudl be good | |
| 23:42:47 | sean-k-mooney | there some traits that operator may want ot forbid in the falvor expclitly but this likel is not one of them | |
| #openstack-nova - 2019-02-28 | |||
| 00:04:04 | openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 00:57:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop using "nova" in API samples when creating a server https://review.openstack.org/639874 | |
| 00:57:18 | mriedem | uff da | |
| 01:17:09 | openstackgerrit | Merged openstack/os-vif master: add additional check and gate jobs for os-vif https://review.openstack.org/639732 | |
| 02:06:30 | mriedem | yonglihe: comments inline https://review.openstack.org/#/c/621474/ | |
| 02:14:54 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | |
| 02:19:44 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | |
| 02:19:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827 | |
| 02:19:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | |
| 02:19:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | |
| 02:19:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | |
| 02:19:47 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.openstack.org/634606 | |
| 02:21:52 | mriedem | gdi artom | |
| 02:22:32 | mriedem | https://review.openstack.org/#/c/634606/36/nova/conductor/tasks/live_migrate.py@177 | |
| 02:24:03 | yonglihe | mriedem: how about i remove the avaliable zone from request and ignore the returned 'nova' avaliable zone in api-sample? | |
| 02:26:01 | mriedem | yonglihe: if you remove the availability_zone=nova from the server create request, the response will correctly be az=nova | |
| 02:26:02 | mriedem | but that's fine | |
| 02:26:09 | mriedem | just remove the az from the request | |
| 02:26:19 | yonglihe | ok then. | |
| 02:30:12 | yonglihe | mriedem: we can not use self.sg_uuid in generalize_subs, because the api sample json verified failed while running it next time. | |
| 02:35:19 | mriedem | I'm not sure why you even need generalize_subs since you are doing this in the tests: | |
| 02:35:20 | mriedem | subs['sg_uuid'] = self.sg_uuid | |
| 02:35:34 | mriedem | as noted, if you just change the template to use %(uuid)s then you don't need the sg_uuid variable | |
| 02:35:54 | mriedem | i know the api samples functional tests are frustrating... | |
| 02:36:03 | mriedem | there is a lot of black magic involved in making them work | |
| 02:38:03 | yonglihe | yeah, I tried, only if I put it in generalize_stub it works..., i changed the template use %(uuid)s, it might conflict with other uuid? i don't know, I gonna try if that works. thanks. | |
| 02:40:33 | mriedem | %(uuid)s is just a regex matcher | |
| 02:40:36 | mriedem | so any uuid will pass | |
| 02:40:37 | mriedem | or should | |
| 02:41:01 | mriedem | yonglihe: see how far you get and push up your changes. if i find more stuff i'll just make the changes myself so we can get this approved. | |
| 02:42:15 | yonglihe | thanks, i think then it gonna works, i'm working on that. | |
| 02:52:53 | yonglihe | use 'uuid' instead of 'sg_uuid' ruined response checking. https://www.irccloud.com/pastebin/2YH9pvmK/use%20'uuid'%20instead%20of%20'sg_uuid'%20ruined%20response%20checking. | |
| 03:24:40 | mriedem | gibi: bauzas: questions inline for the reshaper functional test https://review.openstack.org/#/c/631559/12 | |
| 03:24:46 | mriedem | yonglihe: i can't see the full paste | |
| 03:24:50 | mriedem | i mean the actual error response | |
| 03:25:28 | mriedem | yonglihe: the %(uuid)s has to be in the response template, not the request | |
| 03:25:37 | mriedem | for the request you have to actually pass the server group uuid | |
| 03:25:49 | yonglihe | ohh, i got.. | |
| 03:26:18 | mriedem | in the response template you're saying, i don't care what the server group id is, just that it's present and it's a uuid | |
| 03:26:34 | mriedem | in the request you need to actually pass, via subs, the server group id in the server create request | |
| 03:27:04 | yonglihe | i did add to a wrong place.. | |
| 03:29:36 | yonglihe | ps, we do need own _test_servers_post to pass the sg_uuid in the request template. | |
| 03:31:19 | mriedem | ok. i guess we could pass an extra_subs parameter to _post_server to deal with that but it's up to you | |
| 03:31:55 | mriedem | anyway, i need to shut down for the day, i will look at your changes in the morning | |
| 03:33:34 | openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | |
| 03:34:04 | yonglihe | get some rest, take care, thanks. | |
| 03:55:18 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 06:05:42 | openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | |
| 06:05:43 | openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | |
| 06:05:43 | openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | |
| 06:05:44 | openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | |
| 06:05:44 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | |
| 06:05:45 | openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | |
| 06:40:39 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | |
| 06:52:32 | cfriesen | alex_xu: any chance you could take another look at https://review.openstack.org/#/c/620706/ ? | |
| 06:55:44 | openstackgerrit | Merged openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | |
| 06:57:39 | alex_xu | cfriesen: I guess I didn't express myself again https://review.openstack.org/#/c/620706/24/nova/compute/api.py@624, I mean using get_best_cpu_toplogy instead of _get_cpu_topology_constraints, not rename the method | |
| 06:58:40 | cfriesen | alex_xu: ah, I understand now. will take a look | |
| 07:04:19 | alex_xu | cfriesen: thanks | |
| 07:09:38 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | |
| 07:09:39 | openstackgerrit | Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933 | |
| 07:09:39 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | |
| 07:15:14 | cfriesen | alex_xu: we can't call get_best_cpu_topology() because the values for "allow_threads" and possibly "numa_topology" are not known | |
| 07:17:58 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936 | |
| 07:18:03 | cfriesen | sean-k-mooney: https://review.openstack.org/#/c/639934 is now the top of three commits for emulated vTPM. | |
| 07:21:58 | alex_xu | cfriesen: we needn't pass those two parameter, we just want the check in the _get_possible_cpu_topologies | |
| 07:22:59 | alex_xu | cfriesen: oh, vmware driver need allow_threads as False | |
| 07:25:19 | alex_xu | sounds like we have to check the valid cpu topo in the last stage | |
| 07:25:48 | cfriesen | alex_xu: I think the only real risk is that we might hit exception.ImageVCPULimitsRangeImpossible later on | |
| 07:26:42 | alex_xu | cfriesen: yes, that is one I thought we can check in the beginning also | |
| 07:28:13 | cfriesen | if we called it with the default allow_threads=True, it would at least tell us if it's even possible on a libvirt host. It might still fail on a vmware host | |
| 07:28:40 | alex_xu | yes | |
| 07:28:50 | cfriesen | it would mean doing extra work to enumerate and sort the possible topologies though | |
| 07:29:55 | cfriesen | if you think it's worth it I'm willing to change it | |
| 07:30:27 | cfriesen | or maybe we could try for a follow-up patch to do it more efficiently | |
| 07:31:16 | cfriesen | maybe a flag to bail out as soon as we find one possibility and avoid the sorting | |
| 07:31:55 | alex_xu | cfriesen: that three level loop is terrible, and sounds like we have no limit on the max value | |
| 07:33:01 | alex_xu | it is ok for flavor, since it is admin api | |
| 07:33:07 | cfriesen | maybe merge this as-is and then work on figuring out an efficient way to check for exception.ImageVCPULimitsRangeImpossible ? | |
| 07:34:47 | alex_xu | yes, it is ok. another thing is '_get_cpu_topology_constraints' is private method with '_' prefix | |
| 07:38:37 | alex_xu | cfriesen: also for https://review.openstack.org/#/c/620706/24/nova/compute/api.py@626, I didn't mean get rid of validate_numa flag, I mean get rid of line 3572 "image['status'] = 'active'" | |
| 07:39:09 | cfriesen | for _get_cpu_topology_constraints(), are you suggesting to remove the prefix? | |
| 07:39:38 | alex_xu | yes, but it can be a followup refactor patch | |
| 07:41:08 | cfriesen | if you look at the final version, you can see I did get rid of what was at 3572 by creating a new function _validate_flavor_image_nostatus() | |
| 07:41:15 | cfriesen | and calling it from the resize code path | |
| 07:43:01 | alex_xu | great, I will take a look at | |
| 07:51:37 | cfriesen | gotta go to bed. goodnight. | |
| 08:15:44 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 08:21:00 | gibi | bauzas: i've started looking into mriedem's questions in the reshape functional test patch. Let me know if you are about to change something in that patch | |
| 08:21:39 | bauzas | gibi: I first need to look at those | |
| 08:28:15 | gibi | bauzas: If you are OK with that then I will go and fix mriedem's comments in there | |