Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-28
03:26:34 mriedem in the request you need to actually pass, via subs, the server group id in the server create request
03:27:04 yonglihe i did add to a wrong place..
03:29:36 yonglihe ps, we do need own _test_servers_post to pass the sg_uuid in the request template.
03:31:19 mriedem ok. i guess we could pass an extra_subs parameter to _post_server to deal with that but it's up to you
03:31:55 mriedem anyway, i need to shut down for the day, i will look at your changes in the morning
03:33:34 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
03:34:04 yonglihe get some rest, take care, thanks.
03:55:18 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
06:05:42 openstackgerrit melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
06:05:43 openstackgerrit melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
06:05:43 openstackgerrit melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
06:05:44 openstackgerrit melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072
06:05:44 openstackgerrit melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
06:05:45 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
06:40:39 openstackgerrit Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080
06:52:32 cfriesen alex_xu: any chance you could take another look at https://review.openstack.org/#/c/620706/ ?
06:55:44 openstackgerrit Merged openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591
06:57:39 alex_xu cfriesen: I guess I didn't express myself again https://review.openstack.org/#/c/620706/24/nova/compute/api.py@624, I mean using get_best_cpu_toplogy instead of _get_cpu_topology_constraints, not rename the method
06:58:40 cfriesen alex_xu: ah, I understand now. will take a look
07:04:19 alex_xu cfriesen: thanks
07:09:38 openstackgerrit Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
07:09:39 openstackgerrit Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933
07:09:39 openstackgerrit Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934
07:15:14 cfriesen alex_xu: we can't call get_best_cpu_topology() because the values for "allow_threads" and possibly "numa_topology" are not known
07:17:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936
07:18:03 cfriesen sean-k-mooney: https://review.openstack.org/#/c/639934 is now the top of three commits for emulated vTPM.
07:21:58 alex_xu cfriesen: we needn't pass those two parameter, we just want the check in the _get_possible_cpu_topologies
07:22:59 alex_xu cfriesen: oh, vmware driver need allow_threads as False
07:25:19 alex_xu sounds like we have to check the valid cpu topo in the last stage
07:25:48 cfriesen alex_xu: I think the only real risk is that we might hit exception.ImageVCPULimitsRangeImpossible later on
07:26:42 alex_xu cfriesen: yes, that is one I thought we can check in the beginning also
07:28:13 cfriesen if we called it with the default allow_threads=True, it would at least tell us if it's even possible on a libvirt host. It might still fail on a vmware host
07:28:40 alex_xu yes
07:28:50 cfriesen it would mean doing extra work to enumerate and sort the possible topologies though
07:29:55 cfriesen if you think it's worth it I'm willing to change it
07:30:27 cfriesen or maybe we could try for a follow-up patch to do it more efficiently
07:31:16 cfriesen maybe a flag to bail out as soon as we find one possibility and avoid the sorting
07:31:55 alex_xu cfriesen: that three level loop is terrible, and sounds like we have no limit on the max value
07:33:01 alex_xu it is ok for flavor, since it is admin api
07:33:07 cfriesen maybe merge this as-is and then work on figuring out an efficient way to check for exception.ImageVCPULimitsRangeImpossible ?
07:34:47 alex_xu yes, it is ok. another thing is '_get_cpu_topology_constraints' is private method with '_' prefix
07:38:37 alex_xu cfriesen: also for https://review.openstack.org/#/c/620706/24/nova/compute/api.py@626, I didn't mean get rid of validate_numa flag, I mean get rid of line 3572 "image['status'] = 'active'"
07:39:09 cfriesen for _get_cpu_topology_constraints(), are you suggesting to remove the prefix?
07:39:38 alex_xu yes, but it can be a followup refactor patch
07:41:08 cfriesen if you look at the final version, you can see I did get rid of what was at 3572 by creating a new function _validate_flavor_image_nostatus()
07:41:15 cfriesen and calling it from the resize code path
07:43:01 alex_xu great, I will take a look at
07:51:37 cfriesen gotta go to bed. goodnight.
08:15:44 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
08:21:00 gibi bauzas: i've started looking into mriedem's questions in the reshape functional test patch. Let me know if you are about to change something in that patch
08:21:39 bauzas gibi: I first need to look at those
08:28:15 gibi bauzas: If you are OK with that then I will go and fix mriedem's comments in there
08:31:46 gibi bauzas: or shall I post the fix as a followup?
08:33:03 bauzas gibi: /me looking
08:33:28 bauzas given I already updated your change, which is on top, I'm fine with you updating it
08:33:45 bauzas no need for a FUP unless those are nits and we already have a +2
08:34:55 gibi bauzas: we already have +2 from efried
08:35:19 bauzas oh my bad
08:35:24 bauzas well, your choice
08:35:38 gibi bauzas: OK
08:35:44 bauzas I think we can certainly get efried approving it again
08:36:40 bauzas gibi: ideally, we could also squash efried's patch into it
08:38:46 gibi bauzas: I would ask efried about before we squash
08:38:55 bauzas yup, i agree
08:39:08 bauzas or add him as co-author if you wanna be quick
08:40:47 bauzas gibi: I also need to write a new change, so I -W'd https://review.openstack.org/#/c/599208/18
08:40:50 bauzas I'm on it
08:40:55 bauzas should be quick hopefully
08:41:17 gibi bauzas: OK
09:37:11 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626
09:45:30 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414
09:47:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559
09:48:16 openstackgerrit Stephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code https://review.openstack.org/530487
09:48:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid https://review.openstack.org/530905
09:49:04 stephenfin gibi, bauzas: Fancy putting this through? https://review.openstack.org/#/c/608407/
09:49:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: FUP: docs nit https://review.openstack.org/639647
09:49:57 gibi stephenfin: looking
09:51:14 gibi stephenfin: done
09:51:20 stephenfin \o/ ta
09:51:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014
09:52:09 bauzas hah, got one hour meeting from some tax credit https://www.impots.gouv.fr/portail/international-professionnel/tax-incentives
09:52:26 bauzas folks, in case you wanna relocate in France, consider it twice before moving
09:53:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854
09:53:49 stephenfin lyarwood: Fancy taking a look at this today? https://review.openstack.org/#/c/626369/
09:54:33 gibi bauzas: if you have any idea about https://review.openstack.org/#/c/631559/13/nova/tests/unit/virt/libvirt/fakelibvirt.py@1548 then tell me. The current test works if I return nothing but I shoudl return some nvidia-11 mdev_type there
09:55:44 bauzas gibi: looking
09:56:02 bauzas hah
09:56:34 bauzas gibi: it's because of https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L893
09:56:53 lyarwood stephenfin: sure
10:00:59 bauzas gibi: sec, giving you the right XML that I used for my UTs
10:02:33 bauzas gibi: try this one https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L298-L322
10:02:56 bauzas gibi: AFAIR, the libvirt docs is probably badly writtent
10:03:00 bauzas written*
10:04:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014
10:06:32 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Remove 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932
10:10:44 gibi bauzas: thanks. let me try
10:12:39 openstackgerrit Stephen Finucane proposed openstack/nova master: Update docs, API samples for noVNC 1.0.0 https://review.openstack.org/550173
10:13:11 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
10:14:18 stephenfin lyarwood: Looks like Ubuntu 19.04 will finally switch to noVNC 1.0, but that leaves this patch in limbo til 20.04 is out at least. I wonder if I should just abandon it or insert a TODO instead? https://review.openstack.org/#/c/550173/
10:14:31 stephenfin (Ubuntu 19.04 assertion made based on https://packages.ubuntu.com/search?keywords=novnc)

Earlier   Later